syzbot

======================================================
WARNING: possible circular locking dependency detected
6.16.0-syzkaller-11741-g5998f2bca43e #0 Tainted: GF R                
------------------------------------------------------
syz.6.2329/13740 is trying to acquire lock:
ffff888032ce58e8 (&ima_iint_mutex_key[depth]){+.+.}-{4:4}, at: process_measurement+0x7e0/0x23e0 security/integrity/ima/ima_main.c:299

but task is already holding lock:
ffffffff8f513b08 (dpm_list_mtx){+.+.}-{4:4}, at: device_pm_lock drivers/base/power/main.c:128 [inline]
ffffffff8f513b08 (dpm_list_mtx){+.+.}-{4:4}, at: dpm_for_each_dev drivers/base/power/main.c:2290 [inline]
ffffffff8f513b08 (dpm_list_mtx){+.+.}-{4:4}, at: dpm_for_each_dev+0x2d/0xb0 drivers/base/power/main.c:2283

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (dpm_list_mtx){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/mutex.c:598 [inline]
       __mutex_lock+0x193/0x10b0 kernel/locking/mutex.c:760
       device_pm_add+0x87/0x3e0 drivers/base/power/main.c:152
       device_add+0x9cd/0x1aa0 drivers/base/core.c:3652
       device_create_groups_vargs+0x1f8/0x270 drivers/base/core.c:4371
       device_create+0xed/0x130 drivers/base/core.c:4410
       msr_device_create+0x31/0x70 arch/x86/kernel/msr.c:251
       cpuhp_invoke_callback+0x3d5/0xa10 kernel/cpu.c:195
       cpuhp_thread_fun+0x47e/0x6f0 kernel/cpu.c:1105
       smpboot_thread_fn+0x3f4/0xae0 kernel/smpboot.c:160
       kthread+0x3c5/0x780 kernel/kthread.c:463
       ret_from_fork+0x5d7/0x6f0 arch/x86/kernel/process.c:148
       ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245

-> #3 (cpuhp_state-up){+.+.}-{0:0}:
       cpuhp_lock_acquire kernel/cpu.c:104 [inline]
       cpuhp_thread_fun+0x193/0x6f0 kernel/cpu.c:1082
       smpboot_thread_fn+0x3f4/0xae0 kernel/smpboot.c:160
       kthread+0x3c5/0x780 kernel/kthread.c:463
       ret_from_fork+0x5d7/0x6f0 arch/x86/kernel/process.c:148
       ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245

-> #2 (cpu_hotplug_lock){++++}-{0:0}:
       percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
       percpu_down_read include/linux/percpu-rwsem.h:77 [inline]
       cpus_read_lock+0x42/0x160 kernel/cpu.c:491
       class_cpus_read_lock_constructor include/linux/cpuhplock.h:47 [inline]
       ring_buffer_resize+0x105/0x15c0 kernel/trace/ring_buffer.c:2950
       __tracing_resize_ring_buffer kernel/trace/trace.c:5977 [inline]
       __tracing_resize_ring_buffer kernel/trace/trace.c:5958 [inline]
       tracing_update_buffers+0x15e/0x1f0 kernel/trace/trace.c:6209
       event_pid_write.isra.0+0xf8/0x7f0 kernel/trace/trace_events.c:2426
       do_loop_readv_writev fs/read_write.c:850 [inline]
       do_loop_readv_writev fs/read_write.c:835 [inline]
       vfs_writev+0x5df/0xde0 fs/read_write.c:1059
       do_writev+0x132/0x340 fs/read_write.c:1103
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0x490 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (trace_types_lock){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/mutex.c:598 [inline]
       __mutex_lock+0x193/0x10b0 kernel/locking/mutex.c:760
       class_mutex_constructor include/linux/mutex.h:228 [inline]
       trace_array_get kernel/trace/trace.c:601 [inline]
       tracing_check_open_get_tr.part.0+0x49/0x190 kernel/trace/trace.c:648
       tracing_check_open_get_tr kernel/trace/trace.c:642 [inline]
       tracing_open_generic_tr+0x66/0xf0 kernel/trace/trace.c:4731
       do_dentry_open+0x982/0x1530 fs/open.c:965
       vfs_open+0x82/0x3f0 fs/open.c:1095
       dentry_open+0x71/0xd0 fs/open.c:1118
       ima_calc_file_hash+0x2b6/0x490 security/integrity/ima/ima_crypto.c:553
       ima_collect_measurement+0x899/0xa40 security/integrity/ima/ima_api.c:293
       process_measurement+0x11fa/0x23e0 security/integrity/ima/ima_main.c:405
       ima_file_check+0xc5/0x110 security/integrity/ima/ima_main.c:633
       security_file_post_open+0x8e/0x210 security/security.c:3160
       do_open fs/namei.c:3889 [inline]
       path_openat+0x1404/0x2cb0 fs/namei.c:4046
       do_filp_open+0x20b/0x470 fs/namei.c:4073
       do_sys_openat2+0x11b/0x1d0 fs/open.c:1435
       do_sys_open fs/open.c:1450 [inline]
       __do_sys_openat fs/open.c:1466 [inline]
       __se_sys_openat fs/open.c:1461 [inline]
       __x64_sys_openat+0x174/0x210 fs/open.c:1461
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0x490 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ima_iint_mutex_key[depth]){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x12a6/0x1ce0 kernel/locking/lockdep.c:5237
       lock_acquire kernel/locking/lockdep.c:5868 [inline]
       lock_acquire+0x179/0x350 kernel/locking/lockdep.c:5825
       __mutex_lock_common kernel/locking/mutex.c:598 [inline]
       __mutex_lock+0x193/0x10b0 kernel/locking/mutex.c:760
       process_measurement+0x7e0/0x23e0 security/integrity/ima/ima_main.c:299
       ima_file_check+0xc5/0x110 security/integrity/ima/ima_main.c:633
       security_file_post_open+0x8e/0x210 security/security.c:3160
       do_open fs/namei.c:3889 [inline]
       path_openat+0x1404/0x2cb0 fs/namei.c:4046
       do_file_open_root+0x322/0x610 fs/namei.c:4098
       file_open_root+0x2a7/0x450 fs/open.c:1414
       kernel_read_file_from_path_initns+0x189/0x260 fs/kernel_read_file.c:163
       fw_get_filesystem_firmware drivers/base/firmware_loader/main.c:549 [inline]
       _request_firmware+0x744/0x1470 drivers/base/firmware_loader/main.c:881
       request_firmware drivers/base/firmware_loader/main.c:957 [inline]
       cache_firmware drivers/base/firmware_loader/main.c:1295 [inline]
       __async_dev_cache_fw_image+0xb1/0x340 drivers/base/firmware_loader/main.c:1409
       async_schedule_node_domain+0xd1/0x120 kernel/async.c:221
       async_schedule_domain include/linux/async.h:72 [inline]
       dev_cache_fw_image+0x38e/0x490 drivers/base/firmware_loader/main.c:1465
       dpm_for_each_dev drivers/base/power/main.c:2292 [inline]
       dpm_for_each_dev+0x5d/0xb0 drivers/base/power/main.c:2283
       device_cache_fw_images drivers/base/firmware_loader/main.c:1515 [inline]
       fw_pm_notify+0x81/0x150 drivers/base/firmware_loader/main.c:1566
       notifier_call_chain+0xbc/0x410 kernel/notifier.c:85
       notifier_call_chain_robust kernel/notifier.c:120 [inline]
       blocking_notifier_call_chain_robust kernel/notifier.c:345 [inline]
       blocking_notifier_call_chain_robust+0xc8/0x160 kernel/notifier.c:333
       pm_notifier_call_chain_robust+0x27/0x60 kernel/power/main.c:103
       snapshot_open+0x218/0x2b0 kernel/power/user.c:87
       misc_open+0x35a/0x420 drivers/char/misc.c:161
       chrdev_open+0x234/0x6a0 fs/char_dev.c:414
       do_dentry_open+0x982/0x1530 fs/open.c:965
       vfs_open+0x82/0x3f0 fs/open.c:1095
       do_open fs/namei.c:3887 [inline]
       path_openat+0x1de4/0x2cb0 fs/namei.c:4046
       do_filp_open+0x20b/0x470 fs/namei.c:4073
       do_sys_openat2+0x11b/0x1d0 fs/open.c:1435
       do_sys_open fs/open.c:1450 [inline]
       __do_sys_openat fs/open.c:1466 [inline]
       __se_sys_openat fs/open.c:1461 [inline]
       __x64_sys_openat+0x174/0x210 fs/open.c:1461
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0x490 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ima_iint_mutex_key[depth] --> cpuhp_state-up --> dpm_list_mtx

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(dpm_list_mtx);
                               lock(cpuhp_state-up);
                               lock(dpm_list_mtx);
  lock(&ima_iint_mutex_key[depth]);

 *** DEADLOCK ***

5 locks held by syz.6.2329/13740:
 #0: ffffffff8f303688 (misc_mtx){+.+.}-{4:4}, at: misc_open+0x63/0x420 drivers/char/misc.c:125
 #1: ffffffff8e484768 (system_transition_mutex){+.+.}-{4:4}, at: lock_system_sleep+0x87/0xa0 kernel/power/main.c:57
 #2: ffffffff8e4c4bd0 ((pm_chain_head).rwsem){++++}-{4:4}, at: blocking_notifier_call_chain_robust kernel/notifier.c:344 [inline]
 #2: ffffffff8e4c4bd0 ((pm_chain_head).rwsem){++++}-{4:4}, at: blocking_notifier_call_chain_robust+0xa8/0x160 kernel/notifier.c:333
 #3: ffffffff8f519108 (fw_lock){+.+.}-{4:4}, at: device_cache_fw_images drivers/base/firmware_loader/main.c:1513 [inline]
 #3: ffffffff8f519108 (fw_lock){+.+.}-{4:4}, at: fw_pm_notify+0x69/0x150 drivers/base/firmware_loader/main.c:1566
 #4: ffffffff8f513b08 (dpm_list_mtx){+.+.}-{4:4}, at: device_pm_lock drivers/base/power/main.c:128 [inline]
 #4: ffffffff8f513b08 (dpm_list_mtx){+.+.}-{4:4}, at: dpm_for_each_dev drivers/base/power/main.c:2290 [inline]
 #4: ffffffff8f513b08 (dpm_list_mtx){+.+.}-{4:4}, at: dpm_for_each_dev+0x2d/0xb0 drivers/base/power/main.c:2283

stack backtrace:
CPU: 1 UID: 0 PID: 13740 Comm: syz.6.2329 Tainted: GF R                 6.16.0-syzkaller-11741-g5998f2bca43e #0 PREEMPT(full) 
Tainted: [F]=FORCED_MODULE, [R]=FORCED_RMMOD
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2025
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
 print_circular_bug+0x275/0x350 kernel/locking/lockdep.c:2043
 check_noncircular+0x14c/0x170 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x12a6/0x1ce0 kernel/locking/lockdep.c:5237
 lock_acquire kernel/locking/lockdep.c:5868 [inline]
 lock_acquire+0x179/0x350 kernel/locking/lockdep.c:5825
 __mutex_lock_common kernel/locking/mutex.c:598 [inline]
 __mutex_lock+0x193/0x10b0 kernel/locking/mutex.c:760
 process_measurement+0x7e0/0x23e0 security/integrity/ima/ima_main.c:299
 ima_file_check+0xc5/0x110 security/integrity/ima/ima_main.c:633
 security_file_post_open+0x8e/0x210 security/security.c:3160
 do_open fs/namei.c:3889 [inline]
 path_openat+0x1404/0x2cb0 fs/namei.c:4046
 do_file_open_root+0x322/0x610 fs/namei.c:4098
 file_open_root+0x2a7/0x450 fs/open.c:1414
 kernel_read_file_from_path_initns+0x189/0x260 fs/kernel_read_file.c:163
 fw_get_filesystem_firmware drivers/base/firmware_loader/main.c:549 [inline]
 _request_firmware+0x744/0x1470 drivers/base/firmware_loader/main.c:881
 request_firmware drivers/base/firmware_loader/main.c:957 [inline]
 cache_firmware drivers/base/firmware_loader/main.c:1295 [inline]
 __async_dev_cache_fw_image+0xb1/0x340 drivers/base/firmware_loader/main.c:1409
 async_schedule_node_domain+0xd1/0x120 kernel/async.c:221
 async_schedule_domain include/linux/async.h:72 [inline]
 dev_cache_fw_image+0x38e/0x490 drivers/base/firmware_loader/main.c:1465
 dpm_for_each_dev drivers/base/power/main.c:2292 [inline]
 dpm_for_each_dev+0x5d/0xb0 drivers/base/power/main.c:2283
 device_cache_fw_images drivers/base/firmware_loader/main.c:1515 [inline]
 fw_pm_notify+0x81/0x150 drivers/base/firmware_loader/main.c:1566
 notifier_call_chain+0xbc/0x410 kernel/notifier.c:85
 notifier_call_chain_robust kernel/notifier.c:120 [inline]
 blocking_notifier_call_chain_robust kernel/notifier.c:345 [inline]
 blocking_notifier_call_chain_robust+0xc8/0x160 kernel/notifier.c:333
 pm_notifier_call_chain_robust+0x27/0x60 kernel/power/main.c:103
 snapshot_open+0x218/0x2b0 kernel/power/user.c:87
 misc_open+0x35a/0x420 drivers/char/misc.c:161
 chrdev_open+0x234/0x6a0 fs/char_dev.c:414
 do_dentry_open+0x982/0x1530 fs/open.c:965
 vfs_open+0x82/0x3f0 fs/open.c:1095
 do_open fs/namei.c:3887 [inline]
 path_openat+0x1de4/0x2cb0 fs/namei.c:4046
 do_filp_open+0x20b/0x470 fs/namei.c:4073
 do_sys_openat2+0x11b/0x1d0 fs/open.c:1435
 do_sys_open fs/open.c:1450 [inline]
 __do_sys_openat fs/open.c:1466 [inline]
 __se_sys_openat fs/open.c:1461 [inline]
 __x64_sys_openat+0x174/0x210 fs/open.c:1461
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xcd/0x490 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f424ab8eb69
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f42489f6038 EFLAGS: 00000246 ORIG_RAX: 0000000000000101
RAX: ffffffffffffffda RBX: 00007f424adb5fa0 RCX: 00007f424ab8eb69
RDX: 0000000000001001 RSI: 0000200000000180 RDI: ffffffffffffff9c
RBP: 00007f424ac11df1 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f424adb5fa0 R15: 00007fff785504a8
 </TASK>