syzbot


possible deadlock in jbd2_journal_lock_updates

Status: upstream: reported C repro on 2022/08/08 07:34
Reported-by: syzbot+79e6bbabf3ce17357969@syzkaller.appspotmail.com
First crash: 52d, last: now

Cause bisection: failed (bisect log)
Patch testing requests:
Created Duration User Patch Repo Result
2022/08/21 02:36 18m hdanton@sina.com patch https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git ca688bff68bc OK log
2022/08/19 12:20 18m hdanton@sina.com patch https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git ca688bff68bc OK log

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.0.0-rc6-syzkaller-00309-g1a61b828566f #0 Not tainted
------------------------------------------------------
syz-executor190/3605 is trying to acquire lock:
ffff88814acce170 (&journal->j_barrier){+.+.}-{3:3}, at: jbd2_journal_lock_updates+0x15e/0x310 fs/jbd2/transaction.c:904

but task is already holding lock:
ffff88814acccbd8 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x178/0x530 fs/ext4/inode.c:6013

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&sbi->s_writepages_rwsem){++++}-{0:0}:
       percpu_down_write+0x4d/0x440 kernel/locking/percpu-rwsem.c:221
       ext4_change_inode_journal_flag+0x178/0x530 fs/ext4/inode.c:6013
       ext4_ioctl_setflags fs/ext4/ioctl.c:685 [inline]
       ext4_fileattr_set+0xddf/0x1930 fs/ext4/ioctl.c:1001
       vfs_fileattr_set+0x7f5/0xbe0 fs/ioctl.c:696
       ioctl_fssetxattr fs/ioctl.c:758 [inline]
       do_vfs_ioctl+0xe62/0x15c0 fs/ioctl.c:845
       __do_sys_ioctl fs/ioctl.c:868 [inline]
       __se_sys_ioctl fs/ioctl.c:856 [inline]
       __x64_sys_ioctl+0x108/0x200 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #3 (mapping.invalidate_lock){++++}-{3:3}:
       down_write+0x90/0x150 kernel/locking/rwsem.c:1552
       filemap_invalidate_lock include/linux/fs.h:801 [inline]
       ext4_setattr+0xd9e/0x2c50 fs/ext4/inode.c:5445
       notify_change+0xcd0/0x1440 fs/attr.c:420
       do_truncate+0x13c/0x200 fs/open.c:65
       do_sys_ftruncate+0x536/0x730 fs/open.c:193
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #2 (&sb->s_type->i_mutex_key#8){++++}-{3:3}:
       down_read+0x98/0x450 kernel/locking/rwsem.c:1499
       inode_lock_shared include/linux/fs.h:766 [inline]
       ext4_bmap+0x4e/0x460 fs/ext4/inode.c:3157
       bmap+0xaa/0x120 fs/inode.c:1799
       jbd2_journal_bmap+0xa8/0x180 fs/jbd2/journal.c:971
       __jbd2_journal_erase fs/jbd2/journal.c:1784 [inline]
       jbd2_journal_flush+0x84f/0xc00 fs/jbd2/journal.c:2490
       ext4_ioctl_checkpoint fs/ext4/ioctl.c:1082 [inline]
       __ext4_ioctl+0x28fd/0x4ab0 fs/ext4/ioctl.c:1586
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:870 [inline]
       __se_sys_ioctl fs/ioctl.c:856 [inline]
       __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #1 (&journal->j_checkpoint_mutex){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       mutex_lock_io_nested+0x13f/0x1190 kernel/locking/mutex.c:833
       jbd2_journal_flush+0x19a/0xc00 fs/jbd2/journal.c:2462
       ext4_ioctl_checkpoint fs/ext4/ioctl.c:1082 [inline]
       __ext4_ioctl+0x28fd/0x4ab0 fs/ext4/ioctl.c:1586
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:870 [inline]
       __se_sys_ioctl fs/ioctl.c:856 [inline]
       __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&journal->j_barrier){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3095 [inline]
       check_prevs_add kernel/locking/lockdep.c:3214 [inline]
       validate_chain kernel/locking/lockdep.c:3829 [inline]
       __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5053
       lock_acquire kernel/locking/lockdep.c:5666 [inline]
       lock_acquire+0x1ab/0x570 kernel/locking/lockdep.c:5631
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x12f/0x1350 kernel/locking/mutex.c:747
       jbd2_journal_lock_updates+0x15e/0x310 fs/jbd2/transaction.c:904
       ext4_change_inode_journal_flag+0x180/0x530 fs/ext4/inode.c:6014
       ext4_ioctl_setflags fs/ext4/ioctl.c:685 [inline]
       ext4_fileattr_set+0xddf/0x1930 fs/ext4/ioctl.c:1001
       vfs_fileattr_set+0x7f5/0xbe0 fs/ioctl.c:696
       ioctl_fssetxattr fs/ioctl.c:758 [inline]
       do_vfs_ioctl+0xe62/0x15c0 fs/ioctl.c:845
       __do_sys_ioctl fs/ioctl.c:868 [inline]
       __se_sys_ioctl fs/ioctl.c:856 [inline]
       __x64_sys_ioctl+0x108/0x200 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

Chain exists of:
  &journal->j_barrier --> mapping.invalidate_lock --> &sbi->s_writepages_rwsem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&sbi->s_writepages_rwsem);
                               lock(mapping.invalidate_lock);
                               lock(&sbi->s_writepages_rwsem);
  lock(&journal->j_barrier);

 *** DEADLOCK ***

4 locks held by syz-executor190/3605:
 #0: ffff88814acca460 (sb_writers#4){.+.+}-{0:0}, at: ioctl_setflags fs/ioctl.c:725 [inline]
 #0: ffff88814acca460 (sb_writers#4){.+.+}-{0:0}, at: do_vfs_ioctl+0xe27/0x15c0 fs/ioctl.c:839
 #1: ffff88807419a218 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: inode_lock include/linux/fs.h:756 [inline]
 #1: ffff88807419a218 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: vfs_fileattr_set+0x148/0xbe0 fs/ioctl.c:681
 #2: ffff88807419a3b8 (mapping.invalidate_lock){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:801 [inline]
 #2: ffff88807419a3b8 (mapping.invalidate_lock){++++}-{3:3}, at: ext4_change_inode_journal_flag+0x11f/0x530 fs/ext4/inode.c:6005
 #3: ffff88814acccbd8 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x178/0x530 fs/ext4/inode.c:6013

stack backtrace:
CPU: 1 PID: 3605 Comm: syz-executor190 Not tainted 6.0.0-rc6-syzkaller-00309-g1a61b828566f #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/26/2022
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106
 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3095 [inline]
 check_prevs_add kernel/locking/lockdep.c:3214 [inline]
 validate_chain kernel/locking/lockdep.c:3829 [inline]
 __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5053
 lock_acquire kernel/locking/lockdep.c:5666 [inline]
 lock_acquire+0x1ab/0x570 kernel/locking/lockdep.c:5631
 __mutex_lock_common kernel/locking/mutex.c:603 [inline]
 __mutex_lock+0x12f/0x1350 kernel/locking/mutex.c:747
 jbd2_journal_lock_updates+0x15e/0x310 fs/jbd2/transaction.c:904
 ext4_change_inode_journal_flag+0x180/0x530 fs/ext4/inode.c:6014
 ext4_ioctl_setflags fs/ext4/ioctl.c:685 [inline]
 ext4_fileattr_set+0xddf/0x1930 fs/ext4/ioctl.c:1001
 vfs_fileattr_set+0x7f5/0xbe0 fs/ioctl.c:696
 ioctl_fssetxattr fs/ioctl.c:758 [inline]
 do_vfs_ioctl+0xe62/0x15c0 fs/ioctl.c:845
 __do_sys_ioctl fs/ioctl.c:868 [inline]
 __se_sys_ioctl fs/ioctl.c:856 [inline]
 __x64_sys_ioctl+0x108/0x200 fs/ioctl.c:856
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f9b3c74ebe9
Code: 28 c3 e8 2a 14 00 00 66 2e 0f 1f 84 00 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48

Crashes (19705):
Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Title
ci-upstream-kasan-gce-root 2022/09/25 02:57 upstream 1a61b828566f 0042f2b4 .config log report syz C possible deadlock in jbd2_journal_lock_updates
ci-upstream-kasan-gce-root 2022/08/21 11:39 upstream 15b3f48a4339 26a13b38 .config log report syz C possible deadlock in jbd2_journal_lock_updates
ci-upstream-bpf-kasan-gce 2022/08/24 19:13 bpf 0947ae112108 514514f6 .config log report syz C possible deadlock in jbd2_journal_lock_updates
ci-upstream-bpf-next-kasan-gce 2022/08/24 18:08 bpf-next d24433c0f4a3 514514f6 .config log report syz C possible deadlock in jbd2_journal_lock_updates
ci-upstream-linux-next-kasan-gce-root 2022/08/08 16:37 linux-next ca688bff68bc 88e3a122 .config log report syz C possible deadlock in jbd2_journal_lock_updates
ci-qemu-upstream 2022/09/29 11:15 upstream c3e0e1e23c70 d9da3ac6 .config log report info possible deadlock in jbd2_journal_lock_updates
ci2-upstream-fs 2022/09/29 09:23 upstream 49c13ed0316d a41a2080 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-kasan-gce-root 2022/09/29 08:19 upstream c3e0e1e23c70 e2556bc3 .config log report info possible deadlock in jbd2_journal_lock_updates
ci2-upstream-fs 2022/09/29 07:28 upstream 49c13ed0316d a41a2080 .config log report info possible deadlock in jbd2_journal_lock_updates
ci2-upstream-fs 2022/09/29 06:52 upstream 49c13ed0316d a41a2080 .config log report info possible deadlock in jbd2_journal_lock_updates
ci2-upstream-fs 2022/09/29 06:15 upstream 49c13ed0316d a41a2080 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-kasan-gce-smack-root 2022/09/29 05:36 upstream c3e0e1e23c70 e2556bc3 .config log report info possible deadlock in jbd2_journal_lock_updates
ci2-upstream-fs 2022/09/29 05:32 upstream 49c13ed0316d a41a2080 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-kasan-gce-root 2022/09/29 03:18 upstream c3e0e1e23c70 e2556bc3 .config log report info possible deadlock in jbd2_journal_lock_updates
ci2-upstream-fs 2022/09/29 02:23 upstream 49c13ed0316d a41a2080 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-kasan-gce-selinux-root 2022/09/29 01:48 upstream 49c13ed0316d e2556bc3 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-kasan-gce-selinux-root 2022/09/28 23:02 upstream 49c13ed0316d e2556bc3 .config log report info possible deadlock in jbd2_journal_lock_updates
ci2-upstream-fs 2022/09/28 22:09 upstream 49c13ed0316d a41a2080 .config log report info possible deadlock in jbd2_journal_lock_updates
ci2-upstream-fs 2022/09/28 21:20 upstream 49c13ed0316d a41a2080 .config log report info possible deadlock in jbd2_journal_lock_updates
ci2-upstream-fs 2022/09/28 19:25 upstream 49c13ed0316d a41a2080 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-kasan-gce-root 2022/09/28 19:04 upstream 49c13ed0316d e2556bc3 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-kasan-gce-smack-root 2022/09/28 17:06 upstream 49c13ed0316d e2556bc3 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-kasan-gce-selinux-root 2022/09/28 16:14 upstream 49c13ed0316d e2556bc3 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-kasan-gce-selinux-root 2022/09/28 15:02 upstream 49c13ed0316d e2556bc3 .config log report info possible deadlock in jbd2_journal_lock_updates
ci2-upstream-fs 2022/09/28 14:32 upstream 46452d3786a8 75c78242 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-kasan-gce-smack-root 2022/09/28 14:01 upstream 49c13ed0316d e2556bc3 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-kasan-gce-root 2022/09/28 10:06 upstream 46452d3786a8 75c78242 .config log report info possible deadlock in jbd2_journal_lock_updates
ci2-upstream-fs 2022/09/28 07:36 upstream 46452d3786a8 75c78242 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-kasan-gce-selinux-root 2022/09/28 06:27 upstream 46452d3786a8 75c78242 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-kasan-gce-root 2022/09/28 04:29 upstream 46452d3786a8 75c78242 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-kasan-gce-smack-root 2022/09/28 03:53 upstream 46452d3786a8 75c78242 .config log report info possible deadlock in jbd2_journal_lock_updates
ci2-upstream-fs 2022/09/28 02:53 upstream 46452d3786a8 75c78242 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-kasan-gce-selinux-root 2022/09/28 02:34 upstream 46452d3786a8 75c78242 .config log report info possible deadlock in jbd2_journal_lock_updates
ci2-upstream-fs 2022/09/28 00:23 upstream 46452d3786a8 75c78242 .config log report info possible deadlock in jbd2_journal_lock_updates
ci2-upstream-fs 2022/09/27 23:32 upstream 3800a713b607 10323ddf .config log report info possible deadlock in jbd2_journal_lock_updates
ci2-upstream-fs 2022/09/27 22:39 upstream 3800a713b607 10323ddf .config log report info possible deadlock in jbd2_journal_lock_updates
ci2-upstream-fs 2022/09/27 21:37 upstream 3800a713b607 10323ddf .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-kasan-gce-selinux-root 2022/09/27 20:39 upstream a1375562c0a8 87840e00 .config log report info possible deadlock in jbd2_journal_lock_updates
ci2-upstream-fs 2022/09/27 20:07 upstream 3800a713b607 10323ddf .config log report info possible deadlock in jbd2_journal_lock_updates
ci-qemu-upstream-386 2022/09/28 18:02 upstream 49c13ed0316d e2556bc3 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-qemu-upstream-386 2022/09/28 12:34 upstream 49c13ed0316d e2556bc3 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-qemu-upstream-386 2022/09/28 11:45 upstream 49c13ed0316d e2556bc3 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-bpf-kasan-gce 2022/09/29 00:47 bpf 60240bc26114 e2556bc3 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-bpf-kasan-gce 2022/09/28 20:09 bpf 60240bc26114 e2556bc3 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-net-this-kasan-gce 2022/09/28 15:34 net 44d70bb561da e2556bc3 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-bpf-kasan-gce 2022/09/28 13:11 bpf 60240bc26114 e2556bc3 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-bpf-kasan-gce 2022/09/28 09:11 bpf 60240bc26114 75c78242 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-bpf-kasan-gce 2022/09/28 05:23 bpf 60240bc26114 75c78242 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-bpf-kasan-gce 2022/09/28 01:24 bpf 60240bc26114 75c78242 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-bpf-next-kasan-gce 2022/09/29 10:27 bpf-next 8526f0d6135f 1d385642 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-bpf-next-kasan-gce 2022/09/29 04:30 bpf-next aa55dfd3783f e2556bc3 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-bpf-next-kasan-gce 2022/09/29 03:49 bpf-next aa55dfd3783f e2556bc3 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-net-kasan-gce 2022/09/28 11:07 net-next 7bcd9683e515 75c78242 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-net-kasan-gce 2022/09/28 08:05 net-next 7bcd9683e515 75c78242 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-net-kasan-gce 2022/09/28 06:33 net-next 7bcd9683e515 75c78242 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-linux-next-kasan-gce-root 2022/08/22 22:20 linux-next 8755ae45a9e8 26a13b38 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-linux-next-kasan-gce-root 2022/08/08 07:31 linux-next ca688bff68bc 88e3a122 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-linux-next-kasan-gce-root 2022/08/08 05:07 linux-next ca688bff68bc 88e3a122 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-gce-arm64 2022/09/29 09:38 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci c194837ebb57 1d385642 .config log report info possible deadlock in jbd2_journal_lock_updates
ci-upstream-gce-arm64 2022/09/29 00:11 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci c194837ebb57 e2556bc3 .config log report info possible deadlock in jbd2_journal_lock_updates
* Struck through repros no longer work on HEAD.