syzbot


possible deadlock in evict (2)

Status: closed as dup on 2022/04/21 19:37
Reported-by: syzbot+e0fda9a3d66127dea5c2@syzkaller.appspotmail.com
First crash: 222d, last: 11d
Duplicate of (1):
Title Repro Cause bisect Fix bisect Count Last Reported
possible deadlock in fscrypt_initialize 9 62d 219d
similar bugs (1):
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream possible deadlock in evict 3 623d 651d 0/24 auto-closed as invalid on 2021/07/11 09:40

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.1.0-rc3-syzkaller-00288-gb208b9fbbcba #0 Not tainted
------------------------------------------------------
syz-executor.3/10765 is trying to acquire lock:
ffff88807f456650 (sb_internal){.+.+}-{0:0}, at: evict+0x2ed/0x6b0 fs/inode.c:664

but task is already holding lock:
ffff88807f458b98 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_ext_migrate+0x22c/0x1c10 fs/ext4/migrate.c:436

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&sbi->s_writepages_rwsem){++++}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       ext4_writepages+0x1c4/0x3da0 fs/ext4/inode.c:2694
       do_writepages+0x1ab/0x690 mm/page-writeback.c:2469
       filemap_fdatawrite_wbc mm/filemap.c:388 [inline]
       filemap_fdatawrite_wbc+0x143/0x1b0 mm/filemap.c:378
       __filemap_fdatawrite_range+0xb4/0xf0 mm/filemap.c:421
       filemap_write_and_wait_range+0x85/0x100 mm/filemap.c:674
       __iomap_dio_rw+0x5ed/0x1cb0 fs/iomap/direct-io.c:573
       iomap_dio_rw+0x3c/0xa0 fs/iomap/direct-io.c:690
       ext4_dio_read_iter fs/ext4/file.c:94 [inline]
       ext4_file_read_iter+0x4ba/0x690 fs/ext4/file.c:145
       call_read_iter include/linux/fs.h:2185 [inline]
       generic_file_splice_read+0x17e/0x4b0 fs/splice.c:309
       do_splice_to+0x1b9/0x240 fs/splice.c:793
       splice_direct_to_actor+0x2a7/0x8a0 fs/splice.c:865
       do_splice_direct+0x1a7/0x270 fs/splice.c:974
       do_sendfile+0xb19/0x1270 fs/read_write.c:1255
       __do_sys_sendfile64 fs/read_write.c:1323 [inline]
       __se_sys_sendfile64 fs/read_write.c:1309 [inline]
       __x64_sys_sendfile64+0x1cc/0x210 fs/read_write.c:1309
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #2 (&sb->s_type->i_mutex_key#8){++++}-{3:3}:
       down_read+0x98/0x450 kernel/locking/rwsem.c:1509
       inode_lock_shared include/linux/fs.h:766 [inline]
       ext4_bmap+0x4e/0x460 fs/ext4/inode.c:3164
       bmap+0xaa/0x120 fs/inode.c:1798
       jbd2_journal_bmap+0xa8/0x180 fs/jbd2/journal.c:977
       __jbd2_journal_erase fs/jbd2/journal.c:1789 [inline]
       jbd2_journal_flush+0x84f/0xc00 fs/jbd2/journal.c:2492
       ext4_ioctl_checkpoint fs/ext4/ioctl.c:1082 [inline]
       __ext4_ioctl+0x290a/0x4b70 fs/ext4/ioctl.c:1587
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:870 [inline]
       __se_sys_ioctl fs/ioctl.c:856 [inline]
       __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #1 (&journal->j_checkpoint_mutex){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       mutex_lock_io_nested+0x13f/0x1190 kernel/locking/mutex.c:833
       __jbd2_log_wait_for_space+0x234/0x460 fs/jbd2/checkpoint.c:110
       add_transaction_credits+0xa2d/0xb70 fs/jbd2/transaction.c:298
       start_this_handle+0x3ae/0x14a0 fs/jbd2/transaction.c:422
       jbd2__journal_start+0x399/0x9b0 fs/jbd2/transaction.c:520
       __ext4_journal_start_sb+0x41d/0x530 fs/ext4/ext4_jbd2.c:105
       __ext4_journal_start fs/ext4/ext4_jbd2.h:326 [inline]
       ext4_evict_inode+0x9fa/0x1e30 fs/ext4/inode.c:251
       evict+0x2ed/0x6b0 fs/inode.c:664
       iput_final fs/inode.c:1747 [inline]
       iput.part.0+0x59b/0x880 fs/inode.c:1773
       iput+0x58/0x70 fs/inode.c:1763
       d_delete_notify include/linux/fsnotify.h:261 [inline]
       vfs_rmdir.part.0+0x496/0x5a0 fs/namei.c:4133
       vfs_rmdir fs/namei.c:4105 [inline]
       do_rmdir+0x3a6/0x430 fs/namei.c:4181
       __do_sys_unlinkat fs/namei.c:4361 [inline]
       __se_sys_unlinkat fs/namei.c:4355 [inline]
       __x64_sys_unlinkat+0xeb/0x130 fs/namei.c:4355
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (sb_internal){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3097 [inline]
       check_prevs_add kernel/locking/lockdep.c:3216 [inline]
       validate_chain kernel/locking/lockdep.c:3831 [inline]
       __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055
       lock_acquire kernel/locking/lockdep.c:5668 [inline]
       lock_acquire+0x1df/0x630 kernel/locking/lockdep.c:5633
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1826 [inline]
       sb_start_intwrite include/linux/fs.h:1948 [inline]
       ext4_evict_inode+0x12bd/0x1e30 fs/ext4/inode.c:240
       evict+0x2ed/0x6b0 fs/inode.c:664
       iput_final fs/inode.c:1747 [inline]
       iput.part.0+0x59b/0x880 fs/inode.c:1773
       iput+0x58/0x70 fs/inode.c:1763
       ext4_ext_migrate+0xb9d/0x1c10 fs/ext4/migrate.c:586
       __ext4_ioctl+0x12a4/0x4b70 fs/ext4/ioctl.c:1389
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:870 [inline]
       __se_sys_ioctl fs/ioctl.c:856 [inline]
       __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

Chain exists of:
  sb_internal --> &sb->s_type->i_mutex_key#8 --> &sbi->s_writepages_rwsem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&sbi->s_writepages_rwsem);
                               lock(&sb->s_type->i_mutex_key#8);
                               lock(&sbi->s_writepages_rwsem);
  lock(sb_internal);

 *** DEADLOCK ***

3 locks held by syz-executor.3/10765:
 #0: ffff88807f456460 (sb_writers#4){.+.+}-{0:0}, at: __ext4_ioctl+0x1273/0x4b70 fs/ext4/ioctl.c:1379
 #1: ffff888072455440 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: inode_lock include/linux/fs.h:756 [inline]
 #1: ffff888072455440 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: __ext4_ioctl+0x129c/0x4b70 fs/ext4/ioctl.c:1388
 #2: ffff88807f458b98 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_ext_migrate+0x22c/0x1c10 fs/ext4/migrate.c:436

stack backtrace:
CPU: 1 PID: 10765 Comm: syz-executor.3 Not tainted 6.1.0-rc3-syzkaller-00288-gb208b9fbbcba #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106
 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2177
 check_prev_add kernel/locking/lockdep.c:3097 [inline]
 check_prevs_add kernel/locking/lockdep.c:3216 [inline]
 validate_chain kernel/locking/lockdep.c:3831 [inline]
 __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055
 lock_acquire kernel/locking/lockdep.c:5668 [inline]
 lock_acquire+0x1df/0x630 kernel/locking/lockdep.c:5633
 percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
 __sb_start_write include/linux/fs.h:1826 [inline]
 sb_start_intwrite include/linux/fs.h:1948 [inline]
 ext4_evict_inode+0x12bd/0x1e30 fs/ext4/inode.c:240
 evict+0x2ed/0x6b0 fs/inode.c:664
 iput_final fs/inode.c:1747 [inline]
 iput.part.0+0x59b/0x880 fs/inode.c:1773
 iput+0x58/0x70 fs/inode.c:1763
 ext4_ext_migrate+0xb9d/0x1c10 fs/ext4/migrate.c:586
 __ext4_ioctl+0x12a4/0x4b70 fs/ext4/ioctl.c:1389
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:870 [inline]
 __se_sys_ioctl fs/ioctl.c:856 [inline]
 __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:856
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f812768b5a9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f812844b168 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f81277ac050 RCX: 00007f812768b5a9
RDX: 0000000000000000 RSI: 0000000000006609 RDI: 0000000000000003
RBP: 00007f81276e67b0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffe125440ff R14: 00007f812844b300 R15: 0000000000022000
 </TASK>

Crashes (29):
Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Title
ci-upstream-kasan-gce-root 2022/11/05 20:11 upstream b208b9fbbcba 6d752409 .config log report info possible deadlock in evict
ci-upstream-kasan-gce-root 2022/10/01 10:15 upstream ffb4d94b4314 feb56351 .config log report info possible deadlock in evict
ci-qemu-upstream 2022/09/13 03:50 upstream 6504d82f4440 f371ed7e .config log report info possible deadlock in evict
ci-upstream-kasan-gce-root 2022/08/26 04:23 upstream 4c612826bec1 15195ea3 .config log report info possible deadlock in evict
ci-upstream-kasan-gce-root 2022/08/24 03:36 upstream df0219d11b6f cea8b0f7 .config log report info possible deadlock in evict
ci-upstream-kasan-gce-root 2022/08/18 18:34 upstream 3b06a2755758 d58e263f .config log report info possible deadlock in evict
ci-upstream-kasan-gce-root 2022/08/18 01:53 upstream 274a2eebf80c d58e263f .config log report info possible deadlock in evict
ci-qemu-upstream 2022/04/17 12:50 upstream a2c29ccd9477 8bcc32a6 .config log report info possible deadlock in evict
ci-qemu-upstream-386 2022/10/05 10:59 upstream 2bca25eaeba6 e0b72940 .config log report info possible deadlock in evict
ci-qemu-upstream-386 2022/09/29 20:37 upstream 511cce163b75 d9da3ac6 .config log report info possible deadlock in evict
ci-qemu-upstream-386 2022/09/10 00:34 upstream ce888220d5c7 356d8217 .config log report info possible deadlock in evict
ci-qemu-upstream-386 2022/08/02 01:42 upstream 9de1f9c8ca51 fef302b1 .config log report info possible deadlock in evict
ci-upstream-net-this-kasan-gce 2022/11/07 15:04 net f9027f88f7d1 a779b11a .config log report info possible deadlock in evict
ci-upstream-net-this-kasan-gce 2022/10/21 00:43 net fa182ea26ff0 a0fd4dab .config log report info possible deadlock in evict
ci-upstream-net-this-kasan-gce 2022/09/30 16:55 net 0bafedc53649 feb56351 .config log report info possible deadlock in evict
ci-upstream-net-this-kasan-gce 2022/09/30 16:15 net 0bafedc53649 feb56351 .config log report info possible deadlock in evict
ci-upstream-net-this-kasan-gce 2022/09/05 11:46 net 060ad609fa38 922294ab .config log report info possible deadlock in evict
ci-upstream-net-this-kasan-gce 2022/09/03 07:28 net 05a5474efe93 49e94a20 .config log report info possible deadlock in evict
ci-upstream-net-this-kasan-gce 2022/09/01 06:15 net 90fabae8a2c2 b01ec571 .config log report info possible deadlock in evict
ci-upstream-net-this-kasan-gce 2022/08/27 15:36 net ebe5555c2f34 07177916 .config log report info possible deadlock in evict
ci-upstream-net-kasan-gce 2022/11/15 07:30 net-next f12ed9c04804 97de9cfc .config log report info possible deadlock in evict
ci-upstream-net-kasan-gce 2022/11/08 05:32 net-next fbeb229a6622 881db35d .config log report info possible deadlock in evict
ci-upstream-net-kasan-gce 2022/11/07 13:32 net-next fbeb229a6622 a779b11a .config log report info possible deadlock in evict
ci-upstream-net-kasan-gce 2022/10/03 11:12 net-next 9d43507319cc feb56351 .config log report info possible deadlock in evict
ci-upstream-net-kasan-gce 2022/09/26 06:33 net-next 9258b8b1be2e 0042f2b4 .config log report info possible deadlock in evict
ci-upstream-net-kasan-gce 2022/09/22 03:18 net-next 6fb4825e492b 60af5050 .config log report info possible deadlock in evict
ci-upstream-net-kasan-gce 2022/09/10 08:53 net-next 169ccf0e4082 356d8217 .config log report info possible deadlock in evict
ci-upstream-net-kasan-gce 2022/09/08 21:28 net-next 929d43421ee5 f3027468 .config log report info possible deadlock in evict
ci-upstream-linux-next-kasan-gce-root 2022/08/19 20:07 linux-next 8755ae45a9e8 26a13b38 .config log report info possible deadlock in evict
* Struck through repros no longer work on HEAD.