possible deadlock in io_poll_double

possible deadlock in io_poll_double_wake (2)
Status: upstream: reported C repro on 2020/09/29 02:28
Reported-by: syzbot+28abd693db9e92c160d8@syzkaller.appspotmail.com
Fix commit: io_uring: ignore double poll add on the same waitqueue head
Patched on: [ci-upstream-linux-next-kasan-gce-root], missing on: [ci-qemu-upstream ci-qemu-upstream-386 ci-qemu2-arm32 ci-qemu2-arm64 ci-qemu2-arm64-compat ci-qemu2-arm64-mte ci-upstream-bpf-kasan-gce ci-upstream-bpf-next-kasan-gce ci-upstream-gce-leak ci-upstream-kasan-gce ci-upstream-kasan-gce-386 ci-upstream-kasan-gce-root ci-upstream-kasan-gce-selinux-root ci-upstream-kasan-gce-smack-root ci-upstream-kmsan-gce ci-upstream-kmsan-gce-386 ci-upstream-net-kasan-gce ci-upstream-net-this-kasan-gce ci2-upstream-kcsan-gce ci2-upstream-usb]
First crash: 158d, last: 59m

Cause bisection: failed (bisect log)

Fix bisection: failed (bisect log)

similar bugs (1):
Kernel	Title	Repro	Cause bisect	Fix bisect	Count	Last	Reported	Patched	Status
upstream	possible deadlock in io_poll_double_wake	C			17	170d	198d	0/21	closed as dup on 2020/08/15 18:15

Patch testing requests:
Created	Duration	User	Patch	Repo	Result
2021/03/01 15:27	11m	axboe@kernel.dk		git://git.kernel.dk/linux-block syzbot-test	report log
2021/02/28 23:08	11m	axboe@kernel.dk		git://git.kernel.dk/linux-block syzbot-test	report log

Sample crash report:

============================================
WARNING: possible recursive locking detected
5.11.0-syzkaller #0 Not tainted
--------------------------------------------
swapper/1/0 is trying to acquire lock:
ffff88801b2b1130 (&runtime->sleep){..-.}-{2:2}, at: spin_lock include/linux/spinlock.h:354 [inline]
ffff88801b2b1130 (&runtime->sleep){..-.}-{2:2}, at: io_poll_double_wake+0x25f/0x6a0 fs/io_uring.c:4960

but task is already holding lock:
ffff88801b2b3130 (&runtime->sleep){..-.}-{2:2}, at: __wake_up_common_lock+0xb4/0x130 kernel/sched/wait.c:137

other info that might help us debug this:
 Possible unsafe locking scenario:

       CPU0
       ----
  lock(&runtime->sleep);
  lock(&runtime->sleep);

 *** DEADLOCK ***

 May be due to missing lock nesting notation

2 locks held by swapper/1/0:
 #0: ffff888147474908 (&group->lock){..-.}-{2:2}, at: _snd_pcm_stream_lock_irqsave+0x9f/0xd0 sound/core/pcm_native.c:170
 #1: ffff88801b2b3130 (&runtime->sleep){..-.}-{2:2}, at: __wake_up_common_lock+0xb4/0x130 kernel/sched/wait.c:137

stack backtrace:
CPU: 1 PID: 0 Comm: swapper/1 Not tainted 5.11.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 <IRQ>
 __dump_stack lib/dump_stack.c:79 [inline]
 dump_stack+0xfa/0x151 lib/dump_stack.c:120
 print_deadlock_bug kernel/locking/lockdep.c:2829 [inline]
 check_deadlock kernel/locking/lockdep.c:2872 [inline]
 validate_chain kernel/locking/lockdep.c:3661 [inline]
 __lock_acquire.cold+0x14c/0x3b4 kernel/locking/lockdep.c:4900
 lock_acquire kernel/locking/lockdep.c:5510 [inline]
 lock_acquire+0x1ab/0x730 kernel/locking/lockdep.c:5475
 __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
 _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:151
 spin_lock include/linux/spinlock.h:354 [inline]
 io_poll_double_wake+0x25f/0x6a0 fs/io_uring.c:4960
 __wake_up_common+0x147/0x650 kernel/sched/wait.c:108
 __wake_up_common_lock+0xd0/0x130 kernel/sched/wait.c:138
 snd_pcm_update_state+0x46a/0x540 sound/core/pcm_lib.c:203
 snd_pcm_update_hw_ptr0+0xa75/0x1a50 sound/core/pcm_lib.c:464
 snd_pcm_period_elapsed+0x160/0x250 sound/core/pcm_lib.c:1805
 dummy_hrtimer_callback+0x94/0x1b0 sound/drivers/dummy.c:378
 __run_hrtimer kernel/time/hrtimer.c:1519 [inline]
 __hrtimer_run_queues+0x609/0xe40 kernel/time/hrtimer.c:1583
 hrtimer_run_softirq+0x17b/0x360 kernel/time/hrtimer.c:1600
 __do_softirq+0x29b/0x9f6 kernel/softirq.c:345
 invoke_softirq kernel/softirq.c:221 [inline]
 __irq_exit_rcu kernel/softirq.c:422 [inline]
 irq_exit_rcu+0x134/0x200 kernel/softirq.c:434
 sysvec_apic_timer_interrupt+0x93/0xc0 arch/x86/kernel/apic/apic.c:1100
 </IRQ>
 asm_sysvec_apic_timer_interrupt+0x12/0x20 arch/x86/include/asm/idtentry.h:632
RIP: 0010:native_save_fl arch/x86/include/asm/irqflags.h:29 [inline]
RIP: 0010:arch_local_save_flags arch/x86/include/asm/irqflags.h:70 [inline]
RIP: 0010:arch_irqs_disabled arch/x86/include/asm/irqflags.h:137 [inline]
RIP: 0010:acpi_safe_halt drivers/acpi/processor_idle.c:111 [inline]
RIP: 0010:acpi_idle_do_entry+0x1c9/0x250 drivers/acpi/processor_idle.c:516
Code: dd 38 6e f8 84 db 75 ac e8 54 32 6e f8 e8 0f 1c 74 f8 e9 0c 00 00 00 e8 45 32 6e f8 0f 00 2d 4e 4a c5 00 e8 39 32 6e f8 fb f4 <9c> 5b 81 e3 00 02 00 00 fa 31 ff 48 89 de e8 14 3a 6e f8 48 85 db
RSP: 0018:ffffc90000d47d18 EFLAGS: 00000293
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
RDX: ffff8880115c3780 RSI: ffffffff89052537 RDI: 0000000000000000
RBP: ffff888141127064 R08: 0000000000000001 R09: 0000000000000001
R10: ffffffff81794168 R11: 0000000000000000 R12: 0000000000000001
R13: ffff888141127000 R14: ffff888141127064 R15: ffff888143331804
 acpi_idle_enter+0x361/0x500 drivers/acpi/processor_idle.c:647
 cpuidle_enter_state+0x1b1/0xc80 drivers/cpuidle/cpuidle.c:237
 cpuidle_enter+0x4a/0xa0 drivers/cpuidle/cpuidle.c:351
 call_cpuidle kernel/sched/idle.c:158 [inline]
 cpuidle_idle_call kernel/sched/idle.c:239 [inline]
 do_idle+0x3e1/0x590 kernel/sched/idle.c:300
 cpu_startup_entry+0x14/0x20 kernel/sched/idle.c:397
 start_secondary+0x274/0x350 arch/x86/kernel/smpboot.c:272
 secondary_startup_64_no_verify+0xb0/0xbb

Crashes (104):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	VM info	Title
ci-upstream-kasan-gce	2021/02/28 00:41	upstream	5695e516	4c37c133	.config	log	report	syz	C		possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce	2020/10/01 04:55	upstream	02de58b2	8516f6d3	.config	log	report	syz
ci-upstream-linux-next-kasan-gce-root	2020/12/13 15:56	linux-next	14240d4c	bca53db9	.config	log	report	syz
ci-upstream-linux-next-kasan-gce-root	2020/09/25 02:21	linux-next	d1d2220c	54289b08	.config	log	report	syz
ci-upstream-kasan-gce-selinux-root	2021/03/01 22:47	upstream	fe07bfda	183afb6c	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce	2021/03/01 21:06	upstream	fe07bfda	183afb6c	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce	2021/03/01 19:54	upstream	fe07bfda	183afb6c	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce-selinux-root	2021/03/01 16:32	upstream	fe07bfda	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce	2021/03/01 15:16	upstream	fe07bfda	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-qemu-upstream	2021/03/01 13:44	upstream	fe07bfda	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce-selinux-root	2021/03/01 02:53	upstream	cd278456	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce-selinux-root	2021/03/01 01:36	upstream	cd278456	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-qemu-upstream	2021/03/01 00:25	upstream	cd278456	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce-selinux-root	2021/03/01 00:08	upstream	cd278456	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce-selinux-root	2021/02/28 23:59	upstream	cd278456	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-qemu-upstream	2021/02/28 23:59	upstream	cd278456	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce	2021/02/28 23:55	upstream	cd278456	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce	2021/02/28 23:54	upstream	cd278456	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce	2021/02/28 23:02	upstream	cd278456	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce-root	2021/02/28 14:14	upstream	5695e516	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce-root	2021/02/28 14:12	upstream	5695e516	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce	2021/02/28 11:53	upstream	5695e516	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-qemu-upstream	2021/02/28 11:46	upstream	5695e516	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce-selinux-root	2021/02/28 11:45	upstream	5695e516	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce-smack-root	2021/02/28 11:45	upstream	5695e516	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-qemu-upstream	2021/02/28 11:45	upstream	5695e516	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce-selinux-root	2021/02/28 11:44	upstream	5695e516	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce-smack-root	2021/02/28 11:42	upstream	5695e516	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce	2021/02/28 01:09	upstream	5695e516	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce-selinux-root	2021/02/28 00:57	upstream	5695e516	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce-root	2021/02/28 00:57	upstream	5695e516	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce	2021/02/28 00:07	upstream	5695e516	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce-selinux-root	2021/02/28 00:05	upstream	5695e516	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce-root	2021/02/28 00:05	upstream	5695e516	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-qemu-upstream-386	2021/03/01 23:53	upstream	7a7fd0de	183afb6c	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-qemu-upstream-386	2021/03/01 11:31	upstream	fe07bfda	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-qemu-upstream-386	2021/02/28 23:43	upstream	cd278456	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce-386	2021/02/28 23:39	upstream	06d5d309	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce-386	2021/02/28 23:08	upstream	06d5d309	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce-386	2021/02/28 11:43	upstream	5695e516	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce-386	2021/02/28 11:43	upstream	5695e516	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-qemu-upstream-386	2021/02/28 10:56	upstream	5695e516	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce-386	2021/02/28 10:16	upstream	5695e516	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce-386	2021/02/28 08:20	upstream	5695e516	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-qemu-upstream-386	2021/02/28 01:01	upstream	5ceabb60	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-kasan-gce-386	2021/02/28 00:53	upstream	3fb6d0e0	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-linux-next-kasan-gce-root	2021/03/02 04:39	linux-next	92f791eb	183afb6c	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-linux-next-kasan-gce-root	2021/03/02 03:26	linux-next	92f791eb	183afb6c	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-linux-next-kasan-gce-root	2021/03/01 18:27	linux-next	26ada2d1	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-linux-next-kasan-gce-root	2021/03/01 04:09	linux-next	26ada2d1	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-linux-next-kasan-gce-root	2021/02/28 12:34	linux-next	d01f2f7e	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-linux-next-kasan-gce-root	2021/02/28 12:32	linux-next	d01f2f7e	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-linux-next-kasan-gce-root	2021/02/28 01:02	linux-next	d01f2f7e	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake
ci-upstream-linux-next-kasan-gce-root	2021/02/28 00:08	linux-next	d01f2f7e	4c37c133	.config	log	report			info	possible deadlock in io_poll_double_wake