syzbot


possible deadlock in proc_tgid_io_accounting

Status: auto-closed as invalid on 2020/07/30 02:14
Subsystems: fs
[Documentation on labels]
Reported-by: syzbot+86a925872c5fba672f8c@syzkaller.appspotmail.com
First crash: 1630d, last: 1571d
Discussions (1)
Title Replies (including bot) Last reply
possible deadlock in proc_tgid_io_accounting 0 (1) 2020/02/03 19:38
Similar bugs (4)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-4.14 possible deadlock in proc_tgid_io_accounting C error 9 836d 1446d 0/1 upstream: reported C repro on 2020/08/03 19:18
linux-4.19 possible deadlock in proc_tgid_io_accounting 208 633d 1446d 0/1 auto-obsoleted due to no activity on 2023/02/23 02:05
upstream possible deadlock in proc_tgid_io_accounting (2) fs 1 1412d 1408d 0/27 auto-closed as invalid on 2021/01/04 23:12
linux-4.19 possible deadlock in proc_tgid_io_accounting (2) 2 505d 509d 0/1 upstream: reported on 2023/02/26 17:26

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
5.6.0-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.3/1164 is trying to acquire lock:
ffff88809ef9d2f8 (&sig->cred_guard_mutex){+.+.}-{3:3}, at: do_io_accounting fs/proc/base.c:2864 [inline]
ffff88809ef9d2f8 (&sig->cred_guard_mutex){+.+.}-{3:3}, at: proc_tgid_io_accounting+0x163/0x570 fs/proc/base.c:2913

but task is already holding lock:
ffff88808e790b58 (&p->lock){+.+.}-{3:3}, at: seq_read+0x66/0xd20 fs/seq_file.c:161

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&p->lock){+.+.}-{3:3}:
       lock_acquire+0x169/0x480 kernel/locking/lockdep.c:4923
       __mutex_lock_common+0x189/0x2fc0 kernel/locking/mutex.c:956
       __mutex_lock kernel/locking/mutex.c:1103 [inline]
       mutex_lock_nested+0x1a/0x20 kernel/locking/mutex.c:1118
       seq_read+0x66/0xd20 fs/seq_file.c:161
       proc_reg_read+0x1cd/0x2c0 fs/proc/inode.c:223
       do_loop_readv_writev fs/read_write.c:714 [inline]
       do_iter_read+0x43e/0x550 fs/read_write.c:935
       vfs_readv+0xc2/0x120 fs/read_write.c:1053
       kernel_readv fs/splice.c:365 [inline]
       default_file_splice_read+0x579/0xa40 fs/splice.c:422
       do_splice_to fs/splice.c:892 [inline]
       splice_direct_to_actor+0x3c1/0xb40 fs/splice.c:971
       do_splice_direct+0x201/0x340 fs/splice.c:1080
       do_sendfile+0x809/0xfd0 fs/read_write.c:1520
       __do_sys_sendfile64 fs/read_write.c:1581 [inline]
       __se_sys_sendfile64 fs/read_write.c:1567 [inline]
       __x64_sys_sendfile64+0x164/0x1a0 fs/read_write.c:1567
       do_syscall_64+0xf3/0x1b0 arch/x86/entry/common.c:295
       entry_SYSCALL_64_after_hwframe+0x49/0xb3

-> #2 (sb_writers#3){.+.+}-{0:0}:
       lock_acquire+0x169/0x480 kernel/locking/lockdep.c:4923
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write+0x14b/0x410 fs/super.c:1674
       sb_start_write include/linux/fs.h:1650 [inline]
       mnt_want_write+0x45/0x90 fs/namespace.c:354
       ovl_create_object+0xb1/0x2b0 fs/overlayfs/dir.c:596
       lookup_open fs/namei.c:3309 [inline]
       do_last fs/namei.c:3401 [inline]
       path_openat+0x2221/0x40f0 fs/namei.c:3607
       do_filp_open+0x191/0x3a0 fs/namei.c:3637
       do_sys_openat2+0x448/0x6c0 fs/open.c:1146
       do_sys_open fs/open.c:1162 [inline]
       ksys_open include/linux/syscalls.h:1386 [inline]
       __do_sys_open fs/open.c:1168 [inline]
       __se_sys_open fs/open.c:1166 [inline]
       __x64_sys_open+0x1af/0x1e0 fs/open.c:1166
       do_syscall_64+0xf3/0x1b0 arch/x86/entry/common.c:295
       entry_SYSCALL_64_after_hwframe+0x49/0xb3

-> #1 (&ovl_i_mutex_dir_key[depth]#2){++++}-{3:3}:
       lock_acquire+0x169/0x480 kernel/locking/lockdep.c:4923
       down_read+0x36/0x50 kernel/locking/rwsem.c:1492
       inode_lock_shared include/linux/fs.h:802 [inline]
       do_last fs/namei.c:3400 [inline]
       path_openat+0xbf2/0x40f0 fs/namei.c:3607
       do_filp_open+0x191/0x3a0 fs/namei.c:3637
       do_open_execat+0x101/0x5f0 fs/exec.c:860
       __do_execve_file+0x6ea/0x1b80 fs/exec.c:1791
       do_execveat_common fs/exec.c:1897 [inline]
       do_execve fs/exec.c:1914 [inline]
       __do_sys_execve fs/exec.c:1990 [inline]
       __se_sys_execve fs/exec.c:1985 [inline]
       __x64_sys_execve+0x90/0xa0 fs/exec.c:1985
       do_syscall_64+0xf3/0x1b0 arch/x86/entry/common.c:295
       entry_SYSCALL_64_after_hwframe+0x49/0xb3

-> #0 (&sig->cred_guard_mutex){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:2515 [inline]
       check_prevs_add kernel/locking/lockdep.c:2620 [inline]
       validate_chain+0x1b09/0x8920 kernel/locking/lockdep.c:3237
       __lock_acquire+0x116c/0x2b90 kernel/locking/lockdep.c:4344
       lock_acquire+0x169/0x480 kernel/locking/lockdep.c:4923
       __mutex_lock_common+0x189/0x2fc0 kernel/locking/mutex.c:956
       __mutex_lock kernel/locking/mutex.c:1103 [inline]
       mutex_lock_killable_nested+0x1a/0x20 kernel/locking/mutex.c:1133
       do_io_accounting fs/proc/base.c:2864 [inline]
       proc_tgid_io_accounting+0x163/0x570 fs/proc/base.c:2913
       proc_single_show+0xd5/0x160 fs/proc/base.c:758
       seq_read+0x4aa/0xd20 fs/seq_file.c:229
       do_loop_readv_writev fs/read_write.c:714 [inline]
       do_iter_read+0x43e/0x550 fs/read_write.c:935
       vfs_readv fs/read_write.c:1053 [inline]
       do_preadv+0x17b/0x290 fs/read_write.c:1145
       do_syscall_64+0xf3/0x1b0 arch/x86/entry/common.c:295
       entry_SYSCALL_64_after_hwframe+0x49/0xb3

other info that might help us debug this:

Chain exists of:
  &sig->cred_guard_mutex --> sb_writers#3 --> &p->lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&p->lock);
                               lock(sb_writers#3);
                               lock(&p->lock);
  lock(&sig->cred_guard_mutex);

 *** DEADLOCK ***

1 lock held by syz-executor.3/1164:
 #0: ffff88808e790b58 (&p->lock){+.+.}-{3:3}, at: seq_read+0x66/0xd20 fs/seq_file.c:161

stack backtrace:
CPU: 1 PID: 1164 Comm: syz-executor.3 Not tainted 5.6.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x1e9/0x30e lib/dump_stack.c:118
 print_circular_bug+0xc72/0xea0 kernel/locking/lockdep.c:1722
 check_noncircular+0x1fb/0x3a0 kernel/locking/lockdep.c:1846
 check_prev_add kernel/locking/lockdep.c:2515 [inline]
 check_prevs_add kernel/locking/lockdep.c:2620 [inline]
 validate_chain+0x1b09/0x8920 kernel/locking/lockdep.c:3237
 __lock_acquire+0x116c/0x2b90 kernel/locking/lockdep.c:4344
 lock_acquire+0x169/0x480 kernel/locking/lockdep.c:4923
 __mutex_lock_common+0x189/0x2fc0 kernel/locking/mutex.c:956
 __mutex_lock kernel/locking/mutex.c:1103 [inline]
 mutex_lock_killable_nested+0x1a/0x20 kernel/locking/mutex.c:1133
 do_io_accounting fs/proc/base.c:2864 [inline]
 proc_tgid_io_accounting+0x163/0x570 fs/proc/base.c:2913
 proc_single_show+0xd5/0x160 fs/proc/base.c:758
 seq_read+0x4aa/0xd20 fs/seq_file.c:229
 do_loop_readv_writev fs/read_write.c:714 [inline]
 do_iter_read+0x43e/0x550 fs/read_write.c:935
 vfs_readv fs/read_write.c:1053 [inline]
 do_preadv+0x17b/0x290 fs/read_write.c:1145
 do_syscall_64+0xf3/0x1b0 arch/x86/entry/common.c:295
 entry_SYSCALL_64_after_hwframe+0x49/0xb3
RIP: 0033:0x45c849
Code: ad b6 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 7b b6 fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007fee303cdc78 EFLAGS: 00000246 ORIG_RAX: 0000000000000127
RAX: ffffffffffffffda RBX: 00007fee303ce6d4 RCX: 000000000045c849
RDX: 000000000000037d RSI: 0000000020000500 RDI: 0000000000000006
RBP: 000000000076c040 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00000000ffffffff
R13: 000000000000085a R14: 00000000004cb1ac R15: 000000000076c04c

Crashes (9):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/04/01 02:13 upstream 56a451b78067 a34e2c33 .config console log report ci-upstream-kasan-gce-smack-root
2020/03/30 02:56 upstream e595dd94515e 05736b29 .config console log report ci-upstream-kasan-gce-smack-root
2020/03/30 02:56 upstream e595dd94515e 05736b29 .config console log report ci-upstream-kasan-gce-smack-root
2020/03/24 06:05 upstream 979e52ca0469 33e14df3 .config console log report ci-upstream-kasan-gce-smack-root
2020/03/21 12:33 upstream 5ad0ec0b8652 4288d95e .config console log report ci-upstream-kasan-gce-smack-root
2020/03/03 13:15 upstream 63623fd44972 c88c7b75 .config console log report ci-upstream-kasan-gce-smack-root
2020/02/24 01:18 upstream d2eee25858f2 d801cb02 .config console log report ci-upstream-kasan-gce-smack-root
2020/02/10 23:06 upstream bb6d3fb354c5 18847f55 .config console log report ci-upstream-kasan-gce-smack-root
2020/02/01 21:52 upstream 94f2630b1897 2274ad39 .config console log report ci-upstream-kasan-gce-smack-root
* Struck through repros no longer work on HEAD.