KCSAN: data-race in ext4_writepages / xas_clear

KCSAN: data-race in ext4_writepages / xas_clear_mark (5)
Status: moderation: reported on 2020/12/07 11:55
Reported-by: syzbot+2075ece7f7faae0c842d@syzkaller.appspotmail.com
First crash: 159d, last: 11d

similar bugs (4):
Kernel	Title	Count	Last	Reported	Patched	Status
upstream	KCSAN: data-race in ext4_writepages / xas_clear_mark (4)	5	214d	281d	0/22	auto-closed as invalid on 2020/10/24 01:56
upstream	KCSAN: data-race in ext4_writepages / xas_clear_mark (3)	1	347d	347d	0/22	auto-closed as invalid on 2020/06/18 13:43
upstream	KCSAN: data-race in ext4_writepages / xas_clear_mark	3	538d	544d	0/22	closed as invalid on 2019/11/19 13:24
upstream	KCSAN: data-race in ext4_writepages / xas_clear_mark (2)	1	489d	489d	0/22	auto-closed as invalid on 2020/02/26 13:18

Sample crash report:

==================================================================
BUG: KCSAN: data-race in ext4_writepages / xas_clear_mark

write to 0xffff88801863dd04 of 4 bytes by task 907 on cpu 1:
 xa_mark_clear lib/xarray.c:75 [inline]
 xas_clear_mark+0x16c/0x180 lib/xarray.c:921
 __test_set_page_writeback+0x3db/0x4f0 mm/page-writeback.c:2802
 ext4_bio_write_page+0xfe/0xe60 fs/ext4/page-io.c:450
 mpage_submit_page fs/ext4/inode.c:2102 [inline]
 mpage_process_page_bufs+0x4db/0x5f0 fs/ext4/inode.c:2216
 mpage_prepare_extent_to_map+0x4e6/0x640 fs/ext4/inode.c:2628
 ext4_writepages+0x674/0x1e70 fs/ext4/inode.c:2756
 do_writepages+0x7b/0x150 mm/page-writeback.c:2352
 __filemap_fdatawrite_range+0x19d/0x1d0 mm/filemap.c:424
 file_write_and_wait_range+0x9f/0x120 mm/filemap.c:763
 ext4_sync_file+0x105/0x6e0 fs/ext4/fsync.c:151
 vfs_fsync_range+0x107/0x120 fs/sync.c:200
 generic_write_sync include/linux/fs.h:2843 [inline]
 ext4_buffered_write_iter+0x38f/0x3e0 fs/ext4/file.c:277
 ext4_file_write_iter+0x48a/0x10b0 fs/ext4/file.c:502
 call_write_iter include/linux/fs.h:1977 [inline]
 do_iter_readv_writev+0x2cb/0x360 fs/read_write.c:740
 do_iter_write+0x112/0x4c0 fs/read_write.c:866
 vfs_iter_write+0x4c/0x70 fs/read_write.c:907
 iter_file_splice_write+0x40a/0x750 fs/splice.c:689
 do_splice_from fs/splice.c:767 [inline]
 direct_splice_actor+0x80/0xa0 fs/splice.c:936
 splice_direct_to_actor+0x345/0x650 fs/splice.c:891
 do_splice_direct+0xf5/0x170 fs/splice.c:979
 do_sendfile+0x7a6/0xe20 fs/read_write.c:1260
 __do_sys_sendfile64 fs/read_write.c:1319 [inline]
 __se_sys_sendfile64 fs/read_write.c:1311 [inline]
 __x64_sys_sendfile64+0xa9/0x130 fs/read_write.c:1311
 do_syscall_64+0x39/0x80 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xae

read to 0xffff88801863dd04 of 4 bytes by task 903 on cpu 0:
 xa_marked include/linux/xarray.h:418 [inline]
 mapping_tagged include/linux/fs.h:490 [inline]
 ext4_writepages+0x155/0x1e70 fs/ext4/inode.c:2670
 do_writepages+0x7b/0x150 mm/page-writeback.c:2352
 __filemap_fdatawrite_range+0x19d/0x1d0 mm/filemap.c:424
 filemap_write_and_wait_range+0x8b/0x2a0 mm/filemap.c:657
 __iomap_dio_rw+0x40a/0xa30 fs/iomap/direct-io.c:525
 iomap_dio_rw+0x30/0x70 fs/iomap/direct-io.c:641
 ext4_dio_write_iter fs/ext4/file.c:551 [inline]
 ext4_file_write_iter+0xe5d/0x10b0 fs/ext4/file.c:661
 call_write_iter include/linux/fs.h:1977 [inline]
 do_iter_readv_writev+0x2cb/0x360 fs/read_write.c:740
 do_iter_write+0x112/0x4c0 fs/read_write.c:866
 vfs_iter_write+0x4c/0x70 fs/read_write.c:907
 iter_file_splice_write+0x40a/0x750 fs/splice.c:689
 do_splice_from fs/splice.c:767 [inline]
 direct_splice_actor+0x80/0xa0 fs/splice.c:936
 splice_direct_to_actor+0x345/0x650 fs/splice.c:891
 do_splice_direct+0xf5/0x170 fs/splice.c:979
 do_sendfile+0x7a6/0xe20 fs/read_write.c:1260
 __do_sys_sendfile64 fs/read_write.c:1325 [inline]
 __se_sys_sendfile64 fs/read_write.c:1311 [inline]
 __x64_sys_sendfile64+0xf2/0x130 fs/read_write.c:1311
 do_syscall_64+0x39/0x80 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xae

Reported by Kernel Concurrency Sanitizer on:
CPU: 0 PID: 903 Comm: syz-executor.5 Tainted: G        W         5.12.0-rc6-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
==================================================================

Crashes (14):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	VM info	Title
ci2-upstream-kcsan-gce	2021/04/09 11:28	upstream	17e7124a	6a81331a	.config	log	report	info	KCSAN: data-race in ext4_writepages / xas_clear_mark
ci2-upstream-kcsan-gce	2021/03/13 00:25	upstream	f296bfd5	429d8a6b	.config	log	report	info	KCSAN: data-race in ext4_writepages / xas_clear_mark
ci2-upstream-kcsan-gce	2021/03/12 11:06	upstream	f78d76e7	429d8a6b	.config	log	report	info	KCSAN: data-race in ext4_writepages / xas_clear_mark
ci2-upstream-kcsan-gce	2021/02/11 00:24	upstream	291009f6	a52ee10a	.config	log	report	info	KCSAN: data-race in ext4_writepages / xas_clear_mark
ci2-upstream-kcsan-gce	2021/02/06 15:36	upstream	1e0d27fc	0655e081	.config	log	report	info	KCSAN: data-race in ext4_writepages / xas_clear_mark
ci2-upstream-kcsan-gce	2021/01/31 01:09	upstream	8c947645	fc9fd31e	.config	log	report	info	KCSAN: data-race in ext4_writepages / xas_clear_mark
ci2-upstream-kcsan-gce	2021/01/20 06:14	upstream	45dfb8a5	63631df1	.config	log	report	info	KCSAN: data-race in ext4_writepages / xas_clear_mark
ci2-upstream-kcsan-gce	2021/01/10 22:33	upstream	0653161f	2c1f2513	.config	log	report	info
ci2-upstream-kcsan-gce	2021/01/04 19:28	upstream	36bbbd0e	79264ae3	.config	log	report	info
ci2-upstream-kcsan-gce	2020/12/28 21:24	upstream	c76e02c5	8259d56c	.config	log	report	info
ci2-upstream-kcsan-gce	2020/12/26 12:26	upstream	40f78232	821e0b09	.config	log	report	info
ci2-upstream-kcsan-gce	2020/12/19 01:16	upstream	3644e2d2	04201c06	.config	log	report	info
ci2-upstream-kcsan-gce	2020/11/24 16:51	upstream	d5beb314	e34b696c	.config	log	report	info
ci2-upstream-kcsan-gce	2020/11/12 11:11	upstream	3d5e28bf	77a55c8e	.config	log	report	info