syzbot


WARNING in cfg80211_dev_rename

Status: fixed on 2021/04/09 19:46
Subsystems: wireless
[Documentation on labels]
Reported-by: syzbot+ed107c5fa3e21cdcd86e@syzkaller.appspotmail.com
Fix commit: 0391a45c8007 nl80211: call cfg80211_dev_rename() under RTNL
First crash: 1184d, last: 1178d
Cause bisection: the cause commit could be any of (bisect log):
  2fe8ef106238 cfg80211: change netdev registration/unregistration semantics
  a05829a7222e cfg80211: avoid holding the RTNL when calling the driver
  38ec7c6b6bd6 virt_wifi: fix deadlock on RTNL
  
Discussions (2)
Title Replies (including bot) Last reply
[PATCH 0/4] rtnl-locking fixes 5 (5) 2021/01/28 17:35
WARNING in cfg80211_dev_rename 0 (1) 2021/01/28 16:58

Sample crash report:
netlink: 4 bytes leftover after parsing attributes in process `syz-executor171'.
------------[ cut here ]------------
RTNL: assertion failed at net/wireless/core.c (131)
WARNING: CPU: 1 PID: 8485 at net/wireless/core.c:131 cfg80211_dev_rename+0x1f5/0x230 net/wireless/core.c:131
Modules linked in:
CPU: 1 PID: 8485 Comm: syz-executor171 Not tainted 5.11.0-rc4-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:cfg80211_dev_rename+0x1f5/0x230 net/wireless/core.c:131
Code: 0f 85 5b fe ff ff e8 ca 92 3e f9 ba 83 00 00 00 48 c7 c6 e0 52 61 8a 48 c7 c7 20 53 61 8a c6 05 df 5c bb 04 01 e8 88 05 86 00 <0f> 0b e9 30 fe ff ff e8 4f 70 81 f9 e9 4d fe ff ff e8 45 70 81 f9
RSP: 0018:ffffc900015ef488 EFLAGS: 00010282
RAX: 0000000000000000 RBX: ffffc900015ef680 RCX: 0000000000000000
RDX: ffff888021490000 RSI: ffffffff815b6d25 RDI: fffff520002bde83
RBP: ffff88801b498000 R08: 0000000000000000 R09: 0000000000000000
R10: ffffffff815afefe R11: 0000000000000000 R12: 0000000000000000
R13: ffff888013a58420 R14: ffff88801b4ecbd0 R15: ffff88801b498000
FS:  0000000001f55880(0000) GS:ffff8880b9f00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007faf23dcc000 CR3: 000000001c3ca000 CR4: 00000000001506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 nl80211_set_wiphy+0x22b/0x2b80 net/wireless/nl80211.c:3231
 genl_family_rcv_msg_doit+0x228/0x320 net/netlink/genetlink.c:739
 genl_family_rcv_msg net/netlink/genetlink.c:783 [inline]
 genl_rcv_msg+0x328/0x580 net/netlink/genetlink.c:800
 netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2494
 genl_rcv+0x24/0x40 net/netlink/genetlink.c:811
 netlink_unicast_kernel net/netlink/af_netlink.c:1304 [inline]
 netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1330
 netlink_sendmsg+0x856/0xd90 net/netlink/af_netlink.c:1919
 sock_sendmsg_nosec net/socket.c:652 [inline]
 sock_sendmsg+0xcf/0x120 net/socket.c:672
 ____sys_sendmsg+0x6e8/0x810 net/socket.c:2345
 ___sys_sendmsg+0xf3/0x170 net/socket.c:2399
 __sys_sendmsg+0xe5/0x1b0 net/socket.c:2432
 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x440a29
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 5b 11 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ffe71735868 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 0000000000440a29
RDX: 0000000000000000 RSI: 0000000020000200 RDI: 0000000000000003
RBP: 00000000006ca018 R08: 00000000004002c8 R09: 00000000004002c8
R10: 00000000004002c8 R11: 0000000000000246 R12: 0000000000402010
R13: 00000000004020a0 R14: 0000000000000000 R15: 0000000000000000

Crashes (22):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2021/01/28 12:12 net-next-old d1f3bdd4eaae eefc07f2 .config console log report syz C ci-upstream-net-kasan-gce WARNING in cfg80211_dev_rename
2021/02/03 08:34 net-next-old 9ae4bdc6e4c1 624dad51 .config console log report info ci-upstream-net-kasan-gce WARNING in cfg80211_dev_rename
2021/02/02 05:53 net-next-old 1a2b60f6f165 e6b95f32 .config console log report info ci-upstream-net-kasan-gce WARNING in cfg80211_dev_rename
2021/02/01 23:32 net-next-old 14e8e0f60088 e6b95f32 .config console log report info ci-upstream-net-kasan-gce WARNING in cfg80211_dev_rename
2021/01/31 22:58 net-next-old 14e8e0f60088 fc9fd31e .config console log report info ci-upstream-net-kasan-gce WARNING in cfg80211_dev_rename
2021/01/31 16:46 net-next-old 14e8e0f60088 fc9fd31e .config console log report info ci-upstream-net-kasan-gce WARNING in cfg80211_dev_rename
2021/01/31 16:37 net-next-old 14e8e0f60088 fc9fd31e .config console log report info ci-upstream-net-kasan-gce WARNING in cfg80211_dev_rename
2021/01/31 16:36 net-next-old 14e8e0f60088 fc9fd31e .config console log report info ci-upstream-net-kasan-gce WARNING in cfg80211_dev_rename
2021/01/31 12:21 net-next-old 14e8e0f60088 fc9fd31e .config console log report info ci-upstream-net-kasan-gce WARNING in cfg80211_dev_rename
2021/01/31 02:29 net-next-old 14e8e0f60088 fc9fd31e .config console log report info ci-upstream-net-kasan-gce WARNING in cfg80211_dev_rename
2021/01/30 11:55 net-next-old 14e8e0f60088 fc9fd31e .config console log report info ci-upstream-net-kasan-gce WARNING in cfg80211_dev_rename
2021/01/29 03:05 net-next-old d1f3bdd4eaae 7df34f59 .config console log report info ci-upstream-net-kasan-gce WARNING in cfg80211_dev_rename
2021/01/28 11:32 net-next-old d1f3bdd4eaae eefc07f2 .config console log report info ci-upstream-net-kasan-gce WARNING in cfg80211_dev_rename
2021/01/28 11:19 net-next-old d1f3bdd4eaae eefc07f2 .config console log report info ci-upstream-net-kasan-gce WARNING in cfg80211_dev_rename
2021/01/28 10:48 net-next-old d1f3bdd4eaae eefc07f2 .config console log report info ci-upstream-net-kasan-gce WARNING in cfg80211_dev_rename
2021/01/28 10:46 net-next-old d1f3bdd4eaae eefc07f2 .config console log report info ci-upstream-net-kasan-gce WARNING in cfg80211_dev_rename
2021/01/28 13:09 linux-next d03154e8bb6a eefc07f2 .config console log report info ci-upstream-linux-next-kasan-gce-root WARNING in cfg80211_dev_rename
2021/01/28 12:28 linux-next d03154e8bb6a eefc07f2 .config console log report info ci-upstream-linux-next-kasan-gce-root WARNING in cfg80211_dev_rename
2021/01/28 12:21 linux-next d03154e8bb6a eefc07f2 .config console log report info ci-upstream-linux-next-kasan-gce-root WARNING in cfg80211_dev_rename
2021/01/28 10:13 linux-next d03154e8bb6a eefc07f2 .config console log report info ci-upstream-linux-next-kasan-gce-root WARNING in cfg80211_dev_rename
2021/01/28 10:07 linux-next d03154e8bb6a eefc07f2 .config console log report info ci-upstream-linux-next-kasan-gce-root WARNING in cfg80211_dev_rename
2021/01/28 09:56 linux-next d03154e8bb6a eefc07f2 .config console log report info ci-upstream-linux-next-kasan-gce-root WARNING in cfg80211_dev_rename
* Struck through repros no longer work on HEAD.