KASAN: use-after-free Read in uif

KASAN: use-after-free Read in uif_close
Status: upstream: reported C repro on 2020/05/22 22:34
Reported-by: syzbot+0ce97ea45b008ba3b8bd@syzkaller.appspotmail.com
First crash: 353d, last: 350d

Cause bisection: introduced by (bisect log) :
commit 32ec783ae19d48084b893cc54747fed37b07eb0c
Author: Arnd Bergmann <arnd@arndb.de>
Date: Wed Apr 8 19:02:57 2020 +0000

firmware: imx: fix compile-testing

Crash: INFO: task hung in ctrl_cdev_ioctl (log)
Repro: C syz .config

Patch testing requests:
Created	Duration	User	Patch	Repo	Result
2020/07/14 05:56	17m	rkovhaev@gmail.com		upstream	OK

Sample crash report:

ubi0: detaching mtd0
==================================================================
BUG: KASAN: use-after-free in uif_close+0x15e/0x190 drivers/mtd/ubi/build.c:502
Read of size 4 at addr ffff8880a6ff09e8 by task syz-executor247/8078

CPU: 1 PID: 8078 Comm: syz-executor247 Not tainted 5.7.0-rc6-next-20200522-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x18f/0x20d lib/dump_stack.c:118
 print_address_description.constprop.0.cold+0xd3/0x413 mm/kasan/report.c:383
 __kasan_report mm/kasan/report.c:513 [inline]
 kasan_report.cold+0x1f/0x37 mm/kasan/report.c:530
 uif_close+0x15e/0x190 drivers/mtd/ubi/build.c:502
 ubi_detach_mtd_dev+0x226/0x432 drivers/mtd/ubi/build.c:1110
 ctrl_cdev_ioctl+0x1bf/0x2b0 drivers/mtd/ubi/cdev.c:1068
 vfs_ioctl fs/ioctl.c:48 [inline]
 ksys_ioctl+0x11a/0x180 fs/ioctl.c:753
 __do_sys_ioctl fs/ioctl.c:762 [inline]
 __se_sys_ioctl fs/ioctl.c:760 [inline]
 __x64_sys_ioctl+0x6f/0xb0 fs/ioctl.c:760
 do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295
 entry_SYSCALL_64_after_hwframe+0x49/0xb3
RIP: 0033:0x44af69
Code: e8 7c e6 ff ff 48 83 c4 18 c3 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 1b 05 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007f48c29a8ce8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00000000006e7a08 RCX: 000000000044af69
RDX: 000000000076006e RSI: 0000000040046f41 RDI: 0000000000000003
RBP: 00000000006e7a00 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00000000006e7a0c
R13: 00007ffe9ed2c70f R14: 00007f48c29a99c0 R15: 20c49ba5e353f7cf

Allocated by task 8070:
 save_stack+0x1b/0x40 mm/kasan/common.c:48
 set_track mm/kasan/common.c:56 [inline]
 __kasan_kmalloc mm/kasan/common.c:494 [inline]
 __kasan_kmalloc.constprop.0+0xbf/0xd0 mm/kasan/common.c:467
 kmem_cache_alloc_trace+0x153/0x7d0 mm/slab.c:3551
 kmalloc include/linux/slab.h:555 [inline]
 kzalloc include/linux/slab.h:669 [inline]
 ubi_attach_mtd_dev+0x2e7/0x27c0 drivers/mtd/ubi/build.c:901
 ctrl_cdev_ioctl+0x229/0x2b0 drivers/mtd/ubi/cdev.c:1043
 vfs_ioctl fs/ioctl.c:48 [inline]
 ksys_ioctl+0x11a/0x180 fs/ioctl.c:753
 __do_sys_ioctl fs/ioctl.c:762 [inline]
 __se_sys_ioctl fs/ioctl.c:760 [inline]
 __x64_sys_ioctl+0x6f/0xb0 fs/ioctl.c:760
 do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295
 entry_SYSCALL_64_after_hwframe+0x49/0xb3

Freed by task 8078:
 save_stack+0x1b/0x40 mm/kasan/common.c:48
 set_track mm/kasan/common.c:56 [inline]
 kasan_set_free_info mm/kasan/common.c:316 [inline]
 __kasan_slab_free+0xf7/0x140 mm/kasan/common.c:455
 __cache_free mm/slab.c:3426 [inline]
 kfree+0x109/0x2b0 mm/slab.c:3757
 device_release+0x71/0x200 drivers/base/core.c:1541
 kobject_cleanup lib/kobject.c:701 [inline]
 kobject_release lib/kobject.c:732 [inline]
 kref_put include/linux/kref.h:65 [inline]
 kobject_put+0x1c8/0x2f0 lib/kobject.c:749
 cdev_device_del+0x69/0x80 fs/char_dev.c:575
 uif_close+0xea/0x190 drivers/mtd/ubi/build.c:501
 ubi_detach_mtd_dev+0x226/0x432 drivers/mtd/ubi/build.c:1110
 ctrl_cdev_ioctl+0x1bf/0x2b0 drivers/mtd/ubi/cdev.c:1068
 vfs_ioctl fs/ioctl.c:48 [inline]
 ksys_ioctl+0x11a/0x180 fs/ioctl.c:753
 __do_sys_ioctl fs/ioctl.c:762 [inline]
 __se_sys_ioctl fs/ioctl.c:760 [inline]
 __x64_sys_ioctl+0x6f/0xb0 fs/ioctl.c:760
 do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295
 entry_SYSCALL_64_after_hwframe+0x49/0xb3

The buggy address belongs to the object at ffff8880a6ff0000
 which belongs to the cache kmalloc-8k of size 8192
The buggy address is located 2536 bytes inside of
 8192-byte region [ffff8880a6ff0000, ffff8880a6ff2000)
The buggy address belongs to the page:
page:ffffea00029bfc00 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 head:ffffea00029bfc00 order:2 compound_mapcount:0 compound_pincount:0
flags: 0xfffe0000010200(slab|head)
raw: 00fffe0000010200 ffffea0002382708 ffffea00028eb008 ffff8880aa0021c0
raw: 0000000000000000 ffff8880a6ff0000 0000000100000001 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff8880a6ff0880: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff8880a6ff0900: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
>ffff8880a6ff0980: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                                                          ^
 ffff8880a6ff0a00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff8880a6ff0a80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================

Crashes (33):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro
ci-upstream-linux-next-kasan-gce-root	2020/05/23 14:36	linux-next	c11d28ab	9682898d	.config	log	report	syz	C
ci-upstream-linux-next-kasan-gce-root	2020/05/24 17:19	linux-next	c11d28ab	bd28eb9d	.config	log	report	syz
ci-upstream-linux-next-kasan-gce-root	2020/05/23 16:11	linux-next	c11d28ab	9682898d	.config	log	report	syz
ci-upstream-linux-next-kasan-gce-root	2020/05/23 14:16	linux-next	c11d28ab	9682898d	.config	log	report	syz
ci-upstream-linux-next-kasan-gce-root	2020/05/23 13:54	linux-next	c11d28ab	9682898d	.config	log	report	syz
ci-upstream-linux-next-kasan-gce-root	2020/05/23 13:32	linux-next	c11d28ab	9682898d	.config	log	report	syz
ci-upstream-linux-next-kasan-gce-root	2020/05/23 13:08	linux-next	c11d28ab	9682898d	.config	log	report	syz
ci-upstream-linux-next-kasan-gce-root	2020/05/23 04:37	linux-next	c11d28ab	9682898d	.config	log	report	syz
ci-upstream-linux-next-kasan-gce-root	2020/05/22 22:51	linux-next	c11d28ab	9682898d	.config	log	report	syz
ci-upstream-linux-next-kasan-gce-root	2020/05/22 22:33	linux-next	c11d28ab	9682898d	.config	log	report	syz
ci-upstream-linux-next-kasan-gce-root	2020/05/25 12:48	linux-next	c11d28ab	11284182	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/05/25 06:34	linux-next	c11d28ab	11284182	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/05/25 06:03	linux-next	c11d28ab	11284182	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/05/25 06:03	linux-next	c11d28ab	11284182	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/05/24 21:45	linux-next	c11d28ab	bd28eb9d	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/05/24 21:29	linux-next	c11d28ab	bd28eb9d	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/05/24 21:20	linux-next	c11d28ab	bd28eb9d	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/05/24 20:58	linux-next	c11d28ab	bd28eb9d	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/05/24 10:43	linux-next	c11d28ab	96c92ad3	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/05/24 07:52	linux-next	c11d28ab	96c92ad3	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/05/24 03:04	linux-next	c11d28ab	96c92ad3	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/05/23 17:05	linux-next	c11d28ab	9682898d	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/05/23 16:55	linux-next	c11d28ab	9682898d	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/05/23 13:57	linux-next	c11d28ab	9682898d	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/05/23 13:35	linux-next	c11d28ab	9682898d	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/05/23 13:34	linux-next	c11d28ab	9682898d	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/05/23 12:48	linux-next	c11d28ab	9682898d	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/05/23 12:48	linux-next	c11d28ab	9682898d	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/05/23 12:42	linux-next	c11d28ab	9682898d	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/05/23 12:37	linux-next	c11d28ab	9682898d	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/05/23 12:36	linux-next	c11d28ab	9682898d	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/05/22 20:46	linux-next	c11d28ab	9682898d	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/05/22 15:33	linux-next	c11d28ab	9682898d	.config	log	report