syzbot


WARNING in tty_set_termios

Status: fixed on 2020/01/08 01:06
Reported-by: syzbot+a950165cbb86bdd023a4@syzkaller.appspotmail.com
Fix commit: b36a1552d731 Bluetooth: hci_uart: check for missing tty operations
First crash: 1922d, last: 1722d
Cause bisection: introduced by (bisect log) :
commit 162f812f23bab583f5d514ca0e4df67797ac9cdf
Author: Loic Poulain <loic.poulain@intel.com>
Date: Mon Sep 19 14:29:27 2016 +0000

  Bluetooth: hci_uart: Add Marvell support

Crash: WARNING in tty_set_termios (log)
Repro: C syz .config
  
Fix bisection: fixed by (bisect log) :
commit b36a1552d7319bbfd5cf7f08726c23c5c66d4f73
Author: Vladis Dronov <vdronov@redhat.com>
Date: Tue Jul 30 09:33:45 2019 +0000

  Bluetooth: hci_uart: check for missing tty operations

  
Discussions (14)
Title Replies (including bot) Last reply
WARNING in tty_set_termios 1 (4) 2019/12/12 15:57
Reminder: 29 open syzbot bugs in bluetooth subsystem 1 (1) 2019/07/24 01:41
Reminder: 29 open syzbot bugs in bluetooth subsystem 1 (1) 2019/07/09 19:07
Reminder: 27 open syzbot bugs in bluetooth subsystem 1 (1) 2019/06/24 05:14
[PATCH v5] bluetooth: Fix WARNING in tty_set_termios() 3 (3) 2019/02/12 18:04
[PATCH v4] bluetooth: Fix WARNING in tty_set_termios() 3 (3) 2019/02/04 18:44
[PATCH v3] bluetooth: Fix WARNING in tty_set_termios() 3 (3) 2019/02/03 19:36
[PATCH] Bluetooth: hci_ldisc: Add NULL check for tty set_termios operation 1 (1) 2019/02/03 04:23
[PATCH v2] Bluetooth: hci_uart: Switch pty driver to slave side in tty_set_termios() 3 (3) 2019/02/03 03:30
[PATCH v2] tty: Fix WARNING in tty_set_termios() 8 (8) 2019/02/01 23:21
[PATCH] tty: Fix WARNING in tty_set_termios 8 (8) 2019/01/31 23:23
[PATCH] Bluetooth: hci_uart: Switch pty driver to slave side in tty_set_termios() 5 (5) 2019/01/31 15:43
[PATCH] Bluetooth: Add NULL check for tiocmget() and tiocmset() 4 (4) 2019/01/31 05:08
[PATCH] Bluetooth: hci_ldisc: Fix for pty driver 2 (2) 2019/01/25 07:42
Similar bugs (2)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-4.19 WARNING in tty_set_termios C done 151 1719d 1829d 1/1 fixed on 2019/12/03 19:11
linux-4.14 WARNING in tty_set_termios C 589 409d 1827d 0/1 upstream: reported C repro on 2019/04/18 11:57

Sample crash report:
WARNING: CPU: 0 PID: 1503 at drivers/tty/tty_ioctl.c:319 tty_set_termios+0x7a5/0x8d0 drivers/tty/tty_ioctl.c:319
Kernel panic - not syncing: panic_on_warn set ...
CPU: 0 PID: 1503 Comm: kworker/u5:0 Not tainted 5.2.0-rc3+ #38
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: hci0 hci_power_on
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x172/0x1f0 lib/dump_stack.c:113
 panic+0x2cb/0x744 kernel/panic.c:219
 __warn.cold+0x20/0x4d kernel/panic.c:576
 report_bug+0x263/0x2b0 lib/bug.c:186
 fixup_bug arch/x86/kernel/traps.c:179 [inline]
 fixup_bug arch/x86/kernel/traps.c:174 [inline]
 do_error_trap+0x11b/0x200 arch/x86/kernel/traps.c:272
 do_invalid_op+0x37/0x50 arch/x86/kernel/traps.c:291
 invalid_op+0x14/0x20 arch/x86/entry/entry_64.S:986
RIP: 0010:tty_set_termios+0x7a5/0x8d0 drivers/tty/tty_ioctl.c:319
Code: 0f b6 14 02 48 89 f8 83 e0 07 83 c0 03 38 d0 7c 08 84 d2 0f 85 a3 00 00 00 45 89 a7 d0 03 00 00 e9 49 fe ff ff e8 eb a4 f9 fd <0f> 0b e9 3e f9 ff ff e8 ef 42 32 fe e9 d6 fa ff ff e8 e5 42 32 fe
RSP: 0018:ffff8880a6677968 EFLAGS: 00010293
RAX: ffff8880a66b2640 RBX: ffff8880a6677a28 RCX: ffffffff8376fafd
RDX: 0000000000000000 RSI: ffffffff837701c5 RDI: 0000000000000005
RBP: ffff8880a6677a50 R08: ffff8880a66b2640 R09: fffffbfff163c5f5
R10: fffffbfff163c5f4 R11: 0000000000000003 R12: ffff8880a6677a90
R13: 0000000000010004 R14: 1ffff11014ccef4c R15: ffff88808c594000
 hci_uart_set_baudrate+0x157/0x1c0 drivers/bluetooth/hci_ldisc.c:363
 hci_uart_setup+0xa2/0x490 drivers/bluetooth/hci_ldisc.c:386
 hci_dev_do_open+0x784/0x1760 net/bluetooth/hci_core.c:1450
 hci_power_on+0x10d/0x580 net/bluetooth/hci_core.c:2171
 process_one_work+0x989/0x1790 kernel/workqueue.c:2269
 worker_thread+0x98/0xe40 kernel/workqueue.c:2415
 kthread+0x354/0x420 kernel/kthread.c:255
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352
Kernel Offset: disabled
Rebooting in 86400 seconds..

Crashes (1997):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/06/05 07:09 upstream 788a024921c4 bfb4a51e .config console log report syz C ci-upstream-kasan-gce
2019/06/03 20:50 upstream f2c7c76c5d0a 63bf051f .config console log report syz C ci-upstream-kasan-gce-root
2019/06/03 19:27 upstream f2c7c76c5d0a 63bf051f .config console log report syz C ci-upstream-kasan-gce-selinux-root
2019/06/03 19:27 upstream f2c7c76c5d0a 63bf051f .config console log report syz C ci-upstream-kasan-gce-smack-root
2019/04/18 15:13 upstream e53f31bffe1d b0e8efcb .config console log report syz C ci-upstream-kasan-gce-selinux-root
2019/04/18 14:55 upstream e53f31bffe1d b0e8efcb .config console log report syz C ci-upstream-kasan-gce-smack-root
2019/04/18 13:06 upstream e53f31bffe1d b0e8efcb .config console log report syz C ci-upstream-kasan-gce-root
2019/04/18 12:25 upstream e53f31bffe1d b0e8efcb .config console log report syz C ci-upstream-kasan-gce
2019/04/17 04:08 upstream 444fe9913539 b0e8efcb .config console log report syz C ci-upstream-kasan-gce-smack-root
2019/04/17 02:51 upstream 444fe9913539 b0e8efcb .config console log report syz C ci-upstream-kasan-gce
2019/02/18 21:56 upstream a3b22b9f11d9 59f36113 .config console log report syz C ci-upstream-kasan-gce
2019/02/18 21:55 upstream a3b22b9f11d9 59f36113 .config console log report syz C ci-upstream-kasan-gce-selinux-root
2019/02/18 21:54 upstream a3b22b9f11d9 59f36113 .config console log report syz C ci-upstream-kasan-gce-smack-root
2019/02/18 21:53 upstream a3b22b9f11d9 59f36113 .config console log report syz C ci-upstream-kasan-gce-root
2019/01/13 03:29 upstream 66c56cfa64d9 c3f3344c .config console log report syz C ci-upstream-kasan-gce-selinux-root
2019/01/13 00:27 upstream 66c56cfa64d9 c3f3344c .config console log report syz C ci-upstream-kasan-gce
2019/01/13 00:26 upstream 66c56cfa64d9 c3f3344c .config console log report syz C ci-upstream-kasan-gce-smack-root
2019/01/13 00:06 upstream 66c56cfa64d9 c3f3344c .config console log report syz C ci-upstream-kasan-gce-root
2019/06/03 20:11 upstream f2c7c76c5d0a 63bf051f .config console log report syz C ci-upstream-kasan-gce-386
2019/04/18 11:53 upstream e53f31bffe1d b0e8efcb .config console log report syz C ci-upstream-kasan-gce-386
2019/04/17 02:33 upstream 444fe9913539 b0e8efcb .config console log report syz C ci-upstream-kasan-gce-386
2019/02/19 11:11 upstream b5372fe5dc84 59f36113 .config console log report syz C ci-upstream-kasan-gce-386
2019/01/13 00:47 upstream 66c56cfa64d9 c3f3344c .config console log report syz C ci-upstream-kasan-gce-386
2019/06/13 01:05 linux-next 81a72c79224f 794a1ad7 .config console log report syz C ci-upstream-linux-next-kasan-gce-root
2019/04/18 14:48 linux-next 3f018f4a019a b0e8efcb .config console log report syz C ci-upstream-linux-next-kasan-gce-root
2019/02/18 21:55 linux-next cb916fc5eabf 59f36113 .config console log report syz C ci-upstream-linux-next-kasan-gce-root
2019/01/13 15:04 linux-next b808822a75a3 c3f3344c .config console log report syz C ci-upstream-linux-next-kasan-gce-root
2019/08/01 05:27 upstream 4010b622f1d2 c692b5bd .config console log report ci-upstream-kasan-gce
2019/08/01 03:55 upstream 4010b622f1d2 c692b5bd .config console log report ci-upstream-kasan-gce-root
2019/08/01 00:03 upstream 4010b622f1d2 c692b5bd .config console log report ci-upstream-kasan-gce
2019/07/31 13:02 upstream 629f8205a6cc 7c7ded69 .config console log report ci-upstream-kasan-gce
2019/07/31 10:34 upstream 629f8205a6cc 7c7ded69 .config console log report ci-upstream-kasan-gce
2019/07/31 05:23 upstream 629f8205a6cc 7c7ded69 .config console log report ci-upstream-kasan-gce-smack-root
2019/07/30 18:24 upstream 2a11c76e5301 f28bf2a5 .config console log report ci-upstream-kasan-gce
2019/07/30 07:49 upstream 2a11c76e5301 f67095ee .config console log report ci-upstream-kasan-gce-root
2019/07/30 06:04 upstream 2a11c76e5301 f67095ee .config console log report ci-upstream-kasan-gce
2019/07/30 05:03 upstream 2a11c76e5301 f67095ee .config console log report ci-upstream-kasan-gce
2019/07/29 20:43 upstream 2a11c76e5301 f67095ee .config console log report ci-upstream-kasan-gce-smack-root
2019/07/29 07:41 upstream a9815a4fa2fd c85e1c5b .config console log report ci-upstream-kasan-gce-root
2019/07/29 06:35 upstream a9815a4fa2fd c85e1c5b .config console log report ci-upstream-kasan-gce-selinux-root
2019/07/29 05:29 upstream a9815a4fa2fd c85e1c5b .config console log report ci-upstream-kasan-gce-selinux-root
2019/07/28 18:58 upstream a9815a4fa2fd c85e1c5b .config console log report ci-upstream-kasan-gce
2019/07/28 13:41 upstream 5168afe6ef59 c85e1c5b .config console log report ci-upstream-kasan-gce-root
2019/07/28 12:27 upstream 5168afe6ef59 c85e1c5b .config console log report ci-upstream-kasan-gce
2019/07/28 10:36 upstream 5168afe6ef59 c85e1c5b .config console log report ci-upstream-kasan-gce
2019/07/28 09:02 upstream 5168afe6ef59 c85e1c5b .config console log report ci-upstream-kasan-gce
2019/07/27 16:11 upstream 3ea54d9b0d65 c85e1c5b .config console log report ci-upstream-kasan-gce-selinux-root
2019/07/27 14:58 upstream 3ea54d9b0d65 c85e1c5b .config console log report ci-upstream-kasan-gce
2019/07/27 09:31 upstream 3ea54d9b0d65 c85e1c5b .config console log report ci-upstream-kasan-gce
2019/07/27 01:34 upstream 3ea54d9b0d65 c85e1c5b .config console log report ci-upstream-kasan-gce-selinux-root
2019/07/26 22:13 upstream 6789f873ed37 3e5d1beb .config console log report ci-upstream-kasan-gce
2019/07/26 20:26 upstream 6789f873ed37 3e5d1beb .config console log report ci-upstream-kasan-gce
2019/07/26 18:32 upstream 6789f873ed37 3e5d1beb .config console log report ci-upstream-kasan-gce-selinux-root
2019/07/26 16:32 upstream 6789f873ed37 3e5d1beb .config console log report ci-upstream-kasan-gce-root
2019/07/26 16:29 upstream 6789f873ed37 3e5d1beb .config console log report ci-upstream-kasan-gce-selinux-root
2019/07/26 05:07 upstream 6789f873ed37 732bc5a0 .config console log report ci-upstream-kasan-gce-smack-root
2019/07/26 03:49 upstream 6789f873ed37 732bc5a0 .config console log report ci-upstream-kasan-gce
2019/07/25 21:44 upstream 6789f873ed37 732bc5a0 .config console log report ci-upstream-kasan-gce
2019/07/24 01:52 upstream c6dd78fcb8ee de453f34 .config console log report ci-upstream-kasan-gce-root
2019/07/24 01:28 upstream abdfd52a295f de453f34 .config console log report ci-upstream-kasan-gce
2019/07/23 23:57 upstream c6dd78fcb8ee de453f34 .config console log report ci-upstream-kasan-gce-root
2019/07/31 09:32 upstream 629f8205a6cc 7c7ded69 .config console log report ci-upstream-kasan-gce-386
2019/07/30 18:42 upstream 2a11c76e5301 f28bf2a5 .config console log report ci-upstream-kasan-gce-386
2019/07/30 16:03 upstream 2a11c76e5301 f28bf2a5 .config console log report ci-upstream-kasan-gce-386
2019/07/30 00:05 upstream 2a11c76e5301 f67095ee .config console log report ci-upstream-kasan-gce-386
2019/07/29 13:01 upstream 609488bc979f c85e1c5b .config console log report ci-upstream-kasan-gce-386
2019/07/28 23:53 upstream a9815a4fa2fd c85e1c5b .config console log report ci-upstream-kasan-gce-386
2019/07/27 17:14 upstream 3ea54d9b0d65 c85e1c5b .config console log report ci-upstream-kasan-gce-386
2019/07/26 08:04 upstream 6789f873ed37 732bc5a0 .config console log report ci-upstream-kasan-gce-386
2019/07/25 20:40 upstream 6789f873ed37 732bc5a0 .config console log report ci-upstream-kasan-gce-386
2019/07/25 13:57 upstream bed38c3e2dca 32329ceb .config console log report ci-upstream-kasan-gce-386
2019/07/29 04:21 linux-next fde50b96be82 c85e1c5b .config console log report ci-upstream-linux-next-kasan-gce-root
2019/07/28 20:07 linux-next fde50b96be82 c85e1c5b .config console log report ci-upstream-linux-next-kasan-gce-root
2019/07/27 19:45 linux-next fde50b96be82 c85e1c5b .config console log report ci-upstream-linux-next-kasan-gce-root
2019/07/27 12:59 linux-next fde50b96be82 c85e1c5b .config console log report ci-upstream-linux-next-kasan-gce-root
2019/07/25 01:28 linux-next 9e6dfe8045f8 32329ceb .config console log report ci-upstream-linux-next-kasan-gce-root
2019/07/24 18:01 linux-next 9e6dfe8045f8 32329ceb .config console log report ci-upstream-linux-next-kasan-gce-root
2019/07/24 09:03 linux-next 6d21a41b7b1f de453f34 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/07/24 06:41 linux-next 6d21a41b7b1f de453f34 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/07/24 04:13 linux-next 6d21a41b7b1f de453f34 .config console log report ci-upstream-linux-next-kasan-gce-root
* Struck through repros no longer work on HEAD.