WARNING in fw_load_sysfs

WARNING in fw_load_sysfs_fallback
Status: upstream: reported C repro on 2021/04/03 13:33
Reported-by: syzbot+b064fbd5fc8b2cfae49d@syzkaller.appspotmail.com
First crash: 200d, last: 12h32m

Cause bisection: introduced by (bisect log) [ignored commit]:
commit f2c2e717642c66f7fe7e5dd69b2e8ff5849f4d10
Author: Andrey Konovalov <andreyknvl@google.com>
Date: Mon Feb 24 16:13:03 2020 +0000

  usb: gadget: add raw-gadget interface

Crash: WARNING in firmware_fallback_sysfs (log)
Repro: C syz .config

Fix bisection: the fix commit could be any of (bisect log):
  52e44129fba5 Merge branch 'for-5.12-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/dennis/percpu
  f55966571d5e Merge tag 'drm-next-2021-07-08-1' of git://anongit.freedesktop.org/drm/drm

Sample crash report:

------------[ cut here ]------------
sysfs group 'power' not found for kobject 'ueagle-atm!adi930.fw'
WARNING: CPU: 0 PID: 5 at fs/sysfs/group.c:281 sysfs_remove_group+0x16e/0x280 fs/sysfs/group.c:279
Modules linked in:
CPU: 0 PID: 5 Comm: kworker/0:0 Not tainted 5.12.0-rc6-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: events request_firmware_work_func
RIP: 0010:sysfs_remove_group+0x16e/0x280 fs/sysfs/group.c:279
Code: 89 e0 48 c1 e8 03 42 80 3c 28 00 74 08 4c 89 e7 e8 37 92 cb ff 49 8b 14 24 48 c7 c7 40 1a c2 89 4c 89 f6 31 c0 e8 b2 87 56 ff <0f> 0b 5b 41 5c 41 5d 41 5e 41 5f 5d c3 e8 40 a3 87 ff 49 8d 5e 20
RSP: 0018:ffffc90000ca7a90 EFLAGS: 00010246
RAX: f97192423f200500 RBX: ffff8880351a4038 RCX: ffff888011528000
RDX: 0000000000000000 RSI: 0000000080000000 RDI: 0000000000000000
RBP: 1ffffffff1459c30 R08: ffffffff8160b932 R09: ffffed1017385fe8
R10: ffffed1017385fe8 R11: 0000000000000000 R12: ffff8880351a4008
R13: dffffc0000000000 R14: ffffffff8a2ce140 R15: ffff888035bbc3a0
FS:  0000000000000000(0000) GS:ffff8880b9c00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007ffcb4541b47 CR3: 000000001d137000 CR4: 00000000001506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 device_del+0x26a/0xa90 drivers/base/core.c:3398
 fw_load_sysfs_fallback+0x53e/0x720 drivers/base/firmware_loader/fallback.c:543
 fw_load_from_user_helper+0x242/0x320 drivers/base/firmware_loader/fallback.c:581
 _request_firmware+0x2c5/0x4c0 drivers/base/firmware_loader/main.c:831
 request_firmware_work_func+0xb8/0x1e0 drivers/base/firmware_loader/main.c:1077
 process_one_work+0x789/0xfd0 kernel/workqueue.c:2275
 worker_thread+0xac1/0x1300 kernel/workqueue.c:2421
 kthread+0x39a/0x3c0 kernel/kthread.c:292
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294

Crashes (14):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	VM info	Title
ci-upstream-kasan-gce-smack-root	2021/04/11 15:07	upstream	52e44129fba5	bfeda1b1	.config	log	report	syz	C		WARNING in fw_load_sysfs_fallback
ci-upstream-kasan-gce-smack-root	2021/10/16 17:56	upstream	8fe31e0995f0	0c5d9412	.config	log	report			info	WARNING in fw_load_sysfs_fallback
ci-upstream-kasan-gce-smack-root	2021/10/15 18:29	upstream	ec681c53f8d2	0c5d9412	.config	log	report			info	WARNING in fw_load_sysfs_fallback
ci-upstream-kasan-gce-smack-root	2021/09/30 17:40	upstream	02d5e016800d	be530f6c	.config	log	report			info	WARNING in fw_load_sysfs_fallback
ci-upstream-kasan-gce-smack-root	2021/09/30 17:40	upstream	02d5e016800d	be530f6c	.config	log	report			info	WARNING in fw_load_sysfs_fallback
ci-upstream-kasan-gce-smack-root	2021/09/30 16:38	upstream	02d5e016800d	be530f6c	.config	log	report			info	WARNING in fw_load_sysfs_fallback
ci-upstream-kasan-gce-smack-root	2021/09/30 13:02	upstream	02d5e016800d	be530f6c	.config	log	report			info	WARNING in fw_load_sysfs_fallback
ci-upstream-kasan-gce-smack-root	2021/09/30 12:51	upstream	02d5e016800d	be530f6c	.config	log	report			info	WARNING in fw_load_sysfs_fallback
ci-upstream-kasan-gce-smack-root	2021/06/08 01:36	upstream	614124bea77e	e59537be	.config	log	report			info	WARNING in fw_load_sysfs_fallback
ci-upstream-kasan-gce-smack-root	2021/05/24 09:23	upstream	6ebb6814a1ef	3c7fef33	.config	log	report			info	WARNING in fw_load_sysfs_fallback
ci-upstream-kasan-gce-smack-root	2021/04/16 22:27	upstream	2f7b98d1e55c	7e2b734b	.config	log	report			info	WARNING in fw_load_sysfs_fallback
ci-upstream-kasan-gce-smack-root	2021/04/16 22:15	upstream	2f7b98d1e55c	7e2b734b	.config	log	report			info	WARNING in fw_load_sysfs_fallback
ci-upstream-kasan-gce-smack-root	2021/04/11 14:19	upstream	52e44129fba5	bfeda1b1	.config	log	report			info	WARNING in fw_load_sysfs_fallback
ci-upstream-kasan-gce-smack-root	2021/03/30 13:29	upstream	1e43c377a79f	6a81331a	.config	log	report			info	WARNING in fw_load_sysfs_fallback