syzbot


KASAN: use-after-free Read in tipc_named_reinit (2)

Status: fixed on 2023/02/24 13:50
Subsystems: tipc
[Documentation on labels]
Reported-by: syzbot+47af19f3307fc9c5c82e@syzkaller.appspotmail.com
Fix commit: 911600bf5a5e tipc: fix use-after-free Read in tipc_named_reinit
First crash: 726d, last: 726d
Discussions (5)
Title Replies (including bot) Last reply
[PATCH 5.18 000/181] 5.18.8-rc1 review 202 (202) 2022/07/06 23:51
[PATCH 5.15 000/135] 5.15.51-rc1 review 145 (145) 2022/06/29 10:52
[PATCH 5.10 000/102] 5.10.127-rc1 review 109 (109) 2022/06/29 01:07
[net] tipc: fix use-after-free Read in tipc_named_reinit 2 (2) 2022/06/17 10:40
[syzbot] KASAN: use-after-free Read in tipc_named_reinit (2) 0 (1) 2022/05/03 06:21
Similar bugs (2)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
android-54 KASAN: use-after-free Read in tipc_named_reinit syz 8 1304d 1540d 0/2 auto-obsoleted due to no activity on 2023/04/16 15:56
upstream KASAN: use-after-free Read in tipc_named_reinit tipc 6 1360d 1415d 15/26 fixed on 2020/11/16 12:12

Sample crash report:
tipc: Node number set to 1
==================================================================
BUG: KASAN: use-after-free in tipc_named_reinit+0x94f/0x9b0 net/tipc/name_distr.c:413
Read of size 8 at addr ffff88805299a000 by task kworker/1:9/23764

CPU: 1 PID: 23764 Comm: kworker/1:9 Not tainted 5.18.0-rc4-syzkaller-00878-g17d49e6e8012 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: events tipc_net_finalize_work
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106
 print_address_description.constprop.0.cold+0xeb/0x495 mm/kasan/report.c:313
 print_report mm/kasan/report.c:429 [inline]
 kasan_report.cold+0xf4/0x1c6 mm/kasan/report.c:491
 tipc_named_reinit+0x94f/0x9b0 net/tipc/name_distr.c:413
 tipc_net_finalize+0x234/0x3d0 net/tipc/net.c:138
 process_one_work+0x996/0x1610 kernel/workqueue.c:2289
 worker_thread+0x665/0x1080 kernel/workqueue.c:2436
 kthread+0x2e9/0x3a0 kernel/kthread.c:376
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:298
 </TASK>

The buggy address belongs to the physical page:
page:ffffea00014a6680 refcount:0 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x5299a
flags: 0xfff00000000000(node=0|zone=1|lastcpupid=0x7ff)
raw: 00fff00000000000 0000000000000000 dead000000000122 0000000000000000
raw: 0000000000000000 0000000000000000 00000000ffffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as freed
page last allocated via order 2, migratetype Unmovable, gfp_mask 0x140dc0(GFP_USER|__GFP_COMP|__GFP_ZERO), pid 32268, tgid 32268 (syz-executor.0), ts 2019363271552, free_ts 2022187878511
 prep_new_page mm/page_alloc.c:2441 [inline]
 get_page_from_freelist+0xba2/0x3e00 mm/page_alloc.c:4182
 __alloc_pages+0x1b2/0x500 mm/page_alloc.c:5408
 alloc_pages+0x1aa/0x310 mm/mempolicy.c:2272
 kmalloc_order+0x34/0xf0 mm/slab_common.c:953
 kmalloc_order_trace+0x14/0x120 mm/slab_common.c:969
 kmalloc_large include/linux/slab.h:510 [inline]
 kmalloc include/linux/slab.h:574 [inline]
 kzalloc include/linux/slab.h:714 [inline]
 tipc_nametbl_init+0x145/0x480 net/tipc/name_table.c:891
 tipc_init_net+0x408/0x660 net/tipc/core.c:80
 ops_init+0xaf/0x470 net/core/net_namespace.c:134
 setup_net+0x5d1/0xc50 net/core/net_namespace.c:325
 copy_net_ns+0x318/0x760 net/core/net_namespace.c:471
 create_new_namespaces+0x3f6/0xb20 kernel/nsproxy.c:110
 unshare_nsproxy_namespaces+0xc1/0x1f0 kernel/nsproxy.c:226
 ksys_unshare+0x445/0x920 kernel/fork.c:3132
 __do_sys_unshare kernel/fork.c:3203 [inline]
 __se_sys_unshare kernel/fork.c:3201 [inline]
 __x64_sys_unshare+0x2d/0x40 kernel/fork.c:3201
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x44/0xae
page last free stack trace:
 reset_page_owner include/linux/page_owner.h:24 [inline]
 free_pages_prepare mm/page_alloc.c:1356 [inline]
 free_pcp_prepare+0x549/0xd20 mm/page_alloc.c:1406
 free_unref_page_prepare mm/page_alloc.c:3328 [inline]
 free_unref_page+0x19/0x6a0 mm/page_alloc.c:3423
 tipc_exit_net+0x132/0x560 net/tipc/core.c:117
 ops_exit_list+0xb0/0x170 net/core/net_namespace.c:162
 cleanup_net+0x4ea/0xb00 net/core/net_namespace.c:594
 process_one_work+0x996/0x1610 kernel/workqueue.c:2289
 worker_thread+0x665/0x1080 kernel/workqueue.c:2436
 kthread+0x2e9/0x3a0 kernel/kthread.c:376
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:298

Memory state around the buggy address:
 ffff888052999f00: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
 ffff888052999f80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
>ffff88805299a000: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
                   ^
 ffff88805299a080: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
 ffff88805299a100: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
==================================================================

Crashes (1):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2022/04/29 20:33 net-next-old 17d49e6e8012 44a5ca63 .config console log report info ci-upstream-net-kasan-gce KASAN: use-after-free Read in tipc_named_reinit
* Struck through repros no longer work on HEAD.