KASAN: use-after-free Read in tty_buffer_cancel_work

Status: closed as dup on 2020/02/24 18:35
First crash: 1185d, last: 1134d
Duplicate of (1):
Title Repro Cause bisect Fix bisect Count Last Reported
KASAN: use-after-free Write in release_tty C done 591 1080d 1202d
similar bugs (1):
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-4.14 KASAN: use-after-free Read in tty_buffer_cancel_work C done 2 1110d 1198d 1/1 fixed on 2020/04/04 09:58

Sample crash report:
BUG: KASAN: use-after-free in __flush_work+0x9ae/0xa50 kernel/workqueue.c:3032
Read of size 8 at addr ffff8880a3470020 by task syz-executor.3/14716

CPU: 0 PID: 14716 Comm: syz-executor.3 Not tainted 5.5.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x197/0x210 lib/dump_stack.c:118
 print_address_description.constprop.0.cold+0xd4/0x30b mm/kasan/report.c:374
 __kasan_report.cold+0x1b/0x32 mm/kasan/report.c:506
 kasan_report+0x12/0x20 mm/kasan/common.c:641
 __asan_report_load8_noabort+0x14/0x20 mm/kasan/generic_report.c:135
 __flush_work+0x9ae/0xa50 kernel/workqueue.c:3032
 __cancel_work_timer+0x3d9/0x540 kernel/workqueue.c:3128
 cancel_work_sync+0x18/0x20 kernel/workqueue.c:3164
 tty_buffer_cancel_work+0x16/0x20 drivers/tty/tty_buffer.c:613
 release_tty+0x261/0x470 drivers/tty/tty_io.c:1520
 tty_release_struct+0x3c/0x50 drivers/tty/tty_io.c:1629
 tty_release+0xbcb/0xe90 drivers/tty/tty_io.c:1789
 __fput+0x2ff/0x890 fs/file_table.c:280
 ____fput+0x16/0x20 fs/file_table.c:313
 task_work_run+0x145/0x1c0 kernel/task_work.c:113
 tracehook_notify_resume include/linux/tracehook.h:188 [inline]
 exit_to_usermode_loop+0x316/0x380 arch/x86/entry/common.c:164
 prepare_exit_to_usermode arch/x86/entry/common.c:195 [inline]
 syscall_return_slowpath arch/x86/entry/common.c:278 [inline]
 do_syscall_64+0x676/0x790 arch/x86/entry/common.c:304
RIP: 0033:0x414f31
Code: 75 14 b8 03 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 04 1b 00 00 c3 48 83 ec 08 e8 0a fc ff ff 48 89 04 24 b8 03 00 00 00 0f 05 <48> 8b 3c 24 48 89 c2 e8 53 fc ff ff 48 89 d0 48 83 c4 08 48 3d 01
RSP: 002b:00007ffffc961210 EFLAGS: 00000293 ORIG_RAX: 0000000000000003
RAX: 0000000000000000 RBX: 0000000000000004 RCX: 0000000000414f31
RDX: 0000001b30b20000 RSI: 0000000000000000 RDI: 0000000000000003
RBP: 0000000000000001 R08: 000000005e7c5afa R09: 000000005e7c5afe
R10: 00007ffffc9612f0 R11: 0000000000000293 R12: 000000000075bf20
R13: 0000000000041f88 R14: 0000000000760490 R15: 000000000075bf2c

Allocated by task 14698:
 save_stack+0x23/0x90 mm/kasan/common.c:72
 set_track mm/kasan/common.c:80 [inline]
 __kasan_kmalloc mm/kasan/common.c:515 [inline]
 __kasan_kmalloc.constprop.0+0xcf/0xe0 mm/kasan/common.c:488
 kasan_kmalloc+0x9/0x10 mm/kasan/common.c:529
 kmem_cache_alloc_trace+0x158/0x790 mm/slab.c:3551
 kmalloc include/linux/slab.h:555 [inline]
 kzalloc include/linux/slab.h:669 [inline]
 vc_allocate drivers/tty/vt/vt.c:1085 [inline]
 vc_allocate+0x1fc/0x760 drivers/tty/vt/vt.c:1066
 con_install+0x52/0x410 drivers/tty/vt/vt.c:3229
 tty_driver_install_tty drivers/tty/tty_io.c:1228 [inline]
 tty_init_dev drivers/tty/tty_io.c:1341 [inline]
 tty_init_dev+0xf9/0x470 drivers/tty/tty_io.c:1318
 tty_open_by_driver drivers/tty/tty_io.c:1987 [inline]
 tty_open+0x4a5/0xbb0 drivers/tty/tty_io.c:2035
 chrdev_open+0x245/0x6b0 fs/char_dev.c:414
 do_dentry_open+0x4e6/0x1380 fs/open.c:797
 vfs_open+0xa0/0xd0 fs/open.c:914
 do_last fs/namei.c:3490 [inline]
 path_openat+0x12ee/0x3490 fs/namei.c:3607
 do_filp_open+0x192/0x260 fs/namei.c:3637
 do_sys_openat2+0x5eb/0x7e0 fs/open.c:1149
 do_sys_open+0xf2/0x180 fs/open.c:1165
 ksys_open include/linux/syscalls.h:1386 [inline]
 __do_sys_open fs/open.c:1171 [inline]
 __se_sys_open fs/open.c:1169 [inline]
 __x64_sys_open+0x7e/0xc0 fs/open.c:1169
 do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294

Freed by task 14717:
 save_stack+0x23/0x90 mm/kasan/common.c:72
 set_track mm/kasan/common.c:80 [inline]
 kasan_set_free_info mm/kasan/common.c:337 [inline]
 __kasan_slab_free+0x102/0x150 mm/kasan/common.c:476
 kasan_slab_free+0xe/0x10 mm/kasan/common.c:485
 __cache_free mm/slab.c:3426 [inline]
 kfree+0x10a/0x2c0 mm/slab.c:3757
 vt_disallocate_all+0x2bd/0x3e0 drivers/tty/vt/vt_ioctl.c:323
 vt_ioctl+0xc38/0x26d0 drivers/tty/vt/vt_ioctl.c:816
 tty_ioctl+0xa37/0x14f0 drivers/tty/tty_io.c:2660
 vfs_ioctl fs/ioctl.c:47 [inline]
 ksys_ioctl+0x123/0x180 fs/ioctl.c:763
 __do_sys_ioctl fs/ioctl.c:772 [inline]
 __se_sys_ioctl fs/ioctl.c:770 [inline]
 __x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:770
 do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294

The buggy address belongs to the object at ffff8880a3470000
 which belongs to the cache kmalloc-2k of size 2048
The buggy address is located 32 bytes inside of
 2048-byte region [ffff8880a3470000, ffff8880a3470800)
The buggy address belongs to the page:
page:ffffea00028d1c00 refcount:1 mapcount:0 mapping:ffff8880aa400e00 index:0x0
flags: 0xfffe0000000200(slab)
raw: 00fffe0000000200 ffffea00024b17c8 ffffea00026a6508 ffff8880aa400e00
raw: 0000000000000000 ffff8880a3470000 0000000100000001 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff8880a346ff00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
 ffff8880a346ff80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
>ffff8880a3470000: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff8880a3470080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff8880a3470100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb

Crashes (4):
Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets Title
ci-upstream-kasan-gce-selinux-root 2020/02/09 14:32 upstream fdfa3a6778b1 6ece2ea5 .config console log report
ci-upstream-kasan-gce 2020/02/09 11:42 upstream fdfa3a6778b1 6ece2ea5 .config console log report
ci-qemu-upstream 2020/01/12 15:29 upstream 6327edceb62b 53faa9fe .config console log report
ci-upstream-kasan-gce-selinux-root 2019/12/20 18:57 upstream 7e0165b2f1a9 bc586918 .config console log report
* Struck through repros no longer work on HEAD.