divide error in cdc_ncm_update_rxtx_max

Status: fixed on 2019/10/15 23:40
Subsystems: usb
[Documentation on labels]
Reported-by: syzbot+ce366e2b8296e25d84f5@syzkaller.appspotmail.com
Fix commit: 3fe4b3351301 cdc_ncm: fix divide-by-zero caused by invalid wMaxPacketSize
First crash: 2515d, last: 2497d
▶ ▼ Discussions (15)
Title Replies (including bot) Last reply
[PATCH 5.2 000/313] 5.2.19-stable review 324 (324) 2020/06/23 22:07
[PATCH 4.19 000/211] 4.19.77-stable review 227 (227) 2019/11/12 00:25
[PATCH 5.3 000/344] 5.3.4-stable review 360 (360) 2019/11/11 06:01
[PATCH AUTOSEL 5.3 01/71] drivers: thermal: qcom: tsens: Fix memory leak from qfprom read 74 (74) 2019/10/09 03:45
[PATCH 4.14 000/185] 4.14.147-stable review 191 (191) 2019/10/05 00:10
[PATCH 4.9 000/129] 4.9.195-stable review 135 (135) 2019/10/04 22:56
[PATCH 4.4 00/99] 4.4.195-stable review 105 (105) 2019/10/04 22:55
[PATCH AUTOSEL 4.4 01/15] ima: always return negative code for error 15 (15) 2019/10/01 16:45
[PATCH AUTOSEL 4.9 01/19] ima: always return negative code for error 19 (19) 2019/10/01 16:45
[PATCH AUTOSEL 4.14 01/29] ima: always return negative code for error 29 (29) 2019/10/01 16:44
[PATCH AUTOSEL 4.19 01/43] ima: always return negative code for error 43 (43) 2019/10/01 16:43
[PATCH AUTOSEL 5.2 01/63] drivers: thermal: qcom: tsens: Fix memory leak from qfprom read 63 (63) 2019/10/01 16:41
[PATCH net,stable] cdc_ncm: fix divide-by-zero caused by invalid wMaxPacketSize 2 (3) 2019/09/21 19:30
Reminder: 52 active syzbot reports in usb subsystem 4 (4) 2019/09/19 19:01
divide error in cdc_ncm_update_rxtx_max 2 (4) 2019/09/17 15:46
▶ ▼ Last patch testing requests (3)
Created Duration User Patch Repo Result
2019/09/18 12:02 18m bjorn@mork.no patch https://github.com/google/kasan.git f0df5c1b OK
2019/09/18 11:04 18m bjorn@mork.no patch https://github.com/google/kasan.git f0df5c1b OK
2019/09/17 13:57 10m bjorn@mork.no patch https://github.com/google/kasan.git f0df5c1b report log

Sample crash report:
usb 1-1: SerialNumber: syz
cdc_ncm 1-1:1.0: MAC-Address: 42:42:42:42:42:42
cdc_ncm 1-1:1.0: dwNtbInMaxSize=1 is too small. Using 2048
cdc_ncm 1-1:1.0: setting rx_max = 2048
cdc_ncm 1-1:1.0: setting tx_max = 16384
divide error: 0000 [#1] SMP KASAN
CPU: 1 PID: 83 Comm: kworker/1:2 Not tainted 5.3.0+ #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
RIP: 0010:cdc_ncm_update_rxtx_max+0xc6e/0xef0 drivers/net/usb/cdc_ncm.c:419
Code: e0 07 38 c2 0f 9e c1 84 d2 0f 95 c0 84 c1 0f 85 35 02 00 00 0f b7 5b 04 81 e3 ff 07 00 00 e8 19 1d f4 fd 31 d2 44 89 e0 31 ff <f7> f3 41 89 d5 89 d6 e8 76 1e f4 fd 45 85 ed 0f 85 17 f7 ff ff e8
RSP: 0018:ffff8881d93c7020 EFLAGS: 00010246
RAX: 0000000000004000 RBX: 0000000000000000 RCX: 0000000000000001
RDX: 0000000000000000 RSI: ffffffff834a1f87 RDI: 0000000000000000
RBP: ffff8881d913b300 R08: ffff8881d975c800 R09: ffffed103b665d58
R10: ffffed103b665d57 R11: ffff8881db32eabf R12: 0000000000004000
R13: 0000000000000000 R14: ffff8881d2e50ac0 R15: ffff8881d2e3c500
FS:  0000000000000000(0000) GS:ffff8881db300000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00000000004c2888 CR3: 00000001d46c8000 CR4: 00000000001406e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 cdc_ncm_setup drivers/net/usb/cdc_ncm.c:667 [inline]
 cdc_ncm_bind_common+0x1005/0x2570 drivers/net/usb/cdc_ncm.c:924
 cdc_ncm_bind+0x7c/0x1c0 drivers/net/usb/cdc_ncm.c:1038
 usbnet_probe+0xb43/0x23cf drivers/net/usb/usbnet.c:1722
 usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361
 really_probe+0x281/0x6d0 drivers/base/dd.c:548
 driver_probe_device+0x104/0x210 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490
 device_add+0xae6/0x16f0 drivers/base/core.c:2201
 usb_set_configuration+0xdf6/0x1670 drivers/usb/core/message.c:2023
 generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210
 usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266
 really_probe+0x281/0x6d0 drivers/base/dd.c:548
 driver_probe_device+0x104/0x210 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490
 device_add+0xae6/0x16f0 drivers/base/core.c:2201
 usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2536
 hub_port_connect drivers/usb/core/hub.c:5098 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5213 [inline]
 port_event drivers/usb/core/hub.c:5359 [inline]
 hub_event+0x1b5c/0x3640 drivers/usb/core/hub.c:5441
 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269
 worker_thread+0x96/0xe20 kernel/workqueue.c:2415
 kthread+0x318/0x420 kernel/kthread.c:255

Crashes (5):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/09/30 07:36 https://github.com/google/kasan.git usb-fuzzer 2994c07743fe c1ad5441 .config console log report syz C ci2-upstream-usb
2019/09/25 18:38 https://github.com/google/kasan.git usb-fuzzer 23e42cc70f6e a3355dba .config console log report syz C ci2-upstream-usb
2019/09/25 05:37 https://github.com/google/kasan.git usb-fuzzer d9e63adcd16e e38a6630 .config console log report syz C ci2-upstream-usb
2019/09/19 19:47 https://github.com/google/kasan.git usb-fuzzer e0bd8d794fc9 eb940044 .config console log report syz C ci2-upstream-usb
2019/09/12 16:14 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 0b7672ee .config console log report syz C ci2-upstream-usb
* Struck through repros no longer work on HEAD.