syzbot


possible deadlock in xfs_ilock (2)

Status: upstream: reported on 2024/04/15 00:11
Subsystems: xfs
[Documentation on labels]
Reported-by: syzbot+c6d7bff58a2218f14632@syzkaller.appspotmail.com
First crash: 98d, last: 22d
Discussions (4)
Title Replies (including bot) Last reply
[syzbot] Monthly xfs report (Jul 2024) 0 (1) 2024/07/01 10:28
[syzbot] Monthly xfs report (May 2024) 0 (1) 2024/05/31 06:48
[syzbot] Monthly xfs report (Apr 2024) 0 (1) 2024/04/29 12:34
[syzbot] [xfs?] possible deadlock in xfs_ilock (2) 0 (1) 2024/04/15 00:11
Similar bugs (1)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream possible deadlock in xfs_ilock xfs 30 99d 126d 26/27 fixed on 2024/04/10 03:59

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.10.0-rc2-syzkaller-00007-gf06ce441457d #0 Not tainted
------------------------------------------------------
kswapd0/88 is trying to acquire lock:
ffff88807835bf18 (&xfs_nondir_ilock_class#4){++++}-{3:3}, at: xfs_ilock+0x2ef/0x420 fs/xfs/xfs_inode.c:207

but task is already holding lock:
ffffffff8dd3b440 (fs_reclaim){+.+.}-{0:0}, at: balance_pgdat+0x166/0x18f0 mm/vmscan.c:6798

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (fs_reclaim){+.+.}-{0:0}:
       __fs_reclaim_acquire mm/page_alloc.c:3783 [inline]
       fs_reclaim_acquire+0x102/0x160 mm/page_alloc.c:3797
       might_alloc include/linux/sched/mm.h:334 [inline]
       slab_pre_alloc_hook mm/slub.c:3890 [inline]
       slab_alloc_node mm/slub.c:3980 [inline]
       __do_kmalloc_node mm/slub.c:4120 [inline]
       __kmalloc_noprof+0xb5/0x410 mm/slub.c:4134
       kmalloc_noprof include/linux/slab.h:664 [inline]
       xfs_attr_shortform_list fs/xfs/xfs_attr_list.c:117 [inline]
       xfs_attr_list_ilocked+0x9a0/0x1b00 fs/xfs/xfs_attr_list.c:569
       xfs_attr_list+0x1f9/0x2b0 fs/xfs/xfs_attr_list.c:595
       xfs_vn_listxattr+0x11f/0x1c0 fs/xfs/xfs_xattr.c:324
       vfs_listxattr+0xba/0x140 fs/xattr.c:493
       listxattr+0x69/0x190 fs/xattr.c:840
       __do_sys_flistxattr fs/xattr.c:893 [inline]
       __se_sys_flistxattr fs/xattr.c:885 [inline]
       __x64_sys_flistxattr+0x156/0x1e0 fs/xattr.c:885
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&xfs_nondir_ilock_class#4){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x2478/0x3b30 kernel/locking/lockdep.c:5137
       lock_acquire kernel/locking/lockdep.c:5754 [inline]
       lock_acquire+0x1b1/0x560 kernel/locking/lockdep.c:5719
       down_write_nested+0x3d/0x50 kernel/locking/rwsem.c:1695
       xfs_ilock+0x2ef/0x420 fs/xfs/xfs_inode.c:207
       xfs_reclaim_inode fs/xfs/xfs_icache.c:943 [inline]
       xfs_icwalk_process_inode fs/xfs/xfs_icache.c:1629 [inline]
       xfs_icwalk_ag+0xca6/0x1780 fs/xfs/xfs_icache.c:1711
       xfs_icwalk+0x57/0x100 fs/xfs/xfs_icache.c:1760
       xfs_reclaim_inodes_nr+0x182/0x250 fs/xfs/xfs_icache.c:1009
       super_cache_scan+0x40c/0x550 fs/super.c:227
       do_shrink_slab+0x452/0x11c0 mm/shrinker.c:435
       shrink_slab+0x18a/0x1310 mm/shrinker.c:662
       shrink_one+0x493/0x7c0 mm/vmscan.c:4790
       shrink_many mm/vmscan.c:4851 [inline]
       lru_gen_shrink_node mm/vmscan.c:4951 [inline]
       shrink_node+0x22bd/0x39b0 mm/vmscan.c:5910
       kswapd_shrink_node mm/vmscan.c:6720 [inline]
       balance_pgdat+0x9a0/0x18f0 mm/vmscan.c:6911
       kswapd+0x5ea/0xbf0 mm/vmscan.c:7180
       kthread+0x2c4/0x3a0 kernel/kthread.c:389
       ret_from_fork+0x48/0x80 arch/x86/kernel/process.c:147
       ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(fs_reclaim);
                               lock(&xfs_nondir_ilock_class#4);
                               lock(fs_reclaim);
  lock(&xfs_nondir_ilock_class#4);

 *** DEADLOCK ***

2 locks held by kswapd0/88:
 #0: ffffffff8dd3b440 (fs_reclaim){+.+.}-{0:0}, at: balance_pgdat+0x166/0x18f0 mm/vmscan.c:6798
 #1: ffff88815b0d00e0 (&type->s_umount_key#88){++++}-{3:3}, at: super_trylock_shared fs/super.c:562 [inline]
 #1: ffff88815b0d00e0 (&type->s_umount_key#88){++++}-{3:3}, at: super_cache_scan+0x96/0x550 fs/super.c:196

stack backtrace:
CPU: 1 PID: 88 Comm: kswapd0 Not tainted 6.10.0-rc2-syzkaller-00007-gf06ce441457d #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:114
 check_noncircular+0x31a/0x400 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x2478/0x3b30 kernel/locking/lockdep.c:5137
 lock_acquire kernel/locking/lockdep.c:5754 [inline]
 lock_acquire+0x1b1/0x560 kernel/locking/lockdep.c:5719
 down_write_nested+0x3d/0x50 kernel/locking/rwsem.c:1695
 xfs_ilock+0x2ef/0x420 fs/xfs/xfs_inode.c:207
 xfs_reclaim_inode fs/xfs/xfs_icache.c:943 [inline]
 xfs_icwalk_process_inode fs/xfs/xfs_icache.c:1629 [inline]
 xfs_icwalk_ag+0xca6/0x1780 fs/xfs/xfs_icache.c:1711
 xfs_icwalk+0x57/0x100 fs/xfs/xfs_icache.c:1760
 xfs_reclaim_inodes_nr+0x182/0x250 fs/xfs/xfs_icache.c:1009
 super_cache_scan+0x40c/0x550 fs/super.c:227
 do_shrink_slab+0x452/0x11c0 mm/shrinker.c:435
 shrink_slab+0x18a/0x1310 mm/shrinker.c:662
 shrink_one+0x493/0x7c0 mm/vmscan.c:4790
 shrink_many mm/vmscan.c:4851 [inline]
 lru_gen_shrink_node mm/vmscan.c:4951 [inline]
 shrink_node+0x22bd/0x39b0 mm/vmscan.c:5910
 kswapd_shrink_node mm/vmscan.c:6720 [inline]
 balance_pgdat+0x9a0/0x18f0 mm/vmscan.c:6911
 kswapd+0x5ea/0xbf0 mm/vmscan.c:7180
 kthread+0x2c4/0x3a0 kernel/kthread.c:389
 ret_from_fork+0x48/0x80 arch/x86/kernel/process.c:147
 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244
 </TASK>

Crashes (1422):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/06/04 02:31 upstream f06ce441457d 0aba2352 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-badwrites-root possible deadlock in xfs_ilock
2024/05/19 09:03 upstream 0450d2083be6 c0f1611a .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-selinux-root possible deadlock in xfs_ilock
2024/06/25 06:15 upstream 55027e689933 c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream possible deadlock in xfs_ilock
2024/06/24 03:52 upstream f2661062f16b c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream possible deadlock in xfs_ilock
2024/06/26 06:26 upstream 55027e689933 c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/26 03:43 upstream 55027e689933 c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/25 23:17 upstream 55027e689933 c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/25 19:03 upstream 55027e689933 c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/25 08:36 upstream 55027e689933 c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/24 19:45 upstream 626737a5791b c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/24 17:30 upstream 626737a5791b c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/24 17:30 upstream 626737a5791b c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/24 15:44 upstream 626737a5791b c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/24 13:18 upstream f2661062f16b c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/24 10:06 upstream f2661062f16b c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/24 03:12 upstream f2661062f16b c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/23 22:33 upstream 5f583a3162ff c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/23 15:52 upstream 5f583a3162ff c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/23 14:08 upstream 5f583a3162ff c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/23 10:50 upstream 5f583a3162ff c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/23 09:36 upstream 563a50672d8a c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/23 09:12 upstream 563a50672d8a c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/23 07:11 upstream 563a50672d8a c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/23 01:52 upstream 563a50672d8a c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/22 22:02 upstream 563a50672d8a c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/22 20:14 upstream 35bb670d65fc c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/22 13:26 upstream 35bb670d65fc c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/22 12:19 upstream 35bb670d65fc c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/22 11:00 upstream 35bb670d65fc c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/22 05:39 upstream 66cc544fd75c c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/22 00:50 upstream 66cc544fd75c c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/22 00:50 upstream 66cc544fd75c c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/21 23:23 upstream 66cc544fd75c c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/21 20:14 upstream 66cc544fd75c c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/21 16:46 upstream 50736169ecc8 c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/21 15:33 upstream 50736169ecc8 c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/21 13:29 upstream 50736169ecc8 c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/21 01:57 upstream 50736169ecc8 c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/20 22:02 upstream 50736169ecc8 c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/20 17:53 upstream 2ccbdf43d5e7 c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/20 15:40 upstream 2ccbdf43d5e7 c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/20 14:15 upstream 2ccbdf43d5e7 c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/20 12:50 upstream 2ccbdf43d5e7 c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/20 10:21 upstream 2ccbdf43d5e7 c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/06/20 08:33 upstream 2ccbdf43d5e7 c2e07261 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/04/14 22:19 upstream 72374d71c315 c8349e48 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
2024/04/10 21:24 upstream a6189a740779 33b9e058 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in xfs_ilock
* Struck through repros no longer work on HEAD.