syzbot


possible deadlock in ntfs_mark_rec_free

Status: upstream: reported on 2023/01/03 12:45
Subsystems: ntfs3 (incorrect?)
Reported-by: syzbot+f83f0dbef763c426e3cf@syzkaller.appspotmail.com
First crash: 82d, last: 6h03m
similar bugs (1):
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-6.1 possible deadlock in ntfs_mark_rec_free 1 2d07h 2d07h 0/3 upstream: reported on 2023/03/23 23:58

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.3.0-rc3-syzkaller-00338-gda8e7da11e4b #0 Not tainted
------------------------------------------------------
kworker/u4:5/3461 is trying to acquire lock:
ffff888028b7a120 (&wnd->rw_lock/1){+.+.}-{3:3}, at: ntfs_mark_rec_free+0x3f/0x2b0 fs/ntfs3/fsntfs.c:741

but task is already holding lock:
ffff88804dda0860 (&ni->ni_lock){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1144 [inline]
ffff88804dda0860 (&ni->ni_lock){+.+.}-{3:3}, at: ni_write_inode+0x155/0x1250 fs/ntfs3/frecord.c:3255

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&ni->ni_lock){+.+.}-{3:3}:
       lock_acquire+0x1e1/0x520 kernel/locking/lockdep.c:5669
       __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799
       ntfs_set_state+0x21b/0x6f0 fs/ntfs3/fsntfs.c:946
       attr_set_size+0x3311/0x4290 fs/ntfs3/attrib.c:867
       ntfs_extend_mft+0x2fa/0x4b0 fs/ntfs3/fsntfs.c:526
       ntfs_look_free_mft+0x43d/0x10b0 fs/ntfs3/fsntfs.c:589
       ni_create_attr_list+0x9d4/0x1510 fs/ntfs3/frecord.c:873
       ni_ins_attr_ext+0x334/0xc00 fs/ntfs3/frecord.c:968
       ni_insert_attr+0x358/0x900 fs/ntfs3/frecord.c:1135
       ni_insert_resident+0xf8/0x3c0 fs/ntfs3/frecord.c:1519
       ntfs_set_ea+0xabc/0x1670 fs/ntfs3/xattr.c:432
       ntfs_save_wsl_perm+0x13d/0x490 fs/ntfs3/xattr.c:962
       ntfs3_setattr+0x98d/0xb80 fs/ntfs3/file.c:722
       notify_change+0xc8b/0xf40 fs/attr.c:482
       chown_common+0x500/0x850 fs/open.c:774
       do_fchownat+0x16d/0x240 fs/open.c:805
       __do_sys_fchownat fs/open.c:820 [inline]
       __se_sys_fchownat fs/open.c:817 [inline]
       __x64_sys_fchownat+0xb5/0xd0 fs/open.c:817
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #1 (&ni->file.run_lock#2){++++}-{3:3}:
       lock_acquire+0x1e1/0x520 kernel/locking/lockdep.c:5669
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1573
       ntfs_extend_mft+0x160/0x4b0 fs/ntfs3/fsntfs.c:510
       ntfs_look_free_mft+0x43d/0x10b0 fs/ntfs3/fsntfs.c:589
       ntfs_create_inode+0x4d7/0x3830 fs/ntfs3/inode.c:1296
       ntfs_atomic_open+0x3db/0x530 fs/ntfs3/namei.c:424
       atomic_open fs/namei.c:3279 [inline]
       lookup_open fs/namei.c:3387 [inline]
       open_last_lookups fs/namei.c:3484 [inline]
       path_openat+0x103c/0x3170 fs/namei.c:3712
       do_filp_open+0x234/0x490 fs/namei.c:3742
       do_sys_openat2+0x13f/0x500 fs/open.c:1348
       do_sys_open fs/open.c:1364 [inline]
       __do_sys_open fs/open.c:1372 [inline]
       __se_sys_open fs/open.c:1368 [inline]
       __x64_sys_open+0x225/0x270 fs/open.c:1368
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&wnd->rw_lock/1){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3098 [inline]
       check_prevs_add kernel/locking/lockdep.c:3217 [inline]
       validate_chain+0x166b/0x58e0 kernel/locking/lockdep.c:3832
       __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056
       lock_acquire+0x1e1/0x520 kernel/locking/lockdep.c:5669
       down_write_nested+0x3d/0x50 kernel/locking/rwsem.c:1689
       ntfs_mark_rec_free+0x3f/0x2b0 fs/ntfs3/fsntfs.c:741
       ni_write_inode+0x437/0x1250 fs/ntfs3/frecord.c:3348
       write_inode fs/fs-writeback.c:1453 [inline]
       __writeback_single_inode+0x69b/0xfb0 fs/fs-writeback.c:1665
       writeback_sb_inodes+0x8ef/0x11d0 fs/fs-writeback.c:1891
       wb_writeback+0x458/0xc70 fs/fs-writeback.c:2065
       wb_do_writeback fs/fs-writeback.c:2208 [inline]
       wb_workfn+0x400/0xff0 fs/fs-writeback.c:2248
       process_one_work+0x8a0/0x10e0 kernel/workqueue.c:2390
       worker_thread+0xa63/0x1210 kernel/workqueue.c:2537
       kthread+0x270/0x300 kernel/kthread.c:376
       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308

other info that might help us debug this:

Chain exists of:
  &wnd->rw_lock/1 --> &ni->file.run_lock#2 --> &ni->ni_lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ni->ni_lock);
                               lock(&ni->file.run_lock#2);
                               lock(&ni->ni_lock);
  lock(&wnd->rw_lock/1);

 *** DEADLOCK ***

3 locks held by kworker/u4:5/3461:
 #0: ffff88801781c138 ((wq_completion)writeback){+.+.}-{0:0}, at: process_one_work+0x77e/0x10e0 kernel/workqueue.c:2363
 #1: ffffc9000e1f7d20 ((work_completion)(&(&wb->dwork)->work)){+.+.}-{0:0}, at: process_one_work+0x7c8/0x10e0 kernel/workqueue.c:2365
 #2: ffff88804dda0860 (&ni->ni_lock){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1144 [inline]
 #2: ffff88804dda0860 (&ni->ni_lock){+.+.}-{3:3}, at: ni_write_inode+0x155/0x1250 fs/ntfs3/frecord.c:3255

stack backtrace:
CPU: 1 PID: 3461 Comm: kworker/u4:5 Not tainted 6.3.0-rc3-syzkaller-00338-gda8e7da11e4b #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
Workqueue: writeback wb_workfn (flush-7:0)
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106
 check_noncircular+0x2fe/0x3b0 kernel/locking/lockdep.c:2178
 check_prev_add kernel/locking/lockdep.c:3098 [inline]
 check_prevs_add kernel/locking/lockdep.c:3217 [inline]
 validate_chain+0x166b/0x58e0 kernel/locking/lockdep.c:3832
 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056
 lock_acquire+0x1e1/0x520 kernel/locking/lockdep.c:5669
 down_write_nested+0x3d/0x50 kernel/locking/rwsem.c:1689
 ntfs_mark_rec_free+0x3f/0x2b0 fs/ntfs3/fsntfs.c:741
 ni_write_inode+0x437/0x1250 fs/ntfs3/frecord.c:3348
 write_inode fs/fs-writeback.c:1453 [inline]
 __writeback_single_inode+0x69b/0xfb0 fs/fs-writeback.c:1665
 writeback_sb_inodes+0x8ef/0x11d0 fs/fs-writeback.c:1891
 wb_writeback+0x458/0xc70 fs/fs-writeback.c:2065
 wb_do_writeback fs/fs-writeback.c:2208 [inline]
 wb_workfn+0x400/0xff0 fs/fs-writeback.c:2248
 process_one_work+0x8a0/0x10e0 kernel/workqueue.c:2390
 worker_thread+0xa63/0x1210 kernel/workqueue.c:2537
 kthread+0x270/0x300 kernel/kthread.c:376
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308
 </TASK>

Crashes (117):
Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets Title
ci2-upstream-fs 2023/03/26 00:28 upstream da8e7da11e4b fbf0499a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/03/25 05:08 upstream 65aca32efdcb 9700afae .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/03/25 01:55 upstream 1e760fa3596e 9700afae .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/03/24 15:15 upstream 1e760fa3596e 9700afae .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/03/24 10:15 upstream 1e760fa3596e f94b4a29 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/03/23 18:25 upstream fff5a5e7f528 f94b4a29 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/03/23 14:45 upstream fff5a5e7f528 f94b4a29 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/03/23 13:40 upstream fff5a5e7f528 f94b4a29 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/03/22 17:17 upstream a1effab7a3a3 f94b4a29 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/03/22 09:58 upstream a1effab7a3a3 8b4eb097 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/03/21 17:49 upstream 17214b70a159 8b4eb097 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/03/21 09:02 upstream 17214b70a159 7939252e .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/03/21 02:13 upstream 7d31677bb7b1 7939252e .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/03/21 01:02 upstream 7d31677bb7b1 7939252e .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci-upstream-kasan-gce-root 2023/03/20 23:51 upstream 7d31677bb7b1 7939252e .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/03/20 19:52 upstream 7d31677bb7b1 7939252e .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci-upstream-kasan-gce-root 2023/03/17 13:56 upstream 38e04b3e4240 18b58603 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci-upstream-kasan-gce-root 2023/03/16 23:05 upstream 0ddc84d2dd43 18b58603 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci-upstream-kasan-gce-root 2023/03/16 22:04 upstream 0ddc84d2dd43 18b58603 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/03/16 17:06 upstream 9c1bec9c0b08 18b58603 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/03/16 12:25 upstream 9c1bec9c0b08 18b58603 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/03/04 13:31 upstream 0988a0ea7919 f8902b57 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/03/03 23:52 upstream 0a3f9a6b0265 f8902b57 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/03/02 20:54 upstream 04a357b1f6f0 f8902b57 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/02/26 21:05 upstream 2fcd07b7ccd5 ee50e71c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/02/25 02:48 upstream 8cbd92339db0 ee50e71c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/02/22 23:28 upstream 5b7c4cabbb65 9f1e2cb3 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/02/19 21:54 upstream 925cf0457d7e bcdf85f8 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci-upstream-kasan-gce-root 2023/02/19 10:14 upstream 925cf0457d7e bcdf85f8 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/02/18 23:34 upstream 5e725d112e1a bcdf85f8 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/02/18 06:26 upstream 38f8ccde04a3 d02e9a70 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/02/17 23:30 upstream ec35307e18ba cf8c2d39 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci-upstream-kasan-gce-smack-root 2023/02/17 00:27 upstream 3ac88fa4605e 851bc19a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/02/16 17:40 upstream 033c40a89f55 38b317a7 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/02/16 16:16 upstream 033c40a89f55 38b317a7 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/02/16 05:14 upstream 033c40a89f55 6be0f1f5 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/02/16 01:42 upstream e1c04510f521 6be0f1f5 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/02/15 15:23 upstream e1c04510f521 6be0f1f5 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/02/13 08:36 upstream 711e9a4d52bf 93e26d60 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/02/12 23:22 upstream 711e9a4d52bf 93e26d60 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/02/12 21:51 upstream f339c2597ebb 93e26d60 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/02/09 03:44 upstream 0983f6bf2bfc 14a312c8 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/02/08 20:08 upstream 0983f6bf2bfc fc9c934e .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/02/08 13:02 upstream 0983f6bf2bfc abbb67b7 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/02/08 10:48 upstream 0983f6bf2bfc 15c3d445 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/02/08 08:12 upstream 513c1a3d3f19 15c3d445 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci-upstream-kasan-gce-selinux-root 2023/02/07 23:29 upstream 513c1a3d3f19 15c3d445 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/02/07 07:00 upstream 05ecb680708a 5bc3be51 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci-qemu-upstream 2023/01/03 12:21 upstream 69b41ac87e4a d43e0eb8 .config console log report info possible deadlock in ntfs_mark_rec_free
ci2-upstream-fs 2023/01/02 21:45 upstream 88603b6dc419 ab32d508 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
ci-upstream-linux-next-kasan-gce-root 2023/02/24 22:24 linux-next 0222aa9800b2 ee50e71c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_mark_rec_free
* Struck through repros no longer work on HEAD.