syzbot


inconsistent lock state in padata_do_serial

Status: auto-closed as invalid on 2021/12/25 08:14
Reported-by: syzbot+5952f5d2983bea3ff2ba@syzkaller.appspotmail.com
First crash: 533d, last: 460d
similar bugs (1):
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream inconsistent lock state in padata_do_serial (2) 1 76d 72d 0/24 upstream: reported on 2022/09/18 19:43

Sample crash report:
================================
WARNING: inconsistent lock state
5.14.0-rc7-syzkaller #0 Not tainted
--------------------------------
inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage.
syz-executor.2/28034 [HC0[0]:SC1[1]:HE1:SE0] takes:
ffffe8ffffc45b18 (&pd_list->lock){+.?.}-{2:2}, at: spin_lock include/linux/spinlock.h:354 [inline]
ffffe8ffffc45b18 (&pd_list->lock){+.?.}-{2:2}, at: padata_do_serial+0x192/0x410 kernel/padata.c:405
{SOFTIRQ-ON-W} state was registered at:
  lock_acquire kernel/locking/lockdep.c:5625 [inline]
  lock_acquire+0x1ab/0x510 kernel/locking/lockdep.c:5590
  __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
  _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:151
  spin_lock include/linux/spinlock.h:354 [inline]
  padata_do_serial+0x192/0x410 kernel/padata.c:405
  pcrypt_aead_enc+0x57/0x70 crypto/pcrypt.c:87
  padata_do_parallel+0x754/0x8b0 kernel/padata.c:230
  pcrypt_aead_encrypt+0x39f/0x4d0 crypto/pcrypt.c:115
  crypto_aead_encrypt+0xaa/0xf0 crypto/aead.c:94
  tls_do_encryption net/tls/tls_sw.c:529 [inline]
  tls_push_record+0x13d7/0x31c0 net/tls/tls_sw.c:762
  bpf_exec_tx_verdict+0xd82/0x11a0 net/tls/tls_sw.c:802
  tls_sw_sendmsg+0xa34/0x17f0 net/tls/tls_sw.c:1014
  inet6_sendmsg+0x99/0xe0 net/ipv6/af_inet6.c:642
  sock_sendmsg_nosec net/socket.c:703 [inline]
  sock_sendmsg+0xcf/0x120 net/socket.c:723
  __sys_sendto+0x21c/0x320 net/socket.c:2019
  __do_sys_sendto net/socket.c:2031 [inline]
  __se_sys_sendto net/socket.c:2027 [inline]
  __x64_sys_sendto+0xdd/0x1b0 net/socket.c:2027
  do_syscall_x64 arch/x86/entry/common.c:50 [inline]
  do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
  entry_SYSCALL_64_after_hwframe+0x44/0xae
irq event stamp: 8462
hardirqs last  enabled at (8462): [<ffffffff81464a80>] __local_bh_enable_ip+0xa0/0x120 kernel/softirq.c:388
hardirqs last disabled at (8461): [<ffffffff81464aa3>] __local_bh_enable_ip+0xc3/0x120 kernel/softirq.c:365
softirqs last  enabled at (5462): [<ffffffff812b38bc>] memcpy include/linux/fortify-string.h:191 [inline]
softirqs last  enabled at (5462): [<ffffffff812b38bc>] fpu_clone+0x13c/0x600 arch/x86/kernel/fpu/core.c:275
softirqs last disabled at (8379): [<ffffffff8146492e>] invoke_softirq kernel/softirq.c:432 [inline]
softirqs last disabled at (8379): [<ffffffff8146492e>] __irq_exit_rcu+0x16e/0x1c0 kernel/softirq.c:636

other info that might help us debug this:
 Possible unsafe locking scenario:

       CPU0
       ----
  lock(&pd_list->lock);
  <Interrupt>
    lock(&pd_list->lock);

 *** DEADLOCK ***

2 locks held by syz-executor.2/28034:
 #0: ffffc90000dc0d70 ((&d->timer)){+.-.}-{0:0}, at: lockdep_copy_map include/linux/lockdep.h:35 [inline]
 #0: ffffc90000dc0d70 ((&d->timer)){+.-.}-{0:0}, at: call_timer_fn+0xd5/0x6b0 kernel/time/timer.c:1411
 #1: ffffffff8b97c280 (rcu_read_lock){....}-{1:2}, at: buf_msg net/tipc/msg.h:202 [inline]
 #1: ffffffff8b97c280 (rcu_read_lock){....}-{1:2}, at: tipc_bearer_xmit_skb+0x8c/0x400 net/tipc/bearer.c:549

stack backtrace:
CPU: 1 PID: 28034 Comm: syz-executor.2 Not tainted 5.14.0-rc7-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 <IRQ>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:105
 print_usage_bug kernel/locking/lockdep.c:203 [inline]
 valid_state kernel/locking/lockdep.c:3933 [inline]
 mark_lock_irq kernel/locking/lockdep.c:4136 [inline]
 mark_lock.cold+0x61/0x8e kernel/locking/lockdep.c:4593
 mark_usage kernel/locking/lockdep.c:4488 [inline]
 __lock_acquire+0x11d5/0x54a0 kernel/locking/lockdep.c:4969
 lock_acquire kernel/locking/lockdep.c:5625 [inline]
 lock_acquire+0x1ab/0x510 kernel/locking/lockdep.c:5590
 __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
 _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:151
 spin_lock include/linux/spinlock.h:354 [inline]
 padata_do_serial+0x192/0x410 kernel/padata.c:405
 pcrypt_aead_enc+0x57/0x70 crypto/pcrypt.c:87
 padata_do_parallel+0x754/0x8b0 kernel/padata.c:230
 pcrypt_aead_encrypt+0x39f/0x4d0 crypto/pcrypt.c:115
 crypto_aead_encrypt+0xaa/0xf0 crypto/aead.c:94
 tipc_aead_encrypt net/tipc/crypto.c:828 [inline]
 tipc_crypto_xmit+0x1066/0x2d90 net/tipc/crypto.c:1763
 tipc_bearer_xmit_skb+0x164/0x400 net/tipc/bearer.c:556
 tipc_disc_timeout+0x75e/0xcb0 net/tipc/discover.c:335
 call_timer_fn+0x1a5/0x6b0 kernel/time/timer.c:1421
 expire_timers kernel/time/timer.c:1466 [inline]
 __run_timers.part.0+0x675/0xa20 kernel/time/timer.c:1734
 __run_timers kernel/time/timer.c:1715 [inline]
 run_timer_softirq+0xb3/0x1d0 kernel/time/timer.c:1747
 __do_softirq+0x29b/0x9c2 kernel/softirq.c:558
 invoke_softirq kernel/softirq.c:432 [inline]
 __irq_exit_rcu+0x16e/0x1c0 kernel/softirq.c:636
 irq_exit_rcu+0x5/0x20 kernel/softirq.c:648
 sysvec_apic_timer_interrupt+0x93/0xc0 arch/x86/kernel/apic/apic.c:1100
 </IRQ>
 asm_sysvec_apic_timer_interrupt+0x12/0x20 arch/x86/include/asm/idtentry.h:638
RIP: 0010:__raw_spin_unlock_irqrestore include/linux/spinlock_api_smp.h:161 [inline]
RIP: 0010:_raw_spin_unlock_irqrestore+0x38/0x70 kernel/locking/spinlock.c:191
Code: 74 24 10 e8 5a fa 2d f8 48 89 ef e8 02 70 2e f8 81 e3 00 02 00 00 75 25 9c 58 f6 c4 02 75 2d 48 85 db 74 01 fb bf 01 00 00 00 <e8> c3 4d 22 f8 65 8b 05 bc c8 d4 76 85 c0 74 0a 5b 5d c3 e8 a0 aa
RSP: 0018:ffffc9000187fc78 EFLAGS: 00000206
RAX: 0000000000000002 RBX: 0000000000000200 RCX: 1ffffffff1ad8ad9
RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000001
RBP: ffff8880b9d42400 R08: 0000000000000001 R09: 0000000000000001
R10: ffffffff817bd228 R11: 0000000000000000 R12: dffffc0000000000
R13: 0000000000000001 R14: ffffc9000187fdd8 R15: ffff88808b0db880
 hrtimer_start_expires include/linux/hrtimer.h:436 [inline]
 hrtimer_sleeper_start_expires kernel/time/hrtimer.c:1817 [inline]
 do_nanosleep+0x1e8/0x690 kernel/time/hrtimer.c:1893
 hrtimer_nanosleep+0x1f9/0x4a0 kernel/time/hrtimer.c:1949
 common_nsleep+0xa2/0xc0 kernel/time/posix-timers.c:1227
 __do_sys_clock_nanosleep kernel/time/posix-timers.c:1267 [inline]
 __se_sys_clock_nanosleep kernel/time/posix-timers.c:1245 [inline]
 __x64_sys_clock_nanosleep+0x2f4/0x430 kernel/time/posix-timers.c:1245
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x48a7c1
Code: 24 0c 89 3c 24 48 89 4c 24 18 e8 aa e7 ff ff 4c 8b 54 24 18 48 8b 54 24 10 41 89 c0 8b 74 24 0c 8b 3c 24 b8 e6 00 00 00 0f 05 <44> 89 c7 48 89 04 24 e8 e3 e7 ff ff 48 8b 04 24 eb 97 66 2e 0f 1f
RSP: 002b:00007ffd27462ed0 EFLAGS: 00000293 ORIG_RAX: 00000000000000e6
RAX: ffffffffffffffda RBX: 00000000002b88dd RCX: 000000000048a7c1
RDX: 00007ffd27462f10 RSI: 0000000000000000 RDI: 0000000000000000
RBP: 0000000000000001 R08: 0000000000000000 R09: 00007ffd274dc080
R10: 0000000000000000 R11: 0000000000000293 R12: 000000000056bf80
R13: 000000000056cb00 R14: 000000000056bf80 R15: 00000000002b859c
GRED: Unable to relocate VQ 0x0 after dequeue, screwing up backlog
GRED: Unable to relocate VQ 0x0 after dequeue, screwing up backlog
----------------
Code disassembly (best guess):
   0:	74 24                	je     0x26
   2:	10 e8                	adc    %ch,%al
   4:	5a                   	pop    %rdx
   5:	fa                   	cli
   6:	2d f8 48 89 ef       	sub    $0xef8948f8,%eax
   b:	e8 02 70 2e f8       	callq  0xf82e7012
  10:	81 e3 00 02 00 00    	and    $0x200,%ebx
  16:	75 25                	jne    0x3d
  18:	9c                   	pushfq
  19:	58                   	pop    %rax
  1a:	f6 c4 02             	test   $0x2,%ah
  1d:	75 2d                	jne    0x4c
  1f:	48 85 db             	test   %rbx,%rbx
  22:	74 01                	je     0x25
  24:	fb                   	sti
  25:	bf 01 00 00 00       	mov    $0x1,%edi
* 2a:	e8 c3 4d 22 f8       	callq  0xf8224df2 <-- trapping instruction
  2f:	65 8b 05 bc c8 d4 76 	mov    %gs:0x76d4c8bc(%rip),%eax        # 0x76d4c8f2
  36:	85 c0                	test   %eax,%eax
  38:	74 0a                	je     0x44
  3a:	5b                   	pop    %rbx
  3b:	5d                   	pop    %rbp
  3c:	c3                   	retq
  3d:	e8                   	.byte 0xe8
  3e:	a0                   	.byte 0xa0
  3f:	aa                   	stos   %al,%es:(%rdi)

Crashes (2):
Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Title
ci-upstream-net-this-kasan-gce 2021/08/27 08:13 net 73367f05b25d b318694d .config log report info inconsistent lock state in padata_do_serial
ci-upstream-net-this-kasan-gce 2021/06/14 18:10 net f4cdcae03f9c 1ba81399 .config log report info inconsistent lock state in padata_do_serial
* Struck through repros no longer work on HEAD.