syzbot


possible deadlock in attr_data_get_block

Status: upstream: reported C repro on 2022/10/17 07:43
Subsystems: ntfs3 (incorrect?)
Reported-by: syzbot+36bb70085ef6edc2ebb9@syzkaller.appspotmail.com
First crash: 158d, last: 6h34m

Cause bisection: failed (error log, bisect log)
Last patch testing requests:
Created Duration User Patch Repo Result
2022/12/05 10:08 26m hdanton@sina.com patch https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git c2bf05db6c78 OK log

Sample crash report:
loop0: detected capacity change from 0 to 4096
======================================================
WARNING: possible circular locking dependency detected
6.2.0-rc1-syzkaller-00084-gc8451c141e07 #0 Not tainted
------------------------------------------------------
syz-executor474/5063 is trying to acquire lock:
ffff88807660f700 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1122 [inline]
ffff88807660f700 (&ni->ni_lock/4){+.+.}-{3:3}, at: attr_data_get_block+0x32c/0x19f0 fs/ntfs3/attrib.c:919

but task is already holding lock:
ffff88807aab0158 (&mm->mmap_lock){++++}-{3:3}, at: mmap_write_lock_killable include/linux/mmap_lock.h:87 [inline]
ffff88807aab0158 (&mm->mmap_lock){++++}-{3:3}, at: vm_mmap_pgoff+0x159/0x280 mm/util.c:518

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&mm->mmap_lock){++++}-{3:3}:
       __might_fault mm/memory.c:5647 [inline]
       __might_fault+0x10c/0x180 mm/memory.c:5640
       _copy_to_user+0x29/0x150 lib/usercopy.c:29
       copy_to_user include/linux/uaccess.h:169 [inline]
       fiemap_fill_next_extent+0x217/0x370 fs/ioctl.c:144
       ni_fiemap+0x2f9/0xc00 fs/ntfs3/frecord.c:1944
       ntfs_fiemap+0xcc/0x120 fs/ntfs3/file.c:1150
       ioctl_fiemap fs/ioctl.c:219 [inline]
       do_vfs_ioctl+0x466/0x15b0 fs/ioctl.c:810
       __do_sys_ioctl fs/ioctl.c:868 [inline]
       __se_sys_ioctl fs/ioctl.c:856 [inline]
       __x64_sys_ioctl+0x10c/0x210 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&ni->ni_lock/4){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3097 [inline]
       check_prevs_add kernel/locking/lockdep.c:3216 [inline]
       validate_chain kernel/locking/lockdep.c:3831 [inline]
       __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055
       lock_acquire kernel/locking/lockdep.c:5668 [inline]
       lock_acquire+0x1e3/0x630 kernel/locking/lockdep.c:5633
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x12f/0x1360 kernel/locking/mutex.c:747
       ni_lock fs/ntfs3/ntfs_fs.h:1122 [inline]
       attr_data_get_block+0x32c/0x19f0 fs/ntfs3/attrib.c:919
       ntfs_file_mmap+0x478/0x6a0 fs/ntfs3/file.c:296
       call_mmap include/linux/fs.h:2191 [inline]
       mmap_region+0x6c3/0x1dd0 mm/mmap.c:2621
       do_mmap+0x831/0xf60 mm/mmap.c:1411
       vm_mmap_pgoff+0x1af/0x280 mm/util.c:520
       ksys_mmap_pgoff+0x41f/0x5a0 mm/mmap.c:1457
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&mm->mmap_lock);
                               lock(&ni->ni_lock/4);
                               lock(&mm->mmap_lock);
  lock(&ni->ni_lock/4);

 *** DEADLOCK ***

1 lock held by syz-executor474/5063:
 #0: ffff88807aab0158 (&mm->mmap_lock){++++}-{3:3}, at: mmap_write_lock_killable include/linux/mmap_lock.h:87 [inline]
 #0: ffff88807aab0158 (&mm->mmap_lock){++++}-{3:3}, at: vm_mmap_pgoff+0x159/0x280 mm/util.c:518

stack backtrace:
CPU: 0 PID: 5063 Comm: syz-executor474 Not tainted 6.2.0-rc1-syzkaller-00084-gc8451c141e07 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xd1/0x138 lib/dump_stack.c:106
 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2177
 check_prev_add kernel/locking/lockdep.c:3097 [inline]
 check_prevs_add kernel/locking/lockdep.c:3216 [inline]
 validate_chain kernel/locking/lockdep.c:3831 [inline]
 __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055
 lock_acquire kernel/locking/lockdep.c:5668 [inline]
 lock_acquire+0x1e3/0x630 kernel/locking/lockdep.c:5633
 __mutex_lock_common kernel/locking/mutex.c:603 [inline]
 __mutex_lock+0x12f/0x1360 kernel/locking/mutex.c:747
 ni_lock fs/ntfs3/ntfs_fs.h:1122 [inline]
 attr_data_get_block+0x32c/0x19f0 fs/ntfs3/attrib.c:919
 ntfs_file_mmap+0x478/0x6a0 fs/ntfs3/file.c:296
 call_mmap include/linux/fs.h:2191 [inline]
 mmap_region+0x6c3/0x1dd0 mm/mmap.c:2621
 do_mmap+0x831/0xf60 mm/mmap.c:1411
 vm_mmap_pgoff+0x1af/0x280 mm/util.c:520
 ksys_mmap_pgoff+0x41f/0x5a0 mm/mmap.c:1457
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f5ba64dfcf9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 51 14 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffe29c6bcc8 EFLAGS: 00000246 ORIG_RAX: 0000000000000009
RAX: ffffffffffffffda RBX: 0030656c69662f2e RCX: 00007f5ba64dfcf9

Crashes (595):
Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets Title
ci-upstream-kasan-gce-root 2022/12/31 11:51 upstream c8451c141e07 ab32d508 .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in attr_data_get_block
ci2-upstream-fs 2022/12/04 18:11 upstream c2bf05db6c78 e080de16 .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/24 18:45 upstream 1e760fa3596e 9700afae .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/24 07:17 upstream 9fd6ba5420ba f94b4a29 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/23 14:46 upstream fff5a5e7f528 f94b4a29 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/21 17:35 upstream 17214b70a159 8b4eb097 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/21 16:26 upstream 17214b70a159 7939252e .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/21 08:56 upstream 17214b70a159 7939252e .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/20 19:47 upstream 7d31677bb7b1 7939252e .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/20 13:07 upstream e8d018dd0257 7939252e .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci-upstream-kasan-gce-selinux-root 2023/03/20 00:18 upstream 5cdfdd6da323 7939252e .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci-upstream-kasan-gce-root 2023/03/19 02:10 upstream a3671bd86a97 7939252e .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/18 21:26 upstream 534293368afa 7939252e .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/18 17:44 upstream 478a351ce0d6 7939252e .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/18 08:29 upstream 478a351ce0d6 7939252e .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/17 18:16 upstream 38e04b3e4240 7939252e .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/14 21:52 upstream 4979bf866825 0d5c4377 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci-upstream-kasan-gce-root 2023/03/13 17:14 upstream eeac8ede1755 026e2200 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/13 13:02 upstream eeac8ede1755 026e2200 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/12 17:42 upstream 134231664868 5205ef30 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci-upstream-kasan-gce-root 2023/03/05 22:01 upstream f915322fe014 f8902b57 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/05 20:58 upstream f915322fe014 f8902b57 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/05 02:08 upstream b01fe98d34f3 f8902b57 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/03 09:08 upstream 04a357b1f6f0 f8902b57 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/03 04:19 upstream 04a357b1f6f0 f8902b57 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/02 20:00 upstream 04a357b1f6f0 f8902b57 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/02 13:38 upstream ee3f96b16468 f8902b57 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/02 09:43 upstream ee3f96b16468 f8902b57 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/02 03:46 upstream ee3f96b16468 f8902b57 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/01 21:34 upstream ee3f96b16468 f8902b57 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/01 09:17 upstream c0927a7a5391 ef65e6cb .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/03/01 01:46 upstream e492250d5252 95aee97a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/02/27 20:07 upstream 982818426a0f 9189cb53 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/02/26 23:58 upstream f3a2439f20d9 ee50e71c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/02/25 19:54 upstream 489fa31ea873 ee50e71c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/02/25 02:29 upstream 8cbd92339db0 ee50e71c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/02/24 12:47 upstream d2980d8d8265 ee50e71c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/02/23 05:43 upstream 307e14c03906 9f1e2cb3 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/02/22 21:41 upstream 5b7c4cabbb65 9f1e2cb3 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/02/22 11:01 upstream 5b7c4cabbb65 42a4d508 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/02/21 08:39 upstream 89f5349e0673 f949448d .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci-upstream-kasan-gce-smack-root 2023/02/21 03:08 upstream 91bc559d8d3a 4f5f5209 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/02/20 22:06 upstream 91bc559d8d3a 2414209c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/02/20 18:45 upstream c9c3395d5e3d 2414209c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/02/20 16:09 upstream c9c3395d5e3d bcdf85f8 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/02/20 03:50 upstream c9c3395d5e3d bcdf85f8 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/02/20 03:02 upstream c9c3395d5e3d bcdf85f8 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/02/20 01:30 upstream 925cf0457d7e bcdf85f8 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/02/19 20:47 upstream 925cf0457d7e bcdf85f8 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci2-upstream-fs 2023/02/19 01:05 upstream 5e725d112e1a bcdf85f8 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci-qemu-upstream-386 2023/03/19 00:47 upstream 534293368afa 7939252e .config console log report info possible deadlock in attr_data_get_block
ci-qemu-upstream-386 2023/02/27 08:14 upstream f3a2439f20d9 630c6bc9 .config console log report info possible deadlock in attr_data_get_block
ci-upstream-linux-next-kasan-gce-root 2022/12/18 09:36 linux-next ca39c4daa6f7 05494336 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci-upstream-gce-arm64 2023/03/22 23:37 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci fe15c26ee26e f94b4a29 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci-upstream-gce-arm64 2023/03/16 16:27 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci fe15c26ee26e 18b58603 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci-upstream-gce-arm64 2023/03/08 14:07 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci fe15c26ee26e d2b00170 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci-upstream-gce-arm64 2023/03/07 13:17 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci fe15c26ee26e ffaa5c55 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci-upstream-gce-arm64 2023/02/20 20:28 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci a9b06ec42c0f 4f5f5209 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci-upstream-gce-arm64 2023/02/20 15:03 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 2d3827b3f393 4f5f5209 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in attr_data_get_block
ci-upstream-gce-arm64 2022/10/17 06:53 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci bbed346d5a96 67cb024c .config console log report info [disk image] [vmlinux] possible deadlock in attr_data_get_block
* Struck through repros no longer work on HEAD.