syzbot

F2FS-fs (loop4): Try to recover 1th superblock, ret: 0
F2FS-fs (loop4): Mounted with checkpoint version = 753bd00b
======================================================
WARNING: possible circular locking dependency detected
6.2.0-syzkaller-12485-gf3a2439f20d9 #0 Not tainted
------------------------------------------------------
syz-executor.4/24448 is trying to acquire lock:
ffff888063d12698 (&mm->mmap_lock){++++}-{3:3}, at: __might_fault+0xa9/0x180 mm/memory.c:5624

but task is already holding lock:
ffff888036af8088 (&sbi->sb_lock){++++}-{3:3}, at: f2fs_down_write fs/f2fs/f2fs.h:2213 [inline]
ffff888036af8088 (&sbi->sb_lock){++++}-{3:3}, at: f2fs_ioc_get_encryption_pwsalt fs/f2fs/file.c:2350 [inline]
ffff888036af8088 (&sbi->sb_lock){++++}-{3:3}, at: __f2fs_ioctl+0x3864/0xa910 fs/f2fs/file.c:4169

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #5 (&sbi->sb_lock){++++}-{3:3}:
       down_write+0x92/0x200 kernel/locking/rwsem.c:1573
       f2fs_down_write fs/f2fs/f2fs.h:2213 [inline]
       f2fs_handle_error+0x8e/0x220 fs/f2fs/super.c:3920
       f2fs_check_nid_range.part.0+0x4d/0x60 fs/f2fs/node.c:39
       f2fs_check_nid_range fs/f2fs/node.c:2282 [inline]
       add_free_nid.isra.0+0x781/0x940 fs/f2fs/node.c:2289
       scan_nat_page fs/f2fs/node.c:2391 [inline]
       __f2fs_build_free_nids+0x5b5/0xe10 fs/f2fs/node.c:2497
       f2fs_build_free_nids fs/f2fs/node.c:2535 [inline]
       f2fs_build_node_manager+0x2072/0x3000 fs/f2fs/node.c:3320
       f2fs_fill_super+0x39ad/0x8b90 fs/f2fs/super.c:4328
       mount_bdev+0x351/0x410 fs/super.c:1371
       legacy_get_tree+0x109/0x220 fs/fs_context.c:610
       vfs_get_tree+0x8d/0x350 fs/super.c:1501
       do_new_mount fs/namespace.c:3042 [inline]
       path_mount+0x1342/0x1e40 fs/namespace.c:3372
       do_mount fs/namespace.c:3385 [inline]
       __do_sys_mount fs/namespace.c:3594 [inline]
       __se_sys_mount fs/namespace.c:3571 [inline]
       __x64_sys_mount+0x283/0x300 fs/namespace.c:3571
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #4 (&nm_i->nat_tree_lock){++++}-{3:3}:
       down_read+0x3d/0x50 kernel/locking/rwsem.c:1520
       f2fs_down_read fs/f2fs/f2fs.h:2188 [inline]
       f2fs_get_node_info+0x1ac/0x1070 fs/f2fs/node.c:564
       f2fs_do_write_data_page+0x7f5/0x1e50 fs/f2fs/data.c:2727
       f2fs_write_single_data_page+0x147e/0x19c0 fs/f2fs/data.c:2862
       f2fs_write_cache_pages+0xcf2/0x1f00 fs/f2fs/data.c:3145
       __f2fs_write_data_pages fs/f2fs/data.c:3296 [inline]
       f2fs_write_data_pages+0x4c7/0x1300 fs/f2fs/data.c:3323
       do_writepages+0x1a8/0x640 mm/page-writeback.c:2551
       filemap_fdatawrite_wbc mm/filemap.c:390 [inline]
       filemap_fdatawrite_wbc+0x147/0x1b0 mm/filemap.c:380
       __filemap_fdatawrite_range+0xb8/0xf0 mm/filemap.c:423
       file_write_and_wait_range+0xce/0x140 mm/filemap.c:781
       f2fs_do_sync_file+0x3a4/0x2a60 fs/f2fs/file.c:275
       f2fs_sync_file+0x13a/0x190 fs/f2fs/file.c:393
       vfs_fsync_range+0x13e/0x230 fs/sync.c:188
       generic_write_sync include/linux/fs.h:2452 [inline]
       f2fs_file_write_iter+0x185f/0x3270 fs/f2fs/file.c:4721
       call_write_iter include/linux/fs.h:1851 [inline]
       do_iter_readv_writev+0x20b/0x3b0 fs/read_write.c:735
       do_iter_write+0x182/0x700 fs/read_write.c:861
       vfs_iter_write+0x74/0xa0 fs/read_write.c:902
       iter_file_splice_write+0x743/0xc80 fs/splice.c:778
       do_splice_from fs/splice.c:856 [inline]
       direct_splice_actor+0x114/0x180 fs/splice.c:1023
       splice_direct_to_actor+0x335/0x8a0 fs/splice.c:978
       do_splice_direct+0x1ab/0x280 fs/splice.c:1066
       do_sendfile+0xb19/0x12c0 fs/read_write.c:1255
       __do_sys_sendfile64 fs/read_write.c:1323 [inline]
       __se_sys_sendfile64 fs/read_write.c:1309 [inline]
       __x64_sys_sendfile64+0x1d0/0x210 fs/read_write.c:1309
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #3 (&sbi->cp_rwsem){++++}-{3:3}:
       down_read+0x3d/0x50 kernel/locking/rwsem.c:1520
       f2fs_down_read fs/f2fs/f2fs.h:2188 [inline]
       f2fs_lock_op fs/f2fs/f2fs.h:2231 [inline]
       f2fs_zero_range fs/f2fs/file.c:1563 [inline]
       f2fs_fallocate+0x17b5/0x37a0 fs/f2fs/file.c:1839
       vfs_fallocate+0x48b/0xe40 fs/open.c:324
       ksys_fallocate fs/open.c:347 [inline]
       __do_sys_fallocate fs/open.c:355 [inline]
       __se_sys_fallocate fs/open.c:353 [inline]
       __x64_sys_fallocate+0xd3/0x140 fs/open.c:353
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #2 (mapping.invalidate_lock#12){++++}-{3:3}:
       down_read+0x3d/0x50 kernel/locking/rwsem.c:1520
       filemap_invalidate_lock_shared include/linux/fs.h:813 [inline]
       f2fs_vm_page_mkwrite+0x630/0x1cf0 fs/f2fs/file.c:104
       do_page_mkwrite+0x19b/0x680 mm/memory.c:2925
       wp_page_shared mm/memory.c:3274 [inline]
       do_wp_page+0x356/0x3520 mm/memory.c:3356
       handle_pte_fault mm/memory.c:4927 [inline]
       __handle_mm_fault+0x19a1/0x3e60 mm/memory.c:5051
       handle_mm_fault+0x2ba/0x9c0 mm/memory.c:5197
       do_user_addr_fault+0x475/0x1230 arch/x86/mm/fault.c:1407
       handle_page_fault arch/x86/mm/fault.c:1498 [inline]
       exc_page_fault+0x98/0x170 arch/x86/mm/fault.c:1554
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570
       copy_user_generic_string+0x30/0x50 arch/x86/lib/copy_user_64.S:132
       copy_user_generic arch/x86/include/asm/uaccess_64.h:37 [inline]
       raw_copy_to_user arch/x86/include/asm/uaccess_64.h:58 [inline]
       _copy_to_user lib/usercopy.c:41 [inline]
       _copy_to_user+0x127/0x150 lib/usercopy.c:34
       copy_to_user include/linux/uaccess.h:169 [inline]
       do_pipe2+0x128/0x1b0 fs/pipe.c:1012
       __do_sys_pipe2 fs/pipe.c:1028 [inline]
       __se_sys_pipe2 fs/pipe.c:1026 [inline]
       __x64_sys_pipe2+0x54/0x80 fs/pipe.c:1026
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #1 (sb_pagefaults#5){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1477 [inline]
       sb_start_pagefault include/linux/fs.h:1581 [inline]
       f2fs_vm_page_mkwrite+0x48a/0x1cf0 fs/f2fs/file.c:99
       do_page_mkwrite+0x19b/0x680 mm/memory.c:2925
       wp_page_shared mm/memory.c:3274 [inline]
       do_wp_page+0x356/0x3520 mm/memory.c:3356
       handle_pte_fault mm/memory.c:4927 [inline]
       __handle_mm_fault+0x19a1/0x3e60 mm/memory.c:5051
       handle_mm_fault+0x2ba/0x9c0 mm/memory.c:5197
       do_user_addr_fault+0x475/0x1230 arch/x86/mm/fault.c:1407
       handle_page_fault arch/x86/mm/fault.c:1498 [inline]
       exc_page_fault+0x98/0x170 arch/x86/mm/fault.c:1554
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570
       copy_user_generic_string+0x30/0x50 arch/x86/lib/copy_user_64.S:132
       copy_user_generic arch/x86/include/asm/uaccess_64.h:37 [inline]
       raw_copy_to_user arch/x86/include/asm/uaccess_64.h:58 [inline]
       _copy_to_user lib/usercopy.c:41 [inline]
       _copy_to_user+0x127/0x150 lib/usercopy.c:34
       copy_to_user include/linux/uaccess.h:169 [inline]
       do_pipe2+0x128/0x1b0 fs/pipe.c:1012
       __do_sys_pipe2 fs/pipe.c:1028 [inline]
       __se_sys_pipe2 fs/pipe.c:1026 [inline]
       __x64_sys_pipe2+0x54/0x80 fs/pipe.c:1026
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&mm->mmap_lock){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3098 [inline]
       check_prevs_add kernel/locking/lockdep.c:3217 [inline]
       validate_chain kernel/locking/lockdep.c:3832 [inline]
       __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056
       lock_acquire kernel/locking/lockdep.c:5669 [inline]
       lock_acquire+0x1e3/0x670 kernel/locking/lockdep.c:5634
       __might_fault mm/memory.c:5625 [inline]
       __might_fault+0x10c/0x180 mm/memory.c:5618
       _copy_to_user+0x29/0x150 lib/usercopy.c:36
       copy_to_user include/linux/uaccess.h:169 [inline]
       f2fs_ioc_get_encryption_pwsalt fs/f2fs/file.c:2365 [inline]
       __f2fs_ioctl+0x3994/0xa910 fs/f2fs/file.c:4169
       f2fs_ioctl+0x18e/0x220 fs/f2fs/file.c:4242
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:870 [inline]
       __se_sys_ioctl fs/ioctl.c:856 [inline]
       __x64_sys_ioctl+0x197/0x210 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

Chain exists of:
  &mm->mmap_lock --> &nm_i->nat_tree_lock --> &sbi->sb_lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&sbi->sb_lock);
                               lock(&nm_i->nat_tree_lock);
                               lock(&sbi->sb_lock);
  lock(&mm->mmap_lock);

 *** DEADLOCK ***

2 locks held by syz-executor.4/24448:
 #0: ffff888039bf0460 (sb_writers#19){.+.+}-{0:0}, at: f2fs_ioc_get_encryption_pwsalt fs/f2fs/file.c:2346 [inline]
 #0: ffff888039bf0460 (sb_writers#19){.+.+}-{0:0}, at: __f2fs_ioctl+0x36a2/0xa910 fs/f2fs/file.c:4169
 #1: ffff888036af8088 (&sbi->sb_lock){++++}-{3:3}, at: f2fs_down_write fs/f2fs/f2fs.h:2213 [inline]
 #1: ffff888036af8088 (&sbi->sb_lock){++++}-{3:3}, at: f2fs_ioc_get_encryption_pwsalt fs/f2fs/file.c:2350 [inline]
 #1: ffff888036af8088 (&sbi->sb_lock){++++}-{3:3}, at: __f2fs_ioctl+0x3864/0xa910 fs/f2fs/file.c:4169

stack backtrace:
CPU: 1 PID: 24448 Comm: syz-executor.4 Not tainted 6.2.0-syzkaller-12485-gf3a2439f20d9 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/16/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106
 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2178
 check_prev_add kernel/locking/lockdep.c:3098 [inline]
 check_prevs_add kernel/locking/lockdep.c:3217 [inline]
 validate_chain kernel/locking/lockdep.c:3832 [inline]
 __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056
 lock_acquire kernel/locking/lockdep.c:5669 [inline]
 lock_acquire+0x1e3/0x670 kernel/locking/lockdep.c:5634
 __might_fault mm/memory.c:5625 [inline]
 __might_fault+0x10c/0x180 mm/memory.c:5618
 _copy_to_user+0x29/0x150 lib/usercopy.c:36
 copy_to_user include/linux/uaccess.h:169 [inline]
 f2fs_ioc_get_encryption_pwsalt fs/f2fs/file.c:2365 [inline]
 __f2fs_ioctl+0x3994/0xa910 fs/f2fs/file.c:4169
 f2fs_ioctl+0x18e/0x220 fs/f2fs/file.c:4242
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:870 [inline]
 __se_sys_ioctl fs/ioctl.c:856 [inline]
 __x64_sys_ioctl+0x197/0x210 fs/ioctl.c:856
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f32f3e8c0f9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f32f4ca4168 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f32f3fabf80 RCX: 00007f32f3e8c0f9
RDX: 0000000000000000 RSI: 0000000040106614 RDI: 0000000000000004
RBP: 00007f32f3ee7ae9 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffee64da7df R14: 00007f32f4ca4300 R15: 0000000000022000
 </TASK>