memory leak in cinergyt2_fe

memory leak in cinergyt2_fe_attach
Status: upstream: reported C repro on 2020/11/12 15:07
Reported-by: syzbot+e1de8986786b3722050e@syzkaller.appspotmail.com
Fix commit: 9ad1efee086e media: dvd_usb: memory leak in cinergyt2_fe_attach
Patched on: [ci-qemu-upstream ci-qemu-upstream-386 ci-qemu2-arm64 ci-qemu2-arm64-compat ci-qemu2-arm64-mte ci-qemu2-riscv64 ci-upstream-bpf-kasan-gce ci-upstream-bpf-next-kasan-gce ci-upstream-gce-leak ci-upstream-kasan-gce ci-upstream-kasan-gce-386 ci-upstream-kasan-gce-root ci-upstream-kasan-gce-selinux-root ci-upstream-kasan-gce-smack-root ci-upstream-linux-next-kasan-gce-root ci-upstream-net-kasan-gce ci-upstream-net-this-kasan-gce ci2-upstream-kcsan-gce ci2-upstream-usb], missing on: [ci-qemu2-arm32 ci-upstream-kmsan-gce ci-upstream-kmsan-gce-386]
First crash: 310d, last: 252d

Patch testing requests:
Created	Duration	User	Repo	Result
2021/05/25 07:21	15m	mudongliangabcd@gmail.com	https://github.com/mudongliang/linux d27178eb8e70288894798368592dddef897699f5	OK
2021/05/25 03:22	15m	mudongliangabcd@gmail.com	https://github.com/mudongliang/linux f87e7d2d23ad18728998fb4eda37f4b2c29f6b08	OK
2021/05/21 11:43	7m	mudongliangabcd@gmail.com	upstream	report log
2021/04/26 10:48	14m	atulgopinathan@gmail.com	linux-next	error

Sample crash report:

BUG: memory leak
unreferenced object 0xffff88810f184800 (size 2048):
  comm "kworker/0:2", pid 3811, jiffies 4294945642 (age 13.860s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 54 65 72 72 61 54 65 63  ........TerraTec
    2f 71 61 6e 75 20 55 53 42 32 2e 30 20 48 69 67  /qanu USB2.0 Hig
  backtrace:
    [<0000000056e17b1a>] kmalloc include/linux/slab.h:552 [inline]
    [<0000000056e17b1a>] kzalloc include/linux/slab.h:682 [inline]
    [<0000000056e17b1a>] cinergyt2_fe_attach+0x21/0x80 drivers/media/usb/dvb-usb/cinergyT2-fe.c:271
    [<00000000ae0b1711>] cinergyt2_frontend_attach+0x21/0x70 drivers/media/usb/dvb-usb/cinergyT2-core.c:74
    [<00000000d0254861>] dvb_usb_adapter_frontend_init+0x11b/0x1b0 drivers/media/usb/dvb-usb/dvb-usb-dvb.c:290
    [<0000000002e08ac6>] dvb_usb_adapter_init drivers/media/usb/dvb-usb/dvb-usb-init.c:84 [inline]
    [<0000000002e08ac6>] dvb_usb_init drivers/media/usb/dvb-usb/dvb-usb-init.c:173 [inline]
    [<0000000002e08ac6>] dvb_usb_device_init.cold+0x4d0/0x6ae drivers/media/usb/dvb-usb/dvb-usb-init.c:287
    [<000000003a673d9c>] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
    [<000000002a3d712f>] really_probe+0x159/0x480 drivers/base/dd.c:561
    [<0000000014edc57e>] driver_probe_device+0x84/0x100 drivers/base/dd.c:745
    [<00000000dda5ad89>] __device_attach_driver+0xee/0x110 drivers/base/dd.c:851
    [<0000000038f40b77>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:431
    [<00000000c9a57cac>] __device_attach+0x122/0x250 drivers/base/dd.c:919
    [<00000000f58313ac>] bus_probe_device+0xc6/0xe0 drivers/base/bus.c:491
    [<00000000b587a381>] device_add+0x5be/0xc30 drivers/base/core.c:3091
    [<00000000a4546dd3>] usb_set_configuration+0x9d9/0xb90 drivers/usb/core/message.c:2164
    [<000000003e9c4979>] usb_generic_driver_probe+0x8c/0xc0 drivers/usb/core/generic.c:238
    [<00000000204a1209>] usb_probe_device+0x5c/0x140 drivers/usb/core/driver.c:293
    [<000000002a3d712f>] really_probe+0x159/0x480 drivers/base/dd.c:561

Crashes (3):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro
ci-upstream-gce-leak	2021/01/09 06:46	upstream	6279d812eab6	c104d4a3	.config	log	report	syz	C
ci-upstream-gce-leak	2021/01/08 06:13	upstream	f5e6c330254a	c104d4a3	.config	log	report	syz	C
ci-upstream-gce-leak	2020/11/12 13:24	upstream	3d5e28bff7ad	77a55c8e	.config	log	report	syz	C