syzbot


possible deadlock in gup_fast_fallback

Status: upstream: reported C repro on 2024/04/21 03:14
Subsystems: ntfs3 mm
[Documentation on labels]
Reported-by: syzbot+63ba90b81c16b86379bd@syzkaller.appspotmail.com
First crash: 390d, last: 1d10h
Cause bisection: introduced by (bisect log) :
commit 69505fe98f198ee813898cbcaf6770949636430b
Author: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Date: Thu May 30 07:54:07 2024 +0000

  fs/ntfs3: Replace inode_trylock with inode_lock

Crash: possible deadlock in gup_fast_fallback (log)
Repro: C syz .config
  
Discussions (9)
Title Replies (including bot) Last reply
[syzbot] Monthly mm report (Apr 2025) 0 (1) 2025/04/09 07:11
[syzbot] Monthly mm report (Mar 2025) 0 (1) 2025/03/08 22:16
[syzbot] Monthly mm report (Feb 2025) 0 (1) 2025/02/05 12:44
[syzbot] Monthly mm report (Jan 2025) 0 (1) 2025/01/06 10:01
[syzbot] Monthly mm report (Dec 2024) 0 (1) 2024/12/05 09:04
[syzbot] Monthly mm report (Nov 2024) 1 (2) 2024/11/04 12:58
[syzbot] Monthly mm report (Oct 2024) 0 (1) 2024/10/03 09:02
[syzbot] Monthly mm report (Sep 2024) 0 (1) 2024/09/02 08:17
[syzbot] [mm?] possible deadlock in gup_fast_fallback 0 (3) 2024/07/25 01:01

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.15.0-rc3-syzkaller-00094-g02ddfb981de8 #0 Not tainted
------------------------------------------------------
syz-executor375/5814 is trying to acquire lock:
ffff888078d38be0 (&mm->mmap_lock){++++}-{4:4}, at: gup_fast_fallback+0x205/0x1d60 mm/gup.c:3401

but task is already holding lock:
ffff8880738b0398 (&sb->s_type->i_mutex_key#14){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline]
ffff8880738b0398 (&sb->s_type->i_mutex_key#14){+.+.}-{4:4}, at: __blockdev_direct_IO+0x318/0x3310 fs/direct-io.c:1140

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&sb->s_type->i_mutex_key#14){+.+.}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577
       inode_lock include/linux/fs.h:867 [inline]
       ntfs_file_mmap+0x525/0x730 fs/ntfs3/file.c:397
       call_mmap include/linux/fs.h:2243 [inline]
       mmap_file mm/internal.h:167 [inline]
       __mmap_new_file_vma mm/vma.c:2353 [inline]
       __mmap_new_vma mm/vma.c:2417 [inline]
       __mmap_region mm/vma.c:2519 [inline]
       mmap_region+0x103b/0x1e50 mm/vma.c:2597
       do_mmap+0xc68/0x1100 mm/mmap.c:561
       vm_mmap_pgoff+0x31b/0x4c0 mm/util.c:579
       ksys_mmap_pgoff+0x51f/0x760 mm/mmap.c:607
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&mm->mmap_lock){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3166 [inline]
       check_prevs_add kernel/locking/lockdep.c:3285 [inline]
       validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3909
       __lock_acquire+0xaac/0xd20 kernel/locking/lockdep.c:5235
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       gup_fast_fallback+0x21e/0x1d60 mm/gup.c:3401
       iov_iter_extract_user_pages lib/iov_iter.c:1849 [inline]
       iov_iter_extract_pages+0x35a/0x5e0 lib/iov_iter.c:1912
       dio_refill_pages fs/direct-io.c:172 [inline]
       dio_get_page fs/direct-io.c:213 [inline]
       do_direct_IO fs/direct-io.c:915 [inline]
       __blockdev_direct_IO+0x10ed/0x3310 fs/direct-io.c:1243
       blockdev_direct_IO include/linux/fs.h:3422 [inline]
       ntfs_direct_IO+0x195/0x3a0 fs/ntfs3/inode.c:809
       generic_file_read_iter+0x319/0x510 mm/filemap.c:2871
       new_sync_read fs/read_write.c:489 [inline]
       vfs_read+0x4cd/0x980 fs/read_write.c:570
       ksys_read+0x145/0x250 fs/read_write.c:713
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&sb->s_type->i_mutex_key#14);
                               lock(&mm->mmap_lock);
                               lock(&sb->s_type->i_mutex_key#14);
  rlock(&mm->mmap_lock);

 *** DEADLOCK ***

2 locks held by syz-executor375/5814:
 #0: ffff8880316349b8 (&f->f_pos_lock){+.+.}-{4:4}, at: fdget_pos+0x247/0x320 fs/file.c:1213
 #1: ffff8880738b0398 (&sb->s_type->i_mutex_key#14){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline]
 #1: ffff8880738b0398 (&sb->s_type->i_mutex_key#14){+.+.}-{4:4}, at: __blockdev_direct_IO+0x318/0x3310 fs/direct-io.c:1140

stack backtrace:
CPU: 0 UID: 0 PID: 5814 Comm: syz-executor375 Not tainted 6.15.0-rc3-syzkaller-00094-g02ddfb981de8 #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/19/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120
 print_circular_bug+0x2ee/0x310 kernel/locking/lockdep.c:2079
 check_noncircular+0x134/0x160 kernel/locking/lockdep.c:2211
 check_prev_add kernel/locking/lockdep.c:3166 [inline]
 check_prevs_add kernel/locking/lockdep.c:3285 [inline]
 validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3909
 __lock_acquire+0xaac/0xd20 kernel/locking/lockdep.c:5235
 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
 gup_fast_fallback+0x21e/0x1d60 mm/gup.c:3401
 iov_iter_extract_user_pages lib/iov_iter.c:1849 [inline]
 iov_iter_extract_pages+0x35a/0x5e0 lib/iov_iter.c:1912
 dio_refill_pages fs/direct-io.c:172 [inline]
 dio_get_page fs/direct-io.c:213 [inline]
 do_direct_IO fs/direct-io.c:915 [inline]
 __blockdev_direct_IO+0x10ed/0x3310 fs/direct-io.c:1243
 blockdev_direct_IO include/linux/fs.h:3422 [inline]
 ntfs_direct_IO+0x195/0x3a0 fs/ntfs3/inode.c:809
 generic_file_read_iter+0x319/0x510 mm/filemap.c:2871
 new_sync_read fs/read_write.c:489 [inline]
 vfs_read+0x4cd/0x980 fs/read_write.c:570
 ksys_read+0x145/0x250 fs/read_write.c:713
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f76619e6b19
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fff69e0a378 EFLAGS: 00000246 ORIG_RAX: 0000000000000000
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f76619e6b19
RDX: 0000000000001000 RSI: 0000200000000400 RDI: 0000000000000004
RBP: 00007f7661a795f0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000004 R11: 0000000000000246 R12: 00007fff69e0a3b0
R13: 00007fff69e0a5d8 R14: 431bde82d7b634db R15: 00007f7661a2f03b
 </TASK>

Crashes (1997):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2025/04/25 23:44 upstream 02ddfb981de8 c6b4fb39 .config strace log report syz / log C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-upstream-fs possible deadlock in gup_fast_fallback
2024/12/01 01:30 upstream 2ba9f676d0a2 68914665 .config strace log report syz / log C [disk image] [vmlinux] [kernel image] [mounted in repro #1] [mounted in repro #2] ci2-upstream-fs possible deadlock in gup_fast_fallback
2024/07/24 14:09 upstream 786c8248dbd3 57b2edb1 .config strace log report syz / log C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/03/18 20:19 upstream 76b6905c11fd 22a6c2b1 .config console log report syz / log C [disk image (non-bootable)] [vmlinux] [kernel image] [mounted in repro] ci-snapshot-upstream-root possible deadlock in gup_fast_fallback
2025/05/10 18:04 upstream bec6f00f120e 77908e5f .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/10 13:25 upstream 0e1329d4045c 77908e5f .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/10 04:57 upstream 0e1329d4045c 77908e5f .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/10 00:50 upstream 9c69f8884904 77908e5f .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/09 22:28 upstream 9c69f8884904 77908e5f .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/08 23:09 upstream 2c89c1b655c0 dbf35fa1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/08 11:59 upstream d76bb1ebb558 dbf35fa1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/07 15:48 upstream 707df3375124 350f4ffc .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/07 10:38 upstream 0d8d44db295c 350f4ffc .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/07 07:50 upstream 0d8d44db295c 350f4ffc .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/07 05:08 upstream 0d8d44db295c 350f4ffc .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/06 23:36 upstream 0d8d44db295c 350f4ffc .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/06 14:59 upstream 01f95500a162 ae98e6b9 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/06 11:14 upstream 01f95500a162 ae98e6b9 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/06 05:05 upstream 01f95500a162 ae98e6b9 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/06 02:28 upstream 01f95500a162 ae98e6b9 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/05 16:19 upstream 92a09c47464d 6ca47dd8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/05 09:11 upstream 14c55b7bb0a8 b0714e37 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/05 05:05 upstream 14c55b7bb0a8 b0714e37 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/04 21:52 upstream e8ab83e34bdc b0714e37 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/04 13:00 upstream e8ab83e34bdc b0714e37 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/04 08:35 upstream 2a239ffbebb5 b0714e37 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/04 06:58 upstream 2a239ffbebb5 b0714e37 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/04 02:29 upstream 2a239ffbebb5 b0714e37 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/03 21:14 upstream 2a239ffbebb5 b0714e37 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/03 15:05 upstream 95d3481af6dc b0714e37 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/03 10:22 upstream 95d3481af6dc b0714e37 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/03 07:39 upstream 95d3481af6dc b0714e37 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/03 05:20 upstream 2bfcee565c3a b0714e37 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/03 03:58 upstream 2bfcee565c3a b0714e37 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/02 21:21 upstream 2bfcee565c3a b0714e37 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/02 14:54 upstream ebd297a2affa d7f099d1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/02 09:44 upstream ebd297a2affa d7f099d1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/02 06:44 upstream ebd297a2affa 51b137cd .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/01 23:42 upstream 4f79eaa2ceac 51b137cd .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/01 17:26 upstream 4f79eaa2ceac 51b137cd .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/01 13:21 upstream 4f79eaa2ceac 51b137cd .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/05/01 11:31 upstream 4f79eaa2ceac ce7952f4 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/04/30 11:40 upstream b6ea1680d0ac 85a5a23f .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in gup_fast_fallback
2025/04/28 17:25 upstream b4432656b36e c6b4fb39 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in gup_fast_fallback
2025/04/26 07:55 upstream f1a3944c860b c6b4fb39 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-badwrites-root possible deadlock in gup_fast_fallback
2025/05/08 14:08 upstream d76bb1ebb558 dbf35fa1 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in gup_fast_fallback
2025/05/07 19:56 upstream 707df3375124 dbf35fa1 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in gup_fast_fallback
2025/05/04 23:22 upstream e8ab83e34bdc b0714e37 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in gup_fast_fallback
2025/05/04 17:30 upstream e8ab83e34bdc b0714e37 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in gup_fast_fallback
2025/05/02 12:52 upstream ebd297a2affa d7f099d1 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in gup_fast_fallback
2025/01/16 14:13 upstream 619f0b6fad52 f9e07a6e .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream possible deadlock in gup_fast_fallback
2024/12/18 16:33 upstream aef25be35d23 1432fc84 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in gup_fast_fallback
2025/04/09 17:25 linux-next 46086739de22 988b336c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in gup_fast_fallback
2024/04/17 03:03 linux-next 66e4190e92ce 18f6e127 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in gup_fast_fallback
2025/05/04 00:59 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci e0f4c8dd9d2d b0714e37 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 possible deadlock in gup_fast_fallback
2025/05/01 06:51 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci e0f4c8dd9d2d ce7952f4 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 possible deadlock in gup_fast_fallback
2025/05/01 01:43 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci e0f4c8dd9d2d ce7952f4 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 possible deadlock in gup_fast_fallback
2025/04/30 22:05 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci e0f4c8dd9d2d ce7952f4 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 possible deadlock in gup_fast_fallback
* Struck through repros no longer work on HEAD.