WARNING in ati_remote_sendpacket/usb_submit_urb

Status: fixed on 2020/11/16 12:12
Subsystems: usb media
[Documentation on labels]
Reported-by: syzbot+998261c2ae5932458f6c@syzkaller.appspotmail.com
Fix commit: a8be80053ea7 media: ati_remote: sanity check for both endpoints
First crash: 2563d, last: 2252d
▶ ▼ Discussions (21)
Title Replies (including bot) Last reply
[PATCH 5.9 000/757] 5.9.2-rc1 review 766 (766) 2020/10/30 08:32
[PATCH 4.19 000/264] 4.19.153-rc1 review 275 (275) 2020/10/29 08:56
[PATCH 5.8 000/633] 5.8.17-rc1 review 638 (638) 2020/10/28 22:08
[PATCH 4.4 000/112] 4.4.241-rc1 review 115 (115) 2020/10/28 15:54
[PATCH 4.9 000/139] 4.9.241-rc1 review 141 (141) 2020/10/28 13:53
[PATCH 4.14 000/191] 4.14.203-rc1 review 194 (194) 2020/10/28 12:43
[PATCH 5.4 000/408] 5.4.73-rc1 review 410 (410) 2020/10/28 06:53
[PATCH AUTOSEL 5.9 001/111] md/bitmap: fix memory leak of temporary bitmap 126 (126) 2020/10/25 23:48
[PATCH AUTOSEL 4.4 01/33] media: firewire: fix memory leak 33 (33) 2020/10/18 19:27
[PATCH AUTOSEL 4.9 01/41] crypto: ccp - fix error handling 41 (41) 2020/10/18 19:26
[PATCH AUTOSEL 4.14 01/52] crypto: ccp - fix error handling 52 (52) 2020/10/18 19:25
[PATCH AUTOSEL 4.19 01/56] block: ratelimit handle_bad_sector() message 56 (56) 2020/10/18 19:24
[PATCH AUTOSEL 5.4 01/80] md/bitmap: fix memory leak of temporary bitmap 80 (80) 2020/10/18 19:22
[PATCH AUTOSEL 5.8 001/101] md/bitmap: fix memory leak of temporary bitmap 101 (101) 2020/10/18 19:20
[PATCH] ati_remote: sanity check for both endpoints 1 (1) 2020/09/16 13:50
Reminder: 45 active syzbot reports in usb subsystem 1 (1) 2019/11/19 04:27
Reminder: 67 active syzbot reports in usb subsystem 1 (1) 2019/10/04 03:38
Reminder: 52 active syzbot reports in usb subsystem 1 (1) 2019/08/22 03:28
Reminder: 35 open syzbot bugs in media subsystem 1 (1) 2019/07/24 01:39
Reminder: 67 open syzbot bugs in usb subsystem 1 (1) 2019/07/24 01:35
WARNING in ati_remote_sendpacket/usb_submit_urb 0 (1) 2019/07/23 12:48

Sample crash report:
usb 1-1: New USB device strings: Mfr=0, Product=64, SerialNumber=0
usb 1-1: Product: syz
usb 1-1: config 0 descriptor??
------------[ cut here ]------------
usb 1-1: BOGUS urb xfer, pipe 1 != type 3
WARNING: CPU: 1 PID: 22 at drivers/usb/core/urb.c:477 usb_submit_urb+0x1188/0x13b0 drivers/usb/core/urb.c:477
Kernel panic - not syncing: panic_on_warn set ...
CPU: 1 PID: 22 Comm: kworker/1:1 Not tainted 5.4.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0xef/0x16e lib/dump_stack.c:118
 panic+0x2aa/0x6e1 kernel/panic.c:221
 __warn.cold+0x2f/0x30 kernel/panic.c:582
 report_bug+0x27b/0x2f0 lib/bug.c:195
 fixup_bug arch/x86/kernel/traps.c:174 [inline]
 fixup_bug arch/x86/kernel/traps.c:169 [inline]
 do_error_trap+0x12b/0x1e0 arch/x86/kernel/traps.c:267
 do_invalid_op+0x32/0x40 arch/x86/kernel/traps.c:286
 invalid_op+0x23/0x30 arch/x86/entry/entry_64.S:1027
RIP: 0010:usb_submit_urb+0x1188/0x13b0 drivers/usb/core/urb.c:477
Code: 4d 85 ed 74 2c e8 a8 84 e9 fd 4c 89 f7 e8 20 74 1d ff 41 89 d8 44 89 e1 4c 89 ea 48 89 c6 48 c7 c7 00 29 15 86 e8 10 b3 be fd <0f> 0b e9 20 f4 ff ff e8 7c 84 e9 fd 4c 89 f2 48 b8 00 00 00 00 00
RSP: 0018:ffff8881d902f0d8 EFLAGS: 00010286
RAX: 0000000000000000 RBX: 0000000000000003 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffffffff8128ebcd RDI: ffffed103b205e0d
RBP: ffff8881d5ecf050 R08: ffff8881da64e200 R09: fffffbfff11aeca6
R10: fffffbfff11aeca5 R11: ffffffff88d7652f R12: 0000000000000001
R13: ffff8881d660ab58 R14: ffff8881c650f0a0 R15: ffff8881d574f900
 ati_remote_sendpacket+0x1ee/0x540 drivers/media/rc/ati_remote.c:416
 ati_remote_initialize drivers/media/rc/ati_remote.c:797 [inline]
 ati_remote_probe+0x1254/0x1ffd drivers/media/rc/ati_remote.c:889
 usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361
 really_probe+0x281/0x6d0 drivers/base/dd.c:548
 driver_probe_device+0x104/0x210 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490
 device_add+0x1480/0x1c20 drivers/base/core.c:2487
 usb_set_configuration+0xe67/0x1740 drivers/usb/core/message.c:2023
 generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210
 usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266
 really_probe+0x281/0x6d0 drivers/base/dd.c:548
 driver_probe_device+0x104/0x210 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490
 device_add+0x1480/0x1c20 drivers/base/core.c:2487
 usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2537
 hub_port_connect drivers/usb/core/hub.c:5184 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5324 [inline]
 port_event drivers/usb/core/hub.c:5470 [inline]
 hub_event+0x1e59/0x3860 drivers/usb/core/hub.c:5552
 process_one_work+0x92b/0x1530 kernel/workqueue.c:2264
 worker_thread+0x96/0xe20 kernel/workqueue.c:2410
 kthread+0x318/0x420 kernel/kthread.c:255
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352
Kernel Offset: disabled
Rebooting in 86400 seconds..

Crashes (22):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/12/06 23:30 https://github.com/google/kasan.git usb-fuzzer 1f22d15c209f 85f26751 .config console log report syz C ci2-upstream-usb
2019/11/16 12:23 https://github.com/google/kasan.git usb-fuzzer 46178223c0ca cdac920b .config console log report syz C ci2-upstream-usb
2019/10/29 23:04 https://github.com/google/kasan.git usb-fuzzer ff6409a6ec35 5ea87a66 .config console log report syz C ci2-upstream-usb
2019/10/02 21:35 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 2e29b534 .config console log report syz C ci2-upstream-usb
2019/09/22 15:09 https://github.com/google/kasan.git usb-fuzzer e0bd8d794fc9 d96e88f3 .config console log report syz C ci2-upstream-usb
2019/07/23 07:31 https://github.com/google/kasan.git usb-fuzzer 6a3599ceaa39 bb071d58 .config console log report syz C ci2-upstream-usb
2020/05/29 11:07 https://github.com/google/kasan.git usb-fuzzer d19c64b3d097 d19ed305 .config console log report syz ci2-upstream-usb
2020/03/19 00:33 https://github.com/google/kasan.git usb-fuzzer d6ff8147a51c 2c31c529 .config console log report ci2-upstream-usb
2020/03/16 07:23 https://github.com/google/kasan.git usb-fuzzer d6ff8147a51c 749688d2 .config console log report ci2-upstream-usb
2020/03/14 18:28 https://github.com/google/kasan.git usb-fuzzer d6ff8147a51c 749688d2 .config console log report ci2-upstream-usb
2020/03/08 10:06 https://github.com/google/kasan.git usb-fuzzer d6ff8147a51c 2e9971bb .config console log report ci2-upstream-usb
2020/03/05 12:47 https://github.com/google/kasan.git usb-fuzzer d6ff8147a51c b655d91b .config console log report ci2-upstream-usb
2020/03/03 11:46 https://github.com/google/kasan.git usb-fuzzer d6ff8147a51c 350a7a26 .config console log report ci2-upstream-usb
2020/03/02 18:03 https://github.com/google/kasan.git usb-fuzzer d6ff8147a51c 4a4e0509 .config console log report ci2-upstream-usb
2020/03/01 20:15 https://github.com/google/kasan.git usb-fuzzer d6ff8147a51c c88c7b75 .config console log report ci2-upstream-usb
2020/02/28 01:10 https://github.com/google/kasan.git usb-fuzzer d6ff8147a51c c88c7b75 .config console log report ci2-upstream-usb
2019/11/25 03:38 https://github.com/google/kasan.git usb-fuzzer da06441bb485 598ca6c8 .config console log report ci2-upstream-usb
2019/11/23 21:44 https://github.com/google/kasan.git usb-fuzzer da06441bb485 598ca6c8 .config console log report ci2-upstream-usb
2019/10/15 15:50 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 b5268b89 .config console log report ci2-upstream-usb
2019/09/07 03:39 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 a60cb4cd .config console log report ci2-upstream-usb
2019/08/20 22:49 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 6b8391d0 .config console log report ci2-upstream-usb
2019/08/05 10:04 https://github.com/google/kasan.git usb-fuzzer e96407b49762 6affd8e8 .config console log report ci2-upstream-usb
* Struck through repros no longer work on HEAD.