WARNING in tty_set_ldisc

Status: fixed on 2018/05/08 18:30
Subsystems: serial
[Documentation on labels]
Reported-by: syzbot+1a77aeddeaf63317949b59c3df98f139a1ca34f9@syzkaller.appspotmail.com
Fix commit: 598c2d41ff44 tty: Avoid possible error pointer dereference at tty_ldisc_restore().
First crash: 3275d, last: 3018d

Sample crash report:
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
WARNING: CPU: 1 PID: 3165 at drivers/tty/tty_ldisc.c:531 tty_ldisc_restore drivers/tty/tty_ldisc.c:531 [inline]
WARNING: CPU: 1 PID: 3165 at drivers/tty/tty_ldisc.c:531 tty_set_ldisc+0x4c6/0x7a0 drivers/tty/tty_ldisc.c:599
Kernel panic - not syncing: panic_on_warn set ...

CPU: 1 PID: 3165 Comm: syz-executor0 Not tainted 4.15.0-rc5+ #149
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:17 [inline]
 dump_stack+0x194/0x257 lib/dump_stack.c:53
 panic+0x1e4/0x41c kernel/panic.c:183
 __warn+0x1dc/0x200 kernel/panic.c:547
 report_bug+0x211/0x2d0 lib/bug.c:184
 fixup_bug.part.11+0x37/0x80 arch/x86/kernel/traps.c:178
 fixup_bug arch/x86/kernel/traps.c:247 [inline]
 do_error_trap+0x2d7/0x3e0 arch/x86/kernel/traps.c:296
 do_invalid_op+0x1b/0x20 arch/x86/kernel/traps.c:315
 invalid_op+0x22/0x40 arch/x86/entry/entry_64.S:1061
RIP: 0010:tty_ldisc_restore drivers/tty/tty_ldisc.c:531 [inline]
RIP: 0010:tty_set_ldisc+0x4c6/0x7a0 drivers/tty/tty_ldisc.c:599
RSP: 0018:ffff8801c8497970 EFLAGS: 00010293
RAX: ffff8801d4410180 RBX: ffff8801c9f77400 RCX: ffffffff8287e946
RDX: 0000000000000000 RSI: 1ffff1003a882148 RDI: 0000000000000282
RBP: ffff8801c84979c0 R08: 1ffff10039092eee R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: 00000000ffffffff
R13: ffff8801c9f77970 R14: ffff8801c9ab5100 R15: fffffffffffffff4
 tiocsetd drivers/tty/tty_io.c:2319 [inline]
 tty_ioctl+0x492/0x1610 drivers/tty/tty_io.c:2563
 vfs_ioctl fs/ioctl.c:46 [inline]
 do_vfs_ioctl+0x1b1/0x1520 fs/ioctl.c:686
 C_SYSC_ioctl fs/compat_ioctl.c:1495 [inline]
 compat_SyS_ioctl+0x4ef/0x2a30 fs/compat_ioctl.c:1419
 do_syscall_32_irqs_on arch/x86/entry/common.c:327 [inline]
 do_fast_syscall_32+0x3ee/0xf9d arch/x86/entry/common.c:389
 entry_SYSENTER_compat+0x54/0x63 arch/x86/entry/entry_64_compat.S:125
RIP: 0023:0xf7f63c79
RSP: 002b:000000000844f86c EFLAGS: 00000216 ORIG_RAX: 0000000000000036
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 0000000000005423
RDX: 0000000020171ffc RSI: 0000000000000000 RDI: 0000000000000000
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
Dumping ftrace buffer:
   (ftrace buffer empty)
Kernel Offset: disabled
Rebooting in 86400 seconds..

Crashes (177):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2017/12/29 02:33 upstream 5f520fc31876 7d240098 .config console log report syz ci-upstream-kasan-gce-386
2017/12/23 21:16 upstream caf9a82657b3 73aba437 .config console log report syz ci-upstream-kasan-gce-386
2017/12/23 15:12 upstream 9c294ec08408 73aba437 .config console log report syz ci-upstream-kasan-gce-386
2017/12/22 21:19 upstream ead68f216110 8e409090 .config console log report syz ci-upstream-kasan-gce-386
2017/12/29 22:50 mmots 37759fa6d0fa bb6384b8 .config console log report syz ci-upstream-mmots-kasan-gce
2018/04/21 04:26 upstream 83beed7b2b26 ca03d688 .config console log report ci-upstream-kasan-gce
2018/04/20 07:01 upstream 87ef12027b9b eae05cb0 .config console log report ci-upstream-kasan-gce
2018/04/19 14:36 upstream 87ef12027b9b 3642839c .config console log report ci-upstream-kasan-gce-root
2018/04/16 01:37 upstream 71b8ebbf3d7b 7a67784c .config console log report ci-upstream-kasan-gce
2018/04/15 07:05 upstream 18b7fd1c93e5 7a67784c .config console log report ci-upstream-kasan-gce
2018/04/05 11:09 upstream 3e968c9f1401 5e1ccffc .config console log report ci-upstream-kasan-gce
2018/03/31 11:27 upstream b5dbc28762fd 8fbce0e4 .config console log report ci-upstream-kasan-gce-root
2018/03/30 07:10 upstream c2a9838452a4 d47f0ed6 .config console log report ci-upstream-kasan-gce
2018/03/29 12:53 upstream 0b412605ef5f d47f0ed6 .config console log report ci-upstream-kasan-gce
2018/03/27 15:33 upstream 3eb2ce825ea1 bf5e585c .config console log report ci-upstream-kasan-gce-root
2018/03/25 18:39 upstream bcfc1f455466 e033c1f1 .config console log report ci-upstream-kasan-gce-root
2018/03/15 03:47 upstream 3032f8c504d2 08dacaa0 .config console log report ci-upstream-kasan-gce
2018/03/11 13:53 upstream 3266b5bd97ea 36d1c454 .config console log report ci-upstream-kasan-gce
2018/03/06 03:10 upstream 094b58e1040a aef0b792 .config console log report ci-upstream-kasan-gce
2018/03/05 10:11 upstream 661e50bc8532 2c6f473e .config console log report ci-upstream-kasan-gce
2018/03/02 12:08 upstream 5d60e057d127 2c6f473e .config console log report ci-upstream-kasan-gce
2018/03/01 04:37 upstream c02be2334e75 05b5a32c .config console log report ci-upstream-kasan-gce
2018/02/28 20:51 upstream c02be2334e75 05b5a32c .config console log report ci-upstream-kasan-gce
2018/02/24 13:21 upstream 9cb9c07d6b0c 5c1e0207 .config console log report ci-upstream-kasan-gce
2018/02/18 22:16 upstream 0e06fb5b9ac8 833f78c7 .config console log report ci-upstream-kasan-gce
2018/02/11 00:00 upstream d48fcbd864a0 4e9b726d .config console log report ci-upstream-kasan-gce
2018/01/24 03:31 upstream 1f07476ec143 a5b7566c .config console log report ci-upstream-kasan-gce
2018/01/20 10:17 upstream 8dd903d2cf7b fbbdcd92 .config console log report ci-upstream-kasan-gce
2018/01/17 10:26 upstream 8cbab92dff77 a46e5318 .config console log report ci-upstream-kasan-gce
2018/04/06 16:44 upstream f2d285669aae 4f1152d4 .config console log report ci-upstream-kasan-gce-386
2018/04/01 08:43 upstream 10b84daddbec 0174c6c8 .config console log report ci-upstream-kasan-gce-386
2018/03/30 09:57 upstream c2a9838452a4 d47f0ed6 .config console log report ci-upstream-kasan-gce-386
2018/03/24 01:41 upstream 99fec39e7725 2e9d9054 .config console log report ci-upstream-kasan-gce-386
2018/03/21 12:43 upstream 3215b9d57a2c f63eeee9 .config console log report ci-upstream-kasan-gce-386
2018/03/20 21:30 upstream 1b5f3ba415fe 72c33b66 .config console log report ci-upstream-kasan-gce-386
2018/03/20 03:34 upstream 1b5f3ba415fe 7e7d7ed2 .config console log report ci-upstream-kasan-gce-386
2018/03/18 20:40 upstream 9e1909b9da04 08dacaa0 .config console log report ci-upstream-kasan-gce-386
2018/03/17 03:05 upstream 8f5fd927c3a7 08dacaa0 .config console log report ci-upstream-kasan-gce-386
2018/02/23 10:17 upstream 0f9da844d877 8d8e2494 .config console log report ci-upstream-kasan-gce-386
2018/02/20 16:40 upstream 79c0ef3e85c0 5abac192 .config console log report ci-upstream-kasan-gce-386
2018/02/08 20:02 upstream c0136321924d 9fb5ec43 .config console log report ci-upstream-kasan-gce-386
2018/02/06 13:10 upstream e237f98a9c13 a1bc9d40 .config console log report ci-upstream-kasan-gce-386
2018/02/01 04:23 upstream 255442c93843 02553e22 .config console log report ci-upstream-kasan-gce-386
2018/01/27 15:26 upstream c4e0ca7fa241 1d18b112 .config console log report ci-upstream-kasan-gce-386
2018/01/25 08:57 upstream 5b7d27967dab 6b2a715e .config console log report ci-upstream-kasan-gce-386
2018/01/18 22:38 upstream dda3e15231b3 161c1d64 .config console log report ci-upstream-kasan-gce-386
2018/01/16 13:55 upstream a8750ddca918 4198e588 .config console log report ci-upstream-kasan-gce-386
2018/04/29 23:13 https://github.com/google/kmsan.git master d2d741e5d189 bb79c6ab .config console log report ci-upstream-kmsan-gce
2018/04/28 07:46 https://github.com/google/kmsan.git master d2d741e5d189 d5a5d045 .config console log report ci-upstream-kmsan-gce
2018/04/27 01:47 https://github.com/google/kmsan.git master d2d741e5d189 73417389 .config console log report ci-upstream-kmsan-gce
2018/04/22 17:15 https://github.com/google/kmsan.git master d2d741e5d189 d23fcf6c .config console log report ci-upstream-kmsan-gce
2018/01/22 11:30 mmots 2734fabdcba4 aeb24072 .config console log report ci-upstream-mmots-kasan-gce
* Struck through repros no longer work on HEAD.