possible deadlock in __loop_clr

possible deadlock in __loop_clr_fd (2)
Status: upstream: reported C repro on 2021/07/08 01:27
Reported-by: syzbot+f61766d5763f9e7a118f@syzkaller.appspotmail.com
Fix commit: 1c500ad70638 loop: reduce the loop_ctl_mutex scope
Patched on: [ci-qemu2-arm64 ci-qemu2-arm64-compat ci-qemu2-arm64-mte ci-upstream-bpf-kasan-gce ci-upstream-gce-leak ci-upstream-kasan-gce ci-upstream-kasan-gce-386 ci-upstream-kasan-gce-root ci-upstream-kasan-gce-selinux-root ci-upstream-kasan-gce-smack-root ci-upstream-linux-next-kasan-gce-root ci-upstream-net-kasan-gce ci-upstream-net-this-kasan-gce ci2-upstream-kcsan-gce ci2-upstream-usb], missing on: [ci-qemu-upstream ci-qemu-upstream-386 ci-qemu2-arm32 ci-qemu2-riscv64 ci-upstream-bpf-next-kasan-gce ci-upstream-kmsan-gce ci-upstream-kmsan-gce-386]
First crash: 75d, last: 2h09m

Cause bisection: introduced by (bisect log) [no-op commit]:
commit 86f0a011e548774fd8eb952f67bfeb19f3174dd0
Author: Julian Wiedmann <jwi@linux.ibm.com>
Date: Tue Mar 16 09:45:12 2021 +0000

s390/dasd: remove dasd_fba_probe() wrapper

Crash: WARNING in kvm_wait (log)
Repro: C syz .config

similar bugs (1):
Kernel	Title	Repro	Cause bisect	Fix bisect	Count	Last	Reported	Patched	Status
upstream	possible deadlock in __loop_clr_fd				2	181d	178d	0/22	auto-closed as invalid on 2021/05/18 10:52

Patch testing requests:
Created	Duration	User	Patch	Repo	Result
2021/08/28 15:31	18m	penguin-kernel@i-love.sakura.ne.jp	patch	upstream	OK
2021/08/26 15:37	19m	penguin-kernel@i-love.sakura.ne.jp	patch	upstream	OK
2021/08/15 05:18	18m	penguin-kernel@i-love.sakura.ne.jp	patch	upstream	OK
2021/08/14 05:29	18m	penguin-kernel@i-love.sakura.ne.jp	patch	upstream	OK
2021/08/13 16:41	16m	penguin-kernel@i-love.sakura.ne.jp	patch	upstream	report log

Sample crash report:

loop0: detected capacity change from 0 to 4096
EXT4-fs error (device loop0): ext4_fill_super:4953: inode #2: comm syz-executor258: iget: root inode unallocated
EXT4-fs (loop0): get root inode failed
EXT4-fs (loop0): mount failed
======================================================
WARNING: possible circular locking dependency detected
5.14.0-rc3-next-20210729-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor258/6697 is trying to acquire lock:
ffff88807dbec138 ((wq_completion)loop0){+.+.}-{0:0}, at: flush_workqueue+0xe1/0x1600 kernel/workqueue.c:2784

but task is already holding lock:
ffff88801d535468 (&lo->lo_mutex){+.+.}-{3:3}, at: __loop_clr_fd+0xaf/0x15e0 drivers/block/loop.c:1350

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #6 (&lo->lo_mutex){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:957 [inline]
       __mutex_lock+0x131/0x1300 kernel/locking/mutex.c:1096
       loop_control_remove drivers/block/loop.c:2449 [inline]
       loop_control_ioctl+0x22f/0x450 drivers/block/loop.c:2494
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:866 [inline]
       __se_sys_ioctl fs/ioctl.c:852 [inline]
       __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:852
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x44/0xae

-> #5 (loop_ctl_mutex){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:957 [inline]
       __mutex_lock+0x131/0x1300 kernel/locking/mutex.c:1096
       loop_add+0x9c/0x940 drivers/block/loop.c:2314
       loop_probe+0x6a/0x80 drivers/block/loop.c:2426
       blk_request_module+0x111/0x1d0 block/genhd.c:673
       blkdev_get_no_open+0x178/0x1e0 fs/block_dev.c:1298
       blkdev_get_by_dev.part.0+0x23/0xd40 fs/block_dev.c:1362
       blkdev_get_by_dev fs/block_dev.c:1471 [inline]
       blkdev_open+0x295/0x300 fs/block_dev.c:1477
       do_dentry_open+0x4c8/0x11d0 fs/open.c:826
       do_open fs/namei.c:3374 [inline]
       path_openat+0x1c23/0x27f0 fs/namei.c:3507
       do_filp_open+0x1aa/0x400 fs/namei.c:3534
       do_sys_openat2+0x16d/0x420 fs/open.c:1204
       do_sys_open fs/open.c:1220 [inline]
       __do_sys_open fs/open.c:1228 [inline]
       __se_sys_open fs/open.c:1224 [inline]
       __x64_sys_open+0x119/0x1c0 fs/open.c:1224
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x44/0xae

-> #4 (major_names_lock){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:957 [inline]
       __mutex_lock+0x131/0x1300 kernel/locking/mutex.c:1096
       blkdev_show+0x27/0x160 block/genhd.c:197
       devinfo_show+0xc1/0xf0 fs/proc/devices.c:22
       seq_read_iter+0xbb0/0x1240 fs/seq_file.c:272
       proc_reg_read_iter+0x1fb/0x2d0 fs/proc/inode.c:300
       call_read_iter include/linux/fs.h:2146 [inline]
       new_sync_read+0x41e/0x6e0 fs/read_write.c:415
       vfs_read+0x35c/0x570 fs/read_write.c:496
       ksys_read+0x12d/0x250 fs/read_write.c:634
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x44/0xae

-> #3 (&p->lock){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:957 [inline]
       __mutex_lock+0x131/0x1300 kernel/locking/mutex.c:1096
       seq_read_iter+0xdf/0x1240 fs/seq_file.c:182
       call_read_iter include/linux/fs.h:2146 [inline]
       generic_file_splice_read+0x450/0x6c0 fs/splice.c:311
       do_splice_to+0x1bf/0x250 fs/splice.c:796
       splice_direct_to_actor+0x2c2/0x8c0 fs/splice.c:870
       do_splice_direct+0x1b3/0x280 fs/splice.c:979
       do_sendfile+0x9f0/0x1120 fs/read_write.c:1260
       __do_sys_sendfile64 fs/read_write.c:1325 [inline]
       __se_sys_sendfile64 fs/read_write.c:1311 [inline]
       __x64_sys_sendfile64+0x1cc/0x210 fs/read_write.c:1311
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x44/0xae

-> #2 (sb_writers#3){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1801 [inline]
       sb_start_write include/linux/fs.h:1871 [inline]
       file_start_write include/linux/fs.h:3080 [inline]
       lo_write_bvec+0x3b6/0x6d0 drivers/block/loop.c:327
       lo_write_simple drivers/block/loop.c:350 [inline]
       do_req_filebacked drivers/block/loop.c:668 [inline]
       loop_handle_cmd drivers/block/loop.c:2202 [inline]
       loop_process_work+0xc60/0x24e0 drivers/block/loop.c:2242
       process_one_work+0x98d/0x1630 kernel/workqueue.c:2276
       worker_thread+0x658/0x11f0 kernel/workqueue.c:2422
       kthread+0x3e5/0x4d0 kernel/kthread.c:319
       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295

-> #1 ((work_completion)(&lo->rootcg_work)){+.+.}-{0:0}:
       process_one_work+0x8fc/0x1630 kernel/workqueue.c:2252
       worker_thread+0x658/0x11f0 kernel/workqueue.c:2422
       kthread+0x3e5/0x4d0 kernel/kthread.c:319
       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295

-> #0 ((wq_completion)loop0){+.+.}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3051 [inline]
       check_prevs_add kernel/locking/lockdep.c:3174 [inline]
       validate_chain kernel/locking/lockdep.c:3789 [inline]
       __lock_acquire+0x2a07/0x54a0 kernel/locking/lockdep.c:5015
       lock_acquire kernel/locking/lockdep.c:5625 [inline]
       lock_acquire+0x1ab/0x510 kernel/locking/lockdep.c:5590
       flush_workqueue+0x110/0x1600 kernel/workqueue.c:2787
       drain_workqueue+0x1a5/0x3c0 kernel/workqueue.c:2952
       destroy_workqueue+0x71/0x800 kernel/workqueue.c:4389
       __loop_clr_fd+0x212/0x15e0 drivers/block/loop.c:1368
       loop_clr_fd drivers/block/loop.c:1494 [inline]
       lo_ioctl+0x3c3/0x1880 drivers/block/loop.c:1850
       blkdev_ioctl+0x2a1/0x6d0 block/ioctl.c:587
       block_ioctl+0xf9/0x140 fs/block_dev.c:1569
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:866 [inline]
       __se_sys_ioctl fs/ioctl.c:852 [inline]
       __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:852
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x44/0xae

other info that might help us debug this:

Chain exists of:
  (wq_completion)loop0 --> loop_ctl_mutex --> &lo->lo_mutex

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&lo->lo_mutex);
                               lock(loop_ctl_mutex);
                               lock(&lo->lo_mutex);
  lock((wq_completion)loop0);

 *** DEADLOCK ***

1 lock held by syz-executor258/6697:
 #0: ffff88801d535468 (&lo->lo_mutex){+.+.}-{3:3}, at: __loop_clr_fd+0xaf/0x15e0 drivers/block/loop.c:1350

stack backtrace:
CPU: 1 PID: 6697 Comm: syz-executor258 Not tainted 5.14.0-rc3-next-20210729-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:105
 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2131
 check_prev_add kernel/locking/lockdep.c:3051 [inline]
 check_prevs_add kernel/locking/lockdep.c:3174 [inline]
 validate_chain kernel/locking/lockdep.c:3789 [inline]
 __lock_acquire+0x2a07/0x54a0 kernel/locking/lockdep.c:5015
 lock_acquire kernel/locking/lockdep.c:5625 [inline]
 lock_acquire+0x1ab/0x510 kernel/locking/lockdep.c:5590
 flush_workqueue+0x110/0x1600 kernel/workqueue.c:2787
 drain_workqueue+0x1a5/0x3c0 kernel/workqueue.c:2952
 destroy_workqueue+0x71/0x800 kernel/workqueue.c:4389
 __loop_clr_fd+0x212/0x15e0 drivers/block/loop.c:1368
 loop_clr_fd drivers/block/loop.c:1494 [inline]
 lo_ioctl+0x3c3/0x1880 drivers/block/loop.c:1850
 blkdev_ioctl+0x2a1/0x6d0 block/ioctl.c:587
 block_ioctl+0xf9/0x140 fs/block_dev.c:1569
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:866 [inline]
 __se_sys_ioctl fs/ioctl.c:852 [inline]
 __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:852
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x444717
Code: 3c 1c 48 f7 d8 49 39 c4 72 b8 e8 44 3a 02 00 85 c0 78 bd 48 83 c4 08 4c 89 e0 5b 41 5c c3 0f 1f 44 00 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fffab8ca568 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00000000016232c0 RCX: 0000000000444717
RDX: 0000000000000000 RSI: 0000000000004c01 RDI: 0000000000000007
RBP: 0000000000000075 R08: 00007fffab8ca5c0 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00000000200002a8
R13: 0000000000000006 R14: 0000000000000007 R15: 0000000000000007

Crashes (3242):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	VM info	Title
ci-upstream-linux-next-kasan-gce-root	2021/07/30 08:27	linux-next	4ccc9e2db7ac	c585c7b0	.config	log	report	syz	C		possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce-smack-root	2021/09/17 05:46	upstream	bdb575f87217	5b989942	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce	2021/09/17 04:30	upstream	bdb575f87217	5b989942	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce	2021/09/17 03:16	upstream	bdb575f87217	5b989942	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce	2021/09/16 20:53	upstream	ff1ffd71d5f0	aae492f2	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce-root	2021/09/16 16:45	upstream	ff1ffd71d5f0	aae492f2	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce-root	2021/09/16 16:41	upstream	ff1ffd71d5f0	aae492f2	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce	2021/09/16 15:32	upstream	ff1ffd71d5f0	aae492f2	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce-smack-root	2021/09/16 03:28	upstream	b7213ffa0e58	07e953c1	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce-root	2021/09/16 03:27	upstream	b7213ffa0e58	07e953c1	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce	2021/09/16 02:20	upstream	b7213ffa0e58	07e953c1	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce	2021/09/15 22:44	upstream	3ca706c189db	07e953c1	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce-smack-root	2021/09/15 13:48	upstream	3ca706c189db	07e953c1	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce	2021/09/15 13:17	upstream	3ca706c189db	07e953c1	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce	2021/09/15 11:48	upstream	3ca706c189db	07e953c1	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce	2021/09/15 08:50	upstream	1619b69edce1	07e953c1	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce-smack-root	2021/09/14 20:29	upstream	1619b69edce1	07e953c1	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce	2021/09/14 19:28	upstream	1619b69edce1	07e953c1	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce-root	2021/09/14 18:25	upstream	1619b69edce1	07e953c1	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce-root	2021/09/14 16:42	upstream	d0ee23f9d78b	07e953c1	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce	2021/09/14 15:23	upstream	d0ee23f9d78b	07e953c1	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce-root	2021/09/14 02:24	upstream	d0ee23f9d78b	58d09404	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce	2021/09/14 01:39	upstream	d0ee23f9d78b	58d09404	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce	2021/09/14 00:29	upstream	d0ee23f9d78b	58d09404	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce	2021/09/13 20:56	upstream	6880fa6c5660	3ce60af8	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce	2021/09/13 12:52	upstream	6880fa6c5660	3ce60af8	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce	2021/09/13 11:40	upstream	6880fa6c5660	3ce60af8	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce-selinux-root	2021/09/13 10:45	upstream	6880fa6c5660	3ce60af8	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce-root	2021/09/13 02:52	upstream	f306b90c69ce	5ae8508a	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce-root	2021/09/13 00:31	upstream	f306b90c69ce	5ae8508a	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce-selinux-root	2021/09/12 23:19	upstream	f306b90c69ce	5ae8508a	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce-smack-root	2021/09/12 22:15	upstream	f306b90c69ce	5ae8508a	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce-smack-root	2021/09/12 21:37	upstream	f306b90c69ce	5ae8508a	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce-smack-root	2021/09/12 11:22	upstream	78e709522d2c	5ae8508a	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce	2021/09/12 09:51	upstream	78e709522d2c	5ae8508a	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce	2021/09/12 08:41	upstream	78e709522d2c	5ae8508a	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce-smack-root	2021/09/12 06:04	upstream	c605c39677b9	5ae8508a	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce	2021/09/11 21:00	upstream	c605c39677b9	5ae8508a	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce	2021/09/11 20:02	upstream	c605c39677b9	5ae8508a	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce-smack-root	2021/09/11 19:00	upstream	c605c39677b9	5ae8508a	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce-selinux-root	2021/09/11 13:45	upstream	926de8c4326c	5ae8508a	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce	2021/07/06 03:59	upstream	3dbdb38e2869	55aa55c2	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce	2021/07/04 01:17	upstream	3dbdb38e2869	55aa55c2	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce-386	2021/09/16 14:23	upstream	ff1ffd71d5f0	aae492f2	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce-386	2021/09/16 12:47	upstream	ff1ffd71d5f0	07e953c1	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce-386	2021/09/16 01:10	upstream	b7213ffa0e58	07e953c1	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce-386	2021/09/15 23:45	upstream	b7213ffa0e58	07e953c1	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-kasan-gce-386	2021/09/15 10:46	upstream	3ca706c189db	07e953c1	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-qemu-upstream-386	2021/08/06 04:31	upstream	902e7f373fff	2f537099	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-linux-next-kasan-gce-root	2021/09/16 08:19	linux-next	368847b165bb	07e953c1	.config	log	report			info	possible deadlock in __loop_clr_fd
ci-upstream-linux-next-kasan-gce-root	2021/09/13 06:13	linux-next	24a36d3171e4	5ae8508a	.config	log	report			info	possible deadlock in __loop_clr_fd