memory leak in hdcs_probe

memory leak in hdcs_probe_1x00
Status: upstream: reported C repro on 2021/02/26 14:47
Reported-by: syzbot+e7f4c64a4248a0340c37@syzkaller.appspotmail.com
Fix commit: media: gscpa/stv06xx: fix memory leak
Patched on: [ci-upstream-linux-next-kasan-gce-root], missing on: [ci-qemu-upstream ci-qemu-upstream-386 ci-qemu2-arm32 ci-qemu2-arm64 ci-qemu2-arm64-compat ci-qemu2-arm64-mte ci-qemu2-riscv64 ci-upstream-bpf-kasan-gce ci-upstream-bpf-next-kasan-gce ci-upstream-gce-leak ci-upstream-kasan-gce ci-upstream-kasan-gce-386 ci-upstream-kasan-gce-root ci-upstream-kasan-gce-selinux-root ci-upstream-kasan-gce-smack-root ci-upstream-kmsan-gce ci-upstream-kmsan-gce-386 ci-upstream-net-kasan-gce ci-upstream-net-this-kasan-gce ci2-upstream-kcsan-gce ci2-upstream-usb]
First crash: 55d, last: 55d

Patch testing requests:
Created	Duration	User	Patch	Repo	Result
2021/04/08 09:55	16m	hverkuil@xs4all.nl		git://linuxtv.org/hverkuil/media_tree.git tmp	OK
2021/04/08 08:00	0m	hverkuil@xs4all.nl	patch	git://linuxtv.org/media_tree.git master	error
2021/02/26 21:28	17m	paskripkin@gmail.com		https://linux.googlesource.com/linux/kernel/git/torvalds/linux refs/changes/77/8677/1	OK

Sample crash report:

BUG: memory leak
unreferenced object 0xffff8881100c0300 (size 64):
  comm "kworker/0:3", pid 3861, jiffies 4294943205 (age 14.560s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 08 00 00 00  ................
    08 00 00 00 68 01 00 00 28 01 00 00 04 00 00 00  ....h...(.......
  backtrace:
    [<000000004eb4188f>] kmalloc include/linux/slab.h:554 [inline]
    [<000000004eb4188f>] hdcs_probe_1x00 drivers/media/usb/gspca/stv06xx/stv06xx_hdcs.c:371 [inline]
    [<000000004eb4188f>] hdcs_probe_1x00.cold+0x39/0xc1 drivers/media/usb/gspca/stv06xx/stv06xx_hdcs.c:356
    [<0000000031bd6da6>] stv06xx_config+0xdf/0x190 drivers/media/usb/gspca/stv06xx/stv06xx.c:571
    [<000000007be62196>] gspca_dev_probe2+0x359/0x6c5 drivers/media/usb/gspca/gspca.c:1529
    [<00000000afeef2a3>] gspca_dev_probe.cold+0x42/0x4a drivers/media/usb/gspca/gspca.c:1606
    [<000000006d63a9d3>] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
    [<000000004f1fef67>] really_probe+0x159/0x4a0 drivers/base/dd.c:554
    [<00000000ced991e0>] driver_probe_device+0x84/0x100 drivers/base/dd.c:740
    [<000000001687c39d>] __device_attach_driver+0xee/0x110 drivers/base/dd.c:846
    [<0000000046da487b>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:431
    [<00000000df1d85bd>] __device_attach+0x122/0x250 drivers/base/dd.c:914
    [<00000000fa336975>] bus_probe_device+0xc6/0xe0 drivers/base/bus.c:491
    [<000000002214a827>] device_add+0x5d5/0xc40 drivers/base/core.c:3242
    [<00000000782f72d5>] usb_set_configuration+0x9d9/0xb90 drivers/usb/core/message.c:2164
    [<000000000815ea76>] usb_generic_driver_probe+0x8c/0xc0 drivers/usb/core/generic.c:238
    [<0000000028850013>] usb_probe_device+0x5c/0x140 drivers/usb/core/driver.c:293
    [<000000004f1fef67>] really_probe+0x159/0x4a0 drivers/base/dd.c:554

Crashes (1):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	VM info	Title
ci-upstream-gce-leak	2021/02/26 11:46	upstream	2c87f7a3	76f7fc95	.config	log	report	syz	C		memory leak in hdcs_probe_1x00