BUG: corrupted list in media_gobj

BUG: corrupted list in media_gobj_destroy
Status: upstream: reported on 2020/08/14 12:50
Reported-by: syzbot+4e886425af54bc69daea@syzkaller.appspotmail.com
First crash: 45d, last: 45d

Sample crash report:

usb 1-1: USB disconnect, device number 97
list_del corruption. next->prev should be ffff8881c93dc010, but was ffff8883c93dc012
------------[ cut here ]------------
kernel BUG at lib/list_debug.c:54!
invalid opcode: 0000 [#1] SMP KASAN
CPU: 1 PID: 3074 Comm: kworker/1:3 Not tainted 5.8.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
RIP: 0010:__list_del_entry_valid.cold+0x48/0x55 lib/list_debug.c:54
Code: e8 f1 71 3c ff 0f 0b 4c 89 e2 48 89 ee 48 c7 c7 20 85 1c 86 e8 dd 71 3c ff 0f 0b 48 89 ee 48 c7 c7 e0 85 1c 86 e8 cc 71 3c ff <0f> 0b cc cc cc cc cc cc cc cc cc cc cc 41 57 41 56 41 55 41 54 55
RSP: 0018:ffff8881d50b7498 EFLAGS: 00010286
RAX: 0000000000000054 RBX: ffff8881c93dc000 RCX: 0000000000000000
RDX: 0000000000040000 RSI: ffffffff8129ec93 RDI: ffffed103aa16e85
RBP: ffff8881c93dc010 R08: 0000000000000054 R09: ffff8881db32f54f
R10: 0000000000000000 R11: 000000000007e3b8 R12: ffff8881cdd8d108
R13: ffff8881c93dc090 R14: ffff8881c93dc000 R15: 0000000000000001
FS:  0000000000000000(0000) GS:ffff8881db300000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f3cf3d4a380 CR3: 00000001ab4d2000 CR4: 00000000001506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 __list_del_entry include/linux/list.h:132 [inline]
 list_del include/linux/list.h:146 [inline]
 media_gobj_destroy drivers/media/mc/mc-entity.c:187 [inline]
 media_gobj_destroy+0xa1/0x232 drivers/media/mc/mc-entity.c:176
 __media_device_unregister_entity+0x236/0x300 drivers/media/mc/mc-device.c:603
 media_device_unregister_entity+0x49/0x70 drivers/media/mc/mc-device.c:688
 dvb_media_device_free+0x1d5/0x620 drivers/media/dvb-core/dvbdev.c:226
 dvb_remove_device.part.0+0x8f/0x240 drivers/media/dvb-core/dvbdev.c:561
 dvb_remove_device drivers/media/dvb-core/dvbdev.c:554 [inline]
 dvb_unregister_device+0x1b/0x60 drivers/media/dvb-core/dvbdev.c:583
 dvb_dmxdev_release+0x1a0/0x640 drivers/media/dvb-core/dmxdev.c:1459
 dvb_usb_adapter_dvb_exit+0xa9/0x240 drivers/media/usb/dvb-usb/dvb-usb-dvb.c:224
 dvb_usb_adapter_exit drivers/media/usb/dvb-usb/dvb-usb-init.c:114 [inline]
 dvb_usb_exit.isra.0+0xaa/0x2a0 drivers/media/usb/dvb-usb/dvb-usb-init.c:129
 dvb_usb_device_exit+0x111/0x1a0 drivers/media/usb/dvb-usb/dvb-usb-init.c:306
 usb_unbind_interface+0x1d8/0x8d0 drivers/usb/core/driver.c:436
 __device_release_driver+0x3c6/0x6f0 drivers/base/dd.c:1153
 device_release_driver_internal drivers/base/dd.c:1184 [inline]
 device_release_driver+0x26/0x40 drivers/base/dd.c:1207
 bus_remove_device+0x2eb/0x5a0 drivers/base/bus.c:533
 device_del+0x481/0xd90 drivers/base/core.c:3107
 usb_disable_device+0x387/0x930 drivers/usb/core/message.c:1245
 usb_disconnect.cold+0x27d/0x780 drivers/usb/core/hub.c:2217
 hub_port_connect drivers/usb/core/hub.c:5059 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5348 [inline]
 port_event drivers/usb/core/hub.c:5494 [inline]
 hub_event+0x1c93/0x4390 drivers/usb/core/hub.c:5576
 process_one_work+0x94c/0x15f0 kernel/workqueue.c:2269
 worker_thread+0x64c/0x1120 kernel/workqueue.c:2415
 kthread+0x392/0x470 kernel/kthread.c:292
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294
Modules linked in:
---[ end trace 409eb60372a6c4c3 ]---
RIP: 0010:__list_del_entry_valid.cold+0x48/0x55 lib/list_debug.c:54
Code: e8 f1 71 3c ff 0f 0b 4c 89 e2 48 89 ee 48 c7 c7 20 85 1c 86 e8 dd 71 3c ff 0f 0b 48 89 ee 48 c7 c7 e0 85 1c 86 e8 cc 71 3c ff <0f> 0b cc cc cc cc cc cc cc cc cc cc cc 41 57 41 56 41 55 41 54 55
RSP: 0018:ffff8881d50b7498 EFLAGS: 00010286
RAX: 0000000000000054 RBX: ffff8881c93dc000 RCX: 0000000000000000
RDX: 0000000000040000 RSI: ffffffff8129ec93 RDI: ffffed103aa16e85
RBP: ffff8881c93dc010 R08: 0000000000000054 R09: ffff8881db32f54f
R10: 0000000000000000 R11: 000000000007e3b8 R12: ffff8881cdd8d108
R13: ffff8881c93dc090 R14: ffff8881c93dc000 R15: 0000000000000001
FS:  0000000000000000(0000) GS:ffff8881db300000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f3cf3d4a380 CR3: 00000001ab4d2000 CR4: 00000000001506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400

Crashes (1):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	VM info	Maintainers
ci2-upstream-usb	2020/08/14 05:59	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	449dc8c9	54ce1ed6	.config	log	report				laurent.pinchart@ideasonboard.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, mchehab@kernel.org, sakari.ailus@linux.intel.com