syzbot

JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
5.15.179-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor229/4164 is trying to acquire lock:
ffff888071e8ed88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
ffff888071e8ed88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x18e/0x4c70 fs/ocfs2/suballoc.c:782

but task is already holding lock:
ffff888071e95c78 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x62f/0x1930 fs/ocfs2/xattr.c:3587

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #5 (&oi->ip_xattr_sem){++++}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_init_acl+0x398/0x930 fs/ocfs2/acl.c:365
       ocfs2_mknod+0x1e8f/0x2cd0 fs/ocfs2/namei.c:410
       ocfs2_create+0x194/0x430 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3462 [inline]
       open_last_lookups fs/namei.c:3532 [inline]
       path_openat+0x130a/0x2f20 fs/namei.c:3739
       do_filp_open+0x21c/0x460 fs/namei.c:3769
       do_sys_openat2+0x13b/0x4f0 fs/open.c:1253
       do_sys_open fs/open.c:1269 [inline]
       __do_sys_creat fs/open.c:1345 [inline]
       __se_sys_creat fs/open.c:1339 [inline]
       __x64_sys_creat+0x11f/0x160 fs/open.c:1339
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #4 (jbd2_handle){.+.+}-{0:0}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       start_this_handle+0x12e1/0x1570 fs/jbd2/transaction.c:464
       jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:521
       jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:560
       ocfs2_start_trans+0x3c2/0x6f0 fs/ocfs2/journal.c:354
       ocfs2_modify_bh+0xe9/0x4c0 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x1587/0x19e0 fs/ocfs2/quota_local.c:768
       dquot_load_quota_sb+0x754/0xb90 fs/quota/dquot.c:2463
       dquot_load_quota_inode+0x318/0x600 fs/quota/dquot.c:2500
       ocfs2_enable_quotas+0x165/0x440 fs/ocfs2/super.c:927
       ocfs2_fill_super+0x4423/0x5890 fs/ocfs2/super.c:1140
       mount_bdev+0x2c9/0x3f0 fs/super.c:1400
       legacy_get_tree+0xeb/0x180 fs/fs_context.c:611
       vfs_get_tree+0x88/0x270 fs/super.c:1530
       do_new_mount+0x2ba/0xb40 fs/namespace.c:3012
       do_mount fs/namespace.c:3355 [inline]
       __do_sys_mount fs/namespace.c:3563 [inline]
       __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3540
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #3 (&journal->j_trans_barrier){.+.+}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_start_trans+0x3b7/0x6f0 fs/ocfs2/journal.c:352
       ocfs2_modify_bh+0xe9/0x4c0 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x1587/0x19e0 fs/ocfs2/quota_local.c:768
       dquot_load_quota_sb+0x754/0xb90 fs/quota/dquot.c:2463
       dquot_load_quota_inode+0x318/0x600 fs/quota/dquot.c:2500
       ocfs2_enable_quotas+0x165/0x440 fs/ocfs2/super.c:927
       ocfs2_fill_super+0x4423/0x5890 fs/ocfs2/super.c:1140
       mount_bdev+0x2c9/0x3f0 fs/super.c:1400
       legacy_get_tree+0xeb/0x180 fs/fs_context.c:611
       vfs_get_tree+0x88/0x270 fs/super.c:1530
       do_new_mount+0x2ba/0xb40 fs/namespace.c:3012
       do_mount fs/namespace.c:3355 [inline]
       __do_sys_mount fs/namespace.c:3563 [inline]
       __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3540
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #2 (sb_internal#2){.+.+}-{0:0}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1811 [inline]
       sb_start_intwrite include/linux/fs.h:1928 [inline]
       ocfs2_start_trans+0x2b2/0x6f0 fs/ocfs2/journal.c:350
       ocfs2_mknod+0x15bb/0x2cd0 fs/ocfs2/namei.c:361
       ocfs2_create+0x194/0x430 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3462 [inline]
       open_last_lookups fs/namei.c:3532 [inline]
       path_openat+0x130a/0x2f20 fs/namei.c:3739
       do_filp_open+0x21c/0x460 fs/namei.c:3769
       do_sys_openat2+0x13b/0x4f0 fs/open.c:1253
       do_sys_open fs/open.c:1269 [inline]
       __do_sys_creat fs/open.c:1345 [inline]
       __se_sys_creat fs/open.c:1339 [inline]
       __x64_sys_creat+0x11f/0x160 fs/open.c:1339
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:787 [inline]
       ocfs2_reserve_local_alloc_bits+0x12e/0x27a0 fs/ocfs2/localalloc.c:635
       ocfs2_reserve_clusters_with_limit+0x1b4/0xb50 fs/ocfs2/suballoc.c:1162
       ocfs2_mknod+0x1535/0x2cd0 fs/ocfs2/namei.c:354
       ocfs2_create+0x194/0x430 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3462 [inline]
       open_last_lookups fs/namei.c:3532 [inline]
       path_openat+0x130a/0x2f20 fs/namei.c:3739
       do_filp_open+0x21c/0x460 fs/namei.c:3769
       do_sys_openat2+0x13b/0x4f0 fs/open.c:1253
       do_sys_open fs/open.c:1269 [inline]
       __do_sys_creat fs/open.c:1345 [inline]
       __se_sys_creat fs/open.c:1339 [inline]
       __x64_sys_creat+0x11f/0x160 fs/open.c:1339
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
       __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:787 [inline]
       ocfs2_reserve_suballoc_bits+0x18e/0x4c70 fs/ocfs2/suballoc.c:782
       ocfs2_reserve_new_metadata_blocks+0x418/0x9b0 fs/ocfs2/suballoc.c:978
       ocfs2_init_xattr_set_ctxt+0x38f/0x8c0 fs/ocfs2/xattr.c:3281
       ocfs2_xattr_set+0xf46/0x1930 fs/ocfs2/xattr.c:3638
       __vfs_setxattr+0x3e7/0x420 fs/xattr.c:182
       __vfs_setxattr_noperm+0x12a/0x5e0 fs/xattr.c:216
       vfs_setxattr+0x21d/0x420 fs/xattr.c:303
       do_setxattr fs/xattr.c:588 [inline]
       setxattr+0x27e/0x2e0 fs/xattr.c:611
       path_setxattr+0x1bc/0x2a0 fs/xattr.c:630
       __do_sys_lsetxattr fs/xattr.c:653 [inline]
       __se_sys_lsetxattr fs/xattr.c:649 [inline]
       __x64_sys_lsetxattr+0xb4/0xd0 fs/xattr.c:649
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5 --> jbd2_handle --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(jbd2_handle);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5);

 *** DEADLOCK ***

3 locks held by syz-executor229/4164:
 #0: ffff88802ab3e460 (sb_writers#9){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377
 #1: ffff888071e95f48 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #1: ffff888071e95f48 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: vfs_setxattr+0x1dd/0x420 fs/xattr.c:302
 #2: ffff888071e95c78 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x62f/0x1930 fs/ocfs2/xattr.c:3587

stack backtrace:
CPU: 1 PID: 4164 Comm: syz-executor229 Not tainted 5.15.179-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
 down_write+0x38/0x60 kernel/locking/rwsem.c:1551
 inode_lock include/linux/fs.h:787 [inline]
 ocfs2_reserve_suballoc_bits+0x18e/0x4c70 fs/ocfs2/suballoc.c:782
 ocfs2_reserve_new_metadata_blocks+0x418/0x9b0 fs/ocfs2/suballoc.c:978
 ocfs2_init_xattr_set_ctxt+0x38f/0x8c0 fs/ocfs2/xattr.c:3281
 ocfs2_xattr_set+0xf46/0x1930 fs/ocfs2/xattr.c:3638
 __vfs_setxattr+0x3e7/0x420 fs/xattr.c:182
 __vfs_setxattr_noperm+0x12a/0x5e0 fs/xattr.c:216
 vfs_setxattr+0x21d/0x420 fs/xattr.c:303
 do_setxattr fs/xattr.c:588 [inline]
 setxattr+0x27e/0x2e0 fs/xattr.c:611
 path_setxattr+0x1bc/0x2a0 fs/xattr.c:630
 __do_sys_lsetxattr fs/xattr.c:653 [inline]
 __se_sys_lsetxattr fs/xattr.c:649 [inline]
 __x64_sys_lsetxattr+0xb4/0xd0 fs/xattr.c:649
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7fba7ff826b9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 61 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffdf2936d08 EFLAGS: 00000246 ORIG_RAX: 00000000000000bd
RAX: ffffffffffffffda RBX: 0030656c69662f2e RCX: 00007fba7ff826b9
RDX: 0000200000000100 RSI: 00002000000000c0 RDI: 0000200000000180
RBP: 00007fba7fffa610 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000001001 R11: 0000000000000246 R12: 0000000000000001
R13: 00007ffdf2936ed8 R14: 0000000000000001 R15: 00000000000000