syzbot


possible deadlock in do_page_mkwrite

Status: upstream: reported C repro on 2022/12/12 07:03
Subsystems: reiserfs (incorrect?)
Reported-by: syzbot+ff866d16791d4984b3c7@syzkaller.appspotmail.com
First crash: 105d, last: 23d

Cause bisection: failed (error log, bisect log)
Last patch testing requests:
Created Duration User Patch Repo Result
2022/12/23 11:27 28m hdanton@sina.com patch https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master report log

Sample crash report:
REISERFS (device loop0): Using r5 hash to sort names
REISERFS (device loop0): Created .reiserfs_priv - reserved for xattr storage.
======================================================
WARNING: possible circular locking dependency detected
6.2.0-rc6-syzkaller-00262-g95078069c1e7 #0 Not tainted
------------------------------------------------------
syz-executor150/5579 is trying to acquire lock:
ffff888022827090 (&sbi->lock){+.+.}-{3:3}, at: reiserfs_write_lock+0x79/0x100 fs/reiserfs/lock.c:27

but task is already holding lock:
ffff88802938c558 (sb_pagefaults){.+.+}-{0:0}, at: do_page_mkwrite+0x19b/0x680 mm/memory.c:2943

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (sb_pagefaults){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1814 [inline]
       sb_start_pagefault include/linux/fs.h:1918 [inline]
       filemap_page_mkwrite+0x16e/0x750 mm/filemap.c:3439
       do_page_mkwrite+0x19b/0x680 mm/memory.c:2943
       do_shared_fault mm/memory.c:4579 [inline]
       do_fault mm/memory.c:4647 [inline]
       handle_pte_fault mm/memory.c:4931 [inline]
       __handle_mm_fault+0x23ee/0x3c90 mm/memory.c:5073
       handle_mm_fault+0x1b6/0x850 mm/memory.c:5219
       do_user_addr_fault+0x475/0x1210 arch/x86/mm/fault.c:1428
       handle_page_fault arch/x86/mm/fault.c:1519 [inline]
       exc_page_fault+0x98/0x170 arch/x86/mm/fault.c:1575
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570

-> #1 (&mm->mmap_lock){++++}-{3:3}:
       __might_fault mm/memory.c:5647 [inline]
       __might_fault+0x10c/0x180 mm/memory.c:5640
       reiserfs_ioctl+0x1d2/0x330 fs/reiserfs/ioctl.c:96
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:870 [inline]
       __se_sys_ioctl fs/ioctl.c:856 [inline]
       __x64_sys_ioctl+0x197/0x210 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&sbi->lock){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3097 [inline]
       check_prevs_add kernel/locking/lockdep.c:3216 [inline]
       validate_chain kernel/locking/lockdep.c:3831 [inline]
       __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055
       lock_acquire kernel/locking/lockdep.c:5668 [inline]
       lock_acquire+0x1e3/0x630 kernel/locking/lockdep.c:5633
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x12f/0x1360 kernel/locking/mutex.c:747
       reiserfs_write_lock+0x79/0x100 fs/reiserfs/lock.c:27
       reiserfs_dirty_inode+0xd2/0x260 fs/reiserfs/super.c:704
       __mark_inode_dirty+0x247/0x11e0 fs/fs-writeback.c:2419
       generic_update_time+0x21b/0x2b0 fs/inode.c:1859
       inode_update_time fs/inode.c:1872 [inline]
       __file_update_time fs/inode.c:2057 [inline]
       file_update_time+0x224/0x270 fs/inode.c:2088
       filemap_page_mkwrite+0x280/0x750 mm/filemap.c:3440
       do_page_mkwrite+0x19b/0x680 mm/memory.c:2943
       do_shared_fault mm/memory.c:4579 [inline]
       do_fault mm/memory.c:4647 [inline]
       handle_pte_fault mm/memory.c:4931 [inline]
       __handle_mm_fault+0x23ee/0x3c90 mm/memory.c:5073
       handle_mm_fault+0x1b6/0x850 mm/memory.c:5219
       do_user_addr_fault+0x475/0x1210 arch/x86/mm/fault.c:1428
       handle_page_fault arch/x86/mm/fault.c:1519 [inline]
       exc_page_fault+0x98/0x170 arch/x86/mm/fault.c:1575
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570

other info that might help us debug this:

Chain exists of:
  &sbi->lock --> &mm->mmap_lock --> sb_pagefaults

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(sb_pagefaults);
                               lock(&mm->mmap_lock);
                               lock(sb_pagefaults);
  lock(&sbi->lock);

 *** DEADLOCK ***

2 locks held by syz-executor150/5579:
 #0: ffff88801d856198 (&mm->mmap_lock){++++}-{3:3}, at: mmap_read_trylock include/linux/mmap_lock.h:136 [inline]
 #0: ffff88801d856198 (&mm->mmap_lock){++++}-{3:3}, at: do_user_addr_fault+0x276/0x1210 arch/x86/mm/fault.c:1369
 #1: ffff88802938c558 (sb_pagefaults){.+.+}-{0:0}, at: do_page_mkwrite+0x19b/0x680 mm/memory.c:2943

stack backtrace:
CPU: 1 PID: 5579 Comm: syz-executor150 Not tainted 6.2.0-rc6-syzkaller-00262-g95078069c1e7 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/12/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xd1/0x138 lib/dump_stack.c:106
 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2177
 check_prev_add kernel/locking/lockdep.c:3097 [inline]
 check_prevs_add kernel/locking/lockdep.c:3216 [inline]
 validate_chain kernel/locking/lockdep.c:3831 [inline]
 __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055
 lock_acquire kernel/locking/lockdep.c:5668 [inline]
 lock_acquire+0x1e3/0x630 kernel/locking/lockdep.c:5633
 __mutex_lock_common kernel/locking/mutex.c:603 [inline]
 __mutex_lock+0x12f/0x1360 kernel/locking/mutex.c:747
 reiserfs_write_lock+0x79/0x100 fs/reiserfs/lock.c:27
 reiserfs_dirty_inode+0xd2/0x260 fs/reiserfs/super.c:704
 __mark_inode_dirty+0x247/0x11e0 fs/fs-writeback.c:2419
 generic_update_time+0x21b/0x2b0 fs/inode.c:1859
 inode_update_time fs/inode.c:1872 [inline]
 __file_update_time fs/inode.c:2057 [inline]
 file_update_time+0x224/0x270 fs/inode.c:2088
 filemap_page_mkwrite+0x280/0x750 mm/filemap.c:3440
 do_page_mkwrite+0x19b/0x680 mm/memory.c:2943
 do_shared_fault mm/memory.c:4579 [inline]
 do_fault mm/memory.c:4647 [inline]
 handle_pte_fault mm/memory.c:4931 [inline]
 __handle_mm_fault+0x23ee/0x3c90 mm/memory.c:5073
 handle_mm_fault+0x1b6/0x850 mm/memory.c:5219
 do_user_addr_fault+0x475/0x1210 arch/x86/mm/fault.c:1428
 handle_page_fault arch/x86/mm/fault.c:1519 [inline]
 exc_page_fault+0x98/0x170 arch/x86/mm/fault.c:1575
 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570
RIP: 0033:0x7ffacdfae573
Code: 00 e8 71 25 04 00 48 8b 35 ea 5b 0b 00 31 c9 31 c0 ba 01 76 08 80 bf 10 00 00 00 e8 57 25 04 00 b8 98 00 00 20 b9 20 00 00 00 <c7> 04 25 80 00 00 20 08 00 00 00 66 c7 04 25 84 00 00 20 20 01 48
RSP: 002b:00007ffc61aad4e0 EFLAGS: 00010286
RAX: 0000000020000098 RBX: 0000000000017cd9 RCX: 0000000000000020
RDX: 0000000000000000 RSI: 0000000080087601 RDI: 0000000000000004
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000005 R11: 0000000000000246 R12: 00007ffc61aad50c
R13: 00007ffc61aad540 R14: 00007ffc61aad520 R15: 00000000000000fd
 </TASK>

Crashes (24):
Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets Title
ci-upstream-kasan-gce-root 2023/02/05 15:14 upstream 95078069c1e7 be607b78 .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in do_page_mkwrite
ci2-upstream-fs 2023/01/17 10:19 upstream d532dd102151 a63719e7 .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in do_page_mkwrite
ci2-upstream-fs 2023/01/16 03:55 upstream 5dc4c995db9e a63719e7 .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in do_page_mkwrite
ci2-upstream-fs 2022/12/23 10:49 upstream 8395ae05cb5a 9da18ae8 .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in do_page_mkwrite
ci-upstream-linux-next-kasan-gce-root 2023/03/02 20:24 linux-next 26a4eaba02f7 f8902b57 .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in do_page_mkwrite
ci2-upstream-fs 2023/01/31 15:51 upstream 22b8077d0fce b68fb8d6 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in do_page_mkwrite
ci2-upstream-fs 2023/01/31 01:19 upstream 6d796c50f84c b68fb8d6 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in do_page_mkwrite
ci2-upstream-fs 2023/01/27 22:18 upstream 83abd4d4c4be 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in do_page_mkwrite
ci2-upstream-fs 2023/01/17 16:43 upstream 6e50979a9c87 42660d9e .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in do_page_mkwrite
ci2-upstream-fs 2023/01/16 02:44 upstream 5dc4c995db9e a63719e7 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in do_page_mkwrite
ci2-upstream-fs 2023/01/13 16:00 upstream d9fc1511728c 529798b0 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in do_page_mkwrite
ci2-upstream-fs 2023/01/09 04:16 upstream 1fe4fd6f5cad 1dac8c7a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in do_page_mkwrite
ci2-upstream-fs 2023/01/05 22:33 upstream 41c03ba9beea 1dac8c7a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in do_page_mkwrite
ci2-upstream-fs 2023/01/03 22:25 upstream 69b41ac87e4a f0036e18 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in do_page_mkwrite
ci2-upstream-fs 2023/01/03 21:33 upstream 69b41ac87e4a f0036e18 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in do_page_mkwrite
ci2-upstream-fs 2023/01/02 19:33 upstream 88603b6dc419 ab32d508 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in do_page_mkwrite
ci2-upstream-fs 2022/12/31 16:40 upstream c8451c141e07 ab32d508 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in do_page_mkwrite
ci2-upstream-fs 2022/12/27 13:33 upstream 1b929c02afd3 44712fbc .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in do_page_mkwrite
ci2-upstream-fs 2022/12/25 05:58 upstream 72a85e2b0a1e 9da18ae8 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in do_page_mkwrite
ci2-upstream-fs 2022/12/23 04:14 upstream 0a924817d2ed 9da18ae8 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in do_page_mkwrite
ci2-upstream-fs 2022/12/17 11:55 upstream 77856d911a8c 05494336 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in do_page_mkwrite
ci2-upstream-fs 2022/12/12 17:02 upstream 830b3c68c1fb 67be1ae7 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in do_page_mkwrite
ci2-upstream-fs 2022/12/11 03:07 upstream 296a7b7eb792 67be1ae7 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in do_page_mkwrite
ci2-upstream-fs 2022/12/10 21:39 upstream 3ecc37918c80 67be1ae7 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in do_page_mkwrite
* Struck through repros no longer work on HEAD.