general protection fault in sisusb_probe

Status: fixed on 2019/06/20 05:27
Subsystems: usb
[Documentation on labels]
Reported-by: syzbot+a0cbdbd6d169020c8959@syzkaller.appspotmail.com
Fix commit: 9a5729f68d3a USB: sisusbvga: fix oops in error path of sisusb_probe
First crash: 2633d, last: 2630d
▶ ▼ Discussions (9)
Title Replies (including bot) Last reply
[PATCH 3.16 000/132] 3.16.74-rc1 review 141 (141) 2019/11/19 20:40
[PATCH 4.9 00/83] 4.9.181-stable review 93 (93) 2019/07/31 15:14
[PATCH 4.4 000/241] 4.4.181-stable review 250 (250) 2019/06/11 18:35
[PATCH 5.1 00/85] 5.1.8-stable review 103 (103) 2019/06/11 08:50
[PATCH 4.14 00/69] 4.14.124-stable review 83 (83) 2019/06/09 07:14
[PATCH 4.19 00/73] 4.19.49-stable review 77 (77) 2019/06/08 18:49
general protection fault in sisusb_probe 0 (2) 2019/05/12 09:18
[PATCHv2] USB: sisusbvga: fix oops in error path of sisusb_probe 1 (1) 2019/05/09 12:41
[PATCH] USB: sisusbvga: fix oops in error path of sisusb_probe 1 (1) 2019/05/09 12:30

Sample crash report:
 process_one_work+0x90f/0x1580 kernel/workqueue.c:2269
 worker_thread+0x9b/0xe20 kernel/workqueue.c:2415
 kthread+0x313/0x420 kernel/kthread.c:253
 ret_from_fork+0x3a/0x50 arch/x86/entry/entry_64.S:352
kasan: CONFIG_KASAN_INLINE enabled
kasan: GPF could be caused by NULL-ptr deref or user memory access
general protection fault: 0000 [#1] SMP KASAN PTI
CPU: 1 PID: 17 Comm: kworker/1:0 Not tainted 5.1.0-rc3-319004-g43151d6 #6
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
RIP: 0010:dev_name include/linux/device.h:1087 [inline]
RIP: 0010:__dev_printk+0x3f/0x215 drivers/base/core.c:3208
Code: 89 f5 53 e8 8e 53 1c fc 48 85 ed 0f 84 c9 01 00 00 e8 80 53 1c fc 48 8d 7d 50 b8 ff ff 37 00 48 89 fa 48 c1 e0 2a 48 c1 ea 03 <80> 3c 02 00 74 05 e8 41 68 53 fc 4c 8b 7d 50 4d 85 ff 75 28 e8 53
RSP: 0018:ffff8880a84ff1c8 EFLAGS: 00010206
RAX: dffffc0000000000 RBX: ffffed101509fe40 RCX: ffffffff8980f1cb
RDX: 000000000000001e RSI: ffffffff855576f0 RDI: 00000000000000f0
RBP: 00000000000000a0 R08: ffff8880a84db100 R09: 0000000000000006
R10: ffff8880a84dba08 R11: ffff8880a84db100 R12: ffffffff8f031080
R13: ffff8880a84ff220 R14: ffff888090615500 R15: ffff88808c860000
FS:  0000000000000000(0000) GS:ffff8880ad100000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007faa07b90000 CR3: 00000000a0896000 CR4: 00000000001406e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 _dev_err+0xdc/0x10e drivers/base/core.c:3251
 sisusb_probe+0x1c8/0xbd6 drivers/usb/misc/sisusbvga/sisusb.c:3035
 usb_probe_interface+0x31d/0x820 drivers/usb/core/driver.c:361
 really_probe+0x2da/0xb10 drivers/base/dd.c:509
 driver_probe_device+0x21d/0x350 drivers/base/dd.c:671
 __device_attach_driver+0x1d8/0x290 drivers/base/dd.c:778
 bus_for_each_drv+0x163/0x1e0 drivers/base/bus.c:454
 __device_attach+0x223/0x3a0 drivers/base/dd.c:844
 bus_probe_device+0x1f1/0x2a0 drivers/base/bus.c:514
 device_add+0xad2/0x16e0 drivers/base/core.c:2106
 usb_set_configuration+0xdf7/0x1740 drivers/usb/core/message.c:2023
 generic_probe+0xa2/0xda drivers/usb/core/generic.c:210
 usb_probe_device+0xc0/0x150 drivers/usb/core/driver.c:266
 really_probe+0x2da/0xb10 drivers/base/dd.c:509
 driver_probe_device+0x21d/0x350 drivers/base/dd.c:671
 __device_attach_driver+0x1d8/0x290 drivers/base/dd.c:778
 bus_for_each_drv+0x163/0x1e0 drivers/base/bus.c:454
 __device_attach+0x223/0x3a0 drivers/base/dd.c:844
 bus_probe_device+0x1f1/0x2a0 drivers/base/bus.c:514
 device_add+0xad2/0x16e0 drivers/base/core.c:2106
 usb_new_device.cold+0x537/0xccf drivers/usb/core/hub.c:2534
 hub_port_connect drivers/usb/core/hub.c:5089 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5204 [inline]
 port_event drivers/usb/core/hub.c:5350 [inline]
 hub_event+0x138e/0x3b00 drivers/usb/core/hub.c:5432
 process_one_work+0x90f/0x1580 kernel/workqueue.c:2269
 worker_thread+0x9b/0xe20 kernel/workqueue.c:2415
 kthread+0x313/0x420 kernel/kthread.c:253
 ret_from_fork+0x3a/0x50 arch/x86/entry/entry_64.S:352
Modules linked in:
---[ end trace 3af8db6f82d76f53 ]---
RIP: 0010:dev_name include/linux/device.h:1087 [inline]
RIP: 0010:__dev_printk+0x3f/0x215 drivers/base/core.c:3208
Code: 89 f5 53 e8 8e 53 1c fc 48 85 ed 0f 84 c9 01 00 00 e8 80 53 1c fc 48 8d 7d 50 b8 ff ff 37 00 48 89 fa 48 c1 e0 2a 48 c1 ea 03 <80> 3c 02 00 74 05 e8 41 68 53 fc 4c 8b 7d 50 4d 85 ff 75 28 e8 53
RSP: 0018:ffff8880a84ff1c8 EFLAGS: 00010206
RAX: dffffc0000000000 RBX: ffffed101509fe40 RCX: ffffffff8980f1cb
RDX: 000000000000001e RSI: ffffffff855576f0 RDI: 00000000000000f0
RBP: 00000000000000a0 R08: ffff8880a84db100 R09: 0000000000000006
R10: ffff8880a84dba08 R11: ffff8880a84db100 R12: ffffffff8f031080
R13: ffff8880a84ff220 R14: ffff888090615500 R15: ffff88808c860000
FS:  0000000000000000(0000) GS:ffff8880ad100000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007faa07b90000 CR3: 00000000a0896000 CR4: 00000000001406e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400

Crashes (3):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/05/12 09:18 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce c017728b .config console log report syz C ci2-upstream-usb
2019/05/12 08:41 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce c017728b .config console log report ci2-upstream-usb
2019/05/09 03:30 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce 1ab4c999 .config console log report ci2-upstream-usb
* Struck through repros no longer work on HEAD.