memory leak in hdcs_probe

memory leak in hdcs_probe_1020
Status: upstream: reported C repro on 2021/03/31 19:18
Reported-by: syzbot+990626a4ef6f043ed4cd@syzkaller.appspotmail.com
Fix commit: media: gscpa/stv06xx: fix memory leak
Patched on: [], missing on: [ci-qemu-upstream ci-qemu-upstream-386 ci-qemu2-arm32 ci-qemu2-arm64 ci-qemu2-arm64-compat ci-qemu2-arm64-mte ci-qemu2-riscv64 ci-upstream-bpf-kasan-gce ci-upstream-bpf-next-kasan-gce ci-upstream-gce-leak ci-upstream-kasan-gce ci-upstream-kasan-gce-386 ci-upstream-kasan-gce-root ci-upstream-kasan-gce-selinux-root ci-upstream-kasan-gce-smack-root ci-upstream-kmsan-gce ci-upstream-kmsan-gce-386 ci-upstream-linux-next-kasan-gce-root ci-upstream-net-kasan-gce ci-upstream-net-this-kasan-gce ci2-upstream-kcsan-gce ci2-upstream-usb]
First crash: 26d, last: 26d

Patch testing requests:
Created	Duration	User	Patch	Repo	Result
2021/04/21 18:23	16m	atulgopinathan@gmail.com	patch	upstream	OK
2021/04/08 17:11	16m	atulgopinathan@gmail.com	patch	upstream	OK
2021/04/08 14:37	17m	atulgopinathan@gmail.com	patch	upstream	OK
2021/04/08 14:14	9m	atulgopinathan@gmail.com		upstream	report log

Sample crash report:

BUG: memory leak
unreferenced object 0xffff888110dd9f00 (size 64):
  comm "kworker/0:0", pid 5, jiffies 4294944081 (age 15.000s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 18 00 00 00  ................
    04 00 00 00 60 01 00 00 30 01 00 00 04 00 00 00  ....`...0.......
  backtrace:
    [<ffffffff8424c055>] kmalloc include/linux/slab.h:554 [inline]
    [<ffffffff8424c055>] hdcs_probe_1020 drivers/media/usb/gspca/stv06xx/stv06xx_hdcs.c:428 [inline]
    [<ffffffff8424c055>] hdcs_probe_1020.cold+0x39/0x96 drivers/media/usb/gspca/stv06xx/stv06xx_hdcs.c:413
    [<ffffffff82fe2db7>] stv06xx_config+0x107/0x190 drivers/media/usb/gspca/stv06xx/stv06xx.c:575
    [<ffffffff842427ca>] gspca_dev_probe2+0x359/0x6c5 drivers/media/usb/gspca/gspca.c:1529
    [<ffffffff84242b78>] gspca_dev_probe.cold+0x42/0x4a drivers/media/usb/gspca/gspca.c:1606
    [<ffffffff82ba7c87>] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
    [<ffffffff825f6079>] really_probe+0x159/0x4a0 drivers/base/dd.c:554
    [<ffffffff825f6444>] driver_probe_device+0x84/0x100 drivers/base/dd.c:740
    [<ffffffff825f6b5e>] __device_attach_driver+0xee/0x110 drivers/base/dd.c:846
    [<ffffffff825f2ff7>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:431
    [<ffffffff825f66f2>] __device_attach+0x122/0x250 drivers/base/dd.c:914
    [<ffffffff825f4c96>] bus_probe_device+0xc6/0xe0 drivers/base/bus.c:491
    [<ffffffff825f11e5>] device_add+0x5d5/0xc40 drivers/base/core.c:3242
    [<ffffffff82ba5229>] usb_set_configuration+0x9d9/0xb90 drivers/usb/core/message.c:2164
    [<ffffffff82bb568c>] usb_generic_driver_probe+0x8c/0xc0 drivers/usb/core/generic.c:238
    [<ffffffff82ba73ec>] usb_probe_device+0x5c/0x140 drivers/usb/core/driver.c:293
    [<ffffffff825f6079>] really_probe+0x159/0x4a0 drivers/base/dd.c:554

Crashes (1):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	VM info	Title
ci-upstream-gce-leak	2021/03/27 19:10	upstream	0f4498ce	a8529b82	.config	log	report	syz	C		memory leak in hdcs_probe_1020