syzbot

netdevsim netdevsim0 netdevsim1: set [1, 0] type 2 family 0 port 6081 - 0
netdevsim netdevsim0 netdevsim2: set [1, 0] type 2 family 0 port 6081 - 0
netdevsim netdevsim0 netdevsim3: set [1, 0] type 2 family 0 port 6081 - 0
========================================================
WARNING: possible irq lock inversion dependency detected
5.13.0-rc2-next-20210518-syzkaller #0 Not tainted
--------------------------------------------------------
syz-executor436/8433 just changed the state of lock:
ffff8880181130c0 (&new->fa_lock){.+..}-{2:2}, at: kill_fasync_rcu fs/fcntl.c:1012 [inline]
ffff8880181130c0 (&new->fa_lock){.+..}-{2:2}, at: kill_fasync fs/fcntl.c:1033 [inline]
ffff8880181130c0 (&new->fa_lock){.+..}-{2:2}, at: kill_fasync+0x132/0x460 fs/fcntl.c:1026
but this lock was taken by another, HARDIRQ-safe lock in the past:
 (&dev->event_lock){-...}-{2:2}


and interrupts could create inverse lock ordering between them.


other info that might help us debug this:
Chain exists of:
  &dev->event_lock --> &client->buffer_lock --> &new->fa_lock

 Possible interrupt unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&new->fa_lock);
                               local_irq_disable();
                               lock(&dev->event_lock);
                               lock(&client->buffer_lock);
  <Interrupt>
    lock(&dev->event_lock);

 *** DEADLOCK ***

3 locks held by syz-executor436/8433:
 #0: ffffffff8c17afe0 (rcu_read_lock){....}-{1:2}, at: sock_def_error_report+0x0/0x4e0 include/net/sock.h:2313
 #1: ffffffff8c17afe0 (rcu_read_lock){....}-{1:2}, at: rcu_read_unlock include/linux/rcupdate.h:716 [inline]
 #1: ffffffff8c17afe0 (rcu_read_lock){....}-{1:2}, at: sock_def_error_report+0x2af/0x4e0 net/core/sock.c:2900
 #2: ffffffff8c17afe0 (rcu_read_lock){....}-{1:2}, at: kill_fasync+0x3d/0x460 fs/fcntl.c:1031

the shortest dependencies between 2nd lock and 1st lock:
  -> (&dev->event_lock){-...}-{2:2} {
     IN-HARDIRQ-W at:
                        lock_acquire kernel/locking/lockdep.c:5512 [inline]
                        lock_acquire+0x1ab/0x740 kernel/locking/lockdep.c:5477
                        __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
                        _raw_spin_lock_irqsave+0x39/0x50 kernel/locking/spinlock.c:159
                        input_event drivers/input/input.c:445 [inline]
                        input_event+0x7b/0xb0 drivers/input/input.c:438
                        input_report_key include/linux/input.h:425 [inline]
                        psmouse_report_standard_buttons+0x2c/0x80 drivers/input/mouse/psmouse-base.c:123
                        psmouse_report_standard_packet drivers/input/mouse/psmouse-base.c:141 [inline]
                        psmouse_process_byte+0x1e1/0x890 drivers/input/mouse/psmouse-base.c:232
                        psmouse_handle_byte+0x41/0x1b0 drivers/input/mouse/psmouse-base.c:274
                        psmouse_interrupt+0x304/0xf00 drivers/input/mouse/psmouse-base.c:426
                        serio_interrupt+0x88/0x150 drivers/input/serio/serio.c:1002
                        i8042_interrupt+0x27a/0x520 drivers/input/serio/i8042.c:602
                        __handle_irq_event_percpu+0x303/0x8f0 kernel/irq/handle.c:156
                        handle_irq_event_percpu kernel/irq/handle.c:196 [inline]
                        handle_irq_event+0x102/0x290 kernel/irq/handle.c:213
                        handle_edge_irq+0x25f/0xd00 kernel/irq/chip.c:819
                        generic_handle_irq_desc include/linux/irqdesc.h:158 [inline]
                        handle_irq arch/x86/kernel/irq.c:231 [inline]
                        __common_interrupt+0x9d/0x210 arch/x86/kernel/irq.c:250
                        common_interrupt+0x9f/0xd0 arch/x86/kernel/irq.c:240
                        asm_common_interrupt+0x1e/0x40 arch/x86/include/asm/idtentry.h:638
                        __raw_spin_unlock_irqrestore include/linux/spinlock_api_smp.h:161 [inline]
                        _raw_spin_unlock_irqrestore+0x38/0x70 kernel/locking/spinlock.c:191
                        spin_unlock_irqrestore include/linux/spinlock.h:414 [inline]
                        i8042_command+0x12e/0x150 drivers/input/serio/i8042.c:352
                        i8042_aux_write+0xd7/0x120 drivers/input/serio/i8042.c:387
                        serio_write include/linux/serio.h:125 [inline]
                        ps2_do_sendbyte+0x2cf/0x710 drivers/input/serio/libps2.c:40
                        ps2_sendbyte+0x58/0x150 drivers/input/serio/libps2.c:92
                        cypress_ps2_sendbyte+0x2e/0x160 drivers/input/mouse/cypress_ps2.c:42
                        cypress_ps2_read_cmd_status drivers/input/mouse/cypress_ps2.c:116 [inline]
                        cypress_send_ext_cmd+0x1d0/0x8e0 drivers/input/mouse/cypress_ps2.c:189
                        cypress_detect+0x75/0x190 drivers/input/mouse/cypress_ps2.c:205
                        psmouse_do_detect drivers/input/mouse/psmouse-base.c:1009 [inline]
                        psmouse_try_protocol+0x211/0x370 drivers/input/mouse/psmouse-base.c:1023
                        psmouse_extensions+0x557/0x930 drivers/input/mouse/psmouse-base.c:1146
                        psmouse_switch_protocol+0x52a/0x740 drivers/input/mouse/psmouse-base.c:1542
                        psmouse_connect+0x5e9/0xfd0 drivers/input/mouse/psmouse-base.c:1632
                        serio_connect_driver drivers/input/serio/serio.c:47 [inline]
                        serio_driver_probe+0x72/0xa0 drivers/input/serio/serio.c:778
                        really_probe+0x291/0xf60 drivers/base/dd.c:576
                        driver_probe_device+0x298/0x410 drivers/base/dd.c:763
                        device_driver_attach+0x228/0x290 drivers/base/dd.c:1039
                        __driver_attach+0x190/0x340 drivers/base/dd.c:1117
                        bus_for_each_dev+0x147/0x1d0 drivers/base/bus.c:305
                        serio_attach_driver drivers/input/serio/serio.c:808 [inline]
                        serio_handle_event+0x5f6/0xa30 drivers/input/serio/serio.c:227
                        process_one_work+0x98d/0x1600 kernel/workqueue.c:2275
                        worker_thread+0x64c/0x1120 kernel/workqueue.c:2421
                        kthread+0x3b1/0x4a0 kernel/kthread.c:313
                        ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294
     INITIAL USE at:
                       lock_acquire kernel/locking/lockdep.c:5512 [inline]
                       lock_acquire+0x1ab/0x740 kernel/locking/lockdep.c:5477
                       __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
                       _raw_spin_lock_irqsave+0x39/0x50 kernel/locking/spinlock.c:159
                       input_inject_event+0xa6/0x320 drivers/input/input.c:471
                       __led_set_brightness drivers/leds/led-core.c:47 [inline]
                       led_set_brightness_nopm drivers/leds/led-core.c:271 [inline]
                       led_set_brightness_nosleep+0xe6/0x1a0 drivers/leds/led-core.c:287
                       led_set_brightness+0x134/0x170 drivers/leds/led-core.c:264
                       led_trigger_event drivers/leds/led-triggers.c:388 [inline]
                       led_trigger_event+0x75/0xd0 drivers/leds/led-triggers.c:377
                       kbd_led_trigger_activate+0xc9/0x100 drivers/tty/vt/keyboard.c:1029
                       led_trigger_set+0x61e/0xbd0 drivers/leds/led-triggers.c:195
                       led_trigger_set_default drivers/leds/led-triggers.c:259 [inline]
                       led_trigger_set_default+0x1a6/0x230 drivers/leds/led-triggers.c:246
                       led_classdev_register_ext+0x5b1/0x7c0 drivers/leds/led-class.c:416
                       led_classdev_register include/linux/leds.h:190 [inline]
                       input_leds_connect+0x4bd/0x860 drivers/input/input-leds.c:139
                       input_attach_handler+0x180/0x1f0 drivers/input/input.c:1035
                       input_register_device.cold+0xf0/0x304 drivers/input/input.c:2335
                       atkbd_connect+0x739/0xa00 drivers/input/keyboard/atkbd.c:1293
                       serio_connect_driver drivers/input/serio/serio.c:47 [inline]
                       serio_driver_probe+0x72/0xa0 drivers/input/serio/serio.c:778
                       really_probe+0x291/0xf60 drivers/base/dd.c:576
                       driver_probe_device+0x298/0x410 drivers/base/dd.c:763
                       device_driver_attach+0x228/0x290 drivers/base/dd.c:1039
                       __driver_attach+0x190/0x340 drivers/base/dd.c:1117
                       bus_for_each_dev+0x147/0x1d0 drivers/base/bus.c:305
                       serio_attach_driver drivers/input/serio/serio.c:808 [inline]
                       serio_handle_event+0x5f6/0xa30 drivers/input/serio/serio.c:227
                       process_one_work+0x98d/0x1600 kernel/workqueue.c:2275
                       worker_thread+0x64c/0x1120 kernel/workqueue.c:2421
                       kthread+0x3b1/0x4a0 kernel/kthread.c:313
                       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294
   }
   ... key      at: [<ffffffff90ca37c0>] __key.8+0x0/0x40
   ... acquired at:
   __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
   _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:151
   spin_lock include/linux/spinlock.h:359 [inline]
   evdev_pass_values.part.0+0xf6/0x970 drivers/input/evdev.c:261
   evdev_pass_values drivers/input/evdev.c:253 [inline]
   evdev_events+0x359/0x3e0 drivers/input/evdev.c:306
   input_to_handler+0x2a0/0x4c0 drivers/input/input.c:115
   input_pass_values.part.0+0x230/0x710 drivers/input/input.c:145
   input_pass_values drivers/input/input.c:134 [inline]
   input_handle_event+0x373/0x1440 drivers/input/input.c:404
   input_inject_event+0x1bd/0x320 drivers/input/input.c:476
   evdev_write+0x430/0x760 drivers/input/evdev.c:530
   vfs_write+0x28e/0xa40 fs/read_write.c:603
   ksys_write+0x1ee/0x250 fs/read_write.c:658
   do_syscall_64+0x31/0xb0 arch/x86/entry/common.c:47
   entry_SYSCALL_64_after_hwframe+0x44/0xae

 -> (&client->buffer_lock){....}-{2:2} {
    INITIAL USE at:
                     lock_acquire kernel/locking/lockdep.c:5512 [inline]
                     lock_acquire+0x1ab/0x740 kernel/locking/lockdep.c:5477
                     __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
                     _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:151
                     spin_lock include/linux/spinlock.h:359 [inline]
                     evdev_pass_values.part.0+0xf6/0x970 drivers/input/evdev.c:261
                     evdev_pass_values drivers/input/evdev.c:253 [inline]
                     evdev_events+0x359/0x3e0 drivers/input/evdev.c:306
                     input_to_handler+0x2a0/0x4c0 drivers/input/input.c:115
                     input_pass_values.part.0+0x230/0x710 drivers/input/input.c:145
                     input_pass_values drivers/input/input.c:134 [inline]
                     input_handle_event+0x373/0x1440 drivers/input/input.c:404
                     input_inject_event+0x1bd/0x320 drivers/input/input.c:476
                     evdev_write+0x430/0x760 drivers/input/evdev.c:530
                     vfs_write+0x28e/0xa40 fs/read_write.c:603
                     ksys_write+0x1ee/0x250 fs/read_write.c:658
                     do_syscall_64+0x31/0xb0 arch/x86/entry/common.c:47
                     entry_SYSCALL_64_after_hwframe+0x44/0xae
  }
  ... key      at: [<ffffffff90ca3c40>] __key.4+0x0/0x40
  ... acquired at:
   __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline]
   _raw_read_lock+0x5b/0x70 kernel/locking/spinlock.c:223
   kill_fasync_rcu fs/fcntl.c:1012 [inline]
   kill_fasync fs/fcntl.c:1033 [inline]
   kill_fasync+0x132/0x460 fs/fcntl.c:1026
   __pass_event drivers/input/evdev.c:240 [inline]
   evdev_pass_values.part.0+0x64e/0x970 drivers/input/evdev.c:278
   evdev_pass_values drivers/input/evdev.c:253 [inline]
   evdev_events+0x359/0x3e0 drivers/input/evdev.c:306
   input_to_handler+0x2a0/0x4c0 drivers/input/input.c:115
   input_pass_values.part.0+0x230/0x710 drivers/input/input.c:145
   input_pass_values drivers/input/input.c:134 [inline]
   input_handle_event+0x373/0x1440 drivers/input/input.c:404
   input_inject_event+0x1bd/0x320 drivers/input/input.c:476
   evdev_write+0x430/0x760 drivers/input/evdev.c:530
   vfs_write+0x28e/0xa40 fs/read_write.c:603
   ksys_write+0x1ee/0x250 fs/read_write.c:658
   do_syscall_64+0x31/0xb0 arch/x86/entry/common.c:47
   entry_SYSCALL_64_after_hwframe+0x44/0xae

-> (&new->fa_lock){.+..}-{2:2} {
   HARDIRQ-ON-R at:
                    lock_acquire kernel/locking/lockdep.c:5512 [inline]
                    lock_acquire+0x1ab/0x740 kernel/locking/lockdep.c:5477
                    __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline]
                    _raw_read_lock+0x5b/0x70 kernel/locking/spinlock.c:223
                    kill_fasync_rcu fs/fcntl.c:1012 [inline]
                    kill_fasync fs/fcntl.c:1033 [inline]
                    kill_fasync+0x132/0x460 fs/fcntl.c:1026
                    sock_wake_async+0xd2/0x160 net/socket.c:1312
                    sk_wake_async include/net/sock.h:2313 [inline]
                    sk_wake_async include/net/sock.h:2309 [inline]
                    sock_def_error_report+0x34b/0x4e0 net/core/sock.c:2899
                    sock_queue_err_skb+0x37b/0x750 net/core/skbuff.c:4681
                    __skb_complete_tx_timestamp+0x308/0x420 net/core/skbuff.c:4776
                    __skb_tstamp_tx+0x407/0x780 net/core/skbuff.c:4866
                    __dev_queue_xmit+0x1d0e/0x3150 net/core/dev.c:4181
                    packet_snd net/packet/af_packet.c:3015 [inline]
                    packet_sendmsg+0x2417/0x5280 net/packet/af_packet.c:3040
                    sock_sendmsg_nosec net/socket.c:654 [inline]
                    sock_sendmsg+0xcf/0x120 net/socket.c:674
                    ____sys_sendmsg+0x331/0x810 net/socket.c:2350
                    ___sys_sendmsg+0xf3/0x170 net/socket.c:2404
                    __sys_sendmmsg+0x195/0x470 net/socket.c:2490
                    __do_sys_sendmmsg net/socket.c:2519 [inline]
                    __se_sys_sendmmsg net/socket.c:2516 [inline]
                    __x64_sys_sendmmsg+0x99/0x100 net/socket.c:2516
                    do_syscall_64+0x31/0xb0 arch/x86/entry/common.c:47
                    entry_SYSCALL_64_after_hwframe+0x44/0xae
   INITIAL READ USE at:
                        lock_acquire kernel/locking/lockdep.c:5512 [inline]
                        lock_acquire+0x1ab/0x740 kernel/locking/lockdep.c:5477
                        __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline]
                        _raw_read_lock+0x5b/0x70 kernel/locking/spinlock.c:223
                        kill_fasync_rcu fs/fcntl.c:1012 [inline]
                        kill_fasync fs/fcntl.c:1033 [inline]
                        kill_fasync+0x132/0x460 fs/fcntl.c:1026
                        __pass_event drivers/input/evdev.c:240 [inline]
                        evdev_pass_values.part.0+0x64e/0x970 drivers/input/evdev.c:278
                        evdev_pass_values drivers/input/evdev.c:253 [inline]
                        evdev_events+0x359/0x3e0 drivers/input/evdev.c:306
                        input_to_handler+0x2a0/0x4c0 drivers/input/input.c:115
                        input_pass_values.part.0+0x230/0x710 drivers/input/input.c:145
                        input_pass_values drivers/input/input.c:134 [inline]
                        input_handle_event+0x373/0x1440 drivers/input/input.c:404
                        input_inject_event+0x1bd/0x320 drivers/input/input.c:476
                        evdev_write+0x430/0x760 drivers/input/evdev.c:530
                        vfs_write+0x28e/0xa40 fs/read_write.c:603
                        ksys_write+0x1ee/0x250 fs/read_write.c:658
                        do_syscall_64+0x31/0xb0 arch/x86/entry/common.c:47
                        entry_SYSCALL_64_after_hwframe+0x44/0xae
 }
 ... key      at: [<ffffffff909fdf60>] __key.0+0x0/0x40
 ... acquired at:
   mark_usage kernel/locking/lockdep.c:4381 [inline]
   __lock_acquire+0x120f/0x5230 kernel/locking/lockdep.c:4856
   lock_acquire kernel/locking/lockdep.c:5512 [inline]
   lock_acquire+0x1ab/0x740 kernel/locking/lockdep.c:5477
   __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline]
   _raw_read_lock+0x5b/0x70 kernel/locking/spinlock.c:223
   kill_fasync_rcu fs/fcntl.c:1012 [inline]
   kill_fasync fs/fcntl.c:1033 [inline]
   kill_fasync+0x132/0x460 fs/fcntl.c:1026
   sock_wake_async+0xd2/0x160 net/socket.c:1312
   sk_wake_async include/net/sock.h:2313 [inline]
   sk_wake_async include/net/sock.h:2309 [inline]
   sock_def_error_report+0x34b/0x4e0 net/core/sock.c:2899
   sock_queue_err_skb+0x37b/0x750 net/core/skbuff.c:4681
   __skb_complete_tx_timestamp+0x308/0x420 net/core/skbuff.c:4776
   __skb_tstamp_tx+0x407/0x780 net/core/skbuff.c:4866
   __dev_queue_xmit+0x1d0e/0x3150 net/core/dev.c:4181
   packet_snd net/packet/af_packet.c:3015 [inline]
   packet_sendmsg+0x2417/0x5280 net/packet/af_packet.c:3040
   sock_sendmsg_nosec net/socket.c:654 [inline]
   sock_sendmsg+0xcf/0x120 net/socket.c:674
   ____sys_sendmsg+0x331/0x810 net/socket.c:2350
   ___sys_sendmsg+0xf3/0x170 net/socket.c:2404
   __sys_sendmmsg+0x195/0x470 net/socket.c:2490
   __do_sys_sendmmsg net/socket.c:2519 [inline]
   __se_sys_sendmmsg net/socket.c:2516 [inline]
   __x64_sys_sendmmsg+0x99/0x100 net/socket.c:2516
   do_syscall_64+0x31/0xb0 arch/x86/entry/common.c:47
   entry_SYSCALL_64_after_hwframe+0x44/0xae


stack backtrace:
CPU: 0 PID: 8433 Comm: syz-executor436 Not tainted 5.13.0-rc2-next-20210518-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x13e/0x1d6 lib/dump_stack.c:129
 print_irq_inversion_bug kernel/locking/lockdep.c:203 [inline]
 check_usage_backwards kernel/locking/lockdep.c:3953 [inline]
 mark_lock_irq kernel/locking/lockdep.c:4043 [inline]
 mark_lock.cold+0x1d/0x8e kernel/locking/lockdep.c:4480
 mark_usage kernel/locking/lockdep.c:4381 [inline]
 __lock_acquire+0x120f/0x5230 kernel/locking/lockdep.c:4856
 lock_acquire kernel/locking/lockdep.c:5512 [inline]
 lock_acquire+0x1ab/0x740 kernel/locking/lockdep.c:5477
 __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline]
 _raw_read_lock+0x5b/0x70 kernel/locking/spinlock.c:223
 kill_fasync_rcu fs/fcntl.c:1012 [inline]
 kill_fasync fs/fcntl.c:1033 [inline]
 kill_fasync+0x132/0x460 fs/fcntl.c:1026
 sock_wake_async+0xd2/0x160 net/socket.c:1312
 sk_wake_async include/net/sock.h:2313 [inline]
 sk_wake_async include/net/sock.h:2309 [inline]
 sock_def_error_report+0x34b/0x4e0 net/core/sock.c:2899
 sock_queue_err_skb+0x37b/0x750 net/core/skbuff.c:4681
 __skb_complete_tx_timestamp+0x308/0x420 net/core/skbuff.c:4776
 __skb_tstamp_tx+0x407/0x780 net/core/skbuff.c:4866
 __dev_queue_xmit+0x1d0e/0x3150 net/core/dev.c:4181
 packet_snd net/packet/af_packet.c:3015 [inline]
 packet_sendmsg+0x2417/0x5280 net/packet/af_packet.c:3040
 sock_sendmsg_nosec net/socket.c:654 [inline]
 sock_sendmsg+0xcf/0x120 net/socket.c:674
 ____sys_sendmsg+0x331/0x810 net/socket.c:2350
 ___sys_sendmsg+0xf3/0x170 net/socket.c:2404
 __sys_sendmmsg+0x195/0x470 net/socket.c:2490
 __do_sys_sendmmsg net/socket.c:2519 [inline]
 __se_sys_sendmmsg net/socket.c:2516 [inline]
 __x64_sys_sendmmsg+0x99/0x100 net/socket.c:2516
 do_syscall_64+0x31/0xb0 arch/x86/entry/common.c:47
 entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x447899
Code: 28 c3 e8 4a 15 00 00 66 2e 0f 1f 84 00 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc6ab944c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000133
RAX: ffffffffffffffda RBX: 00007ffc6ab944d8 RCX: 0000000000447899
RDX: 000000000400004e RSI: 0000000020000d00 RDI: 0000000000000005
RBP: 0000000000000003 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007ffc6ab944e0
R13: 00007ffc6ab94500 R14: 00000000004b8018 R15: 00000000004004b8