WARNING in cgroup_apply_control

WARNING in cgroup_apply_control_disable
Status: upstream: reported syz repro on 2020/04/21 09:36
Reported-by: syzbot+5b142e89a1b402a24801@syzkaller.appspotmail.com
First crash: 46d, last: 8h45m

Cause bisection: the bug happens on the oldest tested release
Crash: WARNING in sysfs_warn_dup (log)
Repro: syz .config

similar bugs (2):
Kernel	Title	Repro	Bisected	Count	Last	Reported	Patched	Status
linux-4.14	WARNING in cgroup_apply_control_disable	syz		4	3d23h	38d	0/1	upstream: reported syz repro on 2020/04/25 17:18
linux-4.19	WARNING in cgroup_apply_control_disable	syz		3	3d22h	17d	0/1	upstream: reported syz repro on 2020/05/16 16:55

Sample crash report:

------------[ cut here ]------------
WARNING: CPU: 1 PID: 7007 at kernel/cgroup/cgroup.c:3111 cgroup_apply_control_disable+0x404/0x4d0 kernel/cgroup/cgroup.c:3111
Kernel panic - not syncing: panic_on_warn set ...
CPU: 1 PID: 7007 Comm: syz-executor.0 Not tainted 5.7.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x188/0x20d lib/dump_stack.c:118
 panic+0x2e3/0x75c kernel/panic.c:221
 __warn.cold+0x2f/0x35 kernel/panic.c:582
 report_bug+0x27b/0x2f0 lib/bug.c:195
 fixup_bug arch/x86/kernel/traps.c:105 [inline]
 fixup_bug arch/x86/kernel/traps.c:100 [inline]
 do_error_trap+0x12b/0x220 arch/x86/kernel/traps.c:197
 do_invalid_op+0x32/0x40 arch/x86/kernel/traps.c:216
 invalid_op+0x23/0x30 arch/x86/entry/entry_64.S:1027
RIP: 0010:cgroup_apply_control_disable+0x404/0x4d0 kernel/cgroup/cgroup.c:3111
Code: ff ff ff e8 2e 9c 06 00 48 89 ef 41 ff d5 e9 1a ff ff ff e8 1e 9c 06 00 48 89 ef e8 b6 e5 fe ff e9 08 ff ff ff e8 0c 9c 06 00 <0f> 0b e9 ab fd ff ff 48 83 c4 30 5b 5d 41 5c 41 5d 41 5e 41 5f e9
RSP: 0018:ffffc900016d7a90 EFLAGS: 00010293
RAX: ffff88808afa65c0 RBX: dffffc0000000000 RCX: ffffffff816c9c6d
RDX: 0000000000000000 RSI: ffffffff816c9ec4 RDI: 0000000000000007
RBP: ffff888096afec00 R08: ffff88808afa65c0 R09: ffffed1015ce711c
R10: ffff8880ae7388db R11: ffffed1015ce711b R12: 0000000000000008
R13: 0000000000000002 R14: ffffffff89a2f6c0 R15: ffff88809edd8000
 cgroup_finalize_control kernel/cgroup/cgroup.c:3178 [inline]
 rebind_subsystems+0x3cd/0xb00 kernel/cgroup/cgroup.c:1750
 cgroup_setup_root+0x36a/0xa30 kernel/cgroup/cgroup.c:1984
 cgroup1_root_to_use kernel/cgroup/cgroup-v1.c:1190 [inline]
 cgroup1_get_tree+0xd69/0x13b6 kernel/cgroup/cgroup-v1.c:1207
 vfs_get_tree+0x89/0x2f0 fs/super.c:1547
 do_new_mount fs/namespace.c:2869 [inline]
 do_mount+0x1306/0x1b40 fs/namespace.c:3194
 __do_sys_mount fs/namespace.c:3404 [inline]
 __se_sys_mount fs/namespace.c:3381 [inline]
 __x64_sys_mount+0x18f/0x230 fs/namespace.c:3381
 do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295
 entry_SYSCALL_64_after_hwframe+0x49/0xb3
RIP: 0033:0x45f4ba
Code: b8 a6 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 ad 8c fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 0f 83 8a 8c fb ff c3 66 0f 1f 84 00 00 00 00 00
RSP: 002b:00007ffca09bb6b8 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007ffca09bb710 RCX: 000000000045f4ba
RDX: 00000000004cafd1 RSI: 00000000004c16a5 RDI: 00000000004c1668
RBP: 0000000000000000 R08: 00000000004cfa40 R09: 000000000000001c
R10: 0000000000000000 R11: 0000000000000246 R12: 00000000004185d0
R13: 00007ffca09bb938 R14: 0000000000000000 R15: 0000000000000000
Kernel Offset: disabled
Rebooting in 86400 seconds..

Crashes (9):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	Maintainers
ci-upstream-kasan-gce-selinux-root	2020/06/02 20:08	upstream	f3592877	52fd7b7d	.config	log	report	syz	andriin@fb.com, ast@kernel.org, bpf@vger.kernel.org, cgroups@vger.kernel.org, christian@brauner.io, daniel@iogearbox.net, hannes@cmpxchg.org, john.fastabend@gmail.com, kafai@fb.com, kpsingh@chromium.org, linux-kernel@vger.kernel.org, lizefan@huawei.com, netdev@vger.kernel.org, songliubraving@fb.com, tj@kernel.org, yhs@fb.com
ci-upstream-kasan-gce-selinux-root	2020/05/27 16:07	upstream	444fc5cd	ec153193	.config	log	report	syz	andriin@fb.com, ast@kernel.org, bpf@vger.kernel.org, cgroups@vger.kernel.org, christian@brauner.io, daniel@iogearbox.net, hannes@cmpxchg.org, john.fastabend@gmail.com, kafai@fb.com, kpsingh@chromium.org, linux-kernel@vger.kernel.org, lizefan@huawei.com, netdev@vger.kernel.org, songliubraving@fb.com, tj@kernel.org, yhs@fb.com
ci-upstream-kasan-gce-selinux-root	2020/05/23 13:58	upstream	44456565	9682898d	.config	log	report	syz	andriin@fb.com, ast@kernel.org, bpf@vger.kernel.org, cgroups@vger.kernel.org, christian@brauner.io, daniel@iogearbox.net, hannes@cmpxchg.org, john.fastabend@gmail.com, kafai@fb.com, kpsingh@chromium.org, linux-kernel@vger.kernel.org, lizefan@huawei.com, netdev@vger.kernel.org, songliubraving@fb.com, tj@kernel.org, yhs@fb.com
ci-upstream-kasan-gce-root	2020/04/18 00:21	upstream	95988fbc	435c6d53	.config	log	report	syz	andriin@fb.com, ast@kernel.org, bpf@vger.kernel.org, cgroups@vger.kernel.org, christian@brauner.io, daniel@iogearbox.net, hannes@cmpxchg.org, john.fastabend@gmail.com, kafai@fb.com, kpsingh@chromium.org, linux-kernel@vger.kernel.org, lizefan@huawei.com, netdev@vger.kernel.org, songliubraving@fb.com, tj@kernel.org, yhs@fb.com
ci-upstream-kasan-gce-selinux-root	2020/04/17 09:30	upstream	7a56db02	18397578	.config	log	report	syz	andriin@fb.com, ast@kernel.org, bpf@vger.kernel.org, cgroups@vger.kernel.org, christian@brauner.io, daniel@iogearbox.net, hannes@cmpxchg.org, john.fastabend@gmail.com, kafai@fb.com, kpsingh@chromium.org, linux-kernel@vger.kernel.org, lizefan@huawei.com, netdev@vger.kernel.org, songliubraving@fb.com, tj@kernel.org, yhs@fb.com
ci-upstream-linux-next-kasan-gce-root	2020/06/02 02:27	linux-next	e7b08814	a0331e89	.config	log	report	syz	andriin@fb.com, ast@kernel.org, bpf@vger.kernel.org, cgroups@vger.kernel.org, christian@brauner.io, daniel@iogearbox.net, hannes@cmpxchg.org, john.fastabend@gmail.com, kafai@fb.com, kpsingh@chromium.org, linux-kernel@vger.kernel.org, lizefan@huawei.com, netdev@vger.kernel.org, songliubraving@fb.com, tj@kernel.org, yhs@fb.com
ci-upstream-linux-next-kasan-gce-root	2020/05/27 06:43	linux-next	b0523c7b	9072c126	.config	log	report	syz	andriin@fb.com, ast@kernel.org, bpf@vger.kernel.org, cgroups@vger.kernel.org, christian@brauner.io, daniel@iogearbox.net, hannes@cmpxchg.org, john.fastabend@gmail.com, kafai@fb.com, kpsingh@chromium.org, linux-kernel@vger.kernel.org, lizefan@huawei.com, netdev@vger.kernel.org, songliubraving@fb.com, tj@kernel.org, yhs@fb.com
ci-upstream-linux-next-kasan-gce-root	2020/05/20 04:34	linux-next	ac935d22	67fa1f59	.config	log	report	syz	andriin@fb.com, ast@kernel.org, bpf@vger.kernel.org, cgroups@vger.kernel.org, christian@brauner.io, daniel@iogearbox.net, hannes@cmpxchg.org, john.fastabend@gmail.com, kafai@fb.com, kpsingh@chromium.org, linux-kernel@vger.kernel.org, lizefan@huawei.com, netdev@vger.kernel.org, songliubraving@fb.com, tj@kernel.org, yhs@fb.com
ci-upstream-linux-next-kasan-gce-root	2020/05/07 13:42	linux-next	ac935d22	98cbd87b	.config	log	report	syz	andriin@fb.com, ast@kernel.org, bpf@vger.kernel.org, cgroups@vger.kernel.org, christian@brauner.io, daniel@iogearbox.net, hannes@cmpxchg.org, john.fastabend@gmail.com, kafai@fb.com, kpsingh@chromium.org, linux-kernel@vger.kernel.org, lizefan@huawei.com, netdev@vger.kernel.org, songliubraving@fb.com, tj@kernel.org, yhs@fb.com