WARNING in cgroup_apply_control

WARNING in cgroup_apply_control_disable
Status: closed as dup on 2021/01/21 09:28
Reported-by: syzbot+5b142e89a1b402a24801@syzkaller.appspotmail.com
First crash: 317d, last: 39d

Cause bisection: the issue happens on the oldest tested release (bisect log)
Crash: WARNING in sysfs_warn_dup (log)
Repro: syz .config

Duplicate of (1):
Title	Repro	Cause bisect	Fix bisect	Count	Last	Reported
WARNING in cgroup_finalize_control	syz	done		9	39d	293d

similar bugs (2):
Kernel	Title	Repro	Cause bisect	Fix bisect	Count	Last	Reported	Patched	Status
linux-4.14	WARNING in cgroup_apply_control_disable	syz			10	4d08h	309d	0/1	upstream: reported syz repro on 2020/04/25 17:18
linux-4.19	WARNING in cgroup_apply_control_disable	syz		error	7	206d	288d	0/1	upstream: reported syz repro on 2020/05/16 16:55

Sample crash report:

------------[ cut here ]------------
WARNING: CPU: 1 PID: 8200 at kernel/cgroup/cgroup.c:3104 cgroup_apply_control_disable+0x42b/0x500 kernel/cgroup/cgroup.c:3104
Kernel panic - not syncing: panic_on_warn set ...
CPU: 1 PID: 8200 Comm: syz-executor.1 Not tainted 5.8.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x18f/0x20d lib/dump_stack.c:118
 panic+0x2e3/0x75c kernel/panic.c:231
 __warn.cold+0x20/0x45 kernel/panic.c:600
 report_bug+0x1bd/0x210 lib/bug.c:198
 handle_bug+0x38/0x90 arch/x86/kernel/traps.c:235
 exc_invalid_op+0x14/0x40 arch/x86/kernel/traps.c:255
 asm_exc_invalid_op+0x12/0x20 arch/x86/include/asm/idtentry.h:536
RIP: 0010:cgroup_apply_control_disable+0x42b/0x500 kernel/cgroup/cgroup.c:3104
Code: 49 8d 7d 08 48 89 f8 48 c1 e8 03 0f b6 04 18 84 c0 74 08 3c 03 0f 8e be 00 00 00 45 0f b7 6d 08 e9 6b fe ff ff e8 d5 c6 06 00 <0f> 0b e9 af fd ff ff 48 83 c4 30 5b 5d 41 5c 41 5d 41 5e 41 5f e9
RSP: 0018:ffffc9000a53fb18 EFLAGS: 00010293
RAX: 0000000000000000 RBX: dffffc0000000000 RCX: ffffffff816d78d8
RDX: ffff8880911be380 RSI: ffffffff816d7b2b RDI: 0000000000000007
RBP: ffff8880a2f0d800 R08: 0000000000000001 R09: ffffffff8c5dca27
R10: 0000000000000000 R11: 0000000000056178 R12: 0000000000000008
R13: 0000000000000002 R14: ffffffff89c4e640 R15: ffff888093c02000
 cgroup_finalize_control kernel/cgroup/cgroup.c:3171 [inline]
 rebind_subsystems+0x479/0xbf0 kernel/cgroup/cgroup.c:1743
 cgroup_setup_root+0x374/0xaa0 kernel/cgroup/cgroup.c:1977
 cgroup1_root_to_use kernel/cgroup/cgroup-v1.c:1190 [inline]
 cgroup1_get_tree+0x9ee/0xe33 kernel/cgroup/cgroup-v1.c:1207
 vfs_get_tree+0x89/0x2f0 fs/super.c:1547
 do_new_mount fs/namespace.c:2875 [inline]
 do_mount+0x1592/0x1fe0 fs/namespace.c:3200
 __do_sys_mount fs/namespace.c:3410 [inline]
 __se_sys_mount fs/namespace.c:3387 [inline]
 __x64_sys_mount+0x18f/0x230 fs/namespace.c:3387
 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x45f72a
Code: b8 a6 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 cd 8b fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 0f 83 aa 8b fb ff c3 66 0f 1f 84 00 00 00 00 00
RSP: 002b:00007fffc9c30ac8 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007fffc9c30b20 RCX: 000000000045f72a
RDX: 00000000004cbd9e RSI: 00000000004c18a5 RDI: 00000000004c1868
RBP: 0000000000000000 R08: 00000000004d0bc8 R09: 000000000000001c
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000418760
R13: 00007fffc9c30d48 R14: 0000000000000000 R15: 0000000000000000
Kernel Offset: disabled
Rebooting in 86400 seconds..

Fix bisection attempts:
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro
ci-upstream-kasan-gce-root	2021/01/20 06:57	upstream	45dfb8a5	cb436c69	.config	log	report	syz
ci-upstream-kasan-gce-root	2020/12/21 05:28	upstream	e37b12e4	cb436c69	.config	log	report	syz
ci-upstream-kasan-gce-root	2020/11/13 08:57	upstream	585e5b17	cb436c69	.config	log	report	syz
ci-upstream-kasan-gce-root	2020/10/14 03:21	upstream	b5fc7a89	cb436c69	.config	log	report	syz
ci-upstream-kasan-gce-root	2020/09/09 03:57	upstream	34d4ddd3	cb436c69	.config	log	report	syz

Crashes (22):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro
ci-upstream-kasan-gce-root	2020/08/07 15:01	upstream	d6efb3ac	cb436c69	.config	log	report	syz
ci-upstream-kasan-gce-selinux-root	2020/08/06 15:31	upstream	47ec5303	1f122f88	.config	log	report	syz
ci-upstream-kasan-gce-root	2020/08/05 18:32	upstream	442489c2	b7129355	.config	log	report	syz
ci-upstream-kasan-gce-selinux-root	2020/08/03 22:59	upstream	bcf87687	196277c4	.config	log	report	syz
ci-upstream-kasan-gce-root	2020/08/03 17:42	upstream	bcf87687	196277c4	.config	log	report	syz
ci-upstream-kasan-gce-selinux-root	2020/08/01 17:08	upstream	7dc6fd0f	d895b3be	.config	log	report	syz
ci-upstream-kasan-gce-root	2020/07/30 14:21	upstream	d3590ebf	233283a1	.config	log	report	syz
ci-upstream-kasan-gce-selinux-root	2020/07/29 17:28	upstream	6ba1b005	19a8de55	.config	log	report	syz
ci-upstream-kasan-gce-selinux-root	2020/07/05 22:44	upstream	7cc2a8ea	51095195	.config	log	report	syz
ci-upstream-kasan-gce-root	2020/07/05 08:10	upstream	7cc2a8ea	51095195	.config	log	report	syz
ci-upstream-kasan-gce-selinux-root	2020/06/02 20:08	upstream	f3592877	52fd7b7d	.config	log	report	syz
ci-upstream-kasan-gce-selinux-root	2020/05/27 16:07	upstream	444fc5cd	ec153193	.config	log	report	syz
ci-upstream-kasan-gce-selinux-root	2020/05/23 13:58	upstream	44456565	9682898d	.config	log	report	syz
ci-upstream-kasan-gce-root	2020/04/18 00:21	upstream	95988fbc	435c6d53	.config	log	report	syz
ci-upstream-kasan-gce-selinux-root	2020/04/17 09:30	upstream	7a56db02	18397578	.config	log	report	syz
ci-upstream-linux-next-kasan-gce-root	2020/08/10 03:27	linux-next	01830e6c	70301872	.config	log	report	syz
ci-upstream-linux-next-kasan-gce-root	2020/08/07 15:45	linux-next	01830e6c	cb436c69	.config	log	report	syz
ci-upstream-linux-next-kasan-gce-root	2020/08/01 16:01	linux-next	01830e6c	d895b3be	.config	log	report	syz
ci-upstream-linux-next-kasan-gce-root	2020/06/02 02:27	linux-next	e7b08814	a0331e89	.config	log	report	syz
ci-upstream-linux-next-kasan-gce-root	2020/05/27 06:43	linux-next	b0523c7b	9072c126	.config	log	report	syz
ci-upstream-linux-next-kasan-gce-root	2020/05/20 04:34	linux-next	ac935d22	67fa1f59	.config	log	report	syz
ci-upstream-linux-next-kasan-gce-root	2020/05/07 13:42	linux-next	ac935d22	98cbd87b	.config	log	report	syz