general protection fault in can_rx

general protection fault in can_rx_register
Status: upstream: reported C repro on 2020/01/17 13:46
Reported-by: syzbot+c3ea30e1e2485573f953@syzkaller.appspotmail.com
First crash: 31d, last: 22h20m

Cause bisection: introduced by (bisect log):

commit 9868b5d44f3df9dd75247acd23dddff0a42f79be
Author: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
Date: Mon Oct 8 09:48:33 2018 +0000

can: introduce CAN_REQUIRED_SIZE macro

Crash: general protection fault in can_rx_register (log)
Repro: C syz .config

Sample crash report:

kasan: CONFIG_KASAN_INLINE enabled
kasan: GPF could be caused by NULL-ptr deref or user memory access
general protection fault: 0000 [#1] PREEMPT SMP KASAN
CPU: 0 PID: 10779 Comm: syz-executor679 Not tainted 5.5.0-rc6-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:hlist_add_head_rcu include/linux/rculist.h:528 [inline]
RIP: 0010:can_rx_register+0x325/0x6a0 net/can/af_can.c:476
Code: 49 89 4f 30 80 3c 16 00 0f 85 11 03 00 00 48 8b 8d 30 ff ff ff 48 89 c6 48 ba 00 00 00 00 00 fc ff df 48 c1 ee 03 49 89 4f 38 <80> 3c 16 00 0f 85 d0 02 00 00 48 ba 00 00 00 00 00 fc ff df 4c 89
RSP: 0018:ffffc90002097bd0 EFLAGS: 00010202
RAX: 0000000000000008 RBX: 0000000000000000 RCX: ffff88809fd5c000
RDX: dffffc0000000000 RSI: 0000000000000001 RDI: ffff88809e92a6c8
RBP: ffffc90002097cb0 R08: ffff8880a4648500 R09: fffff52000412f68
R10: fffff52000412f67 R11: 0000000000000003 R12: ffff888215226480
R13: 0000000000000000 R14: ffffc90002097c88 R15: ffff88809e92a690
FS:  00007f3a359e1700(0000) GS:ffff8880ae800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000619570 CR3: 00000000964cf000 CR4: 00000000001406f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 raw_enable_filters+0xe8/0x210 net/can/raw.c:189
 raw_enable_allfilters+0x89/0x1e0 net/can/raw.c:255
 raw_bind+0x2c8/0x940 net/can/raw.c:428
 __sys_bind+0x239/0x290 net/socket.c:1649
 __do_sys_bind net/socket.c:1660 [inline]
 __se_sys_bind net/socket.c:1658 [inline]
 __x64_sys_bind+0x73/0xb0 net/socket.c:1658
 do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x446af9
Code: e8 5c b3 02 00 48 83 c4 18 c3 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 0b 08 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007f3a359e0d98 EFLAGS: 00000246 ORIG_RAX: 0000000000000031
RAX: ffffffffffffffda RBX: 00000000006dbc78 RCX: 0000000000446af9
RDX: 0000000000000008 RSI: 0000000020000180 RDI: 0000000000000003
RBP: 00000000006dbc70 R08: 00007f3a359e1700 R09: 0000000000000000
R10: 00007f3a359e1700 R11: 0000000000000246 R12: 00000000006dbc7c
R13: 0000000000000000 R14: 0000000000000000 R15: 068500100000003c
Modules linked in:
---[ end trace a1179aee13a28d30 ]---
RIP: 0010:hlist_add_head_rcu include/linux/rculist.h:528 [inline]
RIP: 0010:can_rx_register+0x325/0x6a0 net/can/af_can.c:476
Code: 49 89 4f 30 80 3c 16 00 0f 85 11 03 00 00 48 8b 8d 30 ff ff ff 48 89 c6 48 ba 00 00 00 00 00 fc ff df 48 c1 ee 03 49 89 4f 38 <80> 3c 16 00 0f 85 d0 02 00 00 48 ba 00 00 00 00 00 fc ff df 4c 89
RSP: 0018:ffffc90002097bd0 EFLAGS: 00010202
RAX: 0000000000000008 RBX: 0000000000000000 RCX: ffff88809fd5c000
RDX: dffffc0000000000 RSI: 0000000000000001 RDI: ffff88809e92a6c8
RBP: ffffc90002097cb0 R08: ffff8880a4648500 R09: fffff52000412f68
R10: fffff52000412f67 R11: 0000000000000003 R12: ffff888215226480
R13: 0000000000000000 R14: ffffc90002097c88 R15: ffff88809e92a690
FS:  00007f3a359e1700(0000) GS:ffff8880ae800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000619570 CR3: 00000000964cf000 CR4: 00000000001406f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400

Fix bisection attempts:
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro
ci-upstream-kasan-gce-selinux-root	2020/02/16 11:57	upstream	db70e26e	3de7aabb	.config	log	report	syz	C

Crashes (6):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	Maintainers
ci-upstream-kasan-gce-selinux-root	2020/01/17 11:35	upstream	f4353c3e	3de7aabb	.config	log	report	syz	C	davem@davemloft.net, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, mkl@pengutronix.de, netdev@vger.kernel.org, socketcan@hartkopp.net
ci-upstream-kasan-gce-smack-root	2020/01/17 05:11	upstream	f5ae2ea6	3de7aabb	.config	log	report	syz	C	davem@davemloft.net, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, mkl@pengutronix.de, netdev@vger.kernel.org, socketcan@hartkopp.net
ci-upstream-kasan-gce	2020/01/17 03:01	upstream	f5ae2ea6	3de7aabb	.config	log	report	syz	C	davem@davemloft.net, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, mkl@pengutronix.de, netdev@vger.kernel.org, socketcan@hartkopp.net
ci-upstream-net-this-kasan-gce	2020/01/17 04:09	net	567110f1	3de7aabb	.config	log	report	syz	C	davem@davemloft.net, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, mkl@pengutronix.de, netdev@vger.kernel.org, socketcan@hartkopp.net
ci-upstream-net-kasan-gce	2020/01/17 03:57	net-next	1ccf6c13	3de7aabb	.config	log	report	syz		davem@davemloft.net, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, mkl@pengutronix.de, netdev@vger.kernel.org, socketcan@hartkopp.net
ci-upstream-kasan-gce	2020/01/17 01:21	upstream	f5ae2ea6	3de7aabb	.config	log	report			davem@davemloft.net, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, mkl@pengutronix.de, netdev@vger.kernel.org, socketcan@hartkopp.net