syzbot


possible deadlock in __ntfs_clear_inode

Status: upstream: reported on 2022/11/25 10:07
Subsystems: ntfs (incorrect?)
Reported-by: syzbot+5ebb8d0e9b8c47867596@syzkaller.appspotmail.com
First crash: 126d, last: 1h20m
similar bugs (1):
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-4.19 possible deadlock in __ntfs_clear_inode ntfs 2 92d 110d 0/1 upstream: reported on 2022/12/10 22:52

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.3.0-rc4-syzkaller-00051-g8bb95a1662f8 #0 Not tainted
------------------------------------------------------
kswapd0/100 is trying to acquire lock:
ffff888028aef4c0 (&rl->lock){+.+.}-{3:3}, at: __ntfs_clear_inode+0x24/0x260 fs/ntfs/inode.c:2189

but task is already holding lock:
ffffffff8c8e1180 (fs_reclaim){+.+.}-{0:0}, at: set_task_reclaim_state mm/vmscan.c:200 [inline]
ffffffff8c8e1180 (fs_reclaim){+.+.}-{0:0}, at: balance_pgdat+0x170/0x1ac0 mm/vmscan.c:7338

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (fs_reclaim){+.+.}-{0:0}:
       __fs_reclaim_acquire mm/page_alloc.c:4717 [inline]
       fs_reclaim_acquire+0x11d/0x160 mm/page_alloc.c:4731
       might_alloc include/linux/sched/mm.h:271 [inline]
       prepare_alloc_pages+0x159/0x570 mm/page_alloc.c:5363
       __alloc_pages+0x149/0x4a0 mm/page_alloc.c:5581
       alloc_pages+0x1aa/0x270 mm/mempolicy.c:2283
       folio_alloc+0x20/0x70 mm/mempolicy.c:2293
       filemap_alloc_folio+0x3c1/0x470 mm/filemap.c:976
       do_read_cache_folio+0x193/0x510 mm/filemap.c:3647
       do_read_cache_page mm/filemap.c:3749 [inline]
       read_cache_page+0x5d/0x160 mm/filemap.c:3758
       read_mapping_page include/linux/pagemap.h:769 [inline]
       ntfs_map_page fs/ntfs/aops.h:75 [inline]
       map_mft_record_page fs/ntfs/mft.c:73 [inline]
       map_mft_record+0x1df/0x6c0 fs/ntfs/mft.c:156
       ntfs_read_locked_inode+0x19c/0x5ae0 fs/ntfs/inode.c:550
       ntfs_iget+0x131/0x180 fs/ntfs/inode.c:177
       ntfs_lookup+0x2f6/0xbf0 fs/ntfs/namei.c:117
       __lookup_slow+0x24c/0x460 fs/namei.c:1686
       lookup_slow fs/namei.c:1703 [inline]
       walk_component+0x33f/0x5a0 fs/namei.c:1994
       link_path_walk.part.0+0x74e/0xd60 fs/namei.c:2321
       link_path_walk fs/namei.c:2245 [inline]
       path_lookupat+0xb7/0x840 fs/namei.c:2474
       filename_lookup+0x1d2/0x590 fs/namei.c:2504
       user_path_at_empty+0x46/0x60 fs/namei.c:2877
       user_path_at include/linux/namei.h:57 [inline]
       do_sys_truncate.part.0+0x86/0x140 fs/open.c:133
       do_sys_truncate fs/open.c:129 [inline]
       __do_sys_truncate fs/open.c:147 [inline]
       __se_sys_truncate fs/open.c:145 [inline]
       __x64_sys_truncate+0x6d/0xa0 fs/open.c:145
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #1 (&ni->mrec_lock){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x12f/0x1350 kernel/locking/mutex.c:747
       map_mft_record+0x40/0x6c0 fs/ntfs/mft.c:154
       ntfs_truncate+0x243/0x2a50 fs/ntfs/inode.c:2383
       ntfs_truncate_vfs fs/ntfs/inode.c:2862 [inline]
       ntfs_setattr+0x397/0x560 fs/ntfs/inode.c:2914
       notify_change+0xb2c/0x1180 fs/attr.c:482
       do_truncate+0x143/0x200 fs/open.c:66
       vfs_truncate+0x3df/0x4c0 fs/open.c:112
       do_sys_truncate.part.0+0x11e/0x140 fs/open.c:135
       do_sys_truncate fs/open.c:129 [inline]
       __do_sys_truncate fs/open.c:147 [inline]
       __se_sys_truncate fs/open.c:145 [inline]
       __x64_sys_truncate+0x6d/0xa0 fs/open.c:145
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&rl->lock){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3098 [inline]
       check_prevs_add kernel/locking/lockdep.c:3217 [inline]
       validate_chain kernel/locking/lockdep.c:3832 [inline]
       __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056
       lock_acquire kernel/locking/lockdep.c:5669 [inline]
       lock_acquire+0x1af/0x520 kernel/locking/lockdep.c:5634
       down_write+0x92/0x200 kernel/locking/rwsem.c:1573
       __ntfs_clear_inode+0x24/0x260 fs/ntfs/inode.c:2189
       ntfs_evict_big_inode+0x190/0x520 fs/ntfs/inode.c:2278
       evict+0x2ed/0x6b0 fs/inode.c:665
       dispose_list+0x117/0x1e0 fs/inode.c:698
       prune_icache_sb+0xeb/0x150 fs/inode.c:897
       super_cache_scan+0x391/0x590 fs/super.c:106
       do_shrink_slab+0x428/0xaa0 mm/vmscan.c:853
       shrink_slab_memcg mm/vmscan.c:922 [inline]
       shrink_slab+0x388/0x660 mm/vmscan.c:1001
       shrink_one+0x502/0x810 mm/vmscan.c:5343
       shrink_many mm/vmscan.c:5394 [inline]
       lru_gen_shrink_node mm/vmscan.c:5511 [inline]
       shrink_node+0x2064/0x35f0 mm/vmscan.c:6459
       kswapd_shrink_node mm/vmscan.c:7262 [inline]
       balance_pgdat+0xa02/0x1ac0 mm/vmscan.c:7452
       kswapd+0x677/0xd60 mm/vmscan.c:7712
       kthread+0x2e8/0x3a0 kernel/kthread.c:376
       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308

other info that might help us debug this:

Chain exists of:
  &rl->lock --> &ni->mrec_lock --> fs_reclaim

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(fs_reclaim);
                               lock(&ni->mrec_lock);
                               lock(fs_reclaim);
  lock(&rl->lock);

 *** DEADLOCK ***

3 locks held by kswapd0/100:
 #0: ffffffff8c8e1180 (fs_reclaim){+.+.}-{0:0}, at: set_task_reclaim_state mm/vmscan.c:200 [inline]
 #0: ffffffff8c8e1180 (fs_reclaim){+.+.}-{0:0}, at: balance_pgdat+0x170/0x1ac0 mm/vmscan.c:7338
 #1: ffffffff8c897fb0 (shrinker_rwsem){++++}-{3:3}, at: shrink_slab_memcg mm/vmscan.c:895 [inline]
 #1: ffffffff8c897fb0 (shrinker_rwsem){++++}-{3:3}, at: shrink_slab+0x2a0/0x660 mm/vmscan.c:1001
 #2: ffff88802545a0e0 (&type->s_umount_key#82){.+.+}-{3:3}, at: trylock_super fs/super.c:414 [inline]
 #2: ffff88802545a0e0 (&type->s_umount_key#82){.+.+}-{3:3}, at: super_cache_scan+0x70/0x590 fs/super.c:79

stack backtrace:
CPU: 1 PID: 100 Comm: kswapd0 Not tainted 6.3.0-rc4-syzkaller-00051-g8bb95a1662f8 #0
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.14.0-2 04/01/2014
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106
 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2178
 check_prev_add kernel/locking/lockdep.c:3098 [inline]
 check_prevs_add kernel/locking/lockdep.c:3217 [inline]
 validate_chain kernel/locking/lockdep.c:3832 [inline]
 __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056
 lock_acquire kernel/locking/lockdep.c:5669 [inline]
 lock_acquire+0x1af/0x520 kernel/locking/lockdep.c:5634
 down_write+0x92/0x200 kernel/locking/rwsem.c:1573
 __ntfs_clear_inode+0x24/0x260 fs/ntfs/inode.c:2189
 ntfs_evict_big_inode+0x190/0x520 fs/ntfs/inode.c:2278
 evict+0x2ed/0x6b0 fs/inode.c:665
 dispose_list+0x117/0x1e0 fs/inode.c:698
 prune_icache_sb+0xeb/0x150 fs/inode.c:897
 super_cache_scan+0x391/0x590 fs/super.c:106
 do_shrink_slab+0x428/0xaa0 mm/vmscan.c:853
 shrink_slab_memcg mm/vmscan.c:922 [inline]
 shrink_slab+0x388/0x660 mm/vmscan.c:1001
 shrink_one+0x502/0x810 mm/vmscan.c:5343
 shrink_many mm/vmscan.c:5394 [inline]
 lru_gen_shrink_node mm/vmscan.c:5511 [inline]
 shrink_node+0x2064/0x35f0 mm/vmscan.c:6459
 kswapd_shrink_node mm/vmscan.c:7262 [inline]
 balance_pgdat+0xa02/0x1ac0 mm/vmscan.c:7452
 kswapd+0x677/0xd60 mm/vmscan.c:7712
 kthread+0x2e8/0x3a0 kernel/kthread.c:376
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308
 </TASK>

Crashes (113):
Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets Title
ci-qemu-upstream 2023/03/30 22:02 upstream 8bb95a1662f8 f325deb0 .config console log report info possible deadlock in __ntfs_clear_inode
ci2-upstream-fs 2023/03/28 12:53 upstream 3a93e40326c8 47f3aaf1 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in __ntfs_clear_inode
ci-qemu-upstream 2023/03/28 02:04 upstream 3a93e40326c8 47f3aaf1 .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream 2023/03/27 23:09 upstream 3a93e40326c8 47f3aaf1 .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream 2023/03/27 20:34 upstream 197b6b60ae7b f8f96aa9 .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream 2023/03/26 21:53 upstream 0ec57cfa721f fbf0499a .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream 2023/03/26 11:30 upstream da8e7da11e4b fbf0499a .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream 2023/03/25 07:49 upstream e76db6e50c85 fbf0499a .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream 2023/03/24 15:34 upstream 1e760fa3596e ee89d73c .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream 2023/03/24 10:01 upstream 1e760fa3596e f94b4a29 .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream 2023/03/24 04:37 upstream 9fd6ba5420ba f94b4a29 .config console log report info possible deadlock in __ntfs_clear_inode
ci2-upstream-fs 2023/03/24 01:29 upstream 9fd6ba5420ba f94b4a29 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in __ntfs_clear_inode
ci-qemu-upstream 2023/03/23 19:46 upstream 9fd6ba5420ba f94b4a29 .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream 2023/03/23 09:55 upstream fff5a5e7f528 f94b4a29 .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream 2023/03/23 01:03 upstream fff5a5e7f528 f94b4a29 .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream 2023/03/22 09:13 upstream 2faac9a98f01 8b4eb097 .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream 2023/03/22 05:05 upstream 2faac9a98f01 8b4eb097 .config console log report info possible deadlock in __ntfs_clear_inode
ci2-upstream-fs 2023/03/22 01:23 upstream 2faac9a98f01 8b4eb097 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in __ntfs_clear_inode
ci-qemu-upstream 2023/03/21 19:57 upstream 17214b70a159 03fb9538 .config console log report info possible deadlock in __ntfs_clear_inode
ci2-upstream-fs 2023/03/21 03:06 upstream 7d31677bb7b1 7939252e .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in __ntfs_clear_inode
ci-qemu-upstream 2023/03/20 12:18 upstream e8d018dd0257 7939252e .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream 2023/03/18 08:08 upstream 478a351ce0d6 7939252e .config console log report info possible deadlock in __ntfs_clear_inode
ci2-upstream-fs 2023/03/17 23:08 upstream 38e04b3e4240 7939252e .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in __ntfs_clear_inode
ci-qemu-upstream 2023/03/16 01:22 upstream 9c1bec9c0b08 18b58603 .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream 2023/03/15 12:21 upstream 6015b1aca1a2 18b58603 .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream 2023/03/14 18:14 upstream fc89d7fb499b 0d5c4377 .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream 2023/03/14 15:03 upstream fc89d7fb499b 0d5c4377 .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream 2023/03/14 03:31 upstream fc89d7fb499b 026e2200 .config console log report info possible deadlock in __ntfs_clear_inode
ci2-upstream-fs 2022/11/24 19:57 upstream 4312098baf37 ff68ff8f .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in __ntfs_clear_inode
ci-qemu-upstream-386 2023/03/31 15:48 upstream 62bad54b26db f325deb0 .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream-386 2023/03/31 14:17 upstream 62bad54b26db f325deb0 .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream-386 2023/03/31 12:58 upstream 62bad54b26db f325deb0 .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream-386 2023/03/29 15:58 upstream fcd476ea6a88 f325deb0 .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream-386 2023/03/28 14:49 upstream 3a93e40326c8 48c74771 .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream-386 2023/03/27 11:41 upstream 197b6b60ae7b f8f96aa9 .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream-386 2023/03/27 01:07 upstream 18940c888c85 fbf0499a .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream-386 2023/03/26 08:58 upstream da8e7da11e4b fbf0499a .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream-386 2023/03/26 07:25 upstream da8e7da11e4b fbf0499a .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream-386 2023/03/25 06:48 upstream e76db6e50c85 fbf0499a .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream-386 2023/03/25 05:28 upstream e76db6e50c85 fbf0499a .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream-386 2023/03/24 20:12 upstream 1e760fa3596e ee89d73c .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream-386 2023/03/21 01:11 upstream 7d31677bb7b1 7939252e .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream-386 2023/03/21 00:06 upstream 7d31677bb7b1 7939252e .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream-386 2023/03/20 08:46 upstream e8d018dd0257 7939252e .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream-386 2023/03/16 22:27 upstream 0ddc84d2dd43 18b58603 .config console log report info possible deadlock in __ntfs_clear_inode
ci-qemu-upstream-386 2023/03/14 08:08 upstream fc89d7fb499b 026e2200 .config console log report info possible deadlock in __ntfs_clear_inode
ci-upstream-linux-next-kasan-gce-root 2023/02/24 08:09 linux-next 0222aa9800b2 9e2ebb3c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in __ntfs_clear_inode
* Struck through repros no longer work on HEAD.