syzbot


uvm_fault: arp_rtrequest

Status: fixed on 2019/06/14 04:59
Reported-by: syzbot+927e93a362f3ae33dd9c@syzkaller.appspotmail.com
Fix commit: 4cb088386ee5 In arp_rtrequest and nd6_rtrequest return early if the RTF_MPLS flag is set. These mpls routes use the rt_llinfo structure to store the MPLS label and would confuse the arp and nd6 code. OK bluhm@ anton@
First crash: 1284d, last: 1273d
Patch testing requests:
Created Duration User Patch Repo Result
2019/06/09 09:16 16m anton@basename.se https://github.com/mptre/openbsd-src arp OK

Sample crash report:
login: uvm_fault(0xfffffd806e7e2b48, 0x100000008, 0, 2) -> e
kernel: page fault trap, code=0
Stopped at      arp_rtrequest+0x15f:    movq    %rcx,0x8(%r15)
ddb{1}> 
ddb{1}> set $lines = 0
ddb{1}> set $maxwidth = 0
ddb{1}> show panic
kernel page fault
uvm_fault(0xfffffd806e7e2b48, 0x100000008, 0, 2) -> e
arp_rtrequest() at arp_rtrequest+0x15f sys/netinet/if_ether.c:201
end trace frame: 0xffff800020bc1a30, count: 0
ddb{1}> trace
arp_rtrequest() at arp_rtrequest+0x15f sys/netinet/if_ether.c:201
rtm_output(ffff800000975400,ffff800020bc1af0,ffff800020bc1a40,40,0) at rtm_output+0xbf4 sys/net/rtsock.c:1040
route_output(fffffd806f0ce800,fffffd806e9a5788,0,0) at route_output+0x7d2 sys/net/rtsock.c:814
route_usrreq(fffffd806e9a5788,9,fffffd806f0ce800,0,0,ffff800020b85780) at route_usrreq+0x363 sys/net/rtsock.c:271
sosend(fffffd806e9a5788,0,ffff800020bc1ce0,0,0,80) at sosend+0x668 sys/kern/uipc_socket.c:513
sendit(ffff800020b85780,4,ffff800020bc1dc0,0,ffff800020bc1ed0) at sendit+0x52c sys/kern/uipc_syscalls.c:662
sys_sendto(ffff800020b85780,ffff800020bc1e68,ffff800020bc1ed0) at sys_sendto+0x80 sys/kern/uipc_syscalls.c:527
syscall(ffff800020bc1f40) at syscall+0x552 mi_syscall sys/sys/syscall_mi.h:99 [inline]
syscall(ffff800020bc1f40) at syscall+0x552 sys/arch/amd64/amd64/trap.c:574
Xsyscall(6,0,191,0,2a,4) at Xsyscall+0x128
end of kernel
end trace frame: 0x7f7fffffabe0, count: -9
ddb{1}> show registers
rdi                              0x2
rsi               0xffffffff82245450    __sancov_gen_cov_switch_values
rbp               0xffff800020bc1990
rbx               0xffff80000005b850
rdx                             0x8b
rcx               0xdeaf4152deaf4152
rax               0xffff80000005b858
r8                0xffffffff81f09c1f    arp_rtrequest+0x11f
r9                               0x5
r10               0xa1052ed823511cd4
r11               0xaad29c102df2beda
r12               0xffff800000173290
r13                              0x2
r14               0xfffffd806f738540
r15                      0x100000000
rip               0xffffffff81f09c5f    arp_rtrequest+0x15f
cs                               0x8
rflags                       0x10246    __ALIGN_SIZE+0xf246
rsp               0xffff800020bc1910
ss                              0x10
arp_rtrequest+0x15f:    movq    %rcx,0x8(%r15)
ddb{1}> show proc
PROC (syz-executor5432) pid=233399 stat=onproc
    flags process=0 proc=0
    pri=51, usrpri=51, nice=20
    forw=0xffffffffffffffff, list=0xffff800020b85528,0xffffffff82398cb8
    process=0xffff800020afb070 user=0xffff800020bbc000, vmspace=0xfffffd806e7e2b48
    estcpu=2, cpticks=1, pctcpu=0.0
    user=0, sys=1, intr=0
ddb{1}> ps
   PID     TID   PPID    UID  S       FLAGS  WAIT          COMMAND
*78814  233399  70887      0  7           0                syz-executor5432
 70887  144140  93405      0  3        0x82  nanosleep     syz-executor5432
 93405  217815  87825      0  3    0x10008a  pause         ksh
 87825  217624  21294      0  3        0x92  select        sshd
 64666  135616      1      0  3    0x100083  ttyin         getty
 21294   95289      1      0  3        0x80  select        sshd
 46492   36289  48194     74  3    0x100092  bpf           pflogd
 48194   46670      1      0  3        0x80  netio         pflogd
 62947  506589  59714     73  7    0x100010                syslogd
 59714  468757      1      0  3    0x100082  netio         syslogd
  8579   70541      1     77  3    0x100090  poll          dhclient
 41766   53879      1      0  3        0x80  poll          dhclient
 40381  407465      0      0  3     0x14200  pgzero        zerothread
 70244  332952      0      0  3     0x14200  aiodoned      aiodoned
 26835  480035      0      0  3     0x14200  syncer        update
 92500   86850      0      0  3     0x14200  cleaner       cleaner
 43568   86206      0      0  3     0x14200  reaper        reaper
 75885   51045      0      0  3     0x14200  pgdaemon      pagedaemon
 68434  220042      0      0  3     0x14200  bored         crynlk
 11323  520983      0      0  3     0x14200  bored         crypto
 14789  428451      0      0  3  0x40014200  acpi0         acpi0
 34297  454419      0      0  3  0x40014200                idle1
 58051  158086      0      0  3     0x14200  bored         softnet
 72615   42831      0      0  3     0x14200  bored         systqmp
 99895  272031      0      0  3     0x14200  bored         systq
 90433  385291      0      0  3  0x40014200  bored         softclock
 49943  346609      0      0  3  0x40014200                idle0
 36385   82975      0      0  3     0x14200  bored         smr
     1   29890      0      0  3        0x82  wait          init
     0       0     -1      0  3     0x10200  scheduler     swapper
ddb{1}> show all locks
Process 78814 (syz-executor5432) thread 0xffff800020b85780 (233399)
exclusive rwlock netlock r = 0 (0xffffffff82200df8)
#0  witness_lock+0x52e sys/kern/subr_witness.c:1161
#1  rtm_output+0xb86 sys/net/rtsock.c:1031
#2  route_output+0x7d2 sys/net/rtsock.c:814
#3  route_usrreq+0x363 sys/net/rtsock.c:271
#4  sosend+0x668 sys/kern/uipc_socket.c:513
#5  sendit+0x52c sys/kern/uipc_syscalls.c:662
#6  sys_sendto+0x80 sys/kern/uipc_syscalls.c:527
#7  syscall+0x552 mi_syscall sys/sys/syscall_mi.h:99 [inline]
#7  syscall+0x552 sys/arch/amd64/amd64/trap.c:574
#8  Xsyscall+0x128
exclusive kernel_lock &kernel_lock r = 1 (0xffffffff82360fe0)
#0  witness_lock+0x52e sys/kern/subr_witness.c:1161
#1  solock+0x66 sys/kern/uipc_socket2.c:292
#2  sosend+0x52c sys/kern/uipc_socket.c:501
#3  sendit+0x52c sys/kern/uipc_syscalls.c:662
#4  sys_sendto+0x80 sys/kern/uipc_syscalls.c:527
#5  syscall+0x552 mi_syscall sys/sys/syscall_mi.h:99 [inline]
#5  syscall+0x552 sys/arch/amd64/amd64/trap.c:574
#6  Xsyscall+0x128
ddb{1}> show malloc
           Type InUse  MemUse  HighUse   Limit  Requests Type Lim Kern Lim
         devbuf  9450   6382K    6383K  78643K     10537        0        0
            pcb    27      9K       9K  78643K        62        0        0
         rtable    65      2K       2K  78643K       136        0        0
         ifaddr    25      7K       7K  78643K        26        0        0
       counters    39     33K      33K  78643K        39        0        0
       ioctlops     0      0K       4K  78643K      1467        0        0
          mount     1      1K       1K  78643K         1        0        0
         vnodes  1175     74K      74K  78643K      1180        0        0
      UFS quota     1     32K      32K  78643K         1        0        0
      UFS mount     5     36K      36K  78643K         5        0        0
            shm     2      1K       1K  78643K         2        0        0
         VM map     2      1K       1K  78643K         2        0        0
            sem     2      0K       0K  78643K         2        0        0
        dirhash    12      2K       2K  78643K        12        0        0
           ACPI  1808    196K     290K  78643K     12628        0        0
      file desc     1      0K       0K  78643K         1        0        0
           proc    52     50K      58K  78643K       279        0        0
    NFS srvsock     1      0K       0K  78643K         1        0        0
     NFS daemon     1     16K      16K  78643K         1        0        0
       in_multi    11      0K       0K  78643K        11        0        0
    ether_multi     1      0K       0K  78643K         1        0        0
    ISOFS mount     1     32K      32K  78643K         1        0        0
  MSDOSFS mount     1     16K      16K  78643K         1        0        0
           ttys    18     79K      79K  78643K        18        0        0
           exec     0      0K       1K  78643K       179        0        0
        pagedep     1      8K       8K  78643K         1        0        0
       inodedep     1     32K      32K  78643K         1        0        0
         newblk     1      0K       0K  78643K         1        0        0
        VM swap     7     26K      26K  78643K         7        0        0
       UVM amap    58      3K       3K  78643K       817        0        0
       UVM aobj     2      2K       2K  78643K         2        0        0
        memdesc     1      4K       4K  78643K         1        0        0
    crypto data     1      1K       1K  78643K         1        0        0
            NDP     4      0K       0K  78643K         4        0        0
           temp    40   2712K    2776K  78643K      2007        0        0
      SYN cache     2     16K      16K  78643K         2        0        0
ddb{1}> show all pools
Name      Size Requests Fail Releases Pgreq Pgrel Npage Hiwat Minpg Maxpg Idle
arp         64        2    0        0     1     0     1     1     0     8    0
inpcbpl    280       29    0       23     1     0     1     1     0     8    0
plimitpl   152       14    0        8     1     0     1     1     0     8    0
plcache    128       20    0        0     1     0     1     1     0     8    0
rtentry    112       24    0        1     1     0     1     1     0     8    0
syncache   264        5    0        5     1     0     1     1     0     8    1
tcpcb      544        8    0        5     1     0     1     1     0     8    0
pfosfp      40      846    0      423     5     0     5     5     0     8    0
pfosfpen   112     1428    0      714    21     0    21    21     0     8    0
pfstitem    24        8    0        0     1     0     1     1     0     8    0
pfstkey    112        8    0        0     1     0     1     1     0     8    0
pfstate    328        8    0        0     1     0     1     1     0     8    0
pfrule     1360      21    0       16     2     1     1     2     0     8    0
art_heap8  4096       1    0        0     1     0     1     1     0     8    0
art_heap4  256      102    0        0     7     0     7     7     0     8    0
art_table   32      103    0        0     1     0     1     1     0     8    0
art_node    16       23    0        2     1     0     1     1     0     8    0
dirhash    1024      17    0        0     3     0     3     3     0     8    0
dino1pl    128     1394    0       17    45     0    45    45     0     8    0
ffsino     272     1394    0       17    92     0    92    92     0     8    0
nchpl      144     1567    0       32    57     0    57    57     0     8    0
uvmvnodes   72     1404    0        0    26     0    26    26     0     8    0
vnodes     200     1404    0        0    74     0    74    74     0     8    0
namei      1024    3555    0     3555     2     1     1     1     0     8    1
percpumem   16       30    0        0     1     0     1     1     0     8    0
scxspl     192     2452    0     2452     8     2     6     6     0     8    6
sigapl     432      207    0      194     2     0     2     2     0     8    0
knotepl    112        5    0        0     1     0     1     1     0     8    0
kqueuepl   104        1    0        0     1     0     1     1     0     8    0
pipepl     112      134    0      127     2     1     1     1     0     8    0
fdescpl    488      208    0      194     3     0     3     3     0     8    0
filepl     152      964    0      915     2     0     2     2     0     8    0
lockfpl    104        6    0        6     1     1     0     1     0     8    0
lockfspl    48        3    0        3     1     1     0     1     0     8    0
sessionpl  112       18    0        9     1     0     1     1     0     8    0
pgrppl      48       18    0        9     1     0     1     1     0     8    0
ucredpl     96       52    0       43     1     0     1     1     0     8    0
zombiepl   144      194    0      194     2     1     1     1     0     8    1
processpl  840      223    0      194     4     0     4     4     0     8    0
procpl     600      223    0      194     3     0     3     3     0     8    0
sockpl     384       78    0       58     3     0     3     3     0     8    1
mcl4k      4096       5    0        0     1     0     1     1     0     8    0
mcl2k      2048      56    0        0     7     0     7     7     0     8    0
mtagpl      80        1    0        0     1     0     1     1     0     8    0
mbufpl     256       82    0        0     5     0     5     5     0     8    0
bufpl      256     2162    0      287   118     0   118   118     0     8    0
anonpl      16    19428    0    18204     8     2     6     7     0   125    1
amapchunkpl 152     554    0      516     2     0     2     2     0   158    0
amappl16   192       83    0       77     1     0     1     1     0     8    0
amappl14   176       16    0       15     2     1     1     1     0     8    0
amappl12   160        7    0        7     1     0     1     1     0     8    1
amappl11   152       45    0       27     1     0     1     1     0     8    0
amappl10   144       62    0       60     1     0     1     1     0     8    0
amappl9    136      425    0      424     1     0     1     1     0     8    0
amappl8    128      101    0       97     1     0     1     1     0     8    0
amappl7    120       18    0       17     1     0     1     1     0     8    0
amappl6    112       45    0       41     1     0     1     1     0     8    0
amappl5    104      113    0       98     1     0     1     1     0     8    0
amappl4     96      376    0      356     1     0     1     1     0     8    0
amappl3     88      163    0      152     1     0     1     1     0     8    0
amappl2     80      848    0      794     3     1     2     2     0     8    0
amappl1     72    13423    0    13008    15     5    10    15     0     8    0
amappl      80      428    0      406     1     0     1     1     0    84    0
dma4096    4096       1    0        1     1     1     0     1     0     8    0
dma256     256        6    0        6     1     1     0     1     0     8    0
dma64       64      259    0      259     1     1     0     1     0     8    0
dma32       32        7    0        7     1     1     0     1     0     8    0
dma16       16       17    0       17     1     1     0     1     0     8    0
aobjpl      64        1    0        0     1     0     1     1     0     8    0
uaddrrnd    24      208    0      194     1     0     1     1     0     8    0
uaddrbest   32        2    0        0     1     0     1     1     0     8    0
uaddr       24      208    0      194     1     0     1     1     0     8    0
vmmpekpl   168     5600    0     5578     2     0     2     2     0     8    0
vmmpepl    168    28736    0    27922    50    11    39    47     0   357    1
vmsppl     360      207    0      194     2     0     2     2     0     8    0
pdppl      4096     424    0      388     6     0     6     6     0     8    0
pvpl        32    80756    0    77743    31     3    28    28     0   265    3
pmappl     232      207    0      194     1     0     1     1     0     8    0
extentpl    40       41    0       26     1     0     1     1     0     8    0
phpool     112      247    0        4     7     0     7     7     0     8    0

Crashes (79):
Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Title
ci-openbsd-multicore 2019/05/24 01:38 openbsd df989dde9731 0dadcd9d .config log report syz C
ci-openbsd-main 2019/05/23 23:54 openbsd df989dde9731 0dadcd9d .config log report syz
ci-openbsd-main 2019/06/03 03:42 openbsd 5d24dd80fef3 53c81ea5 .config log report
ci-openbsd-main 2019/06/03 02:35 openbsd 5d24dd80fef3 53c81ea5 .config log report
ci-openbsd-main 2019/06/03 00:24 openbsd 5d24dd80fef3 53c81ea5 .config log report
ci-openbsd-main 2019/06/02 22:23 openbsd 5d24dd80fef3 53c81ea5 .config log report
ci-openbsd-multicore 2019/06/02 20:49 openbsd 5d24dd80fef3 53c81ea5 .config log report
ci-openbsd-main 2019/06/02 18:38 openbsd 5d24dd80fef3 53c81ea5 .config log report
ci-openbsd-main 2019/06/02 17:33 openbsd 5d24dd80fef3 53c81ea5 .config log report
ci-openbsd-multicore 2019/06/02 16:01 openbsd 5d24dd80fef3 53c81ea5 .config log report
ci-openbsd-main 2019/05/31 08:19 openbsd 2fcfb473f30c d9aaf3c2 .config log report
ci-openbsd-main 2019/05/30 22:59 openbsd 1f4d754ac3a0 d9aaf3c2 .config log report
ci-openbsd-main 2019/05/30 21:44 openbsd 1f4d754ac3a0 d9aaf3c2 .config log report
ci-openbsd-main 2019/05/30 20:18 openbsd 1f4d754ac3a0 d9aaf3c2 .config log report
ci-openbsd-multicore 2019/05/30 01:25 openbsd 7e4900cc8c0d d9aaf3c2 .config log report
ci-openbsd-main 2019/05/28 06:27 openbsd 3ca64fa9ea2e 6bd61501 .config log report
ci-openbsd-main 2019/05/28 05:20 openbsd 3ca64fa9ea2e 6bd61501 .config log report
ci-openbsd-main 2019/05/28 03:35 openbsd 3ca64fa9ea2e 6bd61501 .config log report
ci-openbsd-main 2019/05/28 02:14 openbsd 3ca64fa9ea2e 6bd61501 .config log report
ci-openbsd-main 2019/05/28 00:57 openbsd 3ca64fa9ea2e 6bd61501 .config log report
ci-openbsd-main 2019/05/28 00:52 openbsd 3ca64fa9ea2e 6bd61501 .config log report
ci-openbsd-main 2019/05/27 22:17 openbsd 3ca64fa9ea2e 6bd61501 .config log report
ci-openbsd-main 2019/05/27 20:30 openbsd 1acca8f20b1a 562efd79 .config log report
ci-openbsd-main 2019/05/27 19:51 openbsd 1acca8f20b1a 562efd79 .config log report
ci-openbsd-main 2019/05/27 19:23 openbsd 1acca8f20b1a 562efd79 .config log report
ci-openbsd-main 2019/05/27 19:05 openbsd 1acca8f20b1a 562efd79 .config log report
ci-openbsd-main 2019/05/27 18:58 openbsd 1acca8f20b1a 562efd79 .config log report
ci-openbsd-main 2019/05/27 16:25 openbsd 1acca8f20b1a 562efd79 .config log report
ci-openbsd-main 2019/05/27 16:25 openbsd 1acca8f20b1a 562efd79 .config log report
ci-openbsd-main 2019/05/27 15:18 openbsd 1acca8f20b1a 562efd79 .config log report
ci-openbsd-main 2019/05/27 15:15 openbsd 1acca8f20b1a 562efd79 .config log report
ci-openbsd-main 2019/05/27 14:56 openbsd 1acca8f20b1a 562efd79 .config log report
ci-openbsd-main 2019/05/27 14:41 openbsd 1acca8f20b1a 562efd79 .config log report
ci-openbsd-main 2019/05/27 14:30 openbsd 1acca8f20b1a 562efd79 .config log report
ci-openbsd-main 2019/05/27 13:54 openbsd 1acca8f20b1a 562efd79 .config log report
ci-openbsd-main 2019/05/27 12:03 openbsd 1acca8f20b1a 562efd79 .config log report
ci-openbsd-main 2019/05/27 11:58 openbsd 1acca8f20b1a 562efd79 .config log report
ci-openbsd-main 2019/05/27 11:24 openbsd 1acca8f20b1a 562efd79 .config log report
ci-openbsd-main 2019/05/27 09:19 openbsd 1acca8f20b1a 562efd79 .config log report
ci-openbsd-main 2019/05/27 09:13 openbsd 1acca8f20b1a 562efd79 .config log report
ci-openbsd-main 2019/05/27 08:43 openbsd 95c8efefea12 85c57315 .config log report
ci-openbsd-main 2019/05/27 08:27 openbsd 95c8efefea12 85c57315 .config log report
ci-openbsd-main 2019/05/27 08:14 openbsd 95c8efefea12 85c57315 .config log report
ci-openbsd-main 2019/05/27 07:50 openbsd 95c8efefea12 85c57315 .config log report
ci-openbsd-main 2019/05/27 06:02 openbsd 95c8efefea12 85c57315 .config log report
ci-openbsd-main 2019/05/27 04:40 openbsd 95c8efefea12 85c57315 .config log report
ci-openbsd-main 2019/05/27 04:39 openbsd 95c8efefea12 85c57315 .config log report
ci-openbsd-main 2019/05/27 02:23 openbsd 95c8efefea12 85c57315 .config log report
ci-openbsd-main 2019/05/27 02:04 openbsd 95c8efefea12 85c57315 .config log report
ci-openbsd-main 2019/05/24 20:19 openbsd b21d7bd479d1 0dadcd9d .config log report
ci-openbsd-main 2019/05/24 10:13 openbsd b21d7bd479d1 0dadcd9d .config log report
ci-openbsd-multicore 2019/05/24 09:51 openbsd b21d7bd479d1 0dadcd9d .config log report
ci-openbsd-main 2019/05/24 09:33 openbsd b21d7bd479d1 0dadcd9d .config log report
ci-openbsd-multicore 2019/05/23 23:48 openbsd df989dde9731 0dadcd9d .config log report
ci-openbsd-multicore 2019/05/23 22:21 openbsd df989dde9731 0dadcd9d .config log report
ci-openbsd-main 2019/05/23 21:28 openbsd df989dde9731 0dadcd9d .config log report
ci-openbsd-main 2019/05/23 21:12 openbsd df989dde9731 0dadcd9d .config log report
ci-openbsd-main 2019/05/23 20:33 openbsd df989dde9731 0dadcd9d .config log report
* Struck through repros no longer work on HEAD.