syzbot


KASAN: use-after-free Read in nla_strlcpy

Status: fixed on 2018/06/07 13:52
Subsystems: netfilter
[Documentation on labels]
Fix commit: 4b83a9049a98 netfilter: provide correct argument to nla_strlcpy()
First crash: 2224d, last: 2211d

Sample crash report:
random: sshd: uninitialized urandom read (32 bytes read)
random: sshd: uninitialized urandom read (32 bytes read)
random: sshd: uninitialized urandom read (32 bytes read)
random: sshd: uninitialized urandom read (32 bytes read)
==================================================================
BUG: KASAN: use-after-free in nla_strlcpy+0x13d/0x150 lib/nlattr.c:314
Read of size 1 at addr ffff8801adad6c9d by task syz-executor150/4520

CPU: 0 PID: 4520 Comm: syz-executor150 Not tainted 4.17.0-rc7+ #73
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x1b9/0x294 lib/dump_stack.c:113
 print_address_description+0x6c/0x20b mm/kasan/report.c:256
 kasan_report_error mm/kasan/report.c:354 [inline]
 kasan_report.cold.7+0x242/0x2fe mm/kasan/report.c:412
 __asan_report_load1_noabort+0x14/0x20 mm/kasan/report.c:430
 nla_strlcpy+0x13d/0x150 lib/nlattr.c:314
 nfnl_acct_new+0x574/0xc50 net/netfilter/nfnetlink_acct.c:118
 nfnetlink_rcv_msg+0xdb5/0xff0 net/netfilter/nfnetlink.c:212
 netlink_rcv_skb+0x172/0x440 net/netlink/af_netlink.c:2448
 nfnetlink_rcv+0x1fe/0x1ba0 net/netfilter/nfnetlink.c:513
 netlink_unicast_kernel net/netlink/af_netlink.c:1310 [inline]
 netlink_unicast+0x58b/0x740 net/netlink/af_netlink.c:1336
 netlink_sendmsg+0x9f0/0xfa0 net/netlink/af_netlink.c:1901
 sock_sendmsg_nosec net/socket.c:629 [inline]
 sock_sendmsg+0xd5/0x120 net/socket.c:639
 sock_write_iter+0x35a/0x5a0 net/socket.c:908
 call_write_iter include/linux/fs.h:1784 [inline]
 new_sync_write fs/read_write.c:474 [inline]
 __vfs_write+0x64d/0x960 fs/read_write.c:487
 vfs_write+0x1f8/0x560 fs/read_write.c:549
 ksys_write+0xf9/0x250 fs/read_write.c:598
 __do_sys_write fs/read_write.c:610 [inline]
 __se_sys_write fs/read_write.c:607 [inline]
 __x64_sys_write+0x73/0xb0 fs/read_write.c:607
 do_syscall_64+0x1b1/0x800 arch/x86/entry/common.c:287
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x43fcd9
RSP: 002b:00007fff7fa48948 EFLAGS: 00000213 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 000000000043fcd9
RDX: 000000000000007b RSI: 0000000020000080 RDI: 0000000000000003
RBP: 00000000006ca018 R08: 00000000004002c8 R09: 00000000004002c8
R10: 00000000004002c8 R11: 0000000000000213 R12: 0000000000401600
R13: 0000000000401690 R14: 0000000000000000 R15: 0000000000000000

Allocated by task 2848:
 save_stack+0x43/0xd0 mm/kasan/kasan.c:448
 set_track mm/kasan/kasan.c:460 [inline]
 kasan_kmalloc+0xc4/0xe0 mm/kasan/kasan.c:553
 kasan_slab_alloc+0x12/0x20 mm/kasan/kasan.c:490
 kmem_cache_alloc+0x12e/0x760 mm/slab.c:3554
 getname_flags+0xd0/0x5a0 fs/namei.c:140
 getname+0x19/0x20 fs/namei.c:211
 do_sys_open+0x39a/0x740 fs/open.c:1087
 __do_sys_open fs/open.c:1111 [inline]
 __se_sys_open fs/open.c:1106 [inline]
 __x64_sys_open+0x7e/0xc0 fs/open.c:1106
 do_syscall_64+0x1b1/0x800 arch/x86/entry/common.c:287
 entry_SYSCALL_64_after_hwframe+0x49/0xbe

Freed by task 2848:
 save_stack+0x43/0xd0 mm/kasan/kasan.c:448
 set_track mm/kasan/kasan.c:460 [inline]
 __kasan_slab_free+0x11a/0x170 mm/kasan/kasan.c:521
 kasan_slab_free+0xe/0x10 mm/kasan/kasan.c:528
 __cache_free mm/slab.c:3498 [inline]
 kmem_cache_free+0x86/0x2d0 mm/slab.c:3756
 putname+0xf2/0x130 fs/namei.c:261
 do_sys_open+0x554/0x740 fs/open.c:1102
 __do_sys_open fs/open.c:1111 [inline]
 __se_sys_open fs/open.c:1106 [inline]
 __x64_sys_open+0x7e/0xc0 fs/open.c:1106
 do_syscall_64+0x1b1/0x800 arch/x86/entry/common.c:287
 entry_SYSCALL_64_after_hwframe+0x49/0xbe

The buggy address belongs to the object at ffff8801adad6c80
 which belongs to the cache names_cache of size 4096
The buggy address is located 29 bytes inside of
 4096-byte region [ffff8801adad6c80, ffff8801adad7c80)
The buggy address belongs to the page:
page:ffffea0006b6b580 count:1 mapcount:0 mapping:ffff8801adad6c80 index:0x0 compound_mapcount: 0
flags: 0x2fffc0000008100(slab|head)
raw: 02fffc0000008100 ffff8801adad6c80 0000000000000000 0000000100000001
raw: ffffea0006b545a0 ffffea0006b53d20 ffff8801da988dc0 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff8801adad6b80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
 ffff8801adad6c00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
>ffff8801adad6c80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                            ^
 ffff8801adad6d00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff8801adad6d80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================

Crashes (59):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2018/05/29 22:55 upstream 3d661e2a2d1c e276de77 .config console log report syz C ci-upstream-kasan-gce-root
2018/05/26 21:25 upstream bc2dbc5420e8 f48c20b8 .config console log report syz C ci-upstream-kasan-gce-root
2018/05/26 20:14 upstream bc2dbc5420e8 f48c20b8 .config console log report syz C ci-upstream-kasan-gce
2018/05/26 20:02 upstream bc2dbc5420e8 f48c20b8 .config console log report syz C ci-upstream-kasan-gce
2018/05/21 18:25 upstream 6741c4bb389d f48c20b8 .config console log report syz C ci-upstream-kasan-gce
2018/05/26 20:37 net-next-old e52cde717093 f48c20b8 .config console log report syz C ci-upstream-net-kasan-gce
2018/05/26 20:14 net-next-old e52cde717093 f48c20b8 .config console log report syz C ci-upstream-net-kasan-gce
2018/05/29 23:12 upstream 3d661e2a2d1c e276de77 .config console log report syz ci-upstream-kasan-gce-386
2018/05/26 20:29 upstream bc2dbc5420e8 f48c20b8 .config console log report syz ci-upstream-kasan-gce-386
2018/05/26 20:16 upstream bc2dbc5420e8 f48c20b8 .config console log report syz ci-upstream-kasan-gce-386
2018/05/26 20:04 upstream bc2dbc5420e8 f48c20b8 .config console log report syz ci-upstream-kasan-gce-386
2018/05/21 18:53 upstream 6741c4bb389d f48c20b8 .config console log report syz ci-upstream-kasan-gce-386
2018/05/21 18:39 upstream 6741c4bb389d f48c20b8 .config console log report syz ci-upstream-kasan-gce-386
2018/06/02 23:29 upstream 4277e6b9fd44 2f93b54f .config console log report ci-upstream-kasan-gce
2018/06/01 20:31 upstream 0512e0134582 2f93b54f .config console log report ci-upstream-kasan-gce-root
2018/06/01 14:28 upstream 0512e0134582 2f93b54f .config console log report ci-upstream-kasan-gce
2018/05/31 13:39 upstream 88a867653065 2f93b54f .config console log report ci-upstream-kasan-gce
2018/05/30 11:25 upstream 0044cdeb7313 2f93b54f .config console log report ci-upstream-kasan-gce
2018/05/29 10:10 upstream 786b71f5b754 f48c20b8 .config console log report ci-upstream-kasan-gce
2018/05/28 09:55 upstream b04e217704b7 f48c20b8 .config console log report ci-upstream-kasan-gce-root
2018/05/28 07:08 upstream 861d9dd37526 f48c20b8 .config console log report ci-upstream-kasan-gce-root
2018/05/27 07:06 upstream 7fbb6157630f f48c20b8 .config console log report ci-upstream-kasan-gce-root
2018/05/26 05:58 upstream 62d18ecfa641 f48c20b8 .config console log report ci-upstream-kasan-gce-root
2018/05/26 05:15 upstream 62d18ecfa641 f48c20b8 .config console log report ci-upstream-kasan-gce
2018/05/23 09:58 upstream a048a07d7f45 f48c20b8 .config console log report ci-upstream-kasan-gce
2018/05/23 00:31 upstream a048a07d7f45 f48c20b8 .config console log report ci-upstream-kasan-gce
2018/05/21 18:00 upstream 6741c4bb389d f48c20b8 .config console log report ci-upstream-kasan-gce
2018/06/01 06:37 upstream dd52cb879063 2f93b54f .config console log report ci-upstream-kasan-gce-386
2018/05/29 09:07 upstream 786b71f5b754 f48c20b8 .config console log report ci-upstream-kasan-gce-386
2018/05/29 04:29 upstream 786b71f5b754 f48c20b8 .config console log report ci-upstream-kasan-gce-386
2018/05/28 08:25 upstream b04e217704b7 f48c20b8 .config console log report ci-upstream-kasan-gce-386
2018/05/27 09:29 upstream 7fbb6157630f f48c20b8 .config console log report ci-upstream-kasan-gce-386
2018/05/26 18:29 upstream bc2dbc5420e8 f48c20b8 .config console log report ci-upstream-kasan-gce-386
2018/05/26 03:21 upstream 62d18ecfa641 f48c20b8 .config console log report ci-upstream-kasan-gce-386
2018/05/25 04:47 upstream d883c6cf3b39 f48c20b8 .config console log report ci-upstream-kasan-gce-386
2018/05/24 17:47 upstream bee797529d7c f48c20b8 .config console log report ci-upstream-kasan-gce-386
2018/05/24 04:55 upstream bee797529d7c f48c20b8 .config console log report ci-upstream-kasan-gce-386
2018/05/22 10:52 upstream a048a07d7f45 f48c20b8 .config console log report ci-upstream-kasan-gce-386
2018/06/03 14:52 net-next-old eaf47b17a77f 2f93b54f .config console log report ci-upstream-net-kasan-gce
2018/06/03 01:06 net-next-old 1ffdd8e1643f 2f93b54f .config console log report ci-upstream-net-kasan-gce
2018/06/02 21:26 net-next-old 1ffdd8e1643f 2f93b54f .config console log report ci-upstream-net-kasan-gce
2018/06/02 20:04 net-next-old 1ffdd8e1643f 2f93b54f .config console log report ci-upstream-net-kasan-gce
2018/06/02 01:16 net-next-old af066ed3d455 2f93b54f .config console log report ci-upstream-net-kasan-gce
2018/05/31 15:30 net-next-old 37c9102f216c 2f93b54f .config console log report ci-upstream-net-kasan-gce
2018/05/31 03:36 net-next-old 37c9102f216c 2f93b54f .config console log report ci-upstream-net-kasan-gce
2018/05/31 01:20 net-next-old 37c9102f216c 2f93b54f .config console log report ci-upstream-net-kasan-gce
2018/05/29 14:33 net-next-old f03329627b46 e276de77 .config console log report ci-upstream-net-kasan-gce
2018/05/27 06:24 net-next-old 5b79c2af667c f48c20b8 .config console log report ci-upstream-net-kasan-gce
2018/05/26 11:24 net-next-old e52cde717093 f48c20b8 .config console log report ci-upstream-net-kasan-gce
2018/05/26 11:16 net-next-old e52cde717093 f48c20b8 .config console log report ci-upstream-net-kasan-gce
2018/05/26 05:35 net-next-old 9c5904904b88 f48c20b8 .config console log report ci-upstream-net-kasan-gce
2018/05/26 05:12 net-next-old 9c5904904b88 f48c20b8 .config console log report ci-upstream-net-kasan-gce
2018/05/25 07:42 net-next-old d97cde6ab547 f48c20b8 .config console log report ci-upstream-net-kasan-gce
2018/05/25 03:21 net-next-old 13405468f49d f48c20b8 .config console log report ci-upstream-net-kasan-gce
2018/05/24 03:26 net-next-old 7c08c41f779e f48c20b8 .config console log report ci-upstream-net-kasan-gce
2018/05/22 22:59 net-next-old 9c803cfd5fe2 f48c20b8 .config console log report ci-upstream-net-kasan-gce
2018/05/22 18:03 net-next-old e3bb946cd922 f48c20b8 .config console log report ci-upstream-net-kasan-gce
2018/05/22 10:12 net-next-old e3bb946cd922 f48c20b8 .config console log report ci-upstream-net-kasan-gce
* Struck through repros no longer work on HEAD.