syzbot

loop3: detected capacity change from 0 to 32768
ocfs2: Mounting device (7,3) on (node local, slot 0) with writeback data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.3.72/4664 is trying to acquire lock:
ffff888050186650 (sb_internal#4){.+.+}-{0:0}, at: ocfs2_write_begin_inline fs/ocfs2/aops.c:1481 [inline]
ffff888050186650 (sb_internal#4){.+.+}-{0:0}, at: ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1584 [inline]
ffff888050186650 (sb_internal#4){.+.+}-{0:0}, at: ocfs2_write_begin_nolock+0x1ca5/0x4270 fs/ocfs2/aops.c:1670

but task is already holding lock:
ffff88805ccc5be0 (&oi->ip_alloc_sem){++++}-{3:3}, at: ocfs2_write_begin+0x195/0x300 fs/ocfs2/aops.c:1902

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&oi->ip_alloc_sem){++++}-{3:3}:
       down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520
       ocfs2_read_virt_blocks+0x265/0x950 fs/ocfs2/extent_map.c:984
       ocfs2_read_dir_block+0xd3/0x4d0 fs/ocfs2/dir.c:508
       ocfs2_dir_foreach_blk_el fs/ocfs2/dir.c:1842 [inline]
       ocfs2_dir_foreach_blk+0x27e/0x1990 fs/ocfs2/dir.c:1928
       ocfs2_dir_foreach+0x15d/0x1b0 fs/ocfs2/dir.c:1938
       ocfs2_empty_dir+0xfe/0x5f0 fs/ocfs2/dir.c:2156
       ocfs2_rename+0x212c/0x3820 fs/ocfs2/namei.c:1499
       vfs_rename+0xbbf/0x10d0 fs/namei.c:4882
       do_renameat2+0x89d/0xc70 fs/namei.c:5035
       __do_sys_rename fs/namei.c:5081 [inline]
       __se_sys_rename fs/namei.c:5079 [inline]
       __x64_sys_rename+0x82/0x90 fs/namei.c:5079
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0x1f49/0x2150 fs/jbd2/transaction.c:463
       jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:520
       jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:559
       ocfs2_start_trans+0x372/0x6c0 fs/ocfs2/journal.c:376
       ocfs2_modify_bh+0xe5/0x460 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x13b1/0x16e0 fs/ocfs2/quota_local.c:764
       dquot_load_quota_sb+0x756/0xac0 fs/quota/dquot.c:2470
       dquot_load_quota_inode+0x2d8/0x5d0 fs/quota/dquot.c:2507
       ocfs2_enable_quotas+0x1c3/0x440 fs/ocfs2/super.c:926
       ocfs2_fill_super+0x409f/0x4d00 fs/ocfs2/super.c:1139
       mount_bdev+0x287/0x3c0 fs/super.c:1443
       legacy_get_tree+0xe6/0x180 fs/fs_context.c:632
       vfs_get_tree+0x88/0x270 fs/super.c:1573
       do_new_mount+0x24a/0xa40 fs/namespace.c:3078
       do_mount fs/namespace.c:3421 [inline]
       __do_sys_mount fs/namespace.c:3629 [inline]
       __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3606
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x366/0x6c0 fs/ocfs2/journal.c:374
       ocfs2_modify_bh+0xe5/0x460 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x13b1/0x16e0 fs/ocfs2/quota_local.c:764
       dquot_load_quota_sb+0x756/0xac0 fs/quota/dquot.c:2470
       dquot_load_quota_inode+0x2d8/0x5d0 fs/quota/dquot.c:2507
       ocfs2_enable_quotas+0x1c3/0x440 fs/ocfs2/super.c:926
       ocfs2_fill_super+0x409f/0x4d00 fs/ocfs2/super.c:1139
       mount_bdev+0x287/0x3c0 fs/super.c:1443
       legacy_get_tree+0xe6/0x180 fs/fs_context.c:632
       vfs_get_tree+0x88/0x270 fs/super.c:1573
       do_new_mount+0x24a/0xa40 fs/namespace.c:3078
       do_mount fs/namespace.c:3421 [inline]
       __do_sys_mount fs/namespace.c:3629 [inline]
       __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3606
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (sb_internal#4){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
       lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1891 [inline]
       sb_start_intwrite include/linux/fs.h:2013 [inline]
       ocfs2_start_trans+0x267/0x6c0 fs/ocfs2/journal.c:372
       ocfs2_write_begin_inline fs/ocfs2/aops.c:1481 [inline]
       ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1584 [inline]
       ocfs2_write_begin_nolock+0x1ca5/0x4270 fs/ocfs2/aops.c:1670
       ocfs2_write_begin+0x1b8/0x300 fs/ocfs2/aops.c:1904
       generic_perform_write+0x2db/0x560 mm/filemap.c:3846
       __generic_file_write_iter+0x172/0x430 mm/filemap.c:3974
       ocfs2_file_write_iter+0x1593/0x1df0 fs/ocfs2/file.c:2469
       do_iter_readv_writev fs/read_write.c:-1 [inline]
       do_iter_write+0x62d/0xaf0 fs/read_write.c:861
       vfs_writev fs/read_write.c:934 [inline]
       do_pwritev+0x201/0x340 fs/read_write.c:1031
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  sb_internal#4 --> jbd2_handle --> &oi->ip_alloc_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_alloc_sem);
                               lock(jbd2_handle);
                               lock(&oi->ip_alloc_sem);
  lock(sb_internal#4);

 *** DEADLOCK ***

3 locks held by syz.3.72/4664:
 #0: ffff888050186460 (sb_writers#26){.+.+}-{0:0}, at: vfs_writev fs/read_write.c:933 [inline]
 #0: ffff888050186460 (sb_writers#26){.+.+}-{0:0}, at: do_pwritev+0x1ef/0x340 fs/read_write.c:1031
 #1: ffff88805ccc5f48 (&sb->s_type->i_mutex_key#32){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #1: ffff88805ccc5f48 (&sb->s_type->i_mutex_key#32){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x438/0x1df0 fs/ocfs2/file.c:2399
 #2: ffff88805ccc5be0 (&oi->ip_alloc_sem){++++}-{3:3}, at: ocfs2_write_begin+0x195/0x300 fs/ocfs2/aops.c:1902

stack backtrace:
CPU: 1 PID: 4664 Comm: syz.3.72 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/02/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x168/0x22e lib/dump_stack.c:106
 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
 lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
 percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
 __sb_start_write include/linux/fs.h:1891 [inline]
 sb_start_intwrite include/linux/fs.h:2013 [inline]
 ocfs2_start_trans+0x267/0x6c0 fs/ocfs2/journal.c:372
 ocfs2_write_begin_inline fs/ocfs2/aops.c:1481 [inline]
 ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1584 [inline]
 ocfs2_write_begin_nolock+0x1ca5/0x4270 fs/ocfs2/aops.c:1670
 ocfs2_write_begin+0x1b8/0x300 fs/ocfs2/aops.c:1904
 generic_perform_write+0x2db/0x560 mm/filemap.c:3846
 __generic_file_write_iter+0x172/0x430 mm/filemap.c:3974
 ocfs2_file_write_iter+0x1593/0x1df0 fs/ocfs2/file.c:2469
 do_iter_readv_writev fs/read_write.c:-1 [inline]
 do_iter_write+0x62d/0xaf0 fs/read_write.c:861
 vfs_writev fs/read_write.c:934 [inline]
 do_pwritev+0x201/0x340 fs/read_write.c:1031
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f103198efc9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f1032807038 EFLAGS: 00000246 ORIG_RAX: 0000000000000148
RAX: ffffffffffffffda RBX: 00007f1031be5fa0 RCX: 00007f103198efc9
RDX: 0000000000000001 RSI: 00002000000001c0 RDI: 0000000000000005
RBP: 00007f1031a11f91 R08: 0000000000000000 R09: 0000000000000010
R10: 00000000ffffffff R11: 0000000000000246 R12: 0000000000000000
R13: 00007f1031be6038 R14: 00007f1031be5fa0 R15: 00007ffd0c08c6b8
 </TASK>