KASAN: use-after-free Read in netdevice_event_work

KASAN: use-after-free Read in netdevice_event_work_handler
Status: upstream: reported C repro on 2020/07/09 23:54
Reported-by: syzbot+20b90969babe05609947@syzkaller.appspotmail.com
First crash: 118d, last: 5h37m

Cause bisection: introduced by (bisect log):

commit d70c47c8dc6902db19555b7ff7e6eeb264d4ac06
Author: Heiner Kallweit <hkallweit1@gmail.com>
Date: Thu Apr 23 19:34:33 2020 +0000

net: phy: make phy_suspend a no-op if PHY is suspended already

Crash: unregister_netdevice: waiting for DEV to become free (log)
Repro: C syz .config

similar bugs (1):
Kernel	Title	Repro	Bisected	Count	Last	Reported	Patched	Status
linux-4.19	KASAN: use-after-free Read in netdevice_event_work_handler			3	9d00h	45d	0/1	upstream: reported on 2020/09/05 14:15

Patch testing requests:
Created	Duration	User	Patch	Repo	Result
2020/08/01 00:31	18m	coiby.xu@gmail.com		https://github.com/coiby/linux.git syzbot1	OK
2020/07/31 21:48	17m	rkovhaev@gmail.com	patch	upstream	OK
2020/07/31 13:39	12m	coiby.xu@gmail.com		https://github.com/coiby/linux.git syzbot1	report log
2020/07/31 06:28	0m	coiby.xu@gmail.com		git@github.com:coiby/linux.git syzbot1	error
2020/07/28 14:23	14m	rkovhaev@gmail.com		upstream	report log
2020/07/14 06:07	17m	rkovhaev@gmail.com		upstream	report log

Sample crash report:

==================================================================
BUG: KASAN: use-after-free in dev_put include/linux/netdevice.h:3853 [inline]
BUG: KASAN: use-after-free in netdevice_event_work_handler+0x15b/0x1b0 drivers/infiniband/core/roce_gid_mgmt.c:627
Read of size 8 at addr ffff88807b13e568 by task kworker/u4:0/7

CPU: 0 PID: 7 Comm: kworker/u4:0 Not tainted 5.8.0-rc4-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: gid-cache-wq netdevice_event_work_handler
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x18f/0x20d lib/dump_stack.c:118
 print_address_description.constprop.0.cold+0xae/0x436 mm/kasan/report.c:383
 __kasan_report mm/kasan/report.c:513 [inline]
 kasan_report.cold+0x1f/0x37 mm/kasan/report.c:530
 dev_put include/linux/netdevice.h:3853 [inline]
 netdevice_event_work_handler+0x15b/0x1b0 drivers/infiniband/core/roce_gid_mgmt.c:627
 process_one_work+0x94c/0x1670 kernel/workqueue.c:2269
 worker_thread+0x64c/0x1120 kernel/workqueue.c:2415
 kthread+0x3b5/0x4a0 kernel/kthread.c:291
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:293

Allocated by task 13061:
 save_stack+0x1b/0x40 mm/kasan/common.c:48
 set_track mm/kasan/common.c:56 [inline]
 __kasan_kmalloc.constprop.0+0xc2/0xd0 mm/kasan/common.c:494
 kmalloc_node include/linux/slab.h:578 [inline]
 kvmalloc_node+0x61/0xf0 mm/util.c:574
 kvmalloc include/linux/mm.h:753 [inline]
 kvzalloc include/linux/mm.h:761 [inline]
 alloc_netdev_mqs+0x97/0xdc0 net/core/dev.c:9938
 __ip_tunnel_create+0x201/0x580 net/ipv4/ip_tunnel.c:254
 ip_tunnel_init_net+0x32b/0x980 net/ipv4/ip_tunnel.c:1072
 ops_init+0xaf/0x470 net/core/net_namespace.c:151
 setup_net+0x2d8/0x850 net/core/net_namespace.c:341
 copy_net_ns+0x2cf/0x5e0 net/core/net_namespace.c:482
 create_new_namespaces+0x3f6/0xb10 kernel/nsproxy.c:110
 unshare_nsproxy_namespaces+0xbd/0x1f0 kernel/nsproxy.c:231
 ksys_unshare+0x36c/0x9a0 kernel/fork.c:2983
 __do_sys_unshare kernel/fork.c:3051 [inline]
 __se_sys_unshare kernel/fork.c:3049 [inline]
 __x64_sys_unshare+0x2d/0x40 kernel/fork.c:3049
 do_syscall_64+0x60/0xe0 arch/x86/entry/common.c:384
 entry_SYSCALL_64_after_hwframe+0x44/0xa9

Freed by task 13061:
 save_stack+0x1b/0x40 mm/kasan/common.c:48
 set_track mm/kasan/common.c:56 [inline]
 kasan_set_free_info mm/kasan/common.c:316 [inline]
 __kasan_slab_free+0xf5/0x140 mm/kasan/common.c:455
 __cache_free mm/slab.c:3426 [inline]
 kfree+0x103/0x2c0 mm/slab.c:3757
 kvfree+0x42/0x50 mm/util.c:603
 device_release+0x71/0x200 drivers/base/core.c:1559
 kobject_cleanup lib/kobject.c:693 [inline]
 kobject_release lib/kobject.c:722 [inline]
 kref_put include/linux/kref.h:65 [inline]
 kobject_put+0x1c0/0x270 lib/kobject.c:739
 put_device+0x1b/0x30 drivers/base/core.c:2779
 free_netdev+0x35d/0x480 net/core/dev.c:10054
 __ip_tunnel_create+0x48f/0x580 net/ipv4/ip_tunnel.c:274
 ip_tunnel_init_net+0x32b/0x980 net/ipv4/ip_tunnel.c:1072
 ops_init+0xaf/0x470 net/core/net_namespace.c:151
 setup_net+0x2d8/0x850 net/core/net_namespace.c:341
 copy_net_ns+0x2cf/0x5e0 net/core/net_namespace.c:482
 create_new_namespaces+0x3f6/0xb10 kernel/nsproxy.c:110
 unshare_nsproxy_namespaces+0xbd/0x1f0 kernel/nsproxy.c:231
 ksys_unshare+0x36c/0x9a0 kernel/fork.c:2983
 __do_sys_unshare kernel/fork.c:3051 [inline]
 __se_sys_unshare kernel/fork.c:3049 [inline]
 __x64_sys_unshare+0x2d/0x40 kernel/fork.c:3049
 do_syscall_64+0x60/0xe0 arch/x86/entry/common.c:384
 entry_SYSCALL_64_after_hwframe+0x44/0xa9

The buggy address belongs to the object at ffff88807b13e000
 which belongs to the cache kmalloc-4k of size 4096
The buggy address is located 1384 bytes inside of
 4096-byte region [ffff88807b13e000, ffff88807b13f000)
The buggy address belongs to the page:
page:ffffea0001ec4f80 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 head:ffffea0001ec4f80 order:1 compound_mapcount:0
flags: 0xfffe0000010200(slab|head)
raw: 00fffe0000010200 ffffea0001ecce88 ffffea0001987988 ffff8880aa002000
raw: 0000000000000000 ffff88807b13e000 0000000100000001 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff88807b13e400: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff88807b13e480: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
>ffff88807b13e500: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                                                          ^
 ffff88807b13e580: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff88807b13e600: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================

Crashes (186):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	VM info	Maintainers
ci-upstream-kasan-gce-selinux-root	2020/07/09 23:42	upstream	0bddd227	bc238812	.config	log	report	syz	C		dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-kasan-gce-root	2020/07/09 01:49	upstream	0bddd227	bc238812	.config	log	report	syz			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-kasan-gce-selinux-root	2020/10/20 15:18	upstream	270315b8	ff4a3345	.config	log	report			info	ap420073@gmail.com, davem@davemloft.net, dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-kasan-gce-root	2020/10/10 06:05	upstream	6f2f486d	93817d89	.config	log	report			info	ap420073@gmail.com, davem@davemloft.net, dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-kasan-gce-root	2020/10/08 09:59	upstream	c85fb28b	1880b4a9	.config	log	report			info	ap420073@gmail.com, davem@davemloft.net, dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-kasan-gce-selinux-root	2020/10/03 04:39	upstream	d3d45f82	2653fa43	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-kasan-gce	2020/09/29 18:07	upstream	fb0155a0	1b88c6d5	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-kasan-gce	2020/09/25 00:13	upstream	c9c9e6a4	54289b08	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-kasan-gce-selinux-root	2020/09/22 06:09	upstream	98477740	9e1fa68e	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-kasan-gce-386	2020/07/27 20:09	upstream	92ed3019	cb93dc6a	.config	log	report				dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/10/15 16:55	net	2ef813b8	63869021	.config	log	report			info	ap420073@gmail.com, davem@davemloft.net, dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/10/08 21:52	net	28802e7c	92390980	.config	log	report			info	ap420073@gmail.com, davem@davemloft.net, dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-bpf-kasan-gce	2020/10/01 03:11	bpf	9cf51446	8516f6d3	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/09/30 20:44	net	2b3e981a	8516f6d3	.config	log	report			info	ap420073@gmail.com, davem@davemloft.net, dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/09/26 22:31	net	5e46e43c	2d5ea0cb	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/09/26 11:25	net	5e46e43c	4a006f63	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/09/25 14:17	net	7241c5a6	54289b08	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/09/24 01:03	net	805c6d3c	287cd75a	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/09/22 12:57	net	25b8ab91	9e1fa68e	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-bpf-kasan-gce	2020/09/21 19:39	bpf	ba2fd563	9e1fa68e	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/09/21 11:13	net	e1b81391	9e1fa68e	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/09/20 14:54	net	f13d783a	9564d2e9	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-bpf-kasan-gce	2020/09/15 12:31	bpf	65dce596	6989d6f6	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/09/14 02:52	net	5760d9ac	2d3cdd63	.config	log	report				dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/09/10 10:21	net	a19454b6	409809d8	.config	log	report				dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/09/10 06:33	net	a19454b6	409809d8	.config	log	report				dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/09/07 19:53	net	72bbee2a	abf9ba4f	.config	log	report				dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-bpf-kasan-gce	2020/09/06 11:29	bpf	e6135df4	abf9ba4f	.config	log	report				dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/09/04 08:32	net	8b4a11c6	abf9ba4f	.config	log	report				dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/09/01 10:29	net	bb8872a1	d5a3ae1f	.config	log	report				dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/06/23 21:45	net	b835a71e	54566aff	.config	log	report				dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/10/19 22:05	net-next	9ff9b0d3	ff4a3345	.config	log	report			info	ap420073@gmail.com, davem@davemloft.net, dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-bpf-next-kasan-gce	2020/10/13 06:20	bpf-next	376dcfe3	d32b0bbf	.config	log	report			info	ap420073@gmail.com, davem@davemloft.net, dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/10/10 23:23	net-next	c77fb07f	4a77ae0b	.config	log	report			info	ap420073@gmail.com, davem@davemloft.net, dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/09/30 17:27	net-next	879456be	8516f6d3	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/09/29 07:42	net-next	bcbf1be0	1b88c6d5	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-bpf-next-kasan-gce	2020/09/29 04:15	bpf-next	1fd17c8c	1b88c6d5	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/09/27 21:34	net-next	435be28b	5dd8aee8	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/09/27 17:56	net-next	435be28b	5dd8aee8	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/09/26 20:17	net-next	6fba737a	2d5ea0cb	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/09/25 10:35	net-next	3fc826f1	54289b08	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/09/24 17:51	net-next	1a26e88d	54289b08	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-bpf-next-kasan-gce	2020/09/23 06:25	bpf-next	a8a71796	3e8f6c27	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/09/18 03:51	net-next	529d1fdf	8247808b	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-bpf-next-kasan-gce	2020/09/17 03:30	bpf-next	c64779e2	8247808b	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/09/16 05:46	net-next	0f9ad4e7	18d7d030	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/09/12 17:15	net-next	5a6bd84f	ce441f06	.config	log	report				dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-bpf-next-kasan-gce	2020/09/11 17:48	bpf-next	18841da9	adfb8b4e	.config	log	report				dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-bpf-next-kasan-gce	2020/09/11 00:43	bpf-next	8081ede1	409809d8	.config	log	report				dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/09/10 20:34	net-next	4f6a5caf	409809d8	.config	log	report				dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/09/07 12:28	net-next	02a20d4f	abf9ba4f	.config	log	report				dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/09/07 00:00	net-next	be239c4d	abf9ba4f	.config	log	report				dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/09/03 11:16	net-next	d3dfc362	abf9ba4f	.config	log	report				dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/09/02 18:24	net-next	dc1a9bf2	abf9ba4f	.config	log	report				dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/09/02 02:56	net-next	dc1a9bf2	abf9ba4f	.config	log	report				dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/08/31 10:38	net-next	0f091e43	d5a3ae1f	.config	log	report				dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-linux-next-kasan-gce-root	2020/09/28 10:33	linux-next	d1d2220c	6bfdbe89	.config	log	report			info	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org