KASAN: use-after-free Read in netdevice_event_work

KASAN: use-after-free Read in netdevice_event_work_handler
Status: upstream: reported C repro on 2020/07/09 23:54
Reported-by: syzbot+20b90969babe05609947@syzkaller.appspotmail.com
First crash: 48d, last: 4h05m

Cause bisection: introduced by (bisect log):

commit d70c47c8dc6902db19555b7ff7e6eeb264d4ac06
Author: Heiner Kallweit <hkallweit1@gmail.com>
Date: Thu Apr 23 19:34:33 2020 +0000

net: phy: make phy_suspend a no-op if PHY is suspended already

Crash: unregister_netdevice: waiting for DEV to become free (log)
Repro: C syz .config

Patch testing requests:
Created	Duration	User	Patch	Repo	Result
2020/08/01 00:31	18m	coiby.xu@gmail.com		https://github.com/coiby/linux.git syzbot1	OK
2020/07/31 21:48	17m	rkovhaev@gmail.com	patch	upstream	OK
2020/07/31 13:39	12m	coiby.xu@gmail.com		https://github.com/coiby/linux.git syzbot1	report log
2020/07/31 06:28	0m	coiby.xu@gmail.com		git@github.com:coiby/linux.git syzbot1	error
2020/07/28 14:23	14m	rkovhaev@gmail.com		upstream	report log
2020/07/14 06:07	17m	rkovhaev@gmail.com		upstream	report log

Sample crash report:

==================================================================
BUG: KASAN: use-after-free in dev_put include/linux/netdevice.h:3853 [inline]
BUG: KASAN: use-after-free in netdevice_event_work_handler+0x15b/0x1b0 drivers/infiniband/core/roce_gid_mgmt.c:627
Read of size 8 at addr ffff88807b13e568 by task kworker/u4:0/7

CPU: 0 PID: 7 Comm: kworker/u4:0 Not tainted 5.8.0-rc4-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: gid-cache-wq netdevice_event_work_handler
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x18f/0x20d lib/dump_stack.c:118
 print_address_description.constprop.0.cold+0xae/0x436 mm/kasan/report.c:383
 __kasan_report mm/kasan/report.c:513 [inline]
 kasan_report.cold+0x1f/0x37 mm/kasan/report.c:530
 dev_put include/linux/netdevice.h:3853 [inline]
 netdevice_event_work_handler+0x15b/0x1b0 drivers/infiniband/core/roce_gid_mgmt.c:627
 process_one_work+0x94c/0x1670 kernel/workqueue.c:2269
 worker_thread+0x64c/0x1120 kernel/workqueue.c:2415
 kthread+0x3b5/0x4a0 kernel/kthread.c:291
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:293

Allocated by task 13061:
 save_stack+0x1b/0x40 mm/kasan/common.c:48
 set_track mm/kasan/common.c:56 [inline]
 __kasan_kmalloc.constprop.0+0xc2/0xd0 mm/kasan/common.c:494
 kmalloc_node include/linux/slab.h:578 [inline]
 kvmalloc_node+0x61/0xf0 mm/util.c:574
 kvmalloc include/linux/mm.h:753 [inline]
 kvzalloc include/linux/mm.h:761 [inline]
 alloc_netdev_mqs+0x97/0xdc0 net/core/dev.c:9938
 __ip_tunnel_create+0x201/0x580 net/ipv4/ip_tunnel.c:254
 ip_tunnel_init_net+0x32b/0x980 net/ipv4/ip_tunnel.c:1072
 ops_init+0xaf/0x470 net/core/net_namespace.c:151
 setup_net+0x2d8/0x850 net/core/net_namespace.c:341
 copy_net_ns+0x2cf/0x5e0 net/core/net_namespace.c:482
 create_new_namespaces+0x3f6/0xb10 kernel/nsproxy.c:110
 unshare_nsproxy_namespaces+0xbd/0x1f0 kernel/nsproxy.c:231
 ksys_unshare+0x36c/0x9a0 kernel/fork.c:2983
 __do_sys_unshare kernel/fork.c:3051 [inline]
 __se_sys_unshare kernel/fork.c:3049 [inline]
 __x64_sys_unshare+0x2d/0x40 kernel/fork.c:3049
 do_syscall_64+0x60/0xe0 arch/x86/entry/common.c:384
 entry_SYSCALL_64_after_hwframe+0x44/0xa9

Freed by task 13061:
 save_stack+0x1b/0x40 mm/kasan/common.c:48
 set_track mm/kasan/common.c:56 [inline]
 kasan_set_free_info mm/kasan/common.c:316 [inline]
 __kasan_slab_free+0xf5/0x140 mm/kasan/common.c:455
 __cache_free mm/slab.c:3426 [inline]
 kfree+0x103/0x2c0 mm/slab.c:3757
 kvfree+0x42/0x50 mm/util.c:603
 device_release+0x71/0x200 drivers/base/core.c:1559
 kobject_cleanup lib/kobject.c:693 [inline]
 kobject_release lib/kobject.c:722 [inline]
 kref_put include/linux/kref.h:65 [inline]
 kobject_put+0x1c0/0x270 lib/kobject.c:739
 put_device+0x1b/0x30 drivers/base/core.c:2779
 free_netdev+0x35d/0x480 net/core/dev.c:10054
 __ip_tunnel_create+0x48f/0x580 net/ipv4/ip_tunnel.c:274
 ip_tunnel_init_net+0x32b/0x980 net/ipv4/ip_tunnel.c:1072
 ops_init+0xaf/0x470 net/core/net_namespace.c:151
 setup_net+0x2d8/0x850 net/core/net_namespace.c:341
 copy_net_ns+0x2cf/0x5e0 net/core/net_namespace.c:482
 create_new_namespaces+0x3f6/0xb10 kernel/nsproxy.c:110
 unshare_nsproxy_namespaces+0xbd/0x1f0 kernel/nsproxy.c:231
 ksys_unshare+0x36c/0x9a0 kernel/fork.c:2983
 __do_sys_unshare kernel/fork.c:3051 [inline]
 __se_sys_unshare kernel/fork.c:3049 [inline]
 __x64_sys_unshare+0x2d/0x40 kernel/fork.c:3049
 do_syscall_64+0x60/0xe0 arch/x86/entry/common.c:384
 entry_SYSCALL_64_after_hwframe+0x44/0xa9

The buggy address belongs to the object at ffff88807b13e000
 which belongs to the cache kmalloc-4k of size 4096
The buggy address is located 1384 bytes inside of
 4096-byte region [ffff88807b13e000, ffff88807b13f000)
The buggy address belongs to the page:
page:ffffea0001ec4f80 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 head:ffffea0001ec4f80 order:1 compound_mapcount:0
flags: 0xfffe0000010200(slab|head)
raw: 00fffe0000010200 ffffea0001ecce88 ffffea0001987988 ffff8880aa002000
raw: 0000000000000000 ffff88807b13e000 0000000100000001 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff88807b13e400: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff88807b13e480: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
>ffff88807b13e500: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                                                          ^
 ffff88807b13e580: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff88807b13e600: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================

Crashes (90):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	Maintainers
ci-upstream-kasan-gce-selinux-root	2020/07/09 23:42	upstream	0bddd227	bc238812	.config	log	report	syz	C	dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-kasan-gce-root	2020/07/09 01:49	upstream	0bddd227	bc238812	.config	log	report	syz		dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-kasan-gce-root	2020/08/01 09:58	upstream	d8b9faec	d895b3be	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-kasan-gce-root	2020/07/30 16:16	upstream	d3590ebf	233283a1	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-kasan-gce-386	2020/07/27 20:09	upstream	92ed3019	cb93dc6a	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-bpf-kasan-gce	2020/08/11 04:24	bpf	7c7ab580	7adc7b65	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-bpf-kasan-gce	2020/08/09 20:57	bpf	1c3b63f1	70301872	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/08/08 06:59	net	c7ca03c2	ff51e522	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/08/08 01:02	net	8912fd6a	cb436c69	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/08/02 07:32	net	fda2ec62	d895b3be	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/08/01 00:22	net	85496a29	d895b3be	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/07/29 23:10	net	1ed06dbc	19a8de55	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/07/27 17:53	net	04300d66	cb93dc6a	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-bpf-kasan-gce	2020/07/27 00:23	bpf	5b801dfb	51265195	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-bpf-kasan-gce	2020/07/26 08:19	bpf	5b801dfb	1f7cc1ca	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-bpf-kasan-gce	2020/07/25 12:36	bpf	5b801dfb	1f7cc1ca	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/07/24 08:06	net	e6827d1a	70c104a1	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/07/19 07:54	net	2ccb0161	9c812472	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/07/18 20:22	net	2ccb0161	9c812472	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/06/23 21:45	net	b835a71e	54566aff	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/08/11 15:14	net-next	bfdd5aaa	bacaf5fa	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/08/11 06:57	net-next	bfdd5aaa	7adc7b65	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/08/10 04:19	net-next	bfdd5aaa	70301872	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/08/09 10:37	net-next	bfdd5aaa	f721e4a0	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/08/09 01:35	net-next	bfdd5aaa	f721e4a0	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/08/07 19:29	net-next	bfdd5aaa	cb436c69	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-bpf-next-kasan-gce	2020/08/07 11:11	bpf-next	bfdd5aaa	cb436c69	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/08/07 00:12	net-next	c1055b76	1f122f88	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/08/06 03:28	net-next	8ed54f16	0487ea6f	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/08/04 11:50	net-next	2f631133	196277c4	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/07/31 14:26	net-next	41d707b7	8df85ed9	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/07/30 05:03	net-next	41d707b7	233283a1	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/07/29 16:31	net-next	490ed0b9	19a8de55	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/07/29 13:35	net-next	490ed0b9	19a8de55	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/07/24 09:52	net-next	1b6687e3	70c104a1	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/07/24 03:20	net-next	7fc3b978	70c104a1	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/07/23 07:51	net-next	a6c0d093	340ea530	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/07/22 20:21	net-next	fa56a987	128cd85f	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/07/21 01:12	net-next	7dce80c2	4285ffa3	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/07/20 21:03	net-next	7dce80c2	4285ffa3	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/07/20 05:02	net-next	a050d82f	9c812472	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/07/18 09:04	net-next	4291dc1a	9c812472	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/07/18 05:35	net-next	4291dc1a	9c812472	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-bpf-next-kasan-gce	2020/07/17 17:26	bpf-next	bfdfa517	9c812472	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/07/16 09:29	net-next	8635764b	f3bec699	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/07/14 23:20	net-next	07dd1b7e	609fb517	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/07/14 09:10	net-next	2be53e0e	ce4c95b3	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/07/14 03:49	net-next	2be53e0e	f90ec899	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/07/12 16:33	net-next	71930d61	115e1930	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/07/12 00:00	net-next	a594920f	18d18b59	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/07/10 02:20	net-next	e80a07b2	bc238812	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/07/10 01:24	net-next	e80a07b2	bc238812	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/07/08 17:39	net-next	e44f65fd	51095195	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/07/08 13:33	net-next	e44f65fd	51095195	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/07/08 08:25	net-next	e44f65fd	51095195	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/07/08 06:48	net-next	e44f65fd	51095195	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/06/29 19:15	net-next	b08866f4	a2cdad9d	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/06/29 16:26	net-next	b08866f4	a2cdad9d	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/06/29 03:36	net-next	b08866f4	a2cdad9d	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/06/29 02:59	net-next	b08866f4	a2cdad9d	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/06/28 15:38	net-next	b08866f4	a2cdad9d	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/06/28 10:20	net-next	7bed1455	ffec44b5	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/06/28 08:16	net-next	7bed1455	ffec44b5	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/06/27 23:30	net-next	7bed1455	ffec44b5	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
ci-upstream-net-kasan-gce	2020/06/27 20:09	net-next	7bed1455	ffec44b5	.config	log	report			dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org