KASAN: use-after-free Read in sk_psock

KASAN: use-after-free Read in sk_psock_unlink
Status: upstream: reported syz repro on 2018/10/26 07:37
Reported-by: syzbot+3acd9f67a6a15766686e@syzkaller.appspotmail.com
First crash: 243d, last: 2h55m

Bisection: introduced by (bisect log):

commit 48a3c64b4649b5b23a4ca756af93b4ee820ff883
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date: Fri Jun 29 14:11:03 2018 +0000

Merge tag 'drm-fixes-2018-06-29' of git://anongit.freedesktop.org/drm/drm

Tree: net-next
Crash: general protection fault in bpf_tcp_close (log)
Repro: syz .config

Sample crash report:

==================================================================
BUG: KASAN: use-after-free in sock_hash_delete_from_link net/core/sock_map.c:585 [inline]
BUG: KASAN: use-after-free in sk_psock_unlink+0x443/0x4b0 net/core/sock_map.c:998
Read of size 8 at addr ffff88808c9abb80 by task syz-executor.0/13883

CPU: 1 PID: 13883 Comm: syz-executor.0 Not tainted 5.2.0-rc5+ #31
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x172/0x1f0 lib/dump_stack.c:113
 print_address_description.cold+0x7c/0x20d mm/kasan/report.c:188
 __kasan_report.cold+0x1b/0x40 mm/kasan/report.c:317
 kasan_report+0x12/0x20 mm/kasan/common.c:614
 __asan_report_load8_noabort+0x14/0x20 mm/kasan/generic_report.c:132
 sock_hash_delete_from_link net/core/sock_map.c:585 [inline]
 sk_psock_unlink+0x443/0x4b0 net/core/sock_map.c:998
 tcp_bpf_remove+0x21/0x50 net/ipv4/tcp_bpf.c:535
 tcp_bpf_close+0x130/0x390 net/ipv4/tcp_bpf.c:575
 inet_release+0xe0/0x1f0 net/ipv4/af_inet.c:427
 inet6_release+0x53/0x80 net/ipv6/af_inet6.c:470
 __sock_release+0xce/0x2a0 net/socket.c:601
 sock_close+0x1b/0x30 net/socket.c:1273
 __fput+0x2ff/0x890 fs/file_table.c:280
 ____fput+0x16/0x20 fs/file_table.c:313
 task_work_run+0x145/0x1c0 kernel/task_work.c:113
 tracehook_notify_resume include/linux/tracehook.h:185 [inline]
 exit_to_usermode_loop+0x273/0x2c0 arch/x86/entry/common.c:168
 prepare_exit_to_usermode arch/x86/entry/common.c:199 [inline]
 syscall_return_slowpath arch/x86/entry/common.c:279 [inline]
 do_syscall_64+0x58e/0x680 arch/x86/entry/common.c:304
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x412fb1
Code: 75 14 b8 03 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 04 1b 00 00 c3 48 83 ec 08 e8 0a fc ff ff 48 89 04 24 b8 03 00 00 00 0f 05 <48> 8b 3c 24 48 89 c2 e8 53 fc ff ff 48 89 d0 48 83 c4 08 48 3d 01
RSP: 002b:00007ffecd8c6510 EFLAGS: 00000293 ORIG_RAX: 0000000000000003
RAX: 0000000000000000 RBX: 0000000000000006 RCX: 0000000000412fb1
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000005
RBP: 0000000000000000 R08: ffffffffffffffff R09: ffffffffffffffff
R10: 00007ffecd8c65f0 R11: 0000000000000293 R12: 00000000007610a8
R13: 00000000000245b9 R14: 00000000000245e6 R15: 000000000075bfd4

Allocated by task 13888:
 save_stack+0x23/0x90 mm/kasan/common.c:71
 set_track mm/kasan/common.c:79 [inline]
 __kasan_kmalloc mm/kasan/common.c:489 [inline]
 __kasan_kmalloc.constprop.0+0xcf/0xe0 mm/kasan/common.c:462
 kasan_kmalloc+0x9/0x10 mm/kasan/common.c:503
 kmem_cache_alloc_trace+0x151/0x750 mm/slab.c:3555
 kmalloc include/linux/slab.h:547 [inline]
 kzalloc include/linux/slab.h:742 [inline]
 sock_hash_alloc net/core/sock_map.c:802 [inline]
 sock_hash_alloc+0x1e3/0x5b0 net/core/sock_map.c:786
 find_and_alloc_map kernel/bpf/syscall.c:121 [inline]
 map_create kernel/bpf/syscall.c:562 [inline]
 __do_sys_bpf+0x730/0x43d0 kernel/bpf/syscall.c:2795
 __se_sys_bpf kernel/bpf/syscall.c:2772 [inline]
 __x64_sys_bpf+0x73/0xb0 kernel/bpf/syscall.c:2772
 do_syscall_64+0xfd/0x680 arch/x86/entry/common.c:301
 entry_SYSCALL_64_after_hwframe+0x49/0xbe

Freed by task 9874:
 save_stack+0x23/0x90 mm/kasan/common.c:71
 set_track mm/kasan/common.c:79 [inline]
 __kasan_slab_free+0x102/0x150 mm/kasan/common.c:451
 kasan_slab_free+0xe/0x10 mm/kasan/common.c:459
 __cache_free mm/slab.c:3432 [inline]
 kfree+0xcf/0x220 mm/slab.c:3755
 sock_hash_free+0x327/0x4a0 net/core/sock_map.c:865
 bpf_map_free_deferred+0xb4/0xe0 kernel/bpf/syscall.c:302
 process_one_work+0x989/0x1790 kernel/workqueue.c:2269
 worker_thread+0x98/0xe40 kernel/workqueue.c:2415
 kthread+0x354/0x420 kernel/kthread.c:255
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352

The buggy address belongs to the object at ffff88808c9aba80
 which belongs to the cache kmalloc-512 of size 512
The buggy address is located 256 bytes inside of
 512-byte region [ffff88808c9aba80, ffff88808c9abc80)
The buggy address belongs to the page:
page:ffffea0002326ac0 refcount:1 mapcount:0 mapping:ffff8880aa400940 index:0x0
flags: 0x1fffc0000000200(slab)
raw: 01fffc0000000200 ffffea00028eb188 ffffea00028c40c8 ffff8880aa400940
raw: 0000000000000000 ffff88808c9ab080 0000000100000006 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff88808c9aba80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff88808c9abb00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
>ffff88808c9abb80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                   ^
 ffff88808c9abc00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff88808c9abc80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
==================================================================

All crashes (42):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	Maintainers
ci-upstream-kasan-gce-selinux-root	2019/06/21 15:30	upstream	abf02e29	34bf9440	.config	log	report	syz	ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-kasan-gce-selinux-root	2019/06/19 03:59	upstream	29f785ff	e3f76baa	.config	log	report	syz	ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-kasan-gce-selinux-root	2019/06/18 05:54	upstream	9e0babf2	442206d7	.config	log	report	syz	ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-kasan-gce-smack-root	2019/06/16 13:14	upstream	e01e060f	442206d7	.config	log	report	syz	ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-kasan-gce-smack-root	2019/06/11 21:52	upstream	01ccc3ad	5b5826d0	.config	log	report	syz	ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-net-this-kasan-gce	2019/06/26 06:00	net	904d88d7	0a8d1a96	.config	log	report	syz	ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-net-this-kasan-gce	2019/06/16 10:37	net	ef7bfa84	442206d7	.config	log	report	syz	ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-net-this-kasan-gce	2019/06/15 12:35	net	35fc07ae	442206d7	.config	log	report	syz	ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-net-this-kasan-gce	2019/06/11 13:28	net	dce5cccc	5b5826d0	.config	log	report	syz	ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-net-this-kasan-gce	2019/06/05 17:50	net	f4cfcfbd	bfb4a51e	.config	log	report	syz	ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-net-this-kasan-gce	2019/05/25 10:52	net	ce8d24f9	85c57315	.config	log	report	syz	ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-net-kasan-gce	2019/05/22 14:44	net-next	f49aa1de	84b9d384	.config	log	report	syz	ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-net-kasan-gce	2019/06/25 11:55	net-next	7d30a7f6	82c13b6b	.config	log	report	syz	ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-linux-next-kasan-gce-root	2019/06/25 03:52	linux-next	9ffadb46	82c13b6b	.config	log	report	syz	ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-linux-next-kasan-gce-root	2019/06/15 22:27	linux-next	f4788d37	442206d7	.config	log	report	syz	ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-kasan-gce-selinux-root	2019/06/23 09:44	upstream	abf02e29	34bf9440	.config	log	report		ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-kasan-gce-selinux-root	2019/06/22 23:22	upstream	abf02e29	34bf9440	.config	log	report		ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-kasan-gce-smack-root	2019/06/22 17:11	upstream	abf02e29	34bf9440	.config	log	report		ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-kasan-gce-root	2019/06/22 13:32	upstream	abf02e29	34bf9440	.config	log	report		ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-kasan-gce-root	2019/06/22 09:58	upstream	abf02e29	34bf9440	.config	log	report		ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-kasan-gce-selinux-root	2019/06/19 07:34	upstream	bed3c0d8	34bf9440	.config	log	report		ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-kasan-gce-smack-root	2019/06/17 14:56	upstream	9e0babf2	442206d7	.config	log	report		ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-kasan-gce-smack-root	2019/06/09 17:00	upstream	d1fdb6d8	0159583c	.config	log	report		ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-kasan-gce-smack-root	2019/06/04 16:06	upstream	788a0249	e41a20c5	.config	log	report		ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-kasan-gce-smack-root	2019/06/04 08:04	upstream	788a0249	ce07a7ae	.config	log	report		ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-kasan-gce-selinux-root	2019/05/27 10:44	upstream	cd6c84d8	562efd79	.config	log	report		ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-kasan-gce-selinux-root	2019/01/20 13:41	upstream	6e693b3f	353f32ea	.config	log	report		daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
ci-upstream-kasan-gce-smack-root	2018/12/14 10:51	upstream	65e08c5e	fe7127be	.config	log	report		daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
ci-upstream-kasan-gce-smack-root	2018/12/02 04:15	upstream	4b783176	5a581673	.config	log	report		daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
ci-upstream-kasan-gce-selinux-root	2018/11/27 00:56	upstream	6f8b52ba	ac912200	.config	log	report		daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
ci-upstream-kasan-gce-root	2018/11/14 12:30	upstream	ccda4af0	5f5f6d14	.config	log	report		daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
ci-upstream-kasan-gce-root	2018/11/14 07:52	upstream	ccda4af0	5f5f6d14	.config	log	report		daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
ci-upstream-net-kasan-gce	2019/06/08 13:19	net-next	a6cdeeb1	cf9c3a50	.config	log	report		ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-linux-next-kasan-gce-root	2018/10/25 20:12	linux-next	8c60c36d	a8292de9	.config	log	report		daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
ci-upstream-linux-next-kasan-gce-root	2019/06/26 05:24	linux-next	90203176	0a8d1a96	.config	log	report		ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-linux-next-kasan-gce-root	2019/06/22 06:29	linux-next	dc636f5d	34bf9440	.config	log	report		ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-linux-next-kasan-gce-root	2019/06/20 17:31	linux-next	dc636f5d	34bf9440	.config	log	report		ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-linux-next-kasan-gce-root	2019/06/18 01:45	linux-next	a125097c	442206d7	.config	log	report		ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-linux-next-kasan-gce-root	2019/06/16 08:30	linux-next	f4788d37	442206d7	.config	log	report		ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-linux-next-kasan-gce-root	2019/06/10 06:59	linux-next	3f310e51	0159583c	.config	log	report		ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-linux-next-kasan-gce-root	2019/06/08 02:13	linux-next	3f310e51	cf9c3a50	.config	log	report		ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-linux-next-kasan-gce-root	2018/12/08 09:08	linux-next	74c4a24d	65ed2472	.config	log	report		daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org