KASAN: slab-out-of-bounds Read in hci_event

KASAN: slab-out-of-bounds Read in hci_event_packet
Status: upstream: reported C repro on 2019/01/07 18:31
Reported-by: syzbot+cec7a50c412a2c03f8f5@syzkaller.appspotmail.com
First crash: 169d, last: 3d08h

Bisection: introduced by (bisect log):

commit c470abd4fde40ea6a0846a2beab642a578c0b8cd
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date: Sun Feb 19 22:34:00 2017 +0000

Linux 4.10

Tree: upstream
Repro: C syz .config

similar bugs (1):
Kernel	Title	Repro	Bisected	Count	Last	Reported	Patched	Status
linux-4.14	KASAN: slab-out-of-bounds Read in hci_event_packet	C		2	55d	55d	0/1	upstream: reported C repro on 2019/05/02 03:07

Sample crash report:

kauditd_printk_skb: 5 callbacks suppressed
audit: type=1400 audit(1546856008.711:36): avc:  denied  { map } for  pid=8365 comm="syz-executor431" path="/root/syz-executor431611296" dev="sda1" ino=16484 scontext=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 tcontext=unconfined_u:object_r:user_home_t:s0 tclass=file permissive=1
==================================================================
BUG: KASAN: slab-out-of-bounds in hci_inquiry_result_with_rssi_evt net/bluetooth/hci_event.c:3988 [inline]
BUG: KASAN: slab-out-of-bounds in hci_event_packet+0xb33e/0xc22e net/bluetooth/hci_event.c:5863
Read of size 1 at addr ffff88809fcab1c0 by task kworker/u5:0/1171

CPU: 1 PID: 1171 Comm: kworker/u5:0 Not tainted 4.20.0+ #13
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: hci0 hci_rx_work
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x1db/0x2d0 lib/dump_stack.c:113
 print_address_description.cold+0x7c/0x20d mm/kasan/report.c:187
 kasan_report.cold+0x1b/0x40 mm/kasan/report.c:317
 __asan_report_load1_noabort+0x14/0x20 mm/kasan/generic_report.c:132
 hci_inquiry_result_with_rssi_evt net/bluetooth/hci_event.c:3988 [inline]
 hci_event_packet+0xb33e/0xc22e net/bluetooth/hci_event.c:5863
 hci_rx_work+0x578/0xcd0 net/bluetooth/hci_core.c:4412
 process_one_work+0xd0c/0x1ce0 kernel/workqueue.c:2153
 worker_thread+0x143/0x14a0 kernel/workqueue.c:2296
 kthread+0x357/0x430 kernel/kthread.c:246
 ret_from_fork+0x3a/0x50 arch/x86/entry/entry_64.S:352

Allocated by task 8369:
 save_stack+0x45/0xd0 mm/kasan/common.c:73
 set_track mm/kasan/common.c:85 [inline]
 kasan_kmalloc mm/kasan/common.c:482 [inline]
 kasan_kmalloc+0xcf/0xe0 mm/kasan/common.c:455
 __do_kmalloc_node mm/slab.c:3671 [inline]
 __kmalloc_node_track_caller+0x4e/0x70 mm/slab.c:3685
 __kmalloc_reserve.isra.0+0x40/0xe0 net/core/skbuff.c:140
 __alloc_skb+0x12d/0x730 net/core/skbuff.c:208
 alloc_skb include/linux/skbuff.h:1011 [inline]
 bt_skb_alloc include/net/bluetooth/bluetooth.h:339 [inline]
 vhci_get_user drivers/bluetooth/hci_vhci.c:180 [inline]
 vhci_write+0xc4/0x470 drivers/bluetooth/hci_vhci.c:299
 call_write_iter include/linux/fs.h:1862 [inline]
 new_sync_write fs/read_write.c:474 [inline]
 __vfs_write+0x764/0xb40 fs/read_write.c:487
 vfs_write+0x20c/0x580 fs/read_write.c:549
 ksys_write+0x105/0x260 fs/read_write.c:598
 __do_sys_write fs/read_write.c:610 [inline]
 __se_sys_write fs/read_write.c:607 [inline]
 __x64_sys_write+0x73/0xb0 fs/read_write.c:607
 do_syscall_64+0x1a3/0x800 arch/x86/entry/common.c:290
 entry_SYSCALL_64_after_hwframe+0x49/0xbe

Freed by task 0:
(stack is not available)

The buggy address belongs to the object at ffff88809fcaadc0
 which belongs to the cache kmalloc-1k of size 1024
The buggy address is located 0 bytes to the right of
 1024-byte region [ffff88809fcaadc0, ffff88809fcab1c0)
The buggy address belongs to the page:
page:ffffea00027f2a80 count:1 mapcount:0 mapping:ffff88812c3f0ac0 index:0x0 compound_mapcount: 0
flags: 0x1fffc0000010200(slab|head)
raw: 01fffc0000010200 ffffea0001d08488 ffffea0002812908 ffff88812c3f0ac0
raw: 0000000000000000 ffff88809fcaa040 0000000100000007 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff88809fcab080: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 ffff88809fcab100: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>ffff88809fcab180: 00 00 00 00 00 00 00 00 fc fc fc fc fc fc fc fc
                                           ^
 ffff88809fcab200: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
 ffff88809fcab280: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
==================================================================

All crashes (7):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	Maintainers
ci-upstream-kasan-gce-selinux-root	2019/01/07 10:16	upstream	574823bf	ee332608	.config	log	report	syz	C	davem@davemloft.net, johan.hedberg@gmail.com, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, marcel@holtmann.org, netdev@vger.kernel.org
ci-upstream-kasan-gce	2019/01/07 09:42	upstream	574823bf	ee332608	.config	log	report	syz	C	davem@davemloft.net, johan.hedberg@gmail.com, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, marcel@holtmann.org, netdev@vger.kernel.org
ci-upstream-kasan-gce-root	2019/01/07 09:41	upstream	574823bf	ee332608	.config	log	report	syz	C	davem@davemloft.net, johan.hedberg@gmail.com, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, marcel@holtmann.org, netdev@vger.kernel.org
ci-upstream-kasan-gce-smack-root	2019/01/07 09:41	upstream	574823bf	ee332608	.config	log	report	syz	C	davem@davemloft.net, johan.hedberg@gmail.com, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, marcel@holtmann.org, netdev@vger.kernel.org
ci-upstream-kasan-gce-386	2019/01/07 09:42	upstream	574823bf	ee332608	.config	log	report	syz	C	davem@davemloft.net, johan.hedberg@gmail.com, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, marcel@holtmann.org, netdev@vger.kernel.org
ci-upstream-linux-next-kasan-gce-root	2019/01/07 09:40	linux-next	a85b6b4f	ee332608	.config	log	report	syz	C	davem@davemloft.net, johan.hedberg@gmail.com, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, marcel@holtmann.org, netdev@vger.kernel.org
ci-upstream-kasan-gce	2019/06/23 00:58	upstream	abf02e29	34bf9440	.config	log	report			davem@davemloft.net, johan.hedberg@gmail.com, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, marcel@holtmann.org, netdev@vger.kernel.org