WARNING in taprio

WARNING in taprio_change
Status: upstream: reported C repro on 2020/09/14 09:19
Reported-by: syzbot+d50710fd0873a9c6b40c@syzkaller.appspotmail.com
First crash: 176d, last: 8d08h

Cause bisection: introduced by (bisect log) :
commit b5b73b26b3ca34574124ed7ae9c5ba8391a7f176
Author: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Date: Thu Sep 10 00:03:11 2020 +0000

taprio: Fix allowing too small intervals

Crash: WARNING in taprio_change (log)
Repro: C syz .config

Sample crash report:

netdevsim netdevsim0 netdevsim1: set [1, 0] type 2 family 0 port 6081 - 0
netdevsim netdevsim0 netdevsim2: set [1, 0] type 2 family 0 port 6081 - 0
netdevsim netdevsim0 netdevsim3: set [1, 0] type 2 family 0 port 6081 - 0
------------[ cut here ]------------
WARNING: CPU: 0 PID: 8460 at net/sched/sch_taprio.c:998 taprio_get_start_time net/sched/sch_taprio.c:998 [inline]
WARNING: CPU: 0 PID: 8460 at net/sched/sch_taprio.c:998 taprio_change+0x1ed0/0x2d40 net/sched/sch_taprio.c:1549
Modules linked in:
CPU: 0 PID: 8460 Comm: syz-executor652 Not tainted 5.10.0-rc7-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:taprio_get_start_time net/sched/sch_taprio.c:998 [inline]
RIP: 0010:taprio_change+0x1ed0/0x2d40 net/sched/sch_taprio.c:1549
Code: 8b 44 24 18 41 bf ea ff ff ff 48 c7 00 c0 31 48 8a e8 d4 fa 4b fa 48 8b 7c 24 08 e8 ba f1 c3 01 e9 0a eb ff ff e8 c0 fa 4b fa <0f> 0b 48 83 7c 24 18 00 74 2e e8 b1 fa 4b fa 48 8b 54 24 18 48 b8
RSP: 0018:ffffc900016ef2b8 EFLAGS: 00010293
RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffffffff87240500
RDX: ffff888020554ec0 RSI: ffffffff872409b0 RDI: 0000000000000007
RBP: 164fa494a1156125 R08: 0000000000000001 R09: ffffffff8ebaf72f
R10: 0000000000000000 R11: 1ffffffff1ceeda4 R12: 0000000000000000
R13: 0000000000000000 R14: 0000000000000002 R15: 0000000000000000
FS:  0000000000a87880(0000) GS:ffff8880b9e00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000020000600 CR3: 0000000011053000 CR4: 00000000001506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 taprio_init+0x52e/0x670 net/sched/sch_taprio.c:1693
 qdisc_create+0x4ba/0x1270 net/sched/sch_api.c:1246
 tc_modify_qdisc+0x4c8/0x1990 net/sched/sch_api.c:1662
 rtnetlink_rcv_msg+0x44e/0xad0 net/core/rtnetlink.c:5562
 netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2494
 netlink_unicast_kernel net/netlink/af_netlink.c:1304 [inline]
 netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1330
 netlink_sendmsg+0x856/0xd90 net/netlink/af_netlink.c:1919
 sock_sendmsg_nosec net/socket.c:651 [inline]
 sock_sendmsg+0xcf/0x120 net/socket.c:671
 ____sys_sendmsg+0x6e8/0x810 net/socket.c:2353
 ___sys_sendmsg+0xf3/0x170 net/socket.c:2407
 __sys_sendmsg+0xe5/0x1b0 net/socket.c:2440
 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x443999
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 eb 0d fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ffd5cf19ec8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000000443999
RDX: 0000000000000000 RSI: 00000000200007c0 RDI: 0000000000000004
RBP: 00007ffd5cf19ed0 R08: 0000000001bbbbbb R09: 0000000001bbbbbb
R10: 0000000001bbbbbb R11: 0000000000000246 R12: 00007ffd5cf19ee0
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000

Crashes (300):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	VM info	Title
ci-upstream-kasan-gce	2020/12/11 11:04	upstream	33dc9614	f900b48c	.config	log	report	syz	C
ci-upstream-kasan-gce-selinux-root	2020/09/28 15:01	upstream	a1b8638b	6bfdbe89	.config	log	report	syz	C
ci-upstream-kasan-gce-root	2020/09/26 23:12	upstream	7c7ec322	2d5ea0cb	.config	log	report	syz	C
ci-upstream-net-this-kasan-gce	2020/11/02 04:13	net	859191b2	8bc4594f	.config	log	report	syz	C
ci-upstream-net-this-kasan-gce	2020/09/12 19:24	net	5760d9ac	ce441f06	.config	log	report	syz	C
ci-upstream-net-kasan-gce	2020/11/02 04:13	net-next	c43fd36f	8bc4594f	.config	log	report	syz	C
ci-upstream-kasan-gce-root	2021/02/14 09:24	upstream	ac30d8ce	98682e5e	.config	log	report			info	WARNING in taprio_change
ci-upstream-kasan-gce-root	2021/01/28 06:29	upstream	76c057c8	eefc07f2	.config	log	report			info	WARNING in taprio_change
ci-upstream-kasan-gce	2021/01/28 06:06	upstream	76c057c8	eefc07f2	.config	log	report			info	WARNING in taprio_change
ci-upstream-net-this-kasan-gce	2021/02/27 13:50	net	eee7ede6	4c37c133	.config	log	report			info	WARNING in taprio_change
ci-upstream-net-this-kasan-gce	2021/02/22 01:27	net	d310ec03	a659b3f1	.config	log	report			info	WARNING in taprio_change
ci-upstream-net-this-kasan-gce	2021/02/12 04:54	net	1bcc51ac	a5f86b15	.config	log	report			info	WARNING in taprio_change
ci-upstream-net-this-kasan-gce	2021/02/11 05:32	net	291009f6	a52ee10a	.config	log	report			info	WARNING in taprio_change
ci-upstream-net-this-kasan-gce	2021/02/09 12:44	net	6bbc088d	2bd9619f	.config	log	report			info	WARNING in taprio_change
ci-upstream-net-this-kasan-gce	2021/02/03 17:07	net	3aaf0a27	624dad51	.config	log	report			info	WARNING in taprio_change
ci-upstream-net-this-kasan-gce	2021/02/01 07:22	net	eb4e8fac	fc9fd31e	.config	log	report			info	WARNING in taprio_change
ci-upstream-net-this-kasan-gce	2021/01/31 23:38	net	eb4e8fac	fc9fd31e	.config	log	report			info	WARNING in taprio_change
ci-upstream-net-this-kasan-gce	2021/01/24 09:06	net	853c56b4	52e37319	.config	log	report			info	WARNING in taprio_change
ci-upstream-net-this-kasan-gce	2021/01/22 14:17	net	35c715c3	d4f4eca5	.config	log	report			info	WARNING in taprio_change
ci-upstream-net-this-kasan-gce	2021/01/21 22:35	net	1c45ba93	d4f4eca5	.config	log	report			info	WARNING in taprio_change
ci-upstream-net-this-kasan-gce	2021/01/17 20:40	net	66c55602	813be542	.config	log	report			info	WARNING in taprio_change
ci-upstream-net-kasan-gce	2021/02/25 20:34	net-next	d310ec03	76f7fc95	.config	log	report			info	WARNING in taprio_change
ci-upstream-net-kasan-gce	2021/02/20 08:25	net-next	38b5133a	f689d40a	.config	log	report			info	WARNING in taprio_change
ci-upstream-net-kasan-gce	2021/02/09 06:12	net-next	8e571586	2bd9619f	.config	log	report			info	WARNING in taprio_change
ci-upstream-net-kasan-gce	2021/02/09 01:28	net-next	8e571586	2bd9619f	.config	log	report			info	WARNING in taprio_change
ci-upstream-net-kasan-gce	2021/01/28 08:49	net-next	6b2e04bc	eefc07f2	.config	log	report			info	WARNING in taprio_change
ci-upstream-kasan-gce-root	2020/12/04 02:15	upstream	34816d20	e6b0d314	.config	log	report			info
ci-upstream-kasan-gce	2020/11/30 07:29	upstream	aae5ab85	a0092f9d	.config	log	report			info
ci-upstream-kasan-gce-smack-root	2020/11/26 17:18	upstream	fa02fcd9	1d2b823e	.config	log	report			info
ci-upstream-kasan-gce	2020/11/17 18:03	upstream	9c87c9f4	bd2a760b	.config	log	report			info
ci-upstream-kasan-gce	2020/11/12 14:40	upstream	3d5e28bf	77a55c8e	.config	log	report			info
ci-upstream-kasan-gce-smack-root	2020/10/31 07:00	upstream	5fc6b075	18e33098	.config	log	report			info
ci-upstream-kasan-gce-selinux-root	2020/10/08 04:55	upstream	c85fb28b	1880b4a9	.config	log	report			info
ci-upstream-kasan-gce-386	2021/01/07 20:13	upstream	71c061d2	c104d4a3	.config	log	report			info
ci-upstream-kasan-gce-386	2020/12/04 23:59	upstream	e87297fa	20366b87	.config	log	report			info
ci-upstream-kasan-gce-386	2020/12/03 13:40	upstream	34816d20	e6b0d314	.config	log	report			info
ci-upstream-kasan-gce-386	2020/11/26 16:09	upstream	fa02fcd9	1d2b823e	.config	log	report			info
ci-upstream-kasan-gce-386	2020/11/26 03:21	upstream	fa02fcd9	2f1cec62	.config	log	report			info
ci-upstream-kasan-gce-386	2020/11/17 15:46	upstream	9c87c9f4	bd2a760b	.config	log	report			info
ci-upstream-kasan-gce-386	2020/11/09 16:52	upstream	f8394f23	64069d48	.config	log	report			info
ci-upstream-net-this-kasan-gce	2021/01/07 05:58	net	3503ee6c	c104d4a3	.config	log	report			info
ci-upstream-net-this-kasan-gce	2020/12/27 06:59	net	1f45dc22	821e0b09	.config	log	report			info
ci-upstream-net-this-kasan-gce	2020/12/19 13:42	net	1e72faed	04201c06	.config	log	report			info
ci-upstream-net-this-kasan-gce	2020/12/07 04:57	net	edd2410b	c521566d	.config	log	report			info
ci-upstream-net-this-kasan-gce	2020/12/06 16:52	net	edd2410b	f12ba0c5	.config	log	report			info
ci-upstream-net-this-kasan-gce	2020/11/30 07:21	net	4d521943	a0092f9d	.config	log	report			info
ci-upstream-net-this-kasan-gce	2020/11/28 00:45	net	d0742c49	486f93ef	.config	log	report			info
ci-upstream-net-this-kasan-gce	2020/11/26 06:40	net	90cf87d1	2f1cec62	.config	log	report			info
ci-upstream-net-this-kasan-gce	2020/11/26 00:25	net	90cf87d1	2f1cec62	.config	log	report			info
ci-upstream-net-this-kasan-gce	2020/11/25 18:51	net	6f7a1f9c	1a1f4bd8	.config	log	report			info
ci-upstream-net-this-kasan-gce	2020/11/24 06:57	net	1eae77bf	1ab681a4	.config	log	report			info
ci-upstream-net-this-kasan-gce	2020/11/23 10:08	net	f9b03653	0d27f508	.config	log	report			info
ci-upstream-net-this-kasan-gce	2020/11/21 10:51	net	207d0bfc	68068804	.config	log	report			info
ci-upstream-net-this-kasan-gce	2020/11/20 11:03	net	e6ea60ba	0767f13f	.config	log	report			info
ci-upstream-net-this-kasan-gce	2020/11/16 01:59	net	849920c7	1bf9a662	.config	log	report			info
ci-upstream-net-this-kasan-gce	2020/11/08 22:21	net	4e0396c5	64069d48	.config	log	report			info
ci-upstream-net-this-kasan-gce	2020/11/06 16:52	net	2bcbf42a	64069d48	.config	log	report			info
ci-upstream-net-this-kasan-gce	2020/10/30 12:47	net	07e08873	a6e3ac3b	.config	log	report			info
ci-upstream-net-this-kasan-gce	2020/09/12 19:06	net	5760d9ac	ce441f06	.config	log	report
ci-upstream-net-kasan-gce	2020/11/26 11:42	net-next	594e31bc	2f1cec62	.config	log	report			info
ci-upstream-net-kasan-gce	2020/11/25 20:05	net-next	470dfd80	1a1f4bd8	.config	log	report			info
ci-upstream-linux-next-kasan-gce-root	2020/10/03 07:25	linux-next	2172e358	2653fa43	.config	log	report			info