WARNING in taprio

WARNING in taprio_change
Status: upstream: reported C repro on 2020/09/14 09:19
Reported-by: syzbot+d50710fd0873a9c6b40c@syzkaller.appspotmail.com
First crash: 9d10h, last: 3h25m

Cause bisection: introduced by (bisect log):

commit b5b73b26b3ca34574124ed7ae9c5ba8391a7f176
Author: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Date: Thu Sep 10 00:03:11 2020 +0000

taprio: Fix allowing too small intervals

Crash: WARNING in taprio_change (log)
Repro: C syz .config

Sample crash report:

netdevsim netdevsim0 netdevsim1: set [1, 0] type 2 family 0 port 6081 - 0
netdevsim netdevsim0 netdevsim2: set [1, 0] type 2 family 0 port 6081 - 0
netdevsim netdevsim0 netdevsim3: set [1, 0] type 2 family 0 port 6081 - 0
------------[ cut here ]------------
WARNING: CPU: 1 PID: 6841 at net/sched/sch_taprio.c:998 taprio_get_start_time net/sched/sch_taprio.c:998 [inline]
WARNING: CPU: 1 PID: 6841 at net/sched/sch_taprio.c:998 taprio_change+0x1e12/0x2b60 net/sched/sch_taprio.c:1549
Kernel panic - not syncing: panic_on_warn set ...
CPU: 1 PID: 6841 Comm: syz-executor809 Not tainted 5.9.0-rc3-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x198/0x1fd lib/dump_stack.c:118
 panic+0x347/0x7c0 kernel/panic.c:231
 __warn.cold+0x20/0x46 kernel/panic.c:600
 report_bug+0x1bd/0x210 lib/bug.c:198
 handle_bug+0x38/0x90 arch/x86/kernel/traps.c:234
 exc_invalid_op+0x14/0x40 arch/x86/kernel/traps.c:254
 asm_exc_invalid_op+0x12/0x20 arch/x86/include/asm/idtentry.h:536
RIP: 0010:taprio_get_start_time net/sched/sch_taprio.c:998 [inline]
RIP: 0010:taprio_change+0x1e12/0x2b60 net/sched/sch_taprio.c:1549
Code: 8b 44 24 08 41 bf ea ff ff ff 48 c7 00 c0 af 03 89 e8 52 9b 06 fb 48 8b 7c 24 10 e8 28 63 89 01 e9 6b eb ff ff e8 3e 9b 06 fb <0f> 0b 48 83 7c 24 08 00 74 2e e8 2f 9b 06 fb 48 8b 54 24 08 48 b8
RSP: 0018:ffffc9000515f2b8 EFLAGS: 00010293
RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffffffff866dab09
RDX: ffff8880a643a240 RSI: ffffffff866dafc2 RDI: 0000000000000007
RBP: 16341fa0ca8d0652 R08: 0000000000000001 R09: ffffffff8c5f4aa7
R10: 0000000000000000 R11: 0000000000086848 R12: 0000000000000000
R13: 0000000000000000 R14: 0000000000000002 R15: 0000000000000000
 taprio_init+0x52e/0x670 net/sched/sch_taprio.c:1693
 qdisc_create+0x4b6/0x12e0 net/sched/sch_api.c:1246
 tc_modify_qdisc+0x4c8/0x1990 net/sched/sch_api.c:1662
 rtnetlink_rcv_msg+0x44e/0xad0 net/core/rtnetlink.c:5563
 netlink_rcv_skb+0x15a/0x430 net/netlink/af_netlink.c:2470
 netlink_unicast_kernel net/netlink/af_netlink.c:1304 [inline]
 netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1330
 netlink_sendmsg+0x856/0xd90 net/netlink/af_netlink.c:1919
 sock_sendmsg_nosec net/socket.c:651 [inline]
 sock_sendmsg+0xcf/0x120 net/socket.c:671
 ____sys_sendmsg+0x6e8/0x810 net/socket.c:2353
 ___sys_sendmsg+0xf3/0x170 net/socket.c:2407
 __sys_sendmsg+0xe5/0x1b0 net/socket.c:2440
 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x443839
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 fb 0f fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ffe06fb51e8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000000443839
RDX: 0000000000000000 RSI: 00000000200007c0 RDI: 0000000000000004
RBP: 00007ffe06fb51f0 R08: 0000000001bbbbbb R09: 0000000001bbbbbb
R10: 0000000001bbbbbb R11: 0000000000000246 R12: 00007ffe06fb5200
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
Kernel Offset: disabled
Rebooting in 86400 seconds..

Crashes (16):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	VM info	Maintainers
ci-upstream-net-this-kasan-gce	2020/09/12 19:24	net	5760d9ac	ce441f06	.config	log	report	syz	C		davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-net-this-kasan-gce	2020/09/22 02:23	net	e1b81391	9e1fa68e	.config	log	report			info	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-net-this-kasan-gce	2020/09/22 01:41	net	e1b81391	9e1fa68e	.config	log	report			info	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-net-this-kasan-gce	2020/09/21 23:04	net	e1b81391	9e1fa68e	.config	log	report			info	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-net-this-kasan-gce	2020/09/21 09:54	net	e1b81391	9564d2e9	.config	log	report			info	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-net-this-kasan-gce	2020/09/21 01:25	net	f13d783a	9564d2e9	.config	log	report			info	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-net-this-kasan-gce	2020/09/20 02:36	net	f13d783a	53ce8104	.config	log	report			info	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-net-this-kasan-gce	2020/09/20 01:34	net	f13d783a	53ce8104	.config	log	report			info	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-net-this-kasan-gce	2020/09/19 08:08	net	fc25fa97	53ce8104	.config	log	report			info	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-net-this-kasan-gce	2020/09/19 07:24	net	fc25fa97	53ce8104	.config	log	report			info	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-net-this-kasan-gce	2020/09/19 01:42	net	fc25fa97	53ce8104	.config	log	report			info	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-net-this-kasan-gce	2020/09/19 01:15	net	fc25fa97	53ce8104	.config	log	report			info	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-net-this-kasan-gce	2020/09/18 23:22	net	fc25fa97	53ce8104	.config	log	report			info	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-net-this-kasan-gce	2020/09/15 22:35	net	8e1b3ac4	6989d6f6	.config	log	report			info	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-net-this-kasan-gce	2020/09/12 19:06	net	5760d9ac	ce441f06	.config	log	report				davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-linux-next-kasan-gce-root	2020/09/15 11:30	linux-next	6b02addb	6989d6f6	.config	log	report			info	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com