general protection fault in cdev

general protection fault in cdev_del
Status: upstream: reported C repro on 2019/05/28 10:48
Reported-by: syzbot+67b2bd0e34f952d0321e@syzkaller.appspotmail.com
First crash: 113d, last: 7h51m

duplicates (1):
Title	Repro	Bisected	Count	Last	Reported	Patched	Status
KASAN: use-after-free Read in device_del			2	2d03h	107d	0/13	closed as dup on 2019/08/19 18:37

Sample crash report:

kasan: CONFIG_KASAN_INLINE enabled
kasan: GPF could be caused by NULL-ptr deref or user memory access
general protection fault: 0000 [#1] SMP KASAN PTI
CPU: 1 PID: 2486 Comm: kworker/1:2 Not tainted 5.2.0-rc1+ #9
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
RIP: 0010:cdev_del+0x22/0x90 fs/char_dev.c:592
Code: cf 0f 1f 80 00 00 00 00 55 48 89 fd 48 83 ec 08 e8 93 a5 d5 ff 48 8d 7d 64 48 b8 00 00 00 00 00 fc ff df 48 89 fa 48 c1 ea 03 <0f> b6 14 02 48 89 f8 83 e0 07 83 c0 03 38 d0 7c 04 84 d2 75 4f 48
RSP: 0018:ffff8881d18e7218 EFLAGS: 00010207
RAX: dffffc0000000000 RBX: ffff8881d249a100 RCX: ffffffff820d879e
RDX: 000000000000000c RSI: ffffffff8167705d RDI: 0000000000000064
RBP: 0000000000000000 R08: ffff8881d18d1800 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
R13: ffff8881d25c9100 R14: 0000000000000000 R15: ffff8881cc2a8070
FS:  0000000000000000(0000) GS:ffff8881db300000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f35af318000 CR3: 00000001cc182000 CR4: 00000000001406e0
Call Trace:
 tty_unregister_device drivers/tty/tty_io.c:3192 [inline]
 tty_unregister_device+0x10d/0x1a0 drivers/tty/tty_io.c:3187
 hso_serial_tty_unregister drivers/net/usb/hso.c:2245 [inline]
 hso_create_bulk_serial_device drivers/net/usb/hso.c:2682 [inline]
 hso_probe.cold+0xc8/0x120 drivers/net/usb/hso.c:2948
 usb_probe_interface+0x30b/0x7a0 drivers/usb/core/driver.c:361
 really_probe+0x287/0x660 drivers/base/dd.c:509
 driver_probe_device+0x104/0x210 drivers/base/dd.c:670
 __device_attach_driver+0x1c4/0x230 drivers/base/dd.c:777
 bus_for_each_drv+0x15e/0x1e0 drivers/base/bus.c:454
 __device_attach+0x217/0x360 drivers/base/dd.c:843
 bus_probe_device+0x1e6/0x290 drivers/base/bus.c:514
 device_add+0xae6/0x1700 drivers/base/core.c:2111
 usb_set_configuration+0xdf6/0x1670 drivers/usb/core/message.c:2023
 generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210
 usb_probe_device+0xa2/0x100 drivers/usb/core/driver.c:266
 really_probe+0x287/0x660 drivers/base/dd.c:509
 driver_probe_device+0x104/0x210 drivers/base/dd.c:670
 __device_attach_driver+0x1c4/0x230 drivers/base/dd.c:777
 bus_for_each_drv+0x15e/0x1e0 drivers/base/bus.c:454
 __device_attach+0x217/0x360 drivers/base/dd.c:843
 bus_probe_device+0x1e6/0x290 drivers/base/bus.c:514
 device_add+0xae6/0x1700 drivers/base/core.c:2111
 usb_new_device.cold+0x8c1/0x1016 drivers/usb/core/hub.c:2534
 hub_port_connect drivers/usb/core/hub.c:5089 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5204 [inline]
 port_event drivers/usb/core/hub.c:5350 [inline]
 hub_event+0x1adc/0x35a0 drivers/usb/core/hub.c:5432
 process_one_work+0x90a/0x1580 kernel/workqueue.c:2268
 worker_thread+0x96/0xe20 kernel/workqueue.c:2414
 kthread+0x30e/0x420 kernel/kthread.c:254
 ret_from_fork+0x3a/0x50 arch/x86/entry/entry_64.S:352
Modules linked in:
---[ end trace 3b56fa5a205cba42 ]---
RIP: 0010:cdev_del+0x22/0x90 fs/char_dev.c:592
Code: cf 0f 1f 80 00 00 00 00 55 48 89 fd 48 83 ec 08 e8 93 a5 d5 ff 48 8d 7d 64 48 b8 00 00 00 00 00 fc ff df 48 89 fa 48 c1 ea 03 <0f> b6 14 02 48 89 f8 83 e0 07 83 c0 03 38 d0 7c 04 84 d2 75 4f 48
RSP: 0018:ffff8881d18e7218 EFLAGS: 00010207
RAX: dffffc0000000000 RBX: ffff8881d249a100 RCX: ffffffff820d879e
RDX: 000000000000000c RSI: ffffffff8167705d RDI: 0000000000000064
RBP: 0000000000000000 R08: ffff8881d18d1800 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
R13: ffff8881d25c9100 R14: 0000000000000000 R15: ffff8881cc2a8070
FS:  0000000000000000(0000) GS:ffff8881db300000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f35af318000 CR3: 00000001cc182000 CR4: 00000000001406e0

All crashes (18):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	Maintainers
ci2-upstream-usb	2019/05/28 02:54	https://github.com/google/kasan.git usb-fuzzer	69bbe8c7	6bd61501	.config	log	report	syz	C	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
ci2-upstream-usb	2019/09/12 01:24	https://github.com/google/kasan.git usb-fuzzer	f0df5c1b	f4e53c10	.config	log	report	syz	C	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
ci2-upstream-usb	2019/08/31 23:07	https://github.com/google/kasan.git usb-fuzzer	eea39f24	bad3cce2	.config	log	report	syz	C	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
ci2-upstream-usb	2019/06/06 13:20	https://github.com/google/kasan.git usb-fuzzer	69bbe8c7	a547defc	.config	log	report	syz	C	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
ci2-upstream-usb	2019/06/02 09:48	https://github.com/google/kasan.git usb-fuzzer	69bbe8c7	53c81ea5	.config	log	report	syz		linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
ci2-upstream-usb	2019/09/18 16:11	https://github.com/google/kasan.git usb-fuzzer	f0df5c1b	46c0be24	.config	log	report			linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
ci2-upstream-usb	2019/09/17 13:32	https://github.com/google/kasan.git usb-fuzzer	f0df5c1b	13dcda9b	.config	log	report			linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
ci2-upstream-usb	2019/09/17 12:58	https://github.com/google/kasan.git usb-fuzzer	f0df5c1b	13dcda9b	.config	log	report			linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
ci2-upstream-usb	2019/09/13 05:00	https://github.com/google/kasan.git usb-fuzzer	f0df5c1b	40fa42bc	.config	log	report			linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
ci2-upstream-usb	2019/09/12 11:29	https://github.com/google/kasan.git usb-fuzzer	f0df5c1b	0b7672ee	.config	log	report			linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
ci2-upstream-usb	2019/09/12 09:26	https://github.com/google/kasan.git usb-fuzzer	f0df5c1b	0b7672ee	.config	log	report			linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
ci2-upstream-usb	2019/09/11 07:35	https://github.com/google/kasan.git usb-fuzzer	f0df5c1b	a60cb4cd	.config	log	report			linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
ci2-upstream-usb	2019/06/03 11:33	https://github.com/google/kasan.git usb-fuzzer	69bbe8c7	63bf051f	.config	log	report			linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
ci2-upstream-usb	2019/06/01 15:50	https://github.com/google/kasan.git usb-fuzzer	69bbe8c7	53c81ea5	.config	log	report			linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
ci2-upstream-usb	2019/05/30 23:22	https://github.com/google/kasan.git usb-fuzzer	69bbe8c7	d9aaf3c2	.config	log	report			linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
ci2-upstream-usb	2019/05/30 01:29	https://github.com/google/kasan.git usb-fuzzer	69bbe8c7	d9aaf3c2	.config	log	report			linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
ci2-upstream-usb	2019/05/29 15:36	https://github.com/google/kasan.git usb-fuzzer	69bbe8c7	f5a25d38	.config	log	report			linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
ci2-upstream-usb	2019/05/28 02:35	https://github.com/google/kasan.git usb-fuzzer	69bbe8c7	6bd61501	.config	log	report			linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk