syzbot


possible deadlock in ntfs_read_block

Status: upstream: reported C repro on 2022/09/30 22:27
Subsystems: ntfs (incorrect?)
Reported-by: syzbot+780dbcbee0942e16bcb6@syzkaller.appspotmail.com
First crash: 181d, last: 52d

Cause bisection: failed (error log, bisect log)

Fix bisection: failed (error log, bisect log)

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.2.0-rc2-syzkaller-00010-g69b41ac87e4a #0 Not tainted
------------------------------------------------------
kworker/u4:3/46 is trying to acquire lock:
ffff8880710bec40 (&rl->lock){++++}-{3:3}, at: ntfs_read_block+0x91a/0x22e0 fs/ntfs/aops.c:248

but task is already holding lock:
ffff8880710b8190 (&ni->mrec_lock){+.+.}-{3:3}, at: map_mft_record+0x46/0x610 fs/ntfs/mft.c:154

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&ni->mrec_lock){+.+.}-{3:3}:
       lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668
       __mutex_lock_common+0x1bd/0x26e0 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799
       map_mft_record+0x46/0x610 fs/ntfs/mft.c:154
       ntfs_attr_extend_allocation+0x5b3/0x4580 fs/ntfs/attrib.c:2002
       ntfs_prepare_file_for_write fs/ntfs/file.c:391 [inline]
       ntfs_file_write_iter+0x425/0x2d40 fs/ntfs/file.c:1915
       call_write_iter include/linux/fs.h:2186 [inline]
       new_sync_write fs/read_write.c:491 [inline]
       vfs_write+0x7dc/0xc50 fs/read_write.c:584
       ksys_write+0x177/0x2a0 fs/read_write.c:637
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&rl->lock){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3097 [inline]
       check_prevs_add kernel/locking/lockdep.c:3216 [inline]
       validate_chain+0x1898/0x6ae0 kernel/locking/lockdep.c:3831
       __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5055
       lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668
       down_read+0x39/0x50 kernel/locking/rwsem.c:1509
       ntfs_read_block+0x91a/0x22e0 fs/ntfs/aops.c:248
       filemap_read_folio+0x187/0x7d0 mm/filemap.c:2426
       do_read_cache_folio+0x2d3/0x790 mm/filemap.c:3553
       do_read_cache_page mm/filemap.c:3595 [inline]
       read_cache_page+0x56/0x270 mm/filemap.c:3604
       read_mapping_page include/linux/pagemap.h:755 [inline]
       ntfs_map_page fs/ntfs/aops.h:75 [inline]
       ntfs_sync_mft_mirror+0x21a/0x1df0 fs/ntfs/mft.c:480
       write_mft_record_nolock+0x1213/0x1930 fs/ntfs/mft.c:787
       write_mft_record fs/ntfs/mft.h:95 [inline]
       __ntfs_write_inode+0x721/0xc90 fs/ntfs/inode.c:3050
       write_inode fs/fs-writeback.c:1451 [inline]
       __writeback_single_inode+0x4d6/0x670 fs/fs-writeback.c:1663
       writeback_sb_inodes+0x812/0x1050 fs/fs-writeback.c:1889
       __writeback_inodes_wb+0x11d/0x260 fs/fs-writeback.c:1960
       wb_writeback+0x440/0x7b0 fs/fs-writeback.c:2065
       wb_check_start_all fs/fs-writeback.c:2187 [inline]
       wb_do_writeback fs/fs-writeback.c:2213 [inline]
       wb_workfn+0x827/0xef0 fs/fs-writeback.c:2246
       process_one_work+0x877/0xdb0 kernel/workqueue.c:2289
       worker_thread+0xb14/0x1330 kernel/workqueue.c:2436
       kthread+0x266/0x300 kernel/kthread.c:376
       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ni->mrec_lock);
                               lock(&rl->lock);
                               lock(&ni->mrec_lock);
  lock(&rl->lock);

 *** DEADLOCK ***

4 locks held by kworker/u4:3/46:
 #0: ffff8880179b4938 ((wq_completion)writeback){+.+.}-{0:0}, at: process_one_work+0x7f2/0xdb0
 #1: ffffc90000b77d00 ((work_completion)(&(&wb->dwork)->work)){+.+.}-{0:0}, at: process_one_work+0x831/0xdb0 kernel/workqueue.c:2264
 #2: ffff88807631c0e0 (&type->s_umount_key#48){++++}-{3:3}, at: trylock_super+0x1b/0xf0 fs/super.c:415
 #3: ffff8880710b8190 (&ni->mrec_lock){+.+.}-{3:3}, at: map_mft_record+0x46/0x610 fs/ntfs/mft.c:154

stack backtrace:
CPU: 1 PID: 46 Comm: kworker/u4:3 Not tainted 6.2.0-rc2-syzkaller-00010-g69b41ac87e4a #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Workqueue: writeback wb_workfn (flush-7:0)
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1b1/0x290 lib/dump_stack.c:106
 check_noncircular+0x2cc/0x390 kernel/locking/lockdep.c:2177
 check_prev_add kernel/locking/lockdep.c:3097 [inline]
 check_prevs_add kernel/locking/lockdep.c:3216 [inline]
 validate_chain+0x1898/0x6ae0 kernel/locking/lockdep.c:3831
 __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5055
 lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668
 down_read+0x39/0x50 kernel/locking/rwsem.c:1509
 ntfs_read_block+0x91a/0x22e0 fs/ntfs/aops.c:248
 filemap_read_folio+0x187/0x7d0 mm/filemap.c:2426
 do_read_cache_folio+0x2d3/0x790 mm/filemap.c:3553
 do_read_cache_page mm/filemap.c:3595 [inline]
 read_cache_page+0x56/0x270 mm/filemap.c:3604
 read_mapping_page include/linux/pagemap.h:755 [inline]
 ntfs_map_page fs/ntfs/aops.h:75 [inline]
 ntfs_sync_mft_mirror+0x21a/0x1df0 fs/ntfs/mft.c:480
 write_mft_record_nolock+0x1213/0x1930 fs/ntfs/mft.c:787
 write_mft_record fs/ntfs/mft.h:95 [inline]
 __ntfs_write_inode+0x721/0xc90 fs/ntfs/inode.c:3050
 write_inode fs/fs-writeback.c:1451 [inline]
 __writeback_single_inode+0x4d6/0x670 fs/fs-writeback.c:1663
 writeback_sb_inodes+0x812/0x1050 fs/fs-writeback.c:1889
 __writeback_inodes_wb+0x11d/0x260 fs/fs-writeback.c:1960
 wb_writeback+0x440/0x7b0 fs/fs-writeback.c:2065
 wb_check_start_all fs/fs-writeback.c:2187 [inline]
 wb_do_writeback fs/fs-writeback.c:2213 [inline]
 wb_workfn+0x827/0xef0 fs/fs-writeback.c:2246
 process_one_work+0x877/0xdb0 kernel/workqueue.c:2289
 worker_thread+0xb14/0x1330 kernel/workqueue.c:2436
 kthread+0x266/0x300 kernel/kthread.c:376
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308
 </TASK>

Crashes (112):
Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets Title
ci2-upstream-fs 2023/01/04 12:33 upstream 69b41ac87e4a 1dac8c7a .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in ntfs_read_block
ci2-upstream-fs 2022/12/17 05:33 upstream 84e57d292203 05494336 .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in ntfs_read_block
ci2-upstream-fs 2022/12/12 04:03 upstream 4cee37b3a4e6 67be1ae7 .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in ntfs_read_block
ci2-upstream-fs 2022/12/09 10:33 upstream f3e8416619ce 1034e5fa .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in ntfs_read_block
ci2-upstream-fs 2022/12/02 20:50 upstream a4412fdd49dc e080de16 .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in ntfs_read_block
ci2-upstream-fs 2022/12/02 06:53 upstream ef4d3ea40565 e080de16 .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in ntfs_read_block
ci2-upstream-fs 2022/11/24 14:06 upstream 4312098baf37 ff68ff8f .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in ntfs_read_block
ci2-upstream-fs 2022/10/01 12:43 upstream 70575e77839f feb56351 .config strace log report syz C [disk image] [vmlinux] possible deadlock in ntfs_read_block
ci-upstream-gce-arm64 2023/01/04 15:16 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci a5541c0811a0 1dac8c7a .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in ntfs_read_block
ci-upstream-gce-arm64 2022/12/17 07:52 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci a5541c0811a0 05494336 .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in ntfs_read_block
ci-upstream-gce-arm64 2022/12/12 06:49 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci a5541c0811a0 67be1ae7 .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in ntfs_read_block
ci-upstream-gce-arm64 2022/12/09 20:12 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci a5541c0811a0 67be1ae7 .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in ntfs_read_block
ci-upstream-gce-arm64 2022/12/02 10:27 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci cdb931b58ff5 e080de16 .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in ntfs_read_block
ci-upstream-gce-arm64 2022/09/30 20:55 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci bbed346d5a96 feb56351 .config console log report syz C [disk image] [vmlinux] possible deadlock in ntfs_read_block
ci-upstream-kasan-gce-smack-root 2023/02/03 11:08 upstream 66a87fff1a87 16d19e30 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/02/03 00:50 upstream e7368fd30165 16d19e30 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/02/02 08:41 upstream 9f266ccaa2f5 9a6f477c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/02/02 02:30 upstream 9f266ccaa2f5 9a6f477c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/02/01 22:17 upstream c0b67534c95c 9a6f477c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/02/01 17:26 upstream c0b67534c95c 9a6f477c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci-upstream-kasan-gce-smack-root 2023/02/01 13:59 upstream c0b67534c95c 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/30 19:22 upstream 6d796c50f84c b68fb8d6 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/30 18:21 upstream 6d796c50f84c b68fb8d6 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/30 05:30 upstream ab072681eabe 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci-upstream-kasan-gce-smack-root 2023/01/29 10:20 upstream c96618275234 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/29 04:07 upstream c96618275234 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/28 15:40 upstream 5af6ce704936 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/28 11:52 upstream 5af6ce704936 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/26 03:23 upstream 7c46948a6e9c 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/25 11:51 upstream 948ef7bb70c4 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/25 10:12 upstream fb6e71db53f3 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/23 11:47 upstream 2475bf0250de 44388686 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/23 05:51 upstream 2475bf0250de cc0f9968 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci-upstream-kasan-gce-smack-root 2023/01/19 22:59 upstream 081edded9b38 1b826a2f .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/18 21:36 upstream c1649ec55708 4620c2d9 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/18 03:29 upstream 6e50979a9c87 42660d9e .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/17 15:24 upstream d532dd102151 a63719e7 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/17 11:07 upstream d532dd102151 a63719e7 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/17 07:18 upstream d532dd102151 a63719e7 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/16 19:47 upstream 5dc4c995db9e a63719e7 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci-upstream-kasan-gce-smack-root 2023/01/16 07:14 upstream 5dc4c995db9e a63719e7 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/15 07:46 upstream 7c6984405241 a63719e7 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/14 18:52 upstream 97ec4d559d93 a63719e7 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/14 01:22 upstream d9fc1511728c 529798b0 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/13 15:20 upstream d9fc1511728c 529798b0 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/13 05:08 upstream c757fc92a3f7 96166539 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/11 02:31 upstream 40c18f363a08 48bc529a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/10 08:37 upstream 5a41237ad1d4 48bc529a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/05 21:50 upstream 41c03ba9beea 1dac8c7a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci-upstream-kasan-gce-smack-root 2023/01/05 05:11 upstream 512dee0c00ad 1dac8c7a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/02 13:58 upstream 88603b6dc419 ab32d508 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/02 02:10 upstream e4cf7c25bae5 ab32d508 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2023/01/01 13:14 upstream e4cf7c25bae5 ab32d508 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2022/12/30 00:22 upstream 2258c2dc850b 44712fbc .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci2-upstream-fs 2022/12/29 17:40 upstream 1b929c02afd3 44712fbc .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci-upstream-gce-arm64 2023/02/06 20:08 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci ca72d58361ee 0a9c11b6 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci-upstream-gce-arm64 2023/01/17 12:59 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 9598c377d828 a63719e7 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci-upstream-gce-arm64 2023/01/16 03:30 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 9598c377d828 a63719e7 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci-upstream-gce-arm64 2023/01/11 15:46 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 358a161a6a9e 1dac8c7a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in ntfs_read_block
ci-upstream-gce-arm64 2022/09/30 20:11 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci bbed346d5a96 feb56351 .config console log report info [disk image] [vmlinux] possible deadlock in ntfs_read_block
* Struck through repros no longer work on HEAD.