KCSAN: data-race in wg_packet_send_staged_packets / wg_packet_send_staged

KCSAN: data-race in wg_packet_send_staged_packets / wg_packet_send_staged_packets (2)
Status: moderation: reported on 2020/10/23 14:26
Reported-by: syzbot+cdfd0c266dd84d19e3fd@syzkaller.appspotmail.com
First crash: 261d, last: 22d

similar bugs (1):
Kernel	Title	Repro	Cause bisect	Fix bisect	Count	Last	Reported	Patched	Status
upstream	KCSAN: data-race in wg_packet_send_staged_packets / wg_packet_send_staged_packets				15	265d	303d	0/21	closed as invalid on 2020/06/18 14:24

Sample crash report:

==================================================================
BUG: KCSAN: data-race in wg_packet_send_staged_packets / wg_packet_send_staged_packets

write to 0xffff88802408aa08 of 4 bytes by interrupt on cpu 1:
 wg_cpumask_next_online drivers/net/wireguard/queueing.h:134 [inline]
 wg_queue_enqueue_per_device_and_peer drivers/net/wireguard/queueing.h:153 [inline]
 wg_packet_create_data drivers/net/wireguard/send.c:326 [inline]
 wg_packet_send_staged_packets+0x5d9/0x9b0 drivers/net/wireguard/send.c:396
 wg_packet_send_keepalive+0x102/0x120 drivers/net/wireguard/send.c:239
 wg_expired_send_persistent_keepalive+0x38/0x50 drivers/net/wireguard/timers.c:141
 call_timer_fn+0x2e/0x240 kernel/time/timer.c:1417
 expire_timers+0x116/0x260 kernel/time/timer.c:1462
 __run_timers+0x358/0x3f0 kernel/time/timer.c:1731
 run_timer_softirq+0x19/0x30 kernel/time/timer.c:1744
 __do_softirq+0x13c/0x2c3 kernel/softirq.c:343
 asm_call_irq_on_stack+0xf/0x20
 __run_on_irqstack arch/x86/include/asm/irq_stack.h:26 [inline]
 run_on_irqstack_cond arch/x86/include/asm/irq_stack.h:77 [inline]
 do_softirq_own_stack+0x32/0x40 arch/x86/kernel/irq_64.c:77
 invoke_softirq kernel/softirq.c:226 [inline]
 __irq_exit_rcu+0xb4/0xc0 kernel/softirq.c:420
 sysvec_apic_timer_interrupt+0x74/0x90 arch/x86/kernel/apic/apic.c:1100
 asm_sysvec_apic_timer_interrupt+0x12/0x20 arch/x86/include/asm/idtentry.h:629
 native_safe_halt arch/x86/include/asm/irqflags.h:60 [inline]
 arch_safe_halt arch/x86/include/asm/irqflags.h:103 [inline]
 acpi_safe_halt drivers/acpi/processor_idle.c:110 [inline]
 acpi_idle_do_entry drivers/acpi/processor_idle.c:516 [inline]
 acpi_idle_enter+0x25b/0x2e0 drivers/acpi/processor_idle.c:647
 cpuidle_enter_state+0x2b6/0x7c0 drivers/cpuidle/cpuidle.c:237
 cpuidle_enter+0x3c/0x60 drivers/cpuidle/cpuidle.c:351
 call_cpuidle kernel/sched/idle.c:158 [inline]
 cpuidle_idle_call kernel/sched/idle.c:239 [inline]
 do_idle+0x193/0x230 kernel/sched/idle.c:299
 cpu_startup_entry+0x15/0x20 kernel/sched/idle.c:396
 secondary_startup_64_no_verify+0xb0/0xbb

read to 0xffff88802408aa08 of 4 bytes by interrupt on cpu 0:
 wg_cpumask_next_online drivers/net/wireguard/queueing.h:130 [inline]
 wg_queue_enqueue_per_device_and_peer drivers/net/wireguard/queueing.h:153 [inline]
 wg_packet_create_data drivers/net/wireguard/send.c:326 [inline]
 wg_packet_send_staged_packets+0x595/0x9b0 drivers/net/wireguard/send.c:396
 wg_packet_send_keepalive+0x102/0x120 drivers/net/wireguard/send.c:239
 wg_expired_send_persistent_keepalive+0x38/0x50 drivers/net/wireguard/timers.c:141
 call_timer_fn+0x2e/0x240 kernel/time/timer.c:1417
 expire_timers+0x116/0x260 kernel/time/timer.c:1462
 __run_timers+0x358/0x3f0 kernel/time/timer.c:1731
 run_timer_softirq+0x19/0x30 kernel/time/timer.c:1744
 __do_softirq+0x13c/0x2c3 kernel/softirq.c:343
 asm_call_irq_on_stack+0xf/0x20
 __run_on_irqstack arch/x86/include/asm/irq_stack.h:26 [inline]
 run_on_irqstack_cond arch/x86/include/asm/irq_stack.h:77 [inline]
 do_softirq_own_stack+0x32/0x40 arch/x86/kernel/irq_64.c:77
 invoke_softirq kernel/softirq.c:226 [inline]
 __irq_exit_rcu+0xb4/0xc0 kernel/softirq.c:420
 sysvec_apic_timer_interrupt+0x74/0x90 arch/x86/kernel/apic/apic.c:1100
 asm_sysvec_apic_timer_interrupt+0x12/0x20 arch/x86/include/asm/idtentry.h:629
 native_restore_fl arch/x86/include/asm/irqflags.h:41 [inline]
 arch_local_irq_restore arch/x86/include/asm/irqflags.h:84 [inline]
 __raw_spin_unlock_irqrestore include/linux/spinlock_api_smp.h:160 [inline]
 _raw_spin_unlock_irqrestore+0x32/0x50 kernel/locking/spinlock.c:191
 spin_unlock_irqrestore include/linux/spinlock.h:409 [inline]
 pcpu_alloc+0x84e/0x1090 mm/percpu.c:1806
 __alloc_percpu_gfp+0x22/0x30 mm/percpu.c:1893
 bpf_map_alloc_percpu+0xab/0x120 kernel/bpf/syscall.c:435
 prealloc_init kernel/bpf/hashtab.c:296 [inline]
 htab_map_alloc+0x807/0xc70 kernel/bpf/hashtab.c:508
 find_and_alloc_map kernel/bpf/syscall.c:122 [inline]
 map_create kernel/bpf/syscall.c:828 [inline]
 __do_sys_bpf+0x420c/0x9950 kernel/bpf/syscall.c:4364
 __se_sys_bpf kernel/bpf/syscall.c:4340 [inline]
 __x64_sys_bpf+0x3d/0x50 kernel/bpf/syscall.c:4340
 do_syscall_64+0x39/0x80 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xa9

Reported by Kernel Concurrency Sanitizer on:
CPU: 0 PID: 15797 Comm: syz-executor.5 Not tainted 5.11.0-rc7-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
==================================================================

Crashes (102):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	VM info	Title
ci2-upstream-kcsan-gce	2021/02/13 08:34	upstream	dcc0b490	98682e5e	.config	log	report	info	KCSAN: data-race in wg_packet_send_staged_packets / wg_packet_send_staged_packets
ci2-upstream-kcsan-gce	2021/02/10 04:43	upstream	e0756cfc	2bd9619f	.config	log	report	info	KCSAN: data-race in wg_packet_send_staged_packets / wg_packet_send_staged_packets
ci2-upstream-kcsan-gce	2021/02/04 06:58	upstream	3afe9076	624dad51	.config	log	report	info	KCSAN: data-race in wg_packet_send_staged_packets / wg_packet_send_staged_packets
ci2-upstream-kcsan-gce	2021/02/03 16:33	upstream	3aaf0a27	624dad51	.config	log	report	info	KCSAN: data-race in wg_packet_send_staged_packets / wg_packet_send_staged_packets
ci2-upstream-kcsan-gce	2021/01/29 15:16	upstream	bec4c296	6593fd32	.config	log	report	info	KCSAN: data-race in wg_packet_send_staged_packets / wg_packet_send_staged_packets
ci2-upstream-kcsan-gce	2021/01/26 05:35	upstream	f8ad8187	52e37319	.config	log	report	info	KCSAN: data-race in wg_packet_send_staged_packets / wg_packet_send_staged_packets
ci2-upstream-kcsan-gce	2021/01/25 19:35	upstream	6ee1d745	52e37319	.config	log	report	info	KCSAN: data-race in wg_packet_send_staged_packets / wg_packet_send_staged_packets
ci2-upstream-kcsan-gce	2021/01/25 06:59	upstream	e6806137	52e37319	.config	log	report	info	KCSAN: data-race in wg_packet_send_staged_packets / wg_packet_send_staged_packets
ci2-upstream-kcsan-gce	2021/01/24 02:31	upstream	e1ae4b0b	52e37319	.config	log	report	info	KCSAN: data-race in wg_packet_send_staged_packets / wg_packet_send_staged_packets
ci2-upstream-kcsan-gce	2021/01/22 00:04	upstream	9791581c	d4f4eca5	.config	log	report	info	KCSAN: data-race in wg_packet_send_staged_packets / wg_packet_send_staged_packets
ci2-upstream-kcsan-gce	2021/01/17 14:32	upstream	0da0a8a0	813be542	.config	log	report	info	KCSAN: data-race in wg_packet_send_staged_packets / wg_packet_send_staged_packets
ci2-upstream-kcsan-gce	2021/01/17 07:30	upstream	54c6247d	65a7a854	.config	log	report	info
ci2-upstream-kcsan-gce	2021/01/14 18:37	upstream	65f0d241	468dbb55	.config	log	report	info
ci2-upstream-kcsan-gce	2021/01/12 07:26	upstream	a0d54b4f	2c1f2513	.config	log	report	info
ci2-upstream-kcsan-gce	2021/01/09 00:50	upstream	6279d812	c104d4a3	.config	log	report	info
ci2-upstream-kcsan-gce	2021/01/01 23:09	upstream	f6e1ea19	79264ae3	.config	log	report	info
ci2-upstream-kcsan-gce	2020/12/31 08:07	upstream	f6e1ea19	5cc121d6	.config	log	report	info
ci2-upstream-kcsan-gce	2020/12/30 06:14	upstream	139711f0	0fa352f2	.config	log	report	info
ci2-upstream-kcsan-gce	2020/12/28 07:33	upstream	5c8fe583	2242f77f	.config	log	report	info
ci2-upstream-kcsan-gce	2020/12/21 20:15	upstream	e37b12e4	04201c06	.config	log	report	info
ci2-upstream-kcsan-gce	2020/12/21 03:15	upstream	6a447b0e	04201c06	.config	log	report	info
ci2-upstream-kcsan-gce	2020/12/16 21:44	upstream	5e60366d	04201c06	.config	log	report	info
ci2-upstream-kcsan-gce	2020/12/08 06:02	upstream	cd796ed3	51a9082e	.config	log	report	info
ci2-upstream-kcsan-gce	2020/12/05 06:07	upstream	e87297fa	20366b87	.config	log	report	info
ci2-upstream-kcsan-gce	2020/11/28 17:22	upstream	c84e1efa	3c7136c0	.config	log	report	info
ci2-upstream-kcsan-gce	2020/11/27 14:36	upstream	85a2c56c	486f93ef	.config	log	report	info
ci2-upstream-kcsan-gce	2020/11/22 16:54	upstream	a349e4c6	0d27f508	.config	log	report	info
ci2-upstream-kcsan-gce	2020/11/21 01:37	upstream	4d02da97	68068804	.config	log	report	info
ci2-upstream-kcsan-gce	2020/11/19 17:59	upstream	c2e7554e	0767f13f	.config	log	report	info
ci2-upstream-kcsan-gce	2020/11/18 18:48	upstream	0fa8ee0d	0767f13f	.config	log	report	info
ci2-upstream-kcsan-gce	2020/11/17 01:39	upstream	9c87c9f4	1bf9a662	.config	log	report	info
ci2-upstream-kcsan-gce	2020/11/16 10:46	upstream	09162bc3	1bf9a662	.config	log	report	info
ci2-upstream-kcsan-gce	2020/11/16 04:36	upstream	0062442e	1bf9a662	.config	log	report	info
ci2-upstream-kcsan-gce	2020/11/15 07:40	upstream	e28c0d7c	1bf9a662	.config	log	report	info
ci2-upstream-kcsan-gce	2020/11/14 00:41	upstream	9e6a39ea	1bf9a662	.config	log	report	info
ci2-upstream-kcsan-gce	2020/11/13 17:28	upstream	585e5b17	4a7fa9b4	.config	log	report	info
ci2-upstream-kcsan-gce	2020/11/13 00:16	upstream	af5043c8	16fca0c8	.config	log	report	info
ci2-upstream-kcsan-gce	2020/11/11 19:22	upstream	eccc8767	cca87986	.config	log	report	info
ci2-upstream-kcsan-gce	2020/11/10 07:03	upstream	3552c370	cba33199	.config	log	report	info
ci2-upstream-kcsan-gce	2020/11/07 06:12	upstream	bf3e7628	cba33199	.config	log	report	info
ci2-upstream-kcsan-gce	2020/11/06 07:17	upstream	521b619a	cba33199	.config	log	report	info
ci2-upstream-kcsan-gce	2020/11/04 19:06	upstream	4ef8451b	cba33199	.config	log	report	info
ci2-upstream-kcsan-gce	2020/11/02 16:20	upstream	3cea11cd	8bc4594f	.config	log	report	info
ci2-upstream-kcsan-gce	2020/11/01 01:01	upstream	c2dc4c07	8bc4594f	.config	log	report	info
ci2-upstream-kcsan-gce	2020/10/23 08:22	upstream	96485e44	4e740c00	.config	log	report	info
ci2-upstream-kcsan-gce	2020/06/19 19:26	upstream	5e857ce6	123cf502	.config	log	report