syzbot


possible deadlock in ext4_bmap

Status: upstream: reported C repro on 2022/08/08 07:33
Reported-by: syzbot+9543479984ae9e576000@syzkaller.appspotmail.com
First crash: 59d, last: 5m

Cause bisection: failed (bisect log)
Patch testing requests:
Created Duration User Patch Repo Result
2022/08/09 11:10 18m hdanton@sina.com patch https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git ca688bff68bc OK log

Sample crash report:
warning: checkpointing journal with EXT4_IOC_CHECKPOINT_FLAG_ZEROOUT can be slow
======================================================
WARNING: possible circular locking dependency detected
6.0.0-rc1-syzkaller-00399-g15b3f48a4339 #0 Not tainted
------------------------------------------------------
syz-executor339/3603 is trying to acquire lock:
ffff88801e2d0400 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: inode_lock_shared include/linux/fs.h:766 [inline]
ffff88801e2d0400 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: ext4_bmap+0x4e/0x460 fs/ext4/inode.c:3157

but task is already holding lock:
ffff88814b1583f8 (&journal->j_checkpoint_mutex){+.+.}-{3:3}, at: jbd2_journal_flush+0x487/0xc00 fs/jbd2/journal.c:2472

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&journal->j_checkpoint_mutex){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       mutex_lock_io_nested+0x13f/0x1190 kernel/locking/mutex.c:833
       jbd2_journal_flush+0x19a/0xc00 fs/jbd2/journal.c:2462
       ext4_ioctl_checkpoint fs/ext4/ioctl.c:1082 [inline]
       __ext4_ioctl+0x28fd/0x4ab0 fs/ext4/ioctl.c:1586
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:870 [inline]
       __se_sys_ioctl fs/ioctl.c:856 [inline]
       __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #2 (&journal->j_barrier){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x12f/0x1350 kernel/locking/mutex.c:747
       jbd2_journal_lock_updates+0x15e/0x310 fs/jbd2/transaction.c:904
       ext4_change_inode_journal_flag+0x180/0x530 fs/ext4/inode.c:6014
       ext4_ioctl_setflags fs/ext4/ioctl.c:685 [inline]
       ext4_fileattr_set+0xddf/0x1930 fs/ext4/ioctl.c:1001
       vfs_fileattr_set+0x7f5/0xbe0 fs/ioctl.c:696
       ioctl_fssetxattr fs/ioctl.c:758 [inline]
       do_vfs_ioctl+0xe62/0x15c0 fs/ioctl.c:845
       __do_sys_ioctl fs/ioctl.c:868 [inline]
       __se_sys_ioctl fs/ioctl.c:856 [inline]
       __x64_sys_ioctl+0x108/0x200 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #1 (&sbi->s_writepages_rwsem){++++}-{0:0}:
       percpu_down_write+0x4d/0x440 kernel/locking/percpu-rwsem.c:221
       ext4_ind_migrate+0x237/0x840 fs/ext4/migrate.c:624
       ext4_ioctl_setflags fs/ext4/ioctl.c:694 [inline]
       ext4_fileattr_set+0x14b8/0x1930 fs/ext4/ioctl.c:1001
       vfs_fileattr_set+0x7f5/0xbe0 fs/ioctl.c:696
       ioctl_fssetxattr fs/ioctl.c:758 [inline]
       do_vfs_ioctl+0xe62/0x15c0 fs/ioctl.c:845
       __do_sys_ioctl fs/ioctl.c:868 [inline]
       __se_sys_ioctl fs/ioctl.c:856 [inline]
       __x64_sys_ioctl+0x108/0x200 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&sb->s_type->i_mutex_key#8){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3095 [inline]
       check_prevs_add kernel/locking/lockdep.c:3214 [inline]
       validate_chain kernel/locking/lockdep.c:3829 [inline]
       __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5053
       lock_acquire kernel/locking/lockdep.c:5666 [inline]
       lock_acquire+0x1ab/0x570 kernel/locking/lockdep.c:5631
       down_read+0x98/0x450 kernel/locking/rwsem.c:1499
       inode_lock_shared include/linux/fs.h:766 [inline]
       ext4_bmap+0x4e/0x460 fs/ext4/inode.c:3157
       bmap+0xaa/0x120 fs/inode.c:1799
       jbd2_journal_bmap+0xa8/0x180 fs/jbd2/journal.c:971
       __jbd2_journal_erase fs/jbd2/journal.c:1784 [inline]
       jbd2_journal_flush+0x84f/0xc00 fs/jbd2/journal.c:2490
       ext4_ioctl_checkpoint fs/ext4/ioctl.c:1082 [inline]
       __ext4_ioctl+0x28fd/0x4ab0 fs/ext4/ioctl.c:1586
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:870 [inline]
       __se_sys_ioctl fs/ioctl.c:856 [inline]
       __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

Chain exists of:
  &sb->s_type->i_mutex_key#8 --> &journal->j_barrier --> &journal->j_checkpoint_mutex

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&journal->j_checkpoint_mutex);
                               lock(&journal->j_barrier);
                               lock(&journal->j_checkpoint_mutex);
  lock(&sb->s_type->i_mutex_key#8);

 *** DEADLOCK ***

2 locks held by syz-executor339/3603:
 #0: ffff88814b158170 (&journal->j_barrier){+.+.}-{3:3}, at: jbd2_journal_lock_updates+0x15e/0x310 fs/jbd2/transaction.c:904
 #1: ffff88814b1583f8 (&journal->j_checkpoint_mutex){+.+.}-{3:3}, at: jbd2_journal_flush+0x487/0xc00 fs/jbd2/journal.c:2472

stack backtrace:
CPU: 1 PID: 3603 Comm: syz-executor339 Not tainted 6.0.0-rc1-syzkaller-00399-g15b3f48a4339 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/22/2022
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106
 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3095 [inline]
 check_prevs_add kernel/locking/lockdep.c:3214 [inline]
 validate_chain kernel/locking/lockdep.c:3829 [inline]
 __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5053
 lock_acquire kernel/locking/lockdep.c:5666 [inline]
 lock_acquire+0x1ab/0x570 kernel/locking/lockdep.c:5631
 down_read+0x98/0x450 kernel/locking/rwsem.c:1499
 inode_lock_shared include/linux/fs.h:766 [inline]
 ext4_bmap+0x4e/0x460 fs/ext4/inode.c:3157
 bmap+0xaa/0x120 fs/inode.c:1799
 jbd2_journal_bmap+0xa8/0x180 fs/jbd2/journal.c:971
 __jbd2_journal_erase fs/jbd2/journal.c:1784 [inline]
 jbd2_journal_flush+0x84f/0xc00 fs/jbd2/journal.c:2490
 ext4_ioctl_checkpoint fs/ext4/ioctl.c:1082 [inline]
 __ext4_ioctl+0x28fd/0x4ab0 fs/ext4/ioctl.c:1586
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:870 [inline]
 __se_sys_ioctl fs/ioctl.c:856 [inline]
 __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:856
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fbad1ff9b69
Code: 28 c3 e8 2a 14 00 00 66 2e 0f 1f 84 00 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc0cef7d38 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fbad1ff9b69
RDX: 0000000020000000 RSI: 000000004004662b RDI: 0000000000000004
RBP: 00007fbad1fbdd10 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007fbad1fbdda0

Crashes (28526):
Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Title
ci-upstream-kasan-gce-root 2022/08/21 13:03 upstream 15b3f48a4339 26a13b38 .config log report syz C possible deadlock in ext4_bmap
ci-upstream-bpf-kasan-gce 2022/08/24 22:03 bpf 0947ae112108 514514f6 .config log report syz C possible deadlock in ext4_bmap
ci-upstream-bpf-kasan-gce 2022/08/24 21:50 bpf 0947ae112108 514514f6 .config log report syz C possible deadlock in ext4_bmap
ci-upstream-bpf-next-kasan-gce 2022/08/24 20:42 bpf-next d24433c0f4a3 514514f6 .config log report syz C possible deadlock in ext4_bmap
ci-upstream-bpf-next-kasan-gce 2022/08/24 20:23 bpf-next d24433c0f4a3 514514f6 .config log report syz C possible deadlock in ext4_bmap
ci-upstream-linux-next-kasan-gce-root 2022/08/08 19:02 linux-next ca688bff68bc 88e3a122 .config log report syz C possible deadlock in ext4_bmap
ci-upstream-kasan-gce-smack-root 2022/10/06 04:32 upstream 833477fce7a1 2c6543ad .config log report info possible deadlock in ext4_bmap
ci-upstream-kasan-gce-root 2022/10/06 03:43 upstream 833477fce7a1 2c6543ad .config log report info possible deadlock in ext4_bmap
ci2-upstream-fs 2022/10/06 02:53 upstream 2bca25eaeba6 2c6543ad .config log report info possible deadlock in ext4_bmap
ci-upstream-kasan-gce-root 2022/10/06 02:01 upstream 833477fce7a1 2c6543ad .config log report info possible deadlock in ext4_bmap
ci-upstream-kasan-gce-selinux-root 2022/10/06 01:00 upstream 833477fce7a1 2c6543ad .config log report info possible deadlock in ext4_bmap
ci2-upstream-fs 2022/10/05 23:58 upstream 2bca25eaeba6 2c6543ad .config log report info possible deadlock in ext4_bmap
ci2-upstream-fs 2022/10/05 21:11 upstream 2bca25eaeba6 2c6543ad .config log report info possible deadlock in ext4_bmap
ci2-upstream-fs 2022/10/05 21:01 upstream 2bca25eaeba6 2c6543ad .config log report info possible deadlock in ext4_bmap
ci-upstream-kasan-gce-smack-root 2022/10/05 19:50 upstream 2bca25eaeba6 267e3bb1 .config log report info possible deadlock in ext4_bmap
ci2-upstream-fs 2022/10/05 18:57 upstream 0326074ff465 267e3bb1 .config log report info possible deadlock in ext4_bmap
ci-upstream-kasan-gce-selinux-root 2022/10/05 17:52 upstream 2bca25eaeba6 267e3bb1 .config log report info possible deadlock in ext4_bmap
ci2-upstream-fs 2022/10/05 16:48 upstream 0326074ff465 267e3bb1 .config log report info possible deadlock in ext4_bmap
ci-upstream-kasan-gce-root 2022/10/05 15:51 upstream 2bca25eaeba6 267e3bb1 .config log report info possible deadlock in ext4_bmap
ci2-upstream-fs 2022/10/05 15:09 upstream 0326074ff465 267e3bb1 .config log report info possible deadlock in ext4_bmap
ci-upstream-kasan-gce-selinux-root 2022/10/05 14:52 upstream 2bca25eaeba6 267e3bb1 .config log report info possible deadlock in ext4_bmap
ci-upstream-kasan-gce-selinux-root 2022/10/05 13:52 upstream 2bca25eaeba6 267e3bb1 .config log report info possible deadlock in ext4_bmap
ci-upstream-kasan-gce-smack-root 2022/10/05 09:34 upstream 2bca25eaeba6 eab8f949 .config log report info possible deadlock in ext4_bmap
ci-upstream-kasan-gce-root 2022/10/05 07:40 upstream a5088ee7251e eab8f949 .config log report info possible deadlock in ext4_bmap
ci2-upstream-fs 2022/10/05 05:43 upstream 0326074ff465 267e3bb1 .config log report info possible deadlock in ext4_bmap
ci-upstream-kasan-gce-selinux-root 2022/10/05 05:40 upstream a5088ee7251e eab8f949 .config log report info possible deadlock in ext4_bmap
ci2-upstream-fs 2022/10/05 04:38 upstream 0326074ff465 267e3bb1 .config log report info possible deadlock in ext4_bmap
ci2-upstream-fs 2022/10/05 03:37 upstream 0326074ff465 267e3bb1 .config log report info possible deadlock in ext4_bmap
ci-qemu-upstream 2022/10/05 01:16 upstream 0326074ff465 267e3bb1 .config log report info possible deadlock in ext4_bmap
ci-upstream-kasan-gce-root 2022/10/05 01:11 upstream a5088ee7251e eab8f949 .config log report info possible deadlock in ext4_bmap
ci-upstream-kasan-gce-root 2022/10/04 22:18 upstream a5088ee7251e eab8f949 .config log report info possible deadlock in ext4_bmap
ci2-upstream-fs 2022/10/04 21:42 upstream 4fe89d07dcc2 eab8f949 .config log report info possible deadlock in ext4_bmap
ci-upstream-kasan-gce-selinux-root 2022/10/04 20:40 upstream a5088ee7251e eab8f949 .config log report info possible deadlock in ext4_bmap
ci-upstream-kasan-gce-smack-root 2022/10/04 19:39 upstream a5088ee7251e eab8f949 .config log report info possible deadlock in ext4_bmap
ci-upstream-kasan-gce-root 2022/10/04 19:14 upstream a5088ee7251e eab8f949 .config log report info possible deadlock in ext4_bmap
ci-upstream-kasan-gce-smack-root 2022/10/04 18:23 upstream a5088ee7251e eab8f949 .config log report info possible deadlock in ext4_bmap
ci-upstream-kasan-gce-root 2022/10/04 18:12 upstream a5088ee7251e eab8f949 .config log report info possible deadlock in ext4_bmap
ci-qemu-upstream-386 2022/10/06 02:07 upstream 833477fce7a1 2c6543ad .config log report info possible deadlock in ext4_bmap
ci-qemu-upstream-386 2022/10/05 22:52 upstream 833477fce7a1 2c6543ad .config log report info possible deadlock in ext4_bmap
ci-qemu-upstream-386 2022/10/05 02:50 upstream 0326074ff465 267e3bb1 .config log report info possible deadlock in ext4_bmap
ci-upstream-bpf-kasan-gce 2022/10/06 00:27 bpf 0326074ff465 2c6543ad .config log report info possible deadlock in ext4_bmap
ci-upstream-bpf-kasan-gce 2022/10/05 23:29 bpf 0326074ff465 2c6543ad .config log report info possible deadlock in ext4_bmap
ci-upstream-net-this-kasan-gce 2022/10/05 22:14 net 0326074ff465 2c6543ad .config log report info possible deadlock in ext4_bmap
ci-upstream-net-this-kasan-gce 2022/10/05 22:11 net 0326074ff465 2c6543ad .config log report info possible deadlock in ext4_bmap
ci-upstream-net-this-kasan-gce 2022/10/05 17:53 net 0326074ff465 267e3bb1 .config log report info possible deadlock in ext4_bmap
ci-upstream-net-this-kasan-gce 2022/10/05 12:54 net 0326074ff465 267e3bb1 .config log report info possible deadlock in ext4_bmap
ci-upstream-net-this-kasan-gce 2022/10/05 12:15 net 0326074ff465 267e3bb1 .config log report info possible deadlock in ext4_bmap
ci-upstream-net-this-kasan-gce 2022/10/05 11:46 net 0326074ff465 267e3bb1 .config log report info possible deadlock in ext4_bmap
ci-upstream-net-this-kasan-gce 2022/10/05 11:14 net 0326074ff465 267e3bb1 .config log report info possible deadlock in ext4_bmap
ci-upstream-net-this-kasan-gce 2022/10/05 10:16 net 0326074ff465 267e3bb1 .config log report info possible deadlock in ext4_bmap
ci-upstream-net-this-kasan-gce 2022/10/05 09:11 net 0326074ff465 eab8f949 .config log report info possible deadlock in ext4_bmap
ci-upstream-bpf-kasan-gce 2022/10/05 00:10 bpf 0152dfee235e eab8f949 .config log report info possible deadlock in ext4_bmap
ci-upstream-net-this-kasan-gce 2022/10/04 17:10 net 93e2be344a7d eab8f949 .config log report info possible deadlock in ext4_bmap
ci-upstream-net-kasan-gce 2022/10/05 10:49 net-next 0326074ff465 267e3bb1 .config log report info possible deadlock in ext4_bmap
ci-upstream-bpf-next-kasan-gce 2022/10/05 06:35 bpf-next b89eced8c329 eab8f949 .config log report info possible deadlock in ext4_bmap
ci-upstream-bpf-next-kasan-gce 2022/10/04 23:19 bpf-next b89eced8c329 eab8f949 .config log report info possible deadlock in ext4_bmap
ci-upstream-linux-next-kasan-gce-root 2022/08/22 03:00 linux-next 8755ae45a9e8 26a13b38 .config log report info possible deadlock in ext4_bmap
ci-upstream-linux-next-kasan-gce-root 2022/08/08 07:09 linux-next ca688bff68bc 88e3a122 .config log report info possible deadlock in ext4_bmap
ci-upstream-linux-next-kasan-gce-root 2022/08/08 04:36 linux-next ca688bff68bc 88e3a122 .config log report info possible deadlock in ext4_bmap
ci-upstream-gce-arm64 2022/10/05 08:29 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci bbed346d5a96 eab8f949 .config log report info possible deadlock in ext4_bmap
ci-upstream-gce-arm64 2022/10/05 02:25 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci bbed346d5a96 eab8f949 .config log report info possible deadlock in ext4_bmap
* Struck through repros no longer work on HEAD.