BUG: corrupted list in klist

BUG: corrupted list in klist_release
Status: upstream: reported C repro on 2020/12/15 22:34
Reported-by: syzbot+676530ea9d4736aad21c@syzkaller.appspotmail.com
First crash: 130d, last: 16d

Cause bisection: introduced by (bisect log) [merge commit]:
commit e812bd905a5cf00fea95da9df4889dad63d4a36a
Author: David S. Miller <davem@davemloft.net>
Date: Sat Sep 17 13:53:29 2016 +0000

Merge tag 'wireless-drivers-next-for-davem-2016-09-15' of git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next

Crash: general protection fault in batadv_iv_ogm_queue_add (log)
Repro: C syz .config

Sample crash report:

IPVS: ftp: loaded support on port[0] = 21
list_del corruption. prev->next should be ffff888014175068, but was ffff888013316040
------------[ cut here ]------------
kernel BUG at lib/list_debug.c:51!
invalid opcode: 0000 [#1] PREEMPT SMP KASAN
CPU: 1 PID: 8380 Comm: syz-executor498 Not tainted 5.12.0-rc5-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:__list_del_entry_valid.cold+0xf/0x4a lib/list_debug.c:51
Code: e8 46 b8 f2 ff 0f 0b 48 89 f1 48 c7 c7 c0 1a c2 89 4c 89 e6 e8 32 b8 f2 ff 0f 0b 48 89 ee 48 c7 c7 60 1c c2 89 e8 21 b8 f2 ff <0f> 0b 4c 89 ea 48 89 ee 48 c7 c7 a0 1b c2 89 e8 0d b8 f2 ff 0f 0b
RSP: 0018:ffffc90000edf930 EFLAGS: 00010282
RAX: 0000000000000054 RBX: 0000000000000001 RCX: 0000000000000000
RDX: ffff88801c4f3880 RSI: ffffffff815c4cf5 RDI: fffff520001dbf18
RBP: ffff888014175068 R08: 0000000000000054 R09: 0000000000000000
R10: ffffffff815bda8e R11: 0000000000000000 R12: ffff888021143068
R13: ffff888021143068 R14: ffff888014175060 R15: 0000000000000000
FS:  0000000000000000(0000) GS:ffff8880b9d00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000556600a788e8 CR3: 0000000014986000 CR4: 0000000000350ee0
Call Trace:
 __list_del_entry include/linux/list.h:132 [inline]
 list_del include/linux/list.h:146 [inline]
 klist_release+0x66/0x480 lib/klist.c:189
 kref_put include/linux/kref.h:65 [inline]
 klist_dec_and_del lib/klist.c:206 [inline]
 klist_put+0xf7/0x1d0 lib/klist.c:217
 device_del+0x245/0xd40 drivers/base/core.c:3400
 hci_conn_del_sysfs+0xdc/0x180 net/bluetooth/hci_sysfs.c:78
 hci_conn_cleanup+0x2e7/0x6c0 net/bluetooth/hci_conn.c:138
 hci_conn_del+0x2a0/0x790 net/bluetooth/hci_conn.c:678
 hci_conn_hash_flush+0x19c/0x260 net/bluetooth/hci_conn.c:1599
 hci_dev_do_close+0x569/0x1110 net/bluetooth/hci_core.c:1778
 hci_unregister_dev+0x263/0x1130 net/bluetooth/hci_core.c:3989
 vhci_release+0x70/0xe0 drivers/bluetooth/hci_vhci.c:340
 __fput+0x288/0x920 fs/file_table.c:280
 task_work_run+0xdd/0x1a0 kernel/task_work.c:140
 exit_task_work include/linux/task_work.h:30 [inline]
 do_exit+0xbfc/0x2a60 kernel/exit.c:825
 do_group_exit+0x125/0x310 kernel/exit.c:922
 __do_sys_exit_group kernel/exit.c:933 [inline]
 __se_sys_exit_group kernel/exit.c:931 [inline]
 __x64_sys_exit_group+0x3a/0x50 kernel/exit.c:931
 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x4443c9
Code: Unable to access opcode bytes at RIP 0x44439f.
RSP: 002b:00007fff79df2b38 EFLAGS: 00000246 ORIG_RAX: 00000000000000e7
RAX: ffffffffffffffda RBX: 00000000004cb370 RCX: 00000000004443c9
RDX: 000000000000003c RSI: 00000000000000e7 RDI: 0000000000000001
RBP: 0000000000000001 R08: ffffffffffffffb8 R09: 000000ff00000001
R10: 00007fff79df2600 R11: 0000000000000246 R12: 00000000004cb370
R13: 0000000000000001 R14: 0000000000000000 R15: 0000000000000001
Modules linked in:
---[ end trace e0124b10d5f008c2 ]---
RIP: 0010:__list_del_entry_valid.cold+0xf/0x4a lib/list_debug.c:51
Code: e8 46 b8 f2 ff 0f 0b 48 89 f1 48 c7 c7 c0 1a c2 89 4c 89 e6 e8 32 b8 f2 ff 0f 0b 48 89 ee 48 c7 c7 60 1c c2 89 e8 21 b8 f2 ff <0f> 0b 4c 89 ea 48 89 ee 48 c7 c7 a0 1b c2 89 e8 0d b8 f2 ff 0f 0b
RSP: 0018:ffffc90000edf930 EFLAGS: 00010282
RAX: 0000000000000054 RBX: 0000000000000001 RCX: 0000000000000000
RDX: ffff88801c4f3880 RSI: ffffffff815c4cf5 RDI: fffff520001dbf18
RBP: ffff888014175068 R08: 0000000000000054 R09: 0000000000000000
R10: ffffffff815bda8e R11: 0000000000000000 R12: ffff888021143068
R13: ffff888021143068 R14: ffff888014175060 R15: 0000000000000000
FS:  0000000000000000(0000) GS:ffff8880b9d00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000556600a788e8 CR3: 0000000014986000 CR4: 0000000000350ee0

Fix bisection attempts:
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro
ci-upstream-kasan-gce	2021/04/02 01:16	upstream	6905b1dc	ba24ffcd	.config	log	report	syz	C
ci-upstream-kasan-gce	2021/03/01 09:36	upstream	fe07bfda	ba24ffcd	.config	log	report	syz	C
ci-upstream-kasan-gce	2021/01/11 06:03	upstream	7c53f6b6	ba24ffcd	.config	log	report	syz	C

Crashes (2):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	VM info	Title
ci-upstream-kasan-gce-root	2021/04/04 21:31	upstream	2023a53b	6a81331a	.config	log	report	syz	C		BUG: corrupted list in klist_release
ci-upstream-kasan-gce	2020/12/11 22:27	upstream	33dc9614	ba24ffcd	.config	log	report	syz	C