memory leak in pcan_usb_fd

memory leak in pcan_usb_fd_init
Status: upstream: reported C repro on 2020/12/11 17:53
Reported-by: syzbot+91adee8d9ebb9193d22d@syzkaller.appspotmail.com
First crash: 48d, last: 16d

Sample crash report:

BUG: memory leak
unreferenced object 0xffff88810b589b80 (size 128):
  comm "kworker/0:0", pid 5, jiffies 4294942321 (age 8.510s)
  hex dump (first 32 bytes):
    00 89 bc 0c 81 88 ff ff 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<000000006d0f552e>] kmalloc include/linux/slab.h:552 [inline]
    [<000000006d0f552e>] kzalloc include/linux/slab.h:682 [inline]
    [<000000006d0f552e>] pcan_usb_fd_init+0x156/0x210 drivers/net/can/usb/peak_usb/pcan_usb_fd.c:868
    [<000000001c15d19c>] peak_usb_create_dev drivers/net/can/usb/peak_usb/pcan_usb_core.c:851 [inline]
    [<000000001c15d19c>] peak_usb_probe+0x389/0x490 drivers/net/can/usb/peak_usb/pcan_usb_core.c:949
    [<00000000aa591fd4>] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
    [<0000000007b1e8a3>] really_probe+0x159/0x480 drivers/base/dd.c:561
    [<00000000e50f35a8>] driver_probe_device+0x84/0x100 drivers/base/dd.c:745
    [<0000000005c02c13>] __device_attach_driver+0xee/0x110 drivers/base/dd.c:851
    [<0000000023f0e318>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:431
    [<000000004efdd2a9>] __device_attach+0x122/0x250 drivers/base/dd.c:919
    [<000000000541dfaa>] bus_probe_device+0xc6/0xe0 drivers/base/bus.c:491
    [<000000008a5b3c00>] device_add+0x5be/0xc30 drivers/base/core.c:3091
    [<00000000fe9fa7d4>] usb_set_configuration+0x9d9/0xb90 drivers/usb/core/message.c:2164
    [<00000000a9661983>] usb_generic_driver_probe+0x8c/0xc0 drivers/usb/core/generic.c:238
    [<000000006e60bbe3>] usb_probe_device+0x5c/0x140 drivers/usb/core/driver.c:293
    [<0000000007b1e8a3>] really_probe+0x159/0x480 drivers/base/dd.c:561
    [<00000000e50f35a8>] driver_probe_device+0x84/0x100 drivers/base/dd.c:745
    [<0000000005c02c13>] __device_attach_driver+0xee/0x110 drivers/base/dd.c:851

BUG: memory leak
unreferenced object 0xffff88810ddc0a00 (size 512):
  comm "kworker/0:0", pid 5, jiffies 4294942321 (age 8.510s)
  hex dump (first 32 bytes):
    01 00 00 00 00 00 00 00 ff ff ff ff ff ff ff ff  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<00000000ba6daee9>] kmalloc include/linux/slab.h:552 [inline]
    [<00000000ba6daee9>] kzalloc include/linux/slab.h:682 [inline]
    [<00000000ba6daee9>] pcan_usb_fd_init+0x181/0x210 drivers/net/can/usb/peak_usb/pcan_usb_fd.c:873
    [<000000001c15d19c>] peak_usb_create_dev drivers/net/can/usb/peak_usb/pcan_usb_core.c:851 [inline]
    [<000000001c15d19c>] peak_usb_probe+0x389/0x490 drivers/net/can/usb/peak_usb/pcan_usb_core.c:949
    [<00000000aa591fd4>] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
    [<0000000007b1e8a3>] really_probe+0x159/0x480 drivers/base/dd.c:561
    [<00000000e50f35a8>] driver_probe_device+0x84/0x100 drivers/base/dd.c:745
    [<0000000005c02c13>] __device_attach_driver+0xee/0x110 drivers/base/dd.c:851
    [<0000000023f0e318>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:431
    [<000000004efdd2a9>] __device_attach+0x122/0x250 drivers/base/dd.c:919
    [<000000000541dfaa>] bus_probe_device+0xc6/0xe0 drivers/base/bus.c:491
    [<000000008a5b3c00>] device_add+0x5be/0xc30 drivers/base/core.c:3091
    [<00000000fe9fa7d4>] usb_set_configuration+0x9d9/0xb90 drivers/usb/core/message.c:2164
    [<00000000a9661983>] usb_generic_driver_probe+0x8c/0xc0 drivers/usb/core/generic.c:238
    [<000000006e60bbe3>] usb_probe_device+0x5c/0x140 drivers/usb/core/driver.c:293
    [<0000000007b1e8a3>] really_probe+0x159/0x480 drivers/base/dd.c:561
    [<00000000e50f35a8>] driver_probe_device+0x84/0x100 drivers/base/dd.c:745
    [<0000000005c02c13>] __device_attach_driver+0xee/0x110 drivers/base/dd.c:851

Crashes (8):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	Maintainers
ci-upstream-gce-leak	2021/01/08 16:03	upstream	f5e6c330	c104d4a3	.config	log	report	syz	C	dan.carpenter@oracle.com, davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, mkl@pengutronix.de, netdev@vger.kernel.org, socketcan@hartkopp.net, wg@grandegger.com
ci-upstream-gce-leak	2021/01/04 15:56	upstream	e71ba945	79264ae3	.config	log	report	syz	C	dan.carpenter@oracle.com, davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, mkl@pengutronix.de, netdev@vger.kernel.org, socketcan@hartkopp.net, wg@grandegger.com
ci-upstream-gce-leak	2021/01/02 22:25	upstream	eda809ae	79264ae3	.config	log	report	syz	C	dan.carpenter@oracle.com, davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, mkl@pengutronix.de, netdev@vger.kernel.org, socketcan@hartkopp.net, wg@grandegger.com
ci-upstream-gce-leak	2020/12/28 01:24	upstream	f838f8d2	2242f77f	.config	log	report	syz	C	dan.carpenter@oracle.com, davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, mkl@pengutronix.de, netdev@vger.kernel.org, socketcan@hartkopp.net, wg@grandegger.com
ci-upstream-gce-leak	2020/12/19 16:42	upstream	3644e2d2	04201c06	.config	log	report	syz	C	dan.carpenter@oracle.com, davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, mkl@pengutronix.de, netdev@vger.kernel.org, socketcan@hartkopp.net, wg@grandegger.com
ci-upstream-gce-leak	2020/12/17 01:38	upstream	5e60366d	04201c06	.config	log	report	syz	C	dan.carpenter@oracle.com, davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, mkl@pengutronix.de, netdev@vger.kernel.org, socketcan@hartkopp.net, wg@grandegger.com
ci-upstream-gce-leak	2020/12/16 08:57	upstream	d635a69d	f213e07e	.config	log	report	syz	C	dan.carpenter@oracle.com, davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, mkl@pengutronix.de, netdev@vger.kernel.org, socketcan@hartkopp.net, wg@grandegger.com
ci-upstream-gce-leak	2020/12/07 17:46	upstream	0477e928	1190297f	.config	log	report	syz	C	dan.carpenter@oracle.com, davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, mkl@pengutronix.de, netdev@vger.kernel.org, s.grosjean@peak-system.com, wg@grandegger.com