WARNING in kernfs_add

[upstream] WARNING in kernfs_add_one
Status: fixed on 2018/07/09 18:05
Reported-by: syzbot+df47f81c226b31d89fb1@syzkaller.appspotmail.com
Commits: driver core: Don't ignore class_dir_create_and_add() failure.
First: 196d, last: 131d

Sample crash report:

RBP: 00007fff808f3e10 R08: 0000000000000002 R09: 00007fff80003534
R10: 0000000000000000 R11: 0000000000000246 R12: ffffffffffffffff
R13: 0000000000000006 R14: 0000000000000000 R15: 0000000000000000
------------[ cut here ]------------
kernfs: ns required in 'ieee80211' for 'phy3'
WARNING: CPU: 0 PID: 4538 at fs/kernfs/dir.c:759 kernfs_add_one+0x406/0x4d0 fs/kernfs/dir.c:758
Kernel panic - not syncing: panic_on_warn set ...

CPU: 0 PID: 4538 Comm: syz-executor486 Not tainted 4.17.0-rc3+ #33
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x1b9/0x294 lib/dump_stack.c:113
 panic+0x22f/0x4de kernel/panic.c:184
 __warn.cold.8+0x163/0x1b3 kernel/panic.c:536
 report_bug+0x252/0x2d0 lib/bug.c:186
 fixup_bug arch/x86/kernel/traps.c:178 [inline]
 do_error_trap+0x1de/0x490 arch/x86/kernel/traps.c:296
 do_invalid_op+0x1b/0x20 arch/x86/kernel/traps.c:315
 invalid_op+0x14/0x20 arch/x86/entry/entry_64.S:992
RIP: 0010:kernfs_add_one+0x406/0x4d0 fs/kernfs/dir.c:758
RSP: 0018:ffff8801ca9eece0 EFLAGS: 00010286
RAX: 000000000000002d RBX: ffffffff87d5cee0 RCX: ffffffff8160ba7d
RDX: 0000000000000000 RSI: ffffffff81610731 RDI: ffff8801ca9ee840
RBP: ffff8801ca9eed20 R08: ffff8801d9538500 R09: 0000000000000006
R10: ffff8801d9538500 R11: 0000000000000000 R12: ffff8801ad1cb6c0
R13: ffffffff885da640 R14: 0000000000000020 R15: 0000000000000000
 kernfs_create_link+0x112/0x180 fs/kernfs/symlink.c:41
 sysfs_do_create_link_sd.isra.2+0x90/0x130 fs/sysfs/symlink.c:43
 sysfs_do_create_link fs/sysfs/symlink.c:79 [inline]
 sysfs_create_link+0x65/0xc0 fs/sysfs/symlink.c:91
 device_add_class_symlinks drivers/base/core.c:1612 [inline]
 device_add+0x7a0/0x16d0 drivers/base/core.c:1810
 wiphy_register+0x178a/0x2430 net/wireless/core.c:806
 ieee80211_register_hw+0x13cd/0x35d0 net/mac80211/main.c:1047
 mac80211_hwsim_new_radio+0x1d9b/0x3410 drivers/net/wireless/mac80211_hwsim.c:2772
 hwsim_new_radio_nl+0x7a7/0xa60 drivers/net/wireless/mac80211_hwsim.c:3246
 genl_family_rcv_msg+0x889/0x1120 net/netlink/genetlink.c:599
 genl_rcv_msg+0xc6/0x170 net/netlink/genetlink.c:624
 netlink_rcv_skb+0x172/0x440 net/netlink/af_netlink.c:2448
 genl_rcv+0x28/0x40 net/netlink/genetlink.c:635
 netlink_unicast_kernel net/netlink/af_netlink.c:1310 [inline]
 netlink_unicast+0x58b/0x740 net/netlink/af_netlink.c:1336
 netlink_sendmsg+0x9f0/0xfa0 net/netlink/af_netlink.c:1901
 sock_sendmsg_nosec net/socket.c:629 [inline]
 sock_sendmsg+0xd5/0x120 net/socket.c:639
 ___sys_sendmsg+0x805/0x940 net/socket.c:2117
 __sys_sendmsg+0x115/0x270 net/socket.c:2155
 __do_sys_sendmsg net/socket.c:2164 [inline]
 __se_sys_sendmsg net/socket.c:2162 [inline]
 __x64_sys_sendmsg+0x78/0xb0 net/socket.c:2162
 do_syscall_64+0x1b1/0x800 arch/x86/entry/common.c:287
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x4404c9
RSP: 002b:00007fff808f3e08 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00000000004404c9
RDX: 0000000000000000 RSI: 0000000020b3dfc8 RDI: 0000000000000005
RBP: 00007fff808f3e10 R08: 0000000000000002 R09: 00007fff80003534
R10: 0000000000000000 R11: 0000000000000246 R12: ffffffffffffffff
R13: 0000000000000006 R14: 0000000000000000 R15: 0000000000000000
Dumping ftrace buffer:
   (ftrace buffer empty)
Kernel Offset: disabled
Rebooting in 86400 seconds..

All crashes (174):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	Maintainers
ci-upstream-net-kasan-gce	2018/05/05 12:59	net-next	8fb11a9a	6a0382b5	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-net-kasan-gce	2018/05/05 05:58	net-next	8fb11a9a	9ce14f4b	.config	log	report	syz		gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kasan-gce	2018/06/04 22:45	upstream	910470e0	a50d873b	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kasan-gce-root	2018/05/31 00:45	upstream	d60d61f3	2f93b54f	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kasan-gce-386	2018/06/06 00:59	upstream	5037be16	863a24bb	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-net-kasan-gce	2018/05/05 03:32	net-next	8fb11a9a	9ce14f4b	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-net-kasan-gce	2018/06/07 08:46	net-next	7170e604	d2ba33fa	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-net-kasan-gce	2018/06/06 22:30	net-next	7170e604	e0e534c6	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-net-kasan-gce	2018/06/06 15:01	net-next	4016a7f1	41f9540d	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-net-kasan-gce	2018/06/06 10:35	net-next	75d4e704	41f9540d	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-net-kasan-gce	2018/06/05 21:38	net-next	75d4e704	863a24bb	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-net-kasan-gce	2018/06/04 20:25	net-next	4cd328f8	a50d873b	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/07/09 03:39	https://github.com/google/kmsan.git/master	a00de5aa	f25e5770	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/07/07 16:04	https://github.com/google/kmsan.git/master	a00de5aa	ab89aea9	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/07/07 12:51	https://github.com/google/kmsan.git/master	a00de5aa	6c0c0099	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/07/05 22:47	https://github.com/google/kmsan.git/master	86eb85c0	d3b2a0e2	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/07/05 10:28	https://github.com/google/kmsan.git/master	c1adbc42	f525fd72	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/07/04 15:34	https://github.com/google/kmsan.git/master	accdc89e	317fc8ea	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/07/03 06:44	https://github.com/google/kmsan.git/master	4ca559bb	317fc8ea	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/07/03 05:12	https://github.com/google/kmsan.git/master	4ca559bb	317fc8ea	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/06/29 03:57	https://github.com/google/kmsan.git/master	12390609	dba0b50e	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/06/28 17:51	https://github.com/google/kmsan.git/master	12390609	dba0b50e	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/06/27 16:33	https://github.com/google/kmsan.git/master	12390609	43e60f7e	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/06/27 03:27	https://github.com/google/kmsan.git/master	12390609	b0294c53	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/06/27 02:08	https://github.com/google/kmsan.git/master	12390609	b0294c53	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/06/23 15:07	https://github.com/google/kmsan.git/master	12390609	2064fc5c	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/06/21 02:25	https://github.com/google/kmsan.git/master	12390609	095ef806	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/06/20 08:13	https://github.com/google/kmsan.git/master	12390609	095ef806	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/06/19 21:41	https://github.com/google/kmsan.git/master	12390609	732e4256	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/06/17 07:02	https://github.com/google/kmsan.git/master	88e0e95b	27c5f59f	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/06/15 04:05	https://github.com/google/kmsan.git/master	88e0e95b	27c5f59f	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/06/13 12:38	https://github.com/google/kmsan.git/master	5cdf0501	27c5f59f	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/06/12 12:23	https://github.com/google/kmsan.git/master	5cdf0501	112eec79	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/06/12 03:58	https://github.com/google/kmsan.git/master	5cdf0501	112eec79	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/06/09 15:24	https://github.com/google/kmsan.git/master	d6c351f8	866118af	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/06/09 03:57	https://github.com/google/kmsan.git/master	d6c351f8	866118af	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/06/08 23:02	https://github.com/google/kmsan.git/master	d6c351f8	866118af	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/06/08 00:56	https://github.com/google/kmsan.git/master	c6a6aed9	645e75f8	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/06/07 21:21	https://github.com/google/kmsan.git/master	c6a6aed9	645e75f8	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/06/07 20:09	https://github.com/google/kmsan.git/master	c6a6aed9	645e75f8	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/06/06 18:16	https://github.com/google/kmsan.git/master	b9a5d319	41f9540d	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/06/06 12:19	https://github.com/google/kmsan.git/master	8fc8ecd1	41f9540d	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/06/06 08:03	https://github.com/google/kmsan.git/master	8fc8ecd1	863a24bb	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/06/05 15:00	https://github.com/google/kmsan.git/master	8fc8ecd1	a316ff92	.config	log	report			akpm@linux-foundation.org, gregkh@linuxfoundation.org, hmclauchlan@fb.com, kstewart@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, pombredanne@nexb.com, tglx@linutronix.de
ci-upstream-kmsan-gce	2018/06/05 11:36	https://github.com/google/kmsan.git/master	8fc8ecd1	a316ff92	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org
ci-upstream-kmsan-gce	2018/06/04 18:46	https://github.com/google/kmsan.git/master	8fc8ecd1	6cbe7c26	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tj@kernel.org