WARNING in bd_unlink_disk_holder

Status: upstream: reported syz repro on 2026/11/06 17:52
Subsystems: block
Labels: prio:low
[Documentation on labels]
Reported-by: syzbot+0a8119ab801b078213ea@syzkaller.appspotmail.com
First crash: 10d, last: 13h00m
✨ AI-generated root cause summary:

In drivers/md/md.c:bind_rdev_to_array(), an rdev is added to mddev->disks and bd_link_disk_holder() is called to create the holder/slave relationship without checking its return value. If bd_link_disk_holder() fails (for example, returning -EINVAL when an array's own block device or partition is imported into itself, or on memory/sysfs failures), no bd_holder_disk entry is added to disk->slave_bdevs, yet the device remains bound to the array. When the array is subsequently stopped via do_md_stop() -> export_array() -> md_kick_rdev_from_array(), bd_unlink_disk_holder() is called and bd_find_holder_disk() returns NULL, triggering WARN_ON_ONCE(holder == NULL) at block/holder.c:147.

▶ ▼ ✨ Full AI root cause analysis
Based on kernel commit b0958b1397fb:

Root Cause Analysis

1. Mechanism and Crash Site

The warning is triggered in block/holder.c:147 inside bd_unlink_disk_holder():

void bd_unlink_disk_holder(struct block_device *bdev, struct gendisk *disk)
{
	struct bd_holder_disk *holder;
...
	mutex_lock(&blk_holder_mutex);
	holder = bd_find_holder_disk(bdev, disk);
	if (!WARN_ON_ONCE(holder == NULL) && !--holder->refcnt) {
...

bd_unlink_disk_holder() expects that every unlinking operation corresponds to a previously established holder relationship recorded in disk->slave_bdevs. When bd_find_holder_disk() traverses disk->slave_bdevs and cannot find an entry whose holder_dir matches bdev->bd_holder_dir, it returns NULL, triggering WARN_ON_ONCE(holder == NULL).

The call trace demonstrates this occurring when stopping an MD array (STOP_ARRAY ioctl):

do_md_stop() -> export_array() -> md_kick_rdev_from_array() -> bd_unlink_disk_holder()

For each struct md_rdev *rdev remaining in mddev->disks, export_array() calls md_kick_rdev_from_array(rdev), which in turn calls bd_unlink_disk_holder(rdev->bdev, rdev->mddev->gendisk).


2. Defect in drivers/md/md.c

In the MD subsystem, an rdev is added to mddev->disks exclusively by bind_rdev_to_array():

static int bind_rdev_to_array(struct md_rdev *rdev, struct mddev *mddev)
{
...
	list_add_rcu(&rdev->same_set, &mddev->disks);
	bd_link_disk_holder(rdev->bdev, mddev->gendisk);

	return 0;
...
}

There are two key flaws in this implementation:

  1. Unchecked Return Value of bd_link_disk_holder(): bind_rdev_to_array() calls bd_link_disk_holder() without checking its return value and returns 0 (success). If bd_link_disk_holder() fails, the rdev remains attached to mddev->disks, but no struct bd_holder_disk is allocated or linked to mddev->gendisk->slave_bdevs.
  2. Missing Invariant Check on Self-Referencing Disks: bind_rdev_to_array() does not check whether rdev->bdev->bd_disk == mddev->gendisk. Inside bd_link_disk_holder() (block/holder.c:70):
    if (bdev->bd_disk == disk)
        return -EINVAL;
    
    A block device cannot hold itself or its own partitions.

3. How the Bug is Triggered

  1. An MD array (e.g., /dev/md4) is started with non-zero capacity (as indicated by the log: md4: detected capacity change from 4096 to 0).
  2. An ioctl such as ADD_NEW_DISK or HOT_ADD_DISK is executed, passing the device number (dev_t) of /dev/md4 itself (or one of its partitions).
  3. md_import_device() opens the device via bdev_file_open_by_dev(). Since the device is active and has non-zero size, it successfully creates the struct md_rdev.
  4. bind_rdev_to_array() is called. It checks for duplicate dev_t entries among existing rdevs via find_rdev(), which passes if /dev/md4 was not previously in the array.
  5. bind_rdev_to_array() places rdev onto &mddev->disks via list_add_rcu(), and calls bd_link_disk_holder(rdev->bdev, mddev->gendisk).
  6. Because rdev->bdev->bd_disk == mddev->gendisk, bd_link_disk_holder() returns -EINVAL without allocating or linking a bd_holder_disk. (Similarly, this occurs if bd_link_disk_holder() fails due to -ENODEV, -ENOMEM, or sysfs link creation failure).
  7. bind_rdev_to_array() ignores the -EINVAL return code and returns 0.
  8. Later, userspace stops the array via STOP_ARRAY (do_md_stop(mddev, 0)). export_array() iterates over mddev->disks and invokes md_kick_rdev_from_array(), which calls bd_unlink_disk_holder(rdev->bdev, mddev->gendisk).
  9. bd_find_holder_disk() returns NULL, triggering the warning at block/holder.c:147.
▶ ▼ ✨ AI Jobs (1)
ID Workflow Result Correct Bug Created Started Finished Revision
00df2403 assessment-security DenialOfService: ❌ Exploitable: ❌ FilesystemTrigger: ❌ FuzzingArtifact: ❌ MemoryCorruption: ❌ NetworkNeedsSetup: ❌ NetworkTrigger: ❌ PeripheralTrigger: ❌ RemoteTrigger: ❌ Unprivileged: ❌ UserNamespace: ❌ VMGuestTrigger: ❌ VMHostTrigger: ❌ ❓ WARNING in bd_unlink_disk_holder 2026/11/05 18:31 2026/11/05 18:31 2026/11/05 19:27 5cecaf1f
▶ ▼ Discussions (2)
Title Replies (including bot) Last reply
[PATCH] md: don't ignore bd_link_disk_holder() failure in bind_rdev_to_array() 2 (2) 2026/11/11 01:31
[syzbot] [block?] WARNING in bd_unlink_disk_holder 0 (1) 2026/11/06 17:52

Sample crash report:
md: md3 stopped.
------------[ cut here ]------------
holder == NULL
WARNING: block/holder.c:147 at bd_unlink_disk_holder+0x3a5/0x490 block/holder.c:147, CPU#0: syz.3.23/6113
Modules linked in:
CPU: 0 UID: 0 PID: 6113 Comm: syz.3.23 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2 04/01/2014
RIP: 0010:bd_unlink_disk_holder+0x3a5/0x490 block/holder.c:147
Code: 4d 89 7f 08 4c 89 ff e8 e9 47 4f fd e9 e1 fd ff ff e8 ff 74 e1 fc 90 0f 0b 90 e9 e4 fd ff ff e8 f1 74 e1 fc e8 ec 74 e1 fc 90 <0f> 0b 90 e9 c0 fd ff ff 4c 89 f7 e8 db ce 5b fd e9 5c fd ff ff 4c
RSP: 0018:ffffc90003ab7b38 EFLAGS: 00010293
RAX: 0000000000000000 RBX: ffff888058f44800 RCX: 0000000000000000
RDX: ffff88803545a580 RSI: ffffffff852d0c14 RDI: 0000000000000001
RBP: ffff8880502843d0 R08: 0000000000000000 R09: fffffbfff24d58cb
R10: ffffc90003ab7b38 R11: 0000000000000000 R12: ffffed1005e86403
R13: ffff888050284000 R14: ffff888058f44818 R15: ffff8880502843d0
FS:  0000555586b5a500(0000) GS:ffff8880d4473000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f8d95e00e9c CR3: 0000000053251000 CR4: 0000000000352ef0
Call Trace:
 <TASK>
 md_kick_rdev_from_array+0x8e/0x580 drivers/md/md.c:2683
 export_array drivers/md/md.c:2714 [inline]
 do_md_stop.cold+0x149/0xd82 drivers/md/md.c:7252
 md_ioctl+0x119b/0x3700 drivers/md/md.c:8462
 blkdev_ioctl+0x5ad/0x6f0 block/ioctl.c:798
 vfs_ioctl fs/ioctl.c:52 [inline]
 __do_sys_ioctl fs/ioctl.c:598 [inline]
 __se_sys_ioctl fs/ioctl.c:584 [inline]
 __x64_sys_ioctl+0x18e/0x210 fs/ioctl.c:584
 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
 do_syscall_64+0x123/0x7b0 arch/x86/entry/syscall_64.c:89
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7efe03da8fd9
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffecf18d558 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007efe04025fa0 RCX: 00007efe03da8fd9
RDX: 0000000000000000 RSI: 0000000000000932 RDI: 0000000000000004
RBP: 00007efe03e37fed R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007efe04025fac R14: 00007efe04025fa0 R15: 00007efe04025fa0
 </TASK>

Crashes (9):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2026/11/12 00:19 upstream 79eb6679ef6a 8d68b303 .config console log report syz / log [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream WARNING in bd_unlink_disk_holder
2026/11/15 18:28 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci ad3fc05c7e65 819ebe34 .config console log report syz / log [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in bd_unlink_disk_holder
2026/11/06 01:21 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci b0958b1397fb 5cecaf1f .config console log report syz / log [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in bd_unlink_disk_holder
2026/11/05 23:59 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci b0958b1397fb 5cecaf1f .config console log report syz / log [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in bd_unlink_disk_holder
2026/11/05 22:32 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci b0958b1397fb 5cecaf1f .config console log report syz / log [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in bd_unlink_disk_holder
2026/11/05 21:04 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci b0958b1397fb 5cecaf1f .config console log report syz / log [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in bd_unlink_disk_holder
2026/11/05 19:15 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci b0958b1397fb 5cecaf1f .config console log report syz / log [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in bd_unlink_disk_holder
2026/11/15 15:59 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci ad3fc05c7e65 819ebe34 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in bd_unlink_disk_holder
2026/11/05 17:52 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci b0958b1397fb 5cecaf1f .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in bd_unlink_disk_holder
* Struck through repros no longer work on HEAD.