syzbot


WARNING in nft_request_module

Status: fixed on 2020/02/18 14:31
Subsystems: netfilter
[Documentation on labels]
Reported-by: syzbot+0e63ae76d117ae1c3a01@syzkaller.appspotmail.com
Fix commit: 9332d27d7918 netfilter: nf_tables: remove WARN and add NLA_STRING upper limits
First crash: 1562d, last: 1561d
Cause bisection: introduced by (bisect log) :
commit 452238e8d5ffd8b77f92387519513839d4ca7379
Author: Florian Westphal <fw@strlen.de>
Date: Wed Jul 11 11:45:10 2018 +0000

  netfilter: nf_tables: add and use helper for module autoload

Crash: WARNING in nft_request_module (log)
Repro: C syz .config
  
Discussions (7)
Title Replies (including bot) Last reply
[PATCH 5.4 000/222] 5.4.14-stable review 238 (238) 2020/01/26 16:57
[PATCH AUTOSEL 5.4 001/107] batman-adv: Fix DAT candidate selection on little endian systems 97 (97) 2020/01/24 21:08
[PATCH AUTOSEL 4.19 01/56] batman-adv: Fix DAT candidate selection on little endian systems 56 (56) 2020/01/24 14:20
[PATCH 4.19 000/103] 4.19.98-stable review 108 (108) 2020/01/22 20:53
[PATCH 0/9] Netfilter updates for net 11 (11) 2020/01/17 09:37
[PATCH nf] netfilter: nf_tables: remove WARN and add NLA_STRING upper limits 2 (2) 2020/01/16 13:58
WARNING in nft_request_module 0 (2) 2020/01/16 10:49
Similar bugs (1)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-4.19 WARNING in nft_request_module C done 1 1561d 1561d 1/1 fixed on 2020/02/16 09:59

Sample crash report:
------------[ cut here ]------------
truncated: 'nft-expr-0-üÖLMMRö~«ÿ*Ÿ{¬üFþžƒµDcâºHc(›Ý?Vª' (len 209)
WARNING: CPU: 0 PID: 10733 at net/netfilter/nf_tables_api.c:588 nft_request_module+0x189/0x1a0 net/netfilter/nf_tables_api.c:588
Kernel panic - not syncing: panic_on_warn set ...
CPU: 0 PID: 10733 Comm: syz-executor867 Not tainted 5.5.0-rc6-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x197/0x210 lib/dump_stack.c:118
 panic+0x2e3/0x75c kernel/panic.c:221
 __warn.cold+0x2f/0x3e kernel/panic.c:582
 report_bug+0x289/0x300 lib/bug.c:195
 fixup_bug arch/x86/kernel/traps.c:174 [inline]
 fixup_bug arch/x86/kernel/traps.c:169 [inline]
 do_error_trap+0x11b/0x200 arch/x86/kernel/traps.c:267
 do_invalid_op+0x37/0x50 arch/x86/kernel/traps.c:286
 invalid_op+0x23/0x30 arch/x86/entry/entry_64.S:1027
RIP: 0010:nft_request_module+0x189/0x1a0 net/netfilter/nf_tables_api.c:588
Code: 00 75 2b 48 81 c4 10 01 00 00 5b 41 5c 41 5d 5d c3 e8 1b 6a 0e fb 44 89 ea 48 c7 c7 e0 7a dc 88 48 8d 74 24 60 e8 a6 19 df fa <0f> 0b eb 9a e8 7e 14 df fa 0f 1f 40 00 66 2e 0f 1f 84 00 00 00 00
RSP: 0018:ffffc90001b37188 EFLAGS: 00010282
RAX: 0000000000000000 RBX: ffffffff8a4c62c0 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffffffff815e5396 RDI: fffff52000366e23
RBP: ffffc90001b372b0 R08: ffff8880a89d0000 R09: fffffbfff165e7b3
R10: fffffbfff165e7b2 R11: ffffffff8b2f3d97 R12: 1ffff92000366e31
R13: 00000000000000d1 R14: ffffffff8a4c62c0 R15: ffffc90001b373a0
 nft_expr_type_request_module+0x65/0xb0 net/netfilter/nf_tables_api.c:2320
 nft_expr_type_get net/netfilter/nf_tables_api.c:2345 [inline]
 nf_tables_expr_parse+0x4e4/0x6b0 net/netfilter/nf_tables_api.c:2420
 nf_tables_newrule+0x72b/0x2400 net/netfilter/nf_tables_api.c:3037
 nfnetlink_rcv_batch+0xf42/0x17a0 net/netfilter/nfnetlink.c:433
 nfnetlink_rcv_skb_batch net/netfilter/nfnetlink.c:543 [inline]
 nfnetlink_rcv+0x3e7/0x460 net/netfilter/nfnetlink.c:561
 netlink_unicast_kernel net/netlink/af_netlink.c:1302 [inline]
 netlink_unicast+0x58c/0x7d0 net/netlink/af_netlink.c:1328
 netlink_sendmsg+0x91c/0xea0 net/netlink/af_netlink.c:1917
 sock_sendmsg_nosec net/socket.c:639 [inline]
 sock_sendmsg+0xd7/0x130 net/socket.c:659
 ____sys_sendmsg+0x753/0x880 net/socket.c:2330
 ___sys_sendmsg+0x100/0x170 net/socket.c:2384
 __sys_sendmsg+0x105/0x1d0 net/socket.c:2417
 __do_sys_sendmsg net/socket.c:2426 [inline]
 __se_sys_sendmsg net/socket.c:2424 [inline]
 __x64_sys_sendmsg+0x78/0xb0 net/socket.c:2424
 do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x440619
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 fb 13 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ffdb09de728 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 0000000000440619
RDX: 0000000000000000 RSI: 0000000020000240 RDI: 0000000000000005
RBP: 00000000006cb018 R08: 00000000004002c8 R09: 00000000004002c8
R10: 00000000004002c8 R11: 0000000000000246 R12: 0000000000401ea0
R13: 0000000000401f30 R14: 0000000000000000 R15: 0000000000000000
Kernel Offset: disabled
Rebooting in 86400 seconds..

Crashes (7):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/01/16 04:11 upstream 51d69817519f f9b69507 .config console log report syz C ci-upstream-kasan-gce-selinux-root
2020/01/16 02:25 upstream 51d69817519f f9b69507 .config console log report syz C ci-upstream-kasan-gce-root
2020/01/16 00:31 upstream 51d69817519f f9b69507 .config console log report syz C ci-upstream-kasan-gce
2020/01/15 23:51 upstream 51d69817519f f9b69507 .config console log report syz C ci-upstream-kasan-gce-smack-root
2020/01/16 04:17 upstream 51d69817519f f9b69507 .config console log report syz C ci-upstream-kasan-gce-386
2020/01/15 23:17 net-old 8b792f84c637 f9b69507 .config console log report syz C ci-upstream-net-this-kasan-gce
2020/01/15 21:54 net-next-old 4e2fa6b90275 f9b69507 .config console log report syz C ci-upstream-net-kasan-gce
* Struck through repros no longer work on HEAD.