KCSAN: data-race in prb_first_seq / prb_reserve

Status: moderation: reported on 2026/11/22 20:39
Subsystems: net
Labels: race:benign prio:high
[Documentation on labels]
Reported-by: syzbot+1cb248b8f4502eeabfe1@syzkaller.appspotmail.com
First crash: 5d17h, last: 2h06m
✨ AI-generated root cause summary:

In kernel/printk/printk_ringbuffer.c, prb_first_seq() speculatively reads sequence metadata from info->seq via an inlined desc_read() using a plain C memory access bounded by smp_rmb() barriers. Concurrently in interrupt context, prb_reserve() recycles the same descriptor ring slot upon ring wrap, atomically updating desc->state_var to desc_reserved and zeroing the printk_info struct via plain memset() at line 1689. Although the ringbuffer algorithm successfully invalidates the read upon detecting the state/ID change (returning desc_miss) and retries the loop, the unannotated concurrent plain memory read and write constitute an LKMM/C data race flagged by KCSAN.

▶ ▼ ✨ Full AI root cause analysis
Based on kernel commit 20eef29b7c84:

Root Cause Analysis

The reported KCSAN bug is a data race between prb_first_seq() (via inline desc_read()) and prb_reserve() in kernel/printk/printk_ringbuffer.c.

1. Background: Lockless Ringbuffer State Machine

In kernel/printk/printk_ringbuffer.c, log records consist of descriptors (struct prb_desc) in desc_ring.descs and associated metadata records (struct printk_info) in desc_ring.infos. Synchronization between writers and lockless readers is governed by an atomic state variable (desc->state_var), which packs both the descriptor ID and the descriptor state (desc_reserved, desc_committed, desc_finalized, or desc_reusable).

To read a descriptor, desc_read() uses an optimistic read-then-validate protocol:

  1. state_val = atomic_long_read(state_var); (desc_read:A)
  2. Validates that the state is not desc_miss or desc_reserved.
  3. Executes a read memory barrier: smp_rmb(); (desc_read:B).
  4. Copies the descriptor and info data:
    if (seq_out)
        *seq_out = info->seq; /* desc_read:C, kernel/printk/printk_ringbuffer.c:499 */
    
  5. Executes another read memory barrier: smp_rmb(); (desc_read:D, line 541).
  6. Re-reads the descriptor state:
    state_val = atomic_long_read(state_var); /* desc_read:E, line 547 */
    d_state = get_desc_state(id, state_val);
    
    If the descriptor was reused or modified concurrently, d_state will return desc_miss (because DESC_ID(state_val) != id) or desc_reserved.

2. Race Condition Trigger

The race occurs when a descriptor slot wraps around and is recycled while another CPU is reading the tail descriptor:

  • Reader Context (CPU 1, Task 31): Task 31 in prb_first_seq() reads tail_id (e.g., id = 0x170ee) and invokes desc_read(desc_ring, 0x170ee, NULL, &seq, NULL) (kernel/printk/printk_ringbuffer.c:2012). It checks desc->state_var (0x170ee), observes a consistent finalized or reusable state, executes smp_rmb(), and prepares to read info->seq (line 499).

  • Writer Context (CPU 0, Interrupt Context): While the reader is between steps 3 and 5, CPU 0 triggers a printk from lapbeth_xmit() -> vprintk_store() -> prb_reserve(). The ring buffer wraps around (0x170ee + DESCS_COUNT (0x2000) = 0x190ee), targeting the exact same descriptor index. desc_reserve() pushes the tail and advances the head, executing:

    atomic_long_try_cmpxchg(&desc->state_var, &prev_state_val, DESC_SV(0x190ee, desc_reserved)); /* desc_reserve:F */
    

    Immediately following this, prb_reserve() executes:

    seq = info->seq;
    memset(info, 0, sizeof(*info)); /* line 1689 */
    info->seq = seq + DESCS_COUNT(desc_ring); /* line 1712 */
    
  • Conflict: CPU 0 performs an 88-byte plain write (memset) starting at info (&info->seq), followed by assigning info->seq = 0x190ee. Simultaneously, CPU 1 executes a plain 8-byte load from info->seq at line 499 (0x170ee -> 0x190ee).

Although the design of printk_ringbuffer guarantees that CPU 1's subsequent check of desc->state_var (desc_read:E) will observe id = 0x190ee != 0x170ee and return desc_miss (causing prb_first_seq() to discard seq and loop again), the memory access at line 499 is a plain unannotated C load that races against a plain write (memset). Under the Linux Kernel Memory Model (LKMM) and C concurrency rules, this constitutes an unannotated data race that is flagged by KCSAN.

▶ ▼ ✨ AI Jobs (2)
ID Workflow Result Correct Bug Created Started Finished Revision
af0789cf assessment-security DenialOfService: ❌ Exploitable: ❌ FilesystemTrigger: ❌ FuzzingArtifact: ❌ MemoryCorruption: ❌ NetworkNeedsSetup: ❌ NetworkTrigger: ✅ PeripheralTrigger: ❌ RemoteTrigger: ✅ Unprivileged: ✅ UserNamespace: ✅ VMGuestTrigger: ❌ VMHostTrigger: ❌ ❓ KCSAN: data-race in prb_first_seq / prb_reserve 2026/11/18 20:04 2026/11/18 20:04 2026/11/18 20:31 2006bdcc
1e50333d assessment-kcsan Benign: ✅ ❓ KCSAN: data-race in prb_first_seq / prb_reserve 2026/11/18 20:01 2026/11/18 20:01 2026/11/18 20:11 2006bdcc

Sample crash report:
==================================================================
BUG: KCSAN: data-race in prb_first_seq / prb_reserve

write to 0xffffffff870ffa10 of 88 bytes by task 30 on cpu 0:
 prb_reserve+0x5d1/0x990 kernel/printk/printk_ringbuffer.c:1689
 vprintk_store+0x54e/0x910 kernel/printk/printk.c:2354
 vprintk_emit+0x1a4/0x580 kernel/printk/printk.c:2455
 vprintk_deferred kernel/printk/printk.c:4754 [inline]
 _printk_deferred+0x82/0xb0 kernel/printk/printk.c:4763
 ___ratelimit+0x4be/0x4e0 lib/ratelimit.c:86
 __printk_ratelimit+0x1c/0x30 kernel/printk/printk.c:4779
 kauditd_printk_skb kernel/audit.c:587 [inline]
 kauditd_hold_skb+0x63/0x1c0 kernel/audit.c:623
 kauditd_send_queue+0x287/0x2e0 kernel/audit.c:808
 kauditd_thread+0x45d/0x690 kernel/audit.c:932
 kthread+0x248/0x2a0 kernel/kthread.c:436
 ret_from_fork+0x146/0x330 arch/x86/kernel/process.c:158
 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245

read to 0xffffffff870ffa10 of 8 bytes by task 29187 on cpu 1:
 desc_read kernel/printk/printk_ringbuffer.c:499 [inline]
 prb_first_seq+0x117/0x190 kernel/printk/printk_ringbuffer.c:2012
 _prb_read_valid+0x1a1/0x610 kernel/printk/printk_ringbuffer.c:2169
 prb_first_valid_seq+0x35/0x70 kernel/printk/printk_ringbuffer.c:2297
 devkmsg_open+0x174/0x1c0 kernel/printk/printk.c:945
 memory_open+0xfa/0x120 mm/char-mem.c:736
 chrdev_open+0x2eb/0x3a0 fs/char_dev.c:413
 do_dentry_open+0x4e0/0xab0 fs/open.c:1000
 vfs_open_consume+0x47/0x210 fs/open.c:1131
 do_open fs/namei.c:4851 [inline]
 path_openat+0xc16/0x11e0 fs/namei.c:5016
 do_file_open+0x16c/0x290 fs/namei.c:5045
 do_sys_openat2+0xa1/0x140 fs/open.c:1443
 do_sys_open fs/open.c:1449 [inline]
 __do_sys_openat fs/open.c:1465 [inline]
 __se_sys_openat fs/open.c:1460 [inline]
 __x64_sys_openat+0xf2/0x120 fs/open.c:1460
 x64_sys_call+0x1f72/0x2550 arch/x86/include/generated/asm/syscalls_64.h:258
 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
 do_syscall_64+0x11e/0x3a0 arch/x86/entry/syscall_64.c:89
 entry_SYSCALL_64_after_hwframe+0x77/0x7f

value changed: 0x00000000000073a4 -> 0x00000000000093a4

Reported by Kernel Concurrency Sanitizer on:
CPU: 1 UID: 0 PID: 29187 Comm: fido_id Not tainted syzkaller #0 PREEMPT(lazy) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/06/2026
==================================================================

Crashes (14):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2026/11/22 18:50 upstream 4843f6873f7c b2c69459 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in prb_first_seq / prb_reserve
2026/11/22 05:57 upstream f802b6558eb8 b2c69459 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in prb_first_seq / prb_reserve
2026/11/21 16:30 upstream c44104f3642d b2c69459 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in prb_first_seq / prb_reserve
2026/11/21 16:29 upstream c44104f3642d b2c69459 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in prb_first_seq / prb_reserve
2026/11/20 23:56 upstream d0f871bfb831 b2c69459 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in prb_first_seq / prb_reserve
2026/11/20 14:55 upstream 65e4fd942f72 625aa117 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in prb_first_seq / prb_reserve
2026/11/20 01:52 upstream 8dac6df92a2e 229865fb .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in prb_first_seq / prb_reserve
2026/11/19 08:24 upstream 4405c18c95d2 f138241c .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in prb_first_seq / prb_reserve
2026/11/19 01:42 upstream 4405c18c95d2 2006bdcc .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in prb_first_seq / prb_reserve
2026/11/19 01:40 upstream 4405c18c95d2 2006bdcc .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in prb_first_seq / prb_reserve
2026/11/18 12:53 upstream 20eef29b7c84 eb4895d7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in prb_first_seq / prb_reserve
2026/11/18 02:59 upstream 63fdb511c27a 122f94d5 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in prb_first_seq / prb_reserve
2026/11/17 16:23 upstream 666539eecdf4 43af6cac .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in prb_first_seq / prb_reserve
2026/11/17 03:08 upstream 666539eecdf4 a3e64cfc .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in prb_first_seq / prb_reserve
* Struck through repros no longer work on HEAD.